Revert "[drivers] Avoid system/dev/lib/mmio deps in libraries and tests"
This reverts commit e5444b60. Reason for revert: <INSERT REASONING HERE> Original change's description: > [drivers] Avoid system/dev/lib/mmio deps in libraries and tests > > Test code needs to use the mock mmio library header while driver > code needs to use the real mmio library header. Hence, a library > like ddktl or hwreg that is used in both contexts cannot rely on > this header directly. Instead, make the APIs agnostic to mmio > implementation by using forward declarations and requiring users of > the mmio-related APIs to #include what they use. > > The renaming of the mock library to aaa-mock-mmio-reg was a previous > attempt to work around this issue, which is actually wholly > inadequate in the current build system. So the library is renamed > back to mock-mmio-reg. > > In the hwreg library, this was achieved by using a template common > to the kernel and non-kernel cases, rather than an explicit forward > declaration. To make that work, the argument order for > RegisterIo::Write was swapped to match MmioBuffer::Write so that > they are interchangeable in template instantiation. > > Both implementations of the <lib/mmio/mmio.h> were using templates > where they should have been using simple forward declarations. Fix > that so that separate forward declarations become tenable. > > Some cases of non-driver code still using the real mmio library > remain and need to be untangled. > > Bug: ZX-4062 #comment hwreg, ddktl libraries made mmio-header-agnostic > Change-Id: I824d395501b35f59ffb23ac37fffb628f163d46e TBR=teisenbe@google.com,qsr@google.com,mcgrathr@google.com Change-Id: Ic4a02278d630b16ae349566ca53d781a26863202 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: ZX-4062 #comment hwreg, ddktl libraries made mmio-header-agnostic
Showing
- garnet/drivers/gpu/msd-img-rgx/mtk/BUILD.gn 0 additions, 1 deletiongarnet/drivers/gpu/msd-img-rgx/mtk/BUILD.gn
- garnet/drivers/gpu/msd-img-rgx/mtk/mt8167s-gpu.h 4 additions, 3 deletionsgarnet/drivers/gpu/msd-img-rgx/mtk/mt8167s-gpu.h
- zircon/system/dev/block/aml-sd-emmc/BUILD.gn 0 additions, 1 deletionzircon/system/dev/block/aml-sd-emmc/BUILD.gn
- zircon/system/dev/block/mtk-sdmmc/BUILD.gn 1 addition, 1 deletionzircon/system/dev/block/mtk-sdmmc/BUILD.gn
- zircon/system/dev/board/mt8167s_ref/mt8167-audio.cpp 3 additions, 3 deletionszircon/system/dev/board/mt8167s_ref/mt8167-audio.cpp
- zircon/system/dev/board/mt8167s_ref/mt8167-display.cpp 2 additions, 4 deletionszircon/system/dev/board/mt8167s_ref/mt8167-display.cpp
- zircon/system/dev/board/mt8167s_ref/mt8167-msdc0.cpp 0 additions, 1 deletionzircon/system/dev/board/mt8167s_ref/mt8167-msdc0.cpp
- zircon/system/dev/bus/pci/BUILD.gn 0 additions, 5 deletionszircon/system/dev/bus/pci/BUILD.gn
- zircon/system/dev/bus/pci/test/fake_ecam.h 1 addition, 1 deletionzircon/system/dev/bus/pci/test/fake_ecam.h
- zircon/system/dev/bus/virtio/BUILD.gn 1 addition, 1 deletionzircon/system/dev/bus/virtio/BUILD.gn
- zircon/system/dev/camera/aml-mipicsi/BUILD.gn 0 additions, 1 deletionzircon/system/dev/camera/aml-mipicsi/BUILD.gn
- zircon/system/dev/camera/arm-isp/pingpong_regs.h 0 additions, 1 deletionzircon/system/dev/camera/arm-isp/pingpong_regs.h
- zircon/system/dev/clk/hisi-lib/BUILD.gn 0 additions, 5 deletionszircon/system/dev/clk/hisi-lib/BUILD.gn
- zircon/system/dev/clk/hisi-lib/hisi-clk.cpp 0 additions, 1 deletionzircon/system/dev/clk/hisi-lib/hisi-clk.cpp
- zircon/system/dev/clk/hisi-lib/include/dev/clk/hisi-lib/hisi-clk.h 3 additions, 2 deletions...stem/dev/clk/hisi-lib/include/dev/clk/hisi-lib/hisi-clk.h
- zircon/system/dev/clk/msm8x53-clk/BUILD.gn 3 additions, 2 deletionszircon/system/dev/clk/msm8x53-clk/BUILD.gn
- zircon/system/dev/display/mt8167s-display/BUILD.gn 25 additions, 23 deletionszircon/system/dev/display/mt8167s-display/BUILD.gn
- zircon/system/dev/display/mt8167s-display/mt8167s-display-test.cpp 1 addition, 0 deletions...stem/dev/display/mt8167s-display/mt8167s-display-test.cpp
- zircon/system/dev/fw/qcom-pil/BUILD.gn 1 addition, 1 deletionzircon/system/dev/fw/qcom-pil/BUILD.gn
- zircon/system/dev/fw/qcom-pil/qcom-pil.cpp 3 additions, 3 deletionszircon/system/dev/fw/qcom-pil/qcom-pil.cpp
Loading
Please register or sign in to comment