[fidlgen][go] Do not export request/response structs
To bridge between function arguments/returns and encoding/decoding, the Go bindings generate request/response structs holdings the various argument/return values. However, developers should not interact which these, instead using method calls and receiving returns. With the introduction of the error syntax, the fidlc compiler creates a name for the struct holding the value, i.e. the first variant of the result union where the second is the error. The name for this struct is suffixed by "Response" which used to clash with the response struct mentioned above. By keeping the request/response struct private (unexported), we avoid this clash. (This does not solve the more general problem of name clashing -- nor does it try to.) FIDL-519 #comment Change-Id: I50767de8d4b3e2d2cfd1b4f7fd4585ead9a455fd
Showing
- garnet/go/src/fidl/compiler/backend/golang/ir/ir.go 30 additions, 31 deletionsgarnet/go/src/fidl/compiler/backend/golang/ir/ir.go
- garnet/go/src/fidl/compiler/backend/golang/ir/ir_test.go 4 additions, 4 deletionsgarnet/go/src/fidl/compiler/backend/golang/ir/ir_test.go
- garnet/go/src/fidl/compiler/backend/goldens/protocols.test.fidl.json 324 additions, 49 deletions...rc/fidl/compiler/backend/goldens/protocols.test.fidl.json
- garnet/go/src/fidl/compiler/backend/goldens/protocols.test.fidl.json.cc.golden 472 additions, 0 deletions...mpiler/backend/goldens/protocols.test.fidl.json.cc.golden
- garnet/go/src/fidl/compiler/backend/goldens/protocols.test.fidl.json.go.golden 427 additions, 176 deletions...mpiler/backend/goldens/protocols.test.fidl.json.go.golden
- garnet/go/src/fidl/compiler/backend/goldens/protocols.test.fidl.json.h.golden 347 additions, 1 deletion...ompiler/backend/goldens/protocols.test.fidl.json.h.golden
- garnet/go/src/fidl/compiler/backend/goldens/protocols.test.fidl.json.llcpp.cc.golden 321 additions, 0 deletions.../backend/goldens/protocols.test.fidl.json.llcpp.cc.golden
- garnet/go/src/fidl/compiler/backend/goldens/protocols.test.fidl.json.llcpp.h.golden 312 additions, 0 deletions...r/backend/goldens/protocols.test.fidl.json.llcpp.h.golden
- garnet/go/src/fidl/compiler/backend/goldens/protocols.test.fidl.json.overnet_internal.cc.golden 7 additions, 0 deletions...ldens/protocols.test.fidl.json.overnet_internal.cc.golden
- garnet/go/src/fidl/compiler/backend/goldens/protocols.test.fidl.json.overnet_internal.h.golden 21 additions, 0 deletions...oldens/protocols.test.fidl.json.overnet_internal.h.golden
- garnet/go/src/fidl/compiler/backend/goldens/protocols.test.fidl.json.rs.golden 766 additions, 0 deletions...mpiler/backend/goldens/protocols.test.fidl.json.rs.golden
- garnet/go/src/fidl/compiler/backend/goldens/protocols.test.fidl.json_test_base.h.golden 13 additions, 0 deletions...ckend/goldens/protocols.test.fidl.json_test_base.h.golden
- garnet/go/src/fidl/compiler/backend/typestest/protocols.test.fidl 10 additions, 0 deletions...o/src/fidl/compiler/backend/typestest/protocols.test.fidl
Loading
Please register or sign in to comment