Skip to content
Snippets Groups Projects
Commit f9915b7a authored by Ankur Mittal's avatar Ankur Mittal Committed by CQ bot account: commit-bot@chromium.org
Browse files

Revert "[wlan-inspect] Be explicit about logging Option"

This reverts commit f50bcc0c.

Reason for revert: Build is failing

Original change's description:
> [wlan-inspect] Be explicit about logging Option
> 
> Previously, we added a blanket WriteInspect implementation to Option
> types that would log a value only if an Option doesn't exist. When
> looking at an inspect_log call on an optional value, it's non-obvious
> that in some cases, no value would be logged, and this blanket
> implementation was only added because inspect_log didn't have a way to
> specify optional logging.
> 
> With this commit, optional logging can be specified with a question
> mark on the key, so the blanket WriteInspect implementation is also
> removed.
> 
> Test: fx run-test wlan-inspect-tests
> Change-Id: I926c20fe2e64fc2e1221c2b84b61d5d9b062e817

TBR=qsr@google.com,hahnr@google.com,eyw@google.com,kiettran@google.com

Change-Id: Iac6d853aa9561dd04089408b071909da66dcb63e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
parent 3f453965
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment