Revert "[wlan-inspect] Be explicit about logging Option"
This reverts commit f50bcc0c. Reason for revert: Build is failing Original change's description: > [wlan-inspect] Be explicit about logging Option > > Previously, we added a blanket WriteInspect implementation to Option > types that would log a value only if an Option doesn't exist. When > looking at an inspect_log call on an optional value, it's non-obvious > that in some cases, no value would be logged, and this blanket > implementation was only added because inspect_log didn't have a way to > specify optional logging. > > With this commit, optional logging can be specified with a question > mark on the key, so the blanket WriteInspect implementation is also > removed. > > Test: fx run-test wlan-inspect-tests > Change-Id: I926c20fe2e64fc2e1221c2b84b61d5d9b062e817 TBR=qsr@google.com,hahnr@google.com,eyw@google.com,kiettran@google.com Change-Id: Iac6d853aa9561dd04089408b071909da66dcb63e No-Presubmit: true No-Tree-Checks: true No-Try: true
Showing
- src/connectivity/wlan/lib/inspect/src/log/impls.rs 10 additions, 0 deletionssrc/connectivity/wlan/lib/inspect/src/log/impls.rs
- src/connectivity/wlan/lib/inspect/src/log/mod.rs 16 additions, 35 deletionssrc/connectivity/wlan/lib/inspect/src/log/mod.rs
- src/connectivity/wlan/lib/inspect/src/nodes/mod.rs 0 additions, 8 deletionssrc/connectivity/wlan/lib/inspect/src/nodes/mod.rs
- src/connectivity/wlan/lib/sme/src/client/mod.rs 1 addition, 1 deletionsrc/connectivity/wlan/lib/sme/src/client/mod.rs
- src/connectivity/wlan/lib/sme/src/client/state.rs 2 additions, 2 deletionssrc/connectivity/wlan/lib/sme/src/client/state.rs
Loading
Please register or sign in to comment