Skip to content
Snippets Groups Projects
  1. Apr 16, 2019
    • Mark Dittmer's avatar
      [traceutil] Stream zedmon to JSON; merge into HTML · 2d652a5d
      Mark Dittmer authored
      - actions: convertTrace() accepts multiple files
      
        - Pass additional zedmon file when -zedmon specified
      
      - Temporary: Local copy of minimal tracing event structs required for
        zedmon trace
      
      - Hardcoded zedmon pseudoprocess PID: "zedm" ASCII
      
      - Channel-based zedmon interface
      
        - On run(): Stream CSV into structs, then JSON bytes
      
          - Return channels for data and errors
      
        - On stop(): Stop streaming and cleanup
      
      Change-Id: Ibf3e9693714d310f62c99aec7f10474a571fc829
      2d652a5d
    • Taylor Cramer's avatar
      [rust][netstack] netstack_intermediary to fuchsia-component · a4b83680
      Taylor Cramer authored
      Change-Id: I7d190d7293ebb77184fd36bfed934c2c1cb27eda
      a4b83680
    • Taylor Cramer's avatar
      [telephony] Remove unused qmi dependencies · 2c9b74f4
      Taylor Cramer authored
      Change-Id: I512517aa1d0f76a07a6c54dc504db8f4da1366e2
      2c9b74f4
    • Suraj Malhotra's avatar
      [paver][build] Split chromebook into a separate board from x64 · fa7ae96b
      Suraj Malhotra authored
      As part of migrating towards a unified A/B/R boot image configuration
      for all supported boards the following changes were made:
      * A chromebook board file was added.
      ** VBOOT images are only built for the new target.
      ** VBOOT images are treated similarly to how signed images on other
         boards are treated.
      * The EFI image was deduplicated into bootloader.
      * The KERNC image was deduplicated into ZIRCON-A.
      * Support for a VB_META_R partition was added.
      * zedboot version was updated (due to breaking changes)
      
      ZX-3861
      
      Tested: Paved pixelbook, NUC, astro, and vim2
      Change-Id: I2344048ef69dd7b5e53004c707a261f5e0e0bb93
      fa7ae96b
    • Erick Tryzelaar's avatar
      [fuchsia-uri] Rename Fuchsia{Boot,Pkg}Uri to {Boot,Pkg}Uri · 48b76b65
      Erick Tryzelaar authored
      This removes some repetition in the items
      `fuchsia_uri::FuchsiaBootUri` and `fuchsia_uri::FuchsiaPkgUri`.
      
      Change-Id: I400a15b98a8fc6e476fa15c3d920c1d5a13780ab
      48b76b65
    • Adam Gousetis's avatar
      [scenic] Move testing helper functions into vk_session_test · 5b179d49
      Adam Gousetis authored
      Change-Id: Icd85ede1a0f4f9492e91907039ba012a908db456
      5b179d49
    • Robert Lord's avatar
      [fidl][rust] Fix deadlock in FIDL client · 91498882
      Robert Lord authored
      Previously, since a waker was reused between loops in recv_all, a
      deadlock was possible:
      
          TASK 1  -> poll_recv_event
                  <- pending, will wake task 1 on next chan.recv_from msg
          TASK 2  -> send MyRequest, poll_recv_msg_response
                  <- pending, will wake task 2 on next chan.recv_from msg
          **event comes in, chan.recv_from's waker is called**
      	    <- wake task 2
          TASK 2  -> poll_recv_msg_response
                  <- pending, will wake task 2 on next chan.recv_from msg
      	    <- but hey also event is ready so wake task 1
          TASK 1  -> poll_recv_event
                  <- ready, will wake task 1 on next chan.recv_from msg
          **task 1 calls await!(Timer(1 year))**
          **MyRequest reply comes in, chan.recv_from's waker is called**
                  <- wake task 1
      	       ^ this will not poll or get recv_all called, since task 1
      	         is waiting on a timer, not a FIDL event, so TASK 2 will
      		 never be woken up with its now-ready response.
      
      Eventually, after one year, task 1 will stop awaiting and either drop
      the EventReceiver or await!() on it again, either of which will call
      recv_all and wake task 2. This may be a contrived example, but I ran
      into it when Task 1 requested a (futures-aware) lock that task 2 was
      holding. Task 1 was blocked waiting on the lock, and task 2 never got
      woken because of the logic above.
      
      This CL makes several changes:
      
      - recv_all now uses the same logic as wake_any to pick a Waker, instead
      of using the initially-used waker, which may not be polling if the
      Future is Ready after recv_all. In the example above, the last
      poll_recv_event would cause the still-waiting task 2 to be registered as
      the recv_from msg waker, instead of the no-longer-waiting task 1.
      - poll_recv_msg_response and poll_recv_event now update their waker
      *before* calling recv_all, so that recv_all can correctly select their
      waker to be the next chan.recv_from waker if they'll still be Pending
      after recv_all is called.
      - When the EventListener is woken, it is now set to
      EventListener::WillPoll to match the Received behavior in responses.
      This means the comment in wake_any() is not necessary, since
      already-called events that are now awaiting on something else will not
      be selected in get_pending_worker(). EventListener::New was also renamed
      to EventListener::WillPoll to clarify this new use of the state. This
      also means the previous comment in wake_any is no longer relevant, since
      an event receiver will only be the waker if got Pending on its last
      poll.
      
      Change-Id: Id3e23fd4575d220117207e43b6a5ce6b1e419f33
      91498882
    • Taylor Cramer's avatar
      [ledger][rust] Remove unnecessary cloud_provider_memory_diff dep · ac33ecdb
      Taylor Cramer authored
      Change-Id: Ic129292339bda65c5a59e98a72cca5e257e40953
      ac33ecdb
    • Ruchira Ravoori's avatar
      [power]Add support for requesting voltage modification · 071e2dd9
      Ruchira Ravoori authored
      This change adds skeleton for 2 protocol ops. One for requesting the
      hardware voltage constraints of a regulator, the other for requesting
      for a particular voltage.
      
      Test: fx full-build. No functionality added here. Will do more tets when
      functionality is added to these protocols.
      
      Change-Id: I499ea4790eb86cb17ab216e9c64446e9b5df4ca3
      071e2dd9
    • Dale Sather's avatar
      [mediaplayer] fix panic on failed HTTP connection · 55e3f851
      Dale Sather authored
      This CL fixes a null dereference in mediaplayer that occurs when the
      player cannot access a URL.
      
      TEST: fx shell present_view \
        fuchsia-pkg://fuchsia.com/mediaplayer_test_util#meta/mediaplayer_test_util.cmx \
        http://ia800201.us.archive.org/12/items/BigBuckBunny_328/BigBuckBunny.ogv
      Change-Id: Ib95a0f4c0dff81ec8ef05b6600d0abef03679b9c
      55e3f851
    • docs-roller's avatar
      [gndoc] Update GN build arguments documentation · 980339eb
      docs-roller authored
      Test: CQ
      
      Change-Id: I992bebbb45c0b5f5316b32bd6eebe5762eb33c1c
      980339eb
    • Adam Barth's avatar
      [recovery] Add docs for building and running recovery · 5ea44fe4
      Adam Barth authored
      Change-Id: Ide75beb0e1f6b35137a5103019ef0219dfbb27cc
      5ea44fe4
    • Dale Sather's avatar
      [mdns] tighten up (and correct) string checks · 83557d0c
      Dale Sather authored
      This CL addresses some misunderstandings concerning constraints on
      various DNS/mDNS-related string values (chiefly around max length)
      and makes string checking more thorough. Also added unit tests.
      
      TEST: fx run-test mdns_tests
      Change-Id: I4ca0bbbab463378fb11381bbb01fb59b9f4779b6
      83557d0c
    • Adam MacBeth's avatar
      [media][codec] Log missing hardware decoder type · d967976f
      Adam MacBeth authored
      Change-Id: Id63faf19219bdec97bc2c63e81e24b7f5e10d0cd
      d967976f
    • Nick Van der Auwermeulen's avatar
      [docs] Added changes back that were lost when change 264617 was rebased. · daaf504b
      Nick Van der Auwermeulen authored
      Change-Id: I2ea40a4ea46dedc08f429707ca79d1611de5f89f
      daaf504b
    • Marco Vanotti's avatar
      Reland "[thinfs] fix nil pointer dereference." · ed21e860
      Marco Vanotti authored
      This reverts commit 6be4d762.
      
      Reason for revert: Looks like the build errors were unrelated to this commit.
      
      Original change's description:
      > Revert "[thinfs] fix nil pointer dereference."
      > 
      > This reverts commit 36b9d349.
      > 
      > Reason for revert: I received a LUCI email saying that this breaks asan builds.
      > 
      > Original change's description:
      > > [thinfs] fix nil pointer dereference.
      > > 
      > > This CL fixes a nil pointer dereference that happens in the
      > > thinfs/zircon/rpc package.
      > > 
      > > The issue is that the `directoryWrapper is not correctly initialized,
      > > not setting the cookies map. Upon calls to GetToken(), the dictionary is
      > > dereferenced and that causes a panic.
      > > 
      > > The commit just makes sure that the cookies map is initialized
      > > correctly, and adds a test for it.
      > > 
      > > ZX-3928: Done
      > > 
      > > TEST=/pkfs/packages/go_thinfs_tests/0/test/go_thinfs_test
      > > 
      > > Change-Id: I4686714f547f8a759d11dcc2e9414ce60e37707d
      > 
      > TBR=kulakowski@google.com,smklein@google.com,mvanotti@google.com
      > 
      > Change-Id: I8bd13bf33f3ee744afed06d4e5d43e74b4349041
      > No-Presubmit: true
      > No-Tree-Checks: true
      > No-Try: true
      
      TBR=kulakowski@google.com,smklein@google.com,mvanotti@google.com
      
      Change-Id: I96f2afca116fac4a8f83dfbc15113234907cac17
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      ed21e860
    • Ilya Bobyr's avatar
      [pseudo-fs] Watchers support for directory::lazy · 8a3f7a1d
      Ilya Bobyr authored
      ZX-3581 #done
      
      Change-Id: Id55af08c814ec2921e31dfd9f707281a0d6b830f
      8a3f7a1d
    • Bert Muthalaly's avatar
      [netstack] Report error message from fuchsia.netstack.BridgeInterfaces · cde168fa
      Bert Muthalaly authored
      I additionally grepped the tree for instances of NetErr that weren't
      StatusOk that left the Message field empty; this is the only one.
      
      Change-Id: I607748dd6a91083e0f74decc16743be3879b8633
      cde168fa
    • P.Y. Laligand's avatar
      [sdk] Removed obsolete "new_parts" attribute. · b1cf08e1
      P.Y. Laligand authored
      Bug: DX-1045 #done
      Change-Id: I277dd292b4f35a5cf3953928fab0d6bd72770803
      b1cf08e1
    • Mitch Rudominer's avatar
      [cobalt] Adds fuchsia.logger.LogSink to sandbox services in cmx file. · b1b49554
      Mitch Rudominer authored
      TEST=Manually ran and observed that warning in console went away.
      
      Change-Id: I548e20d7df618d4cf031bff12237233a7f8bd493
      b1b49554
    • Taylor Cramer's avatar
      [rust][ime] ime_service to fuchsia-component · c602f0ae
      Taylor Cramer authored
      Change-Id: Idf4fbd28106e45c982fee6f024e27f6d30469052
      c602f0ae
    • Claudio Cherubino's avatar
      [rust] Adding handlebars Rust crate. · 927ed863
      Claudio Cherubino authored
      This was approved in OSRB-168.
      
      Change-Id: Ib3f0b14ebb2c39e37e0d968ab810d6b4a55db002
      927ed863
    • Aaron Green's avatar
      [gitignore] Exclude test_data more narrowly · f25da1bd
      Aaron Green authored
      CL 267663 was a bit too aggressive in excluding //test_data.
      
      Test: fd && mkdir -p test_data zircon/test_data
            touch test_data/foo zircon/test_data/bar
            git status   # Shows zircon/test_data/bar but nor test_data/foo
      Change-Id: Ie6a2512eb368e9a9ffe21796e53ef4520977670b
      f25da1bd
    • Doug Evans's avatar
      [trace-manager] Handle tracing having stopped when provider reports started · c99ddb2f
      Doug Evans authored
      Tested: Apply repro-inducer from bug report, note that test no longer
      fails due to timing out.
      
      PT-133 #done
      
      Change-Id: I78e1a34f77fe02075512bca75e89222cfae3293f
      c99ddb2f
    • Zach Bush's avatar
      [cobalt] Start setting channel in SystemProfile · 78b23a4c
      Zach Bush authored
      Change-Id: I8ee983db6b3ca88113264c86af8c6ec4ceeb0d39
      78b23a4c
    • Kevin Wells's avatar
      [fx][build] Fixup switch argument parsing · 9099e205
      Kevin Wells authored
      The arguments of switches were ending up in targets arrays instead of
      the switches arrays. Also remove some unused local variables.
      
      Test: fx build; fx build -t targets
      Change-Id: I07582facadf19b9300cc96f27f12b857dfb808d7
      9099e205
    • Dale Sather's avatar
      [mdns] reviewed FIDL definition for fuchsia.net.mdns · a706e3a8
      Dale Sather authored
      This CL adds fuchsia.net.mdns, which will replace fuchsia.mdns. This
      library definition has been reviewed and approved.
      
      TEST: no behavior change
      
      Change-Id: I9df801befe3466ccda59f308d4739eef6cb26e0f
      a706e3a8
    • Taylor Cramer's avatar
      [rust][overnet] overnet to fuchsia-component · 7d3522ba
      Taylor Cramer authored
      Change-Id: If463cd17fff48aaa53ca027c594a1c8107e2154e
      7d3522ba
    • Yifei Teng's avatar
      [fidlgen] [llcpp] Move llcpp to its own backend · 5ed47b09
      Yifei Teng authored
      Change-Id: Idddba28f06a49623f50c1a29bca22c48912a32e2
      5ed47b09
    • Adam Barth's avatar
      [products] Migrate to new GN label syntax · b921b6a3
      Adam Barth authored
      Now that oldset is no longer supported, we can migrate these product
      configurations to use the new GN label syntax.
      
      Change-Id: Ieacdd19f38a655f8ff3c6c59a8ff2be1f12f5034
      b921b6a3
    • Marty Faltesek's avatar
      [utest][async] Migrate ZX_WAIT_ASYNC_REPEATING to ZX_WAIT_ASYNC_ONCE · 0024b0ac
      Marty Faltesek authored
      ZX_WAIT_ASYNC_REPEATING is deprecated so convert code to use
      ZX_WAIT_ASYNC_ONCE instead.
      
      Bug: ZX-3090
      
      Test: /boot/test/sys/debugger-test and /boot/test/sys/exception-test
      Change-Id: I134ce421dccaf85b23a657f92855055552a3d32b
      0024b0ac
    • Bruno Dal Bo's avatar
      [netemul] Move netemul to //src · b993b8df
      Bruno Dal Bo authored
      - Move netemul to //src/connectivity/network/testing/netemul.
      - Remove bad dependencies on garnet/lib/component/cpp that were left
      dangling.
      
      BUG: NET-2217 #done
      
      Change-Id: Ib3cc013d4e66f2661a4cc6e7e96fe25412134e80
      b993b8df
    • Pat Erley's avatar
      [sl4f][audio] Cleanup accounting in virtual output. · 6aef5722
      Pat Erley authored
      There's a potential race where output capture could be started and
      if the first audio we're interested in capturing comes in less than
      50ms (really, whatever our notification interval is), that audio
      data could be lost or corrupted.  Fix this the same way we resolved
      tracking the injection accounting, by always tracking where our
      next read needs to come from.
      
      Bug: MTWN-268
      Test: Start facade then play an mp3 from the command line.  Trigger
            capturing after approximately 100ms, then listen to the wave
            produced.  Without the patch (sometimes) will have a pop at
            the beginning of the capture.
      Change-Id: I0d5fa6fb5d7f4969b3a39c0095ff5875cc5fb83f
      6aef5722
    • Taylor Cramer's avatar
      [rust][http] http_client to fuchsia-component · 33b6af7b
      Taylor Cramer authored
      Change-Id: Ie7784bc3cc61f543db94265e48be178fb2e3b9d4
      33b6af7b
    • Pascal Perez's avatar
      [fidlc] Fix to coding tables for xunion/table members · 70594875
      Pascal Perez authored
      Certain types only need to be coded when they appear within envelopes,
      e.g. primitives and arrays. We therefore need to know in which context
      we generate coding tables to conditionally generate coding tables for
      these types.
      
      This worked for primitives because these are interned, such that
      referencing these coding tables was sufficient. For arrays however, we
      must generate the coding table, and then reference it.
      
      Test: in fidlc and
      Test: ./scripts/build-zircon-x64 && ./scripts/run-zircon-x64 -c zircon.autorun.boot=/boot/test/sys/fidl-coding-tables-test
      Change-Id: I4c923cd2c6bc36c6e4e974b4a05cd139fded34d4
      70594875
    • Taylor Cramer's avatar
      [fidl][rust] Remove unnecessary fidl-changes dependencies · 4db7de5e
      Taylor Cramer authored
      Change-Id: Ic5055293fe3cefd24a1127ced61dcb3f09a47cd6
      4db7de5e
    • Joshua Conner's avatar
      [brcmfmac] Remove unused code · 2222b3b3
      Joshua Conner authored
      Mostly p2p, with a bit of regulatory. All code and structures that
      weren't being used.
      
      WLAN-1072
      
      TEST: Smoke test with TP-Link AP (Archer C59)
      Change-Id: I77be5f9efd99b82f498b82f6bb3fa7ad21489385
      2222b3b3
    • Rob Tsuk's avatar
      [carnelian] eliminate z-fighting · 702ca598
      Rob Tsuk authored
      Right now this is done with carefully selected constants. In
      the future carnelian will calculate appropriate z values.
      
      Change-Id: I30edda5d12c541bedd675e20914c46d2f664eb0d
      702ca598
    • John Bauman's avatar
      [escher] Use similar properties to client when creating images · 3acf8c3a
      John Bauman authored
      The vkCreateImage parameters need to match exactly when two images alias
      the same memory, or else they may interpret the memory differently -
      e.g. one may use AFBC, and the other may not.
      Add color attachment and mutable format to match
      topaz/runtime/flutter_runner/vulkan_surface.cc
      
      Change-Id: I04b42507f710da97bf1e84941a8075efddaac88a
      3acf8c3a
    • Ian McKellar's avatar
      [fidl][compatibility_test] Read server from command line · c642371e
      Ian McKellar authored
      Move away from parameterized tests and instead just loop through the
      list of tests supplied in the environment or on the command-line.
      
      Change-Id: Ibb5638d088b80d9a96e46eccf35a90457a671b15
      c642371e
Loading