Skip to content
Snippets Groups Projects
  1. Apr 27, 2019
    • Drew Fisher's avatar
      [fshost] log when encountering unknown disk format · 396d2162
      Drew Fisher authored
      DNO-492 #comment
      Tests: paved an Astro, saw this log reasonable content
      for the empty volumes before formatted, did not log after paved.
      
      Change-Id: I07a80dc2a826e80ba5c12ca5901d460a65266153
      396d2162
    • Venkatesh Srinivas's avatar
      [kernel][x86] Add write_msr_safe · eafd9b14
      Venkatesh Srinivas authored
      write_msr_safe attempts to write a value to an MSR; if it encounters a #GP
      fault, it returns a status with the value unwritten.
      
      Like read_msr_safe, this should be executed with interrupts disabled; I
      plan to change both of them soon to assert that we are either cpu-pinned
      or have hard interrupts disabled.
      
      Tested: See 4th CL in stack; adds 'k' commands to access read_msr/write_msr.
      
      ZX-3359
      
      Change-Id: I6f91818bf1ffc34f54e041ad17aca1317d240321
      eafd9b14
    • Venkatesh Srinivas's avatar
      [kernel][x86] Introduce read_msr_on_cpu · bdd2d1c2
      Venkatesh Srinivas authored
      read_msr_on_cpu reads an MSR on a single target CPU. The MSR needs to be
      readable without causing a #GP; the read happens in IPI function handler.
      
      ZX-3359
      
      Tested: See 4th patch in patch stack; k cpu rdmsr/wrmsr are added to
      exercise these.
      
      Change-Id: I42e6162ba8c2f19872b4d058532b454367e19879
      bdd2d1c2
    • David Reveman's avatar
      [vulkan] Improve hw support for VK_LAYER_FUCHSIA_imagepipe_swapchain · 891e5d45
      David Reveman authored
      This doesn't cause a change in behavior. The code is only used for
      examples and the change simply increase hw support and allows for
      optimizations in future drivers.
      
      - Determine memory type index instead of assuming 0.
      - This is a memory allocation dedicated to a single image. Inform
        the driver of this. Required by goldfish ICD and useful for
        other drivers.
      
      The result of this change is that examples that use this layer can
      be used when running fuchsia on aemu.
      
      DX-939 #comment
      
      Test: fx shell present_view fuchsia-pkg://fuchsia.com/vkcube_on_scenic#meta/vkcube_on_scenic.cmx
      Change-Id: Ib27140ea6c5871e34af01d4ea631e2f4b80fa600
      891e5d45
    • Bryce Lee's avatar
      [SetUI] Support account login override mutations. · c0cc79bf
      Bryce Lee authored
      This changelist adds support for retrieving and modifying account
      settings. It also updates the corresponding fidls by adding a
      provision login override type and fixing a typo.
      
      Bug: SU-167
      Test: fx run-test setui_service_tests -- --test
      Change-Id: I7ddb2ca2f41ebc71fb32feea1094cb3722e86263
      c0cc79bf
    • Bryce Lee's avatar
      [SetUI] Add SetUISettingService to base packages. · 8938cc5d
      Bryce Lee authored
      This is necessary for the service to be used as an environment
      service.
      
      Bug: SU-167
      Test: manual
      Change-Id: I3bd44796d7b9f7e4e214626d28cac422f4b084be
      8938cc5d
    • Bryce Lee's avatar
      [SetUI] Add Persistent storage to SetUI service. · b0c7a662
      Bryce Lee authored
      This changelist introduces persistent storage for retaining settings
      accessed through the SetUI service. The functionality is exposed
      through two main traits. The Store trait defines an API for writing
      and retrieving values, while the SettingCodec trait defines an
      encoding/decoding protocol. Concrete implementations for both
      have been provided, using JSON for the latter.
      
      Note that the codecs must be updated to support new SettingData
      types. The JSON codec currently only supports StringValue and
      AccountSettings.
      
      Bug: SU-167
      Test: fx run-test setui_service_tests -- --test
      Change-Id: Iae55c256bdeaeec957a62836abe342793320d2c4
      b0c7a662
    • Wez .'s avatar
      [scenic] Revert "[scenic] Convert ViewTokenPair to object" · 1c2f0e56
      Wez . authored
      This reverts commit 426805c5.
      
      Reason for revert: ViewTokenPair is published in the Fuchsia SDK, so this change was a hard API transition for SDK consumers (e.g. Chromium & ANGLE).
      
      Original change's description:
      > [scenic] Convert ViewTokenPair to object
      >
      > This unifies the API for C++, Dart, and Rust better.  All 3 language
      > bindings are pretty idiomatic now.
      >
      > Tested: view_token_pair_test
      > SCN-1214 #comment
      >
      > Change-Id: I00bcbde5ff64c747ce427764cdfffdf6530e1295
      
      TBR=abarth@google.com,jjosh@google.com,dworsham@google.com,jsankey@google.com,adamgousetis@google.com
      
      Change-Id: Ie9219897b794e5adc38ad5e84a79ee99c1491bca
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      1c2f0e56
    • Bryce Lee's avatar
      [SetUI] Introduce Adapters. · 145eeba7
      Bryce Lee authored
      This changelist adds adapters to the SetUI setting service. Adapters
      allow us to extend the service to handle different types of settings. It
      also implements the setting listen functionality.
      
      A TestAdapter has also been added for the Unknown setting type as
      an example.
      
      Bug: SU-167
      Test: fx run-test setui_service_tests -- --test
      Change-Id: Ia105d77a18ba80d3624bb45d509c6ad6b211a5c3
      145eeba7
    • Cristián Donoso's avatar
      [debugger] Watchpoint integration test. · fc18365e
      Cristián Donoso authored
      This is the stub of the test, that is not joined to the build. This is
      because a lot of logic for making this test to work is required and the
      CL is big enough at it is. The following CL will do the actual
      watchpoint logic and hook up this test to run.
      
      TEST=No functional change.
      
      Change-Id: Idee83c1e65aa55552242d5679e0ff178b8151fcc
      fc18365e
    • Sean Klein's avatar
      [blobfs][writeback] Use composition of WriteTxn instead of inheritance · 220b09fb
      Sean Klein authored
      Although slightly more verbose, being explicit makes the semantics of
      WritebackWork easier to reason about (and easier to refactor).
      
      Change-Id: If9b6bb6677eb3ec3713a31ef3eb03557c71685a2
      220b09fb
    • James Robinson's avatar
      [sys] Start component_test_runner, a component runner for tests · c835869c
      James Robinson authored
      This starts a component_test_runner which is an implementation of the
      fuchsia.sys.Runner interface that can instantiate a component within an
      environment configured for tests.  The specification of the test
      environment and of the component under test is the component manifest
      itself. This way a test author can configure different environments to
      run a test in without having to modify the code for the component under
      test.
      
      This patch responds to incoming Runner requests and starts parsing the
      test specification data, but doesn't yet actually attempt to create the
      test environment or actually instantiate the component.
      
      Change-Id: Ibc70a60202c026174268a109a376c072bd370a10
      c835869c
    • Robert Hahn's avatar
      [wlan][sme] Combine EAPOL logging with cause · 8e188c61
      Robert Hahn authored
      This should allow us to easier map a cause to a specific
      frame.
      
      Test=Only logging changed. Verified new logging format by
      inspecting bug report
      
      Change-Id: Ifa43161e45228ecc5ae5215c50bdf1fe6f5befb4
      8e188c61
    • Gurjant Kalsi's avatar
      [msm8x53][clk] Implement RCG support for MSM8x53. · 11fa9b9b
      Gurjant Kalsi authored
      Implements Root Clock Generator Enable/Disable/Request Rate support
      for 8x53.
      
      Change-Id: I8c52e5dd2734e5c3a6d71bd1f67f9dfbf95b9a7d
      11fa9b9b
    • Marty Faltesek's avatar
      [zircon][async] Remove ZX_WAIT_ASYNC_REPEATING flag. · cc6f71ca
      Marty Faltesek authored
      Disable the usage of ZX_WAIT_ASYNC_REPEATING, and print a message if
      some previously built binary attempts to use it, to aid in debugging.
      
      A subsequent CL will remove the implementation code after a refactor.
      
      Bug: ZX-3090
      
      Test: CQ.
      Change-Id: I52f7a51a8b5ddcffcfa528780ba57046fe88bd97
      cc6f71ca
    • Jody Sankey's avatar
      [identity] Remove transition suffix from Google auth provider. · 8711d99d
      Jody Sankey authored
      This is step 4 of 4 in a soft transition to migrate the Auth Provider
      between repos.
      
      AUTH-164 #comment
      
      Change-Id: I65871f247eee4a23628a5adfcf5bd8c9464ec7be
      8711d99d
    • Francois Rousseau's avatar
      [feedback] move unittest stubs to their own files · 5b471531
      Francois Rousseau authored
      * this will reduce the amount of code in feedback_agent_unittest
      * this will allow us to shared the StubLogListener with the upcoming log_listener_unittest
      
      TESTED=`fx run-test feedback_agent_tests -t feedback_agent_unittest`
      
      Change-Id: I97d1312a4980053193848332ce12f01a076a0411
      5b471531
    • Roland McGrath's avatar
      [build][ldso] Use libprefix for all instrumented variants · 6c72e46b
      Roland McGrath authored
      Also add an explicit option in environment() to enable a per-variant
      libprefix in all variants of a toolchain (or none).  By default, each
      variant that has the "instrumented" tag gets "$variant/" appended to its
      ${toolchain.libprefix} value.  Remove the "asan" variant's explicit
      toolchain_vars.libprefix setting, which is now redundant.
      
      The dynamic linker is compiled to request the libprefix from the loader
      service, and all executables have the prefixed name in PT_INTERP so they
      get the same variant's dynamic linker.
      
      Bug: BLD-429 #done
      Bug: ZX-3624 #done
      Change-Id: Ia74bc8d449aa6ce3ded00df8940b057e790486f4
      6c72e46b
    • Pat Erley's avatar
      [sl4f][e2e][audio] Increase ringbuffer size · e9de410d
      Pat Erley authored
      There are situation in which we're being delayed in the 150-200ms range.
      Until that situation is resolved bump the ringbuffer size 'higher than
      should ever be needed'.
      
      Test: Built+ran end to end test. CI repeatedly passing will be the final
            test.
      Bug: ZX-3973
      Change-Id: Ic240384192a7c418de8b37249a7379045d8e6c27
      e9de410d
    • Sean Klein's avatar
      [fshost][minfs] Add fshost tests for reformatting, verifying filesystems · 41c8da6a
      Sean Klein authored
      Additionally, some minor related changes:
      - Remove unused "FormatMinfs" function.
      - Plumb the "Should we check filesystems?" boolean through explicit
      arguments instead of environment variables.
      - Make minfs superblock validation more strict. This validates that
      clients can't format a filesystem with N blocks, and either mount
      of check the consistency of a filesystem with M blocks, for M < N.
      This change, along with the fshost tests, acts as a regression for
      a bug where the consistency checker only inspected a subsection of the
      filesystem.
      
      Change-Id: I15470e9529553526011c8fba2d8a6f5987b8e1a6
      41c8da6a
    • Ricardo Vargas's avatar
      [zircon/ftl] Update FTL version number to 1.0.11 · c7c5cd5f
      Ricardo Vargas authored
      This reflects FTL library code refactors to:
      - map page cache improvements
      - Change FTL-NDM interface to direct function calls
      
      Change-Id: If3668b3fb079cc18c6d4b28b122c74789fff0e78
      c7c5cd5f
    • Josh Gargus's avatar
      [scenic] Remove hit-testing APIs from Scenic session. · 53af9707
      Josh Gargus authored
      These were only used by ViewManager, which is no longer used.
      
      SCN-1318 #comment
      
      Change-Id: Ie9778af954992b9bef96079cdc67281d4da3c1e5
      53af9707
    • Cristián Donoso's avatar
      [debugger] Extended breakpoint Add IPC request to support watchpoints. · b35925f2
      Cristián Donoso authored
      This required to extract a bit the "breakpoint type" from the settings.
      This change is a no-op but requires to touch quite a bit of files because
      of our "use the ipc type as our internal storage" strategy.
      
      TEST=host + target tests.
      
      Change-Id: Ia24efea188224a330e38ff1c5a44585f0021da8b
      b35925f2
    • Ankur Mittal's avatar
      [appmgr] Kill realm when its job dies · 3073a3fe
      Ankur Mittal authored
      When realm's job dies, that realm becomes useless because it cannot
      create any more components aor realms inside of it, so better to kill it
      and lets realm owner know that realm was killed so that they can exit
      gracefully or create a new one.
      
      This will also complete bug CF-706 because now we have checks in place
      which ensure that appmgr doesn't crashdue to closed handles  when there
      is a oom.
      
      CF-706 #done
      
      TEST=fx run-test appmgr_integration_tests
      
      Change-Id: I4a06bc73d76fe44a075d63fc3f0f762a94a19a14
      3073a3fe
    • Roland McGrath's avatar
      [libc] Move setjmp implementation out of third_party/ulib/musl · 322467db
      Roland McGrath authored
      This code was all written from scratch for Fuchsia.
      Move it to system/ulib/c to make its provenance more clear.
      
      Test: no effect on the build
      Change-Id: I6b4105157c9233ad3b7ec41124c35cbf144c2ae0
      322467db
    • David Worsham's avatar
      [scenic] Convert ViewTokenPair to object · 426805c5
      David Worsham authored
      This unifies the API for C++, Dart, and Rust better.  All 3 language
      bindings are pretty idiomatic now.
      
      Tested: view_token_pair_test
      SCN-1214 #comment
      
      Change-Id: I00bcbde5ff64c747ce427764cdfffdf6530e1295
      426805c5
  2. Apr 26, 2019
    • Yifei Teng's avatar
      [fdio] Check in llcpp bindings for fuchsia-io · dceff158
      Yifei Teng authored
      This is the start of fdio conversion from C to LLCPP.
      
      TEST: Compiles
      Change-Id: Ia546d5199d9b73677cb30ae38b445f45225fea34
      dceff158
    • Yifei Teng's avatar
      [fidl] [llcpp] Validate that checked in bindings are up to date · 78ebdcd5
      Yifei Teng authored
      Implements fx build tools/fidlgen_llcpp_zircon:validate.
      In addition, adds the validation pass to the fuchsia build.
      
      Test: Use fuchsia-mem:llcpp somewhere, then change it. Observe that the
      build fails with an error prompting the user to re-run bindings
      generation.
      
      Change-Id: I376516c794120fa5faaaf4e2afaffc0283604d09
      78ebdcd5
    • Vardhan Mudunuru's avatar
      [modular] Fix build: Make modular_test_harness accessible outside of fuchsia.git buildbots · 267ab8cf
      Vardhan Mudunuru authored
      Change-Id: I24a609e37a42c956514076b330b924464e73ed41
      267ab8cf
    • Josh Gargus's avatar
      [escher] Rename PaperRenderer2 to PaperRenderer. · 962e4b01
      Josh Gargus authored
      ES-198 #done
      
      Change-Id: I5dcdec7f10067c90d0e8fc18d17069f26bbfeb59
      962e4b01
    • Yifei Teng's avatar
      [fidl] Generate and check in the llcpp bindings for fuchsia.mem · 7767c1fb
      Yifei Teng authored
      TEST: tried importing the generated fuchsia.mem in some test and it
      builds.
      
      Bug: ZX-3874
      
      Change-Id: Ibb963f4581e0f9fc1bfca862d36b6fb0a76335c0
      7767c1fb
    • Mike Voydanoff's avatar
      [dev][platform-bus] Remove support for proxying the I2C protocol · a202b3c3
      Mike Voydanoff authored
      This support is no longer being used.
      All drivers are now binding to the generic I2C either directly
      or as a composite device.
      
      TEST: Touch screen works on astro and cleo. runtests -t platform-bus-test.
      Change-Id: If189943cdabfebc2fab2df1010881daf458ada6b
      a202b3c3
    • Jeremy Manson's avatar
      [fidlcat] Fix issue with interface vector resizing. · 082d4818
      Jeremy Manson authored
      When the number of interfaces grows, the vector containing the interfaces
      grows with it.  This involves the interface being moved.
      
      When you generate an interface for the first time, each interface method is
      given a pointer to the enclosing interface.
      
      When the interface vector is resized, the interface method's pointer is
      dangling.
      
      This CL fixes the issue in two ways:
      
      - The move constructor for the interface now creates an updated interface
      method instead of reusing the old one.
      
      - Interface vector initialization now reserves enough space for all of the
      interfaces, so that moves will no longer be necessary.
      
      Change-Id: Ifa4c51f21bb3dc194695d5af5029a46b862ae907
      082d4818
    • Francois Rousseau's avatar
      [feedback] cancel the timeout if log collection already completed · b4c625d4
      Francois Rousseau authored
      * there is no need to run the underlying delayed task if the log collection already completed
      
      TESTED=manually removed the complete_ok() in Done() and checked the timeout callback is no longer called
      
      Change-Id: Ic844d6ca95ebe65d31651b080e4e26a4cece7870
      b4c625d4
    • Roland McGrath's avatar
      [zircon][gn] fidl_library() support for llcpp · 5f6c5d79
      Roland McGrath authored
      This implements half the FIDL generation for LLCPP bindings.  It
      can't be done fully the straightforward way until we can build the
      fidlgen tool (Go).  Instead, this integrates it halfway by doing the
      JSON generation part.  Then instead of running fidlgen, it produces
      a build API module (JSON) describing how it would have run fidlgen,
      and expects to find the fidlgen output files in the source tree.
      Later integration will take that information and do the regeneration
      and/or check that it doesn't need to be done, so that the
      higher-level build can verify what the Zircon build alone can't yet.
      
      Bug: BLD-442 #comment fidl_library() support for llcpp
      Bug: BLD-353 #comment Switchback for FIDL LLCPP bindings before unification
      Change-Id: Ied2e9972da1c1bb4957e29f98c721d96d8839d97
      5f6c5d79
    • Tim Stoutamore's avatar
      [zircon/ftl] Changed FTL-NDM interface from callbacks to direct function calls. · 03fe4c4f
      Tim Stoutamore authored
      1. Because Google app doesn't require callback interface between the FTL and
         the NDM, removed it to increase clarity and decrease lines of code.
      2. Changed some local variables from 'ftl' to 'ftl_cfg' to better differentiate
         between control block handles and temporary configuration structures.
      3. Removed ENOMEM definition from 'kernel.h'.
      4. Removed FsError() calls from routines in 'fsmem.c' since their callers
         invoke FsError2() if there is an error.
      5. Introduced 'ftl_pri.h' (for internal use) and 'ftl_pub.h' (for driver).
         Following check-ins will consolidate other headers into those files.
      
      Change-Id: I6c27dfd24755c5fda1e0cb5ba09e8707ce31b653
      03fe4c4f
    • Sean Klein's avatar
      [fshost] Refactor for testing; add unit tests. · aa3518da
      Sean Klein authored
      Create an abstract "BlockDeviceInterface" class, and
      add unit tests for it.
      
      Change-Id: Ie61268a11a217a27e23fabfbdd5873d01e734a8a
      aa3518da
    • Vardhan Mudunuru's avatar
      [overnet] Disable flakey overnet_examples_tests · 62159b8e
      Vardhan Mudunuru authored
      FLK-187
      FLK-188
      
      Change-Id: I25a5a2c72bd5a5348953e315142bc2bdc8fff610
      62159b8e
    • Bryce Lee's avatar
      [SetUI] Refactor SetUIService into a Struct. · e6bedd99
      Bryce Lee authored
      This changelist encapsulates the SetUIService into a struct/impl.
      This structure will facilitate future changes where state and logical
      units will need to exist across channels.
      
      Test: fx run-test setui_service_tests -- --test
      Bug: SU-167
      Change-Id: I850d75321a7d9f830bc611ba4ffc3bfcb6680534
      e6bedd99
    • Ariana Mott's avatar
      [Scenic] Frame Scheduler cleanup · 2a2d4141
      Ariana Mott authored
      Renamed session update function and moved CommandContext creation to
      be assigned the trace ID, rather than guess the next ID.
      
      Tested:
      - updated unittests
      - ran astro
      
      Change-Id: I421ffe839c9add7440361209cc881c66c80e0843
      2a2d4141
Loading