Skip to content
Snippets Groups Projects
  1. Apr 30, 2019
    • Allan MacKinnon's avatar
      [graphics][compute] Add graphics/lib/compute/common and common/vk to build · 3d49b2fe
      Allan MacKinnon authored
      Test: fx build src/graphics/lib/compute/common
      
      Change-Id: I6e49f2a9dec89515e00dd863d988bb26af207a86
      3d49b2fe
    • Mark Schott's avatar
      [fbl] Add type check to macros.h · ec17cc79
      Mark Schott authored
      You can currently test for the existence of member functions with the
      fbl macros, but not arbitrary member classes or typedefs. This CL adds
      support for that.
      
      It also adds tests for all of macros.h since those previously didn't
      exist.
      
      TEST: new file macro_tests.cpp
      Change-Id: If751e56a562ee37e89fb1962b124bf89b7d3de86
      ec17cc79
    • Jaeheon Yi's avatar
      [zircon][doc] Don't refer to Event objects in zx_object_signal_peer. · 6561adf3
      Jaeheon Yi authored
      This patch removes references to Event objects in zx_object_signal_peer,
      since Event objects don't have a peer.
      
      TEST: View in gtiles link.
      Change-Id: I7ca0bcf36ae0043b6b887a1ad86f72cc3aa15d80
      6561adf3
    • Mark Seaborn's avatar
      [benchmarks] Speed up the block IO performance test (biotime) · 8a556443
      Mark Seaborn authored
      Pass an option to biotime to reduce the time it takes.  Without
      passing this option, biotime reads the entire 111GB device, which is
      excessive and takes 3.9 minutes!
      
      Rename the "-tt" option to "-total-bytes-to-transfer" to make the code
      more self-documenting.
      
      Bug: PT-142
      Test: garnet-x64-perf-dawson_canyon trybot
        + check time taken shown in bot log
      Change-Id: I5f4b78179215e88a20dd914c832dcc77c37eb657
      8a556443
    • Christopher R. Johnson's avatar
      [libiquery] Reenable most tests, leaving out flaky ones. · 699af6d5
      Christopher R. Johnson authored
      Still investigating FLK-186, this change disables only affected tests.
      
      FLK-186: #comment
      Change-Id: Icf5831c0b3b161f38a8c7a126cc0723b9de30d95
      699af6d5
    • Venkatesh's avatar
      [kernel][x86] Introduce write_msr_on_cpu · 572b3510
      Venkatesh authored
      write_msr_on_cpu is a helper to write a value to an MSR on a particular
      CPU. The write must not cause a #GP fault as it is executed from a
      context that handles IPI functions.
      
      Tested:
      1) See succesor CR which adds k cpu rdmsr/wrmsr commands.
      
      2) Unit tests (x64_platform_tests) on qemu tcg, qemu kvm x64.
      
      ZX-3359
      
      Change-Id: I700a1997d47494904eda823f611eec253b8dace3
      572b3510
    • Ankur Mittal's avatar
      [libsys][testing] Fix Instructions in header. · 0a21e8fa
      Ankur Mittal authored
      Change-Id: Ia46e1a0848a1afe5ff467fcf87f13e0bd753458b
      0a21e8fa
    • Francois Rousseau's avatar
      [feedback] increase log collection timeout in test case · 8be4f991
      Francois Rousseau authored
      while it never fails locally for me (--gtest_repeat=10000), it seems that 1ms might be sometimes too short on the bots and the stub doesn't even have the time to send its first message
      
      FLK-206 #done #comment
      
      Change-Id: Iccedcfe592c654d4a999553214c4e853000d4f4f
      8be4f991
    • Vikram Auradkar's avatar
      [blobfs] Print info on finding invalid headers · 11db329e
      Vikram Auradkar authored
      Test: Ran blobfs-test to see the printed messages
      
      Change-Id: I44a4bf57d1414f285867653297415665e6c4be36
      11db329e
    • Robert Hahn's avatar
      [wlan][driver] Request SME channel in Start func. · 32eba8da
      Robert Hahn authored
      wlanmac and wlanif drivers request a channel to the SME from
      their parent when notifying those via the Start(...) callback
      in the respective protocol.
      The returned channel might be ZX_HANDLE_INVALID if the driver
      does not support the new approach.
      
      WLAN-927 #comment
      
      Test=Sanity check broadcom and ath10k
      
      Change-Id: I4bc2b7d1188964685c0321b0b638e9d90f523204
      32eba8da
    • Julie Hockett's avatar
      [fx][build] Generate the compilation database. · a1babf57
      Julie Hockett authored
      Fixes fx set/compdb and the build-zircon script to properly generate
      the compdb
      
      Change-Id: Ie4f32b66337349967036280e58780f41836827ec
      a1babf57
    • Pascal Perez's avatar
      [fidlc] Detect uneeded libraries provided to fidlc · d8403769
      Pascal Perez authored
      FIDL-600 #comment
      
      Change-Id: Ia850cc08a3a0757ea509216be8c1d5d302480ab4
      d8403769
    • Steffen Meschkat's avatar
      [e2e] add end to end test for the terminal product · f7c638ef
      Steffen Meschkat authored
      The test verifies that after reboot, the screen is not
      black. It could be used for more than one product, but is configured
      for now to test the terminal product.
      
      The test is in the directory src/end_to_end_tests. The directory
      src/ is organized by areas, but end to end tests by definition span
      areas, so they get their own area under src.
      
      That the test is added to the terminal product for now only makes it
      build when the build configuration is terminal.*. It doesn't cause
      the test to be executed by a CI/CQ builder of that product. That requires
      that the builder is configured to pick up tests with the label assigned
      to the test, e2e-terminal.
      
      How to execute the test on a linux workstation:
      
        fx set terminal.astro
        fx build
        fx reboot -r
        fx pave -1
        FUCHSIA_IPV4_ADDR=$(buildtools/linux-x64/dev_finder list) \
        FUCHSIA_SSH_KEY=${PWD}/.ssh/pkey \
        FUCHSIA_TEST_OUTDIR=${PWD}/outdir \
        ./out/default/host_x64/screen_is_not_black_test
      
      This is the output:
      
        00:00 +0: screen_is_not_black_test the startup screen is not black
        Target device: 192.168.1.231
        Try 0 at starting sl4f.
        Running over ssh: run fuchsia-pkg://fuchsia.com/sl4f#meta/sl4f.cmx
        SL4F has started.
        Saw a screen that is not black.
        Running over ssh: killall sl4f.cmx
        00:05 +1: All tests passed!
      
      INTK-1031 #comment This change adds the test to run in the new builder.
      
      Change-Id: I9bfe3055f12fd3dc58f94d57f82d15eadbb3137a
      f7c638ef
    • Kiet Tran's avatar
      [wlanstack] Migrate to Cobalt 1.0 · 1d2f41e6
      Kiet Tran authored
      Test:
      1. Manually verify that events are logged by Cobalt by setting
         also_log_locally flag in Cobalt config
      2. fx run-test wlanstack2-tests
      3. Metrics tables for connectivity_wlan contain data from April 25th
      
      Change-Id: I9a46fb991fddfdd73e73bc2774f9b2e116477d66
      1d2f41e6
    • Nick Cook's avatar
      [docs] Remove link to deprecated codelab. · 3241bfa1
      Nick Cook authored
      DX-1454
      
      Change-Id: I9594abd184836865e4bd6a2d53660acb32b355b2
      3241bfa1
    • Pascal Perez's avatar
      [fidlc] Check for unused using · 91d0df9b
      Pascal Perez authored
      - Tracking uses of dependencies, and verifying that all dependencies
      have been used at the end of a library compilation;
      - To uses through direct references or aliases, introducing library
      references which can be shared.
      
      FIDL-600 #comment
      
      Change-Id: I952f758232fab7f16fca6bffd8c2877378837754
      91d0df9b
    • James Tucker's avatar
      [build] restore the signed zedboots in updates · 9d705f58
      James Tucker authored
      This removes all build reliance on the update_kernels build argument. A
      cleanup is to follow that should alter many of the imperative statements to
      instead be declarative (i.e. switch boards to explicitly declare that they
      want EFI images or not).
      
      Test: observe manifest contents after build, ensure no non-signed entries are added, and signed entries are added, in appropriate cases.
      Bug: DNO-476 #done
      Change-Id: I1da14fd33f8c1e198340db7afd4bce5b40e6916f
      9d705f58
    • Pascal Perez's avatar
      [fidl] Removing unused using · bf762948
      Pascal Perez authored
      FIDL-600 #comment
      
      Change-Id: I6ed6005f858493330368b24bf12db1295646f42b
      bf762948
    • Robert Hahn's avatar
      [wlan][rsn] Improve Supplicant robustness · 3a8f9140
      Robert Hahn authored
      (1) Allow replays of the 3rd message of the 4-Way Handshake but
          explicitly never re-install any keys.
      (2) Install keys in the Supplicant after the 3rd message of the
          4-Way Handshake was exchanged.
      (3) Install keys in the Authenticator after the 4th message of the
          4-Way Handshake was received.
      (4) Simplify key reporting in ESS-SA
      
      Test:
      - Updated existing tests which cover these changes
      - Added additional test for replaying 3rd msg of the 4-Way Handshake.
      - Manual test with a various APs
      
      Change-Id: I587e18c274c8ec2574efe05366d421dae5fc57e4
      3a8f9140
    • Drew Fisher's avatar
      [devmgr] Add more logging around driver binding · dc0be681
      Drew Fisher authored
      We suspect that something may be causing occasional deadlock around the
      time that we attempt to bind the zxcrypt driver.  Add more logging, and
      increase verbosity in a couple places to see if we can narrow down where
      we're going awry.
      
      DNO-492 #comment
      TEST: no behavioral change, just more logging
      
      Change-Id: Ib03af33da1d67533599c80e4453ef27dc160950e
      dc0be681
    • John Sheu's avatar
      [banjo] Require enum declaration to set a value · 57dffb55
      John Sheu authored
      The parser grammar accepted enum declarations without an explicit value,
      but the AST processing does not.  We intend to enforce FIDL-like
      behavior of requiring all such declarations to have a value, so this
      change modifies the grammar to reflect this.
      
      Change-Id: Ieaa5e0f5dbd40f5b78341be3c626a3e073709328
      57dffb55
    • Bryan Henry's avatar
      [component_manager] Move from //garnet/bin/sys to //src/sys · cf83bd76
      Bryan Henry authored
      Change-Id: Id31ae5ae9c19d2f37f2d34b3e4af701b7af8e05e
      cf83bd76
    • Gary Bressler's avatar
      [fidl] Migrate pkg_resolver tests to use `spawn_local_stream_handler` · 4fec7a21
      Gary Bressler authored
      This makes mocking a fidl service slightly less boilerplatey.
      
      Change-Id: Ie98a5c5798bc32082763c1d63c33ef650cef356b
      4fec7a21
    • Tamir Duberstein's avatar
      [dhcp] move to //src/connectivity · db88aac9
      Tamir Duberstein authored
      dhcp_test_client is removed; it was apparently only used for manual
      testing, and we now have an automated test.
      
      Change-Id: I686ebd5d92970d0c809e461e4b6149074eb469b2
      db88aac9
    • Craig Tiller's avatar
      [overnet] Packet nub fuzzer fixes · 1068a307
      Craig Tiller authored
      Change-Id: Ia60b1ce5509059f20932a6d2676e9fc6d7690330
      1068a307
    • Carlos Pizano's avatar
      [kernel] Refactor handle processing · 02b2d533
      Carlos Pizano authored
      This change does not have new behaviors. It changes code
      structure to prepare for channel_write_etc implementation
      
      - New overload of RemoveHandleLocked(Handle*) and use of
        it instead pf RemoveHandleLocked(zx_handle_t)
      - Centralize handle operations related to channel in
        user_handles.
      
      TEST: existing channel-tests
      
      Change-Id: I45ae6b4915264e3a2d428a80dace28af7d54786b
      02b2d533
    • docs-roller's avatar
      [gndoc] Update GN build arguments documentation · a39048bd
      docs-roller authored
      Test: CQ
      
      Change-Id: I91823a0d0f12f2a26093ba5b0602a92afb4c7141
      a39048bd
    • David Gilhooley's avatar
      [virtio][input] Add input_touch unit tests · fe0f8857
      David Gilhooley authored
      Add unit tests for the virtio touchscreen
      functionality. This verifies that X and
      Y values are sent in the correct range,
      and that multiple fingers are tracked
      correctly.
      
      TEST: runtests -t virtio-test
      
      Change-Id: I5bd575dcd6155a18f6440ec6426d724f6187581f
      fe0f8857
    • Sean Klein's avatar
      [ramdisk][test] Delete UncleanShutdown test · 6a9ec4b9
      Sean Klein authored
      This test is inherently flaky, since it has
      a dependency on sleeping. This is not a useful
      end-to-end test, so remove it.
      
      FLK-205 #done
      
      Change-Id: Ic216e3b814b9bfecff028851c31edf9da7658c12
      6a9ec4b9
    • David Gilhooley's avatar
      [virtio][input] Extend QEMU multitouch ids · 90b35818
      David Gilhooley authored
      Add support for a new version id that QEMU
      can pass through for a multitouch device.
      
      DX-1364 #done
      
      TEST: Ran in AEMU and manually verified that the
            new virtio driver registered as an HID
            touchscreen and was sending valid HID
            reports.
      
      Change-Id: Ia5e57b07ff5278358abc6815426c5cee7b3a80be
      90b35818
    • Marie Janssen 💖's avatar
      [bt][bredr] Skip SDP discovery with no searches · 629148df
      Marie Janssen 💖 authored
      When a BR/EDR connection completes, we may search for services on the
      remote peer if any searches are registered.  If no searches are
      required, we should not connect to do nothing.
      
      Added a failure to FakeDomain when an expected outgoing L2CAP connection is
      added but never connected to.
      
      Also fx format-code
      
      BT-861 #done
      BT-857
      
      Test: bt-host-unittests
            (updated GAP_BrEdrConnectionManagerTest.ServiceSearch,
             GAP_BrEdrConnectionManagerTest.AddServiceSearchAll,
             SDP_ServiceDiscovererTest.*)
      Change-Id: Ib5730fa738718eba10ad29bd26695103cdfe01ee
      629148df
    • Braden Kell's avatar
      [mt8167][i2c] Do one dummy write on each bus when initializing · 63accd49
      Braden Kell authored
      This works around an issue where the first transaction after enabling
      the VGP1 regulator gets a NACK error.
      
      Also add a test to verify this behavior.
      
      Bug: ZX-3486
      Test: Rebooted 30 times, didn't see any I2C sensor failure messages
      Test: runtests -t mt8167-i2c-test
      Test: runtests -t mt8167s_ref-test
      Change-Id: Ife7555f8037c520d0e3c6b4aa050ed5bf2620612
      63accd49
    • Erick Tryzelaar's avatar
      [system-ota-test] Add an upgrade test · f851c88a
      Erick Tryzelaar authored
      This changes the test to perform a system OTA upgrade after the
      downgrade, assuming the `--amber-files` argument or `AMBER_FILES`
      environment variable is specified.
      
      Change-Id: I02aabaec293c4e8da568bf0ec03ac6ea29add577
      f851c88a
    • Nathaniel Manista's avatar
      [ledger] Add static Inspect objects for ledgers · 8ae91f5a
      Nathaniel Manista authored
      Change-Id: I828c47a7444896da759437fc69bd4f4931a02fbc
      8ae91f5a
    • Erick Tryzelaar's avatar
      [system-ota-tests] refactor test code · 438099d3
      Erick Tryzelaar authored
      This rewrites the OTA tests to be more object oriented and flexible.
      Major changes:
      
      * "amber" package is renamed to "packages" since amber is going away.
      * "packages" grows a bunch of methods to interact with the package
        repository. It's now possible to open packages and blobs and extract
        out package files.
      * "build" package is renamed to "artifacts".
      * "artifacts" grows a struct to represent a build artifact, which has
        the ability to provide the package repository and system snapshot.
      * Added a method to download the build-archive.tgz file (which is
        currently unused, but may be used later to support paving).
      
      Change-Id: I53c0fe1b3f0b3a2659828c6172be175f9b38c125
      438099d3
    • Ghanan Gowripalan's avatar
      [netstack3] Send an ICMP message for parameter problem parsing errors · bc67f562
      Ghanan Gowripalan authored
      BUG: NET-2241 #done
      
      Conditonally send ICMP Parameter Problem repsponses when failing to
      parse an IP Packet with a parameter problem error.
      
      Change-Id: Icc4424da5f47ac2c0113cf89cb14bb7125f44278
      bc67f562
    • Yifei Teng's avatar
      [build] [fidl] Generate llcpp targets in the legacy metadata · 64844b19
      Yifei Teng authored
      This allows low-level C++ bindings for Zircon FIDL libraries to be used
      in the Fuchsia build.
      
      TEST: Verify that the low-level C++ binding
      targets can be included in the fuchsia build.
      
      Change-Id: I4ca5b09a563b1eec8001c5d11d4a87f014d4f079
      64844b19
    • David Greenaway's avatar
      [docs] Fix broken link in "CONTRIBUTING.md". · 5a35e489
      David Greenaway authored
      Documentation has since been moved into the "docs/" subdirectory.
      
      Change-Id: I87fdadbd4eac87412efe48a80301370ad5a9c209
      5a35e489
    • Yifei Teng's avatar
      [build] [fidl] FIDL dependencies should be in public_deps in gn metadata · 2807911d
      Yifei Teng authored
      Putting dependencies in public_deps allows their headers to be exposed
      correctly.
      
      TEST: 1. Observe that the correct public_deps are emitted in
      out/default.zircon/legacy_targets-x64.json; 2. In a subsequent patch,
        verify that the low-level C++ binding targets can be included in the
        fuchsia build.
      
      Change-Id: Icb09077c33ef1d95922b51d112ebae1f4cbc5401
      2807911d
    • Sean Klein's avatar
      [block] Remove FVM ioctls · fa254335
      Sean Klein authored
      Change-Id: I8154dac79e9e569fe54f705d41ebaa868f7958d1
      fa254335
Loading