Skip to content
Snippets Groups Projects
  1. Jan 31, 2019
  2. Jan 30, 2019
  3. Jan 29, 2019
    • James Robinson's avatar
      [blobstats] Fork blobstats visualization template, improve · 29e20023
      James Robinson authored
      This forks the visualization template and dependencies of the blobstats
      tool and updates them to take into account features of blobs and
      packages, instead of pretending everything is a symbol in a binary.
      
      Improvements:
      * Update all terminology (symbol->blob, directory->package)
      * Add information about compressed and uncompressed sizes and reference
      count on shared blobs
      * Update colors to be more neutral
      * Update labels on entries to be more accurate
      * Update report naming and contents
      * Remove dead links
      * Add original and estimated compressed sizes to data model
      
      Also moves the code to its own directory and imports the d3 library
      instead of reaching into the Dart VM's internal directory.
      
      Test: fx blobstats
      
      Change-Id: I95cea2fa7e4c005d0917c991a726098326b00116
      29e20023
  4. Jan 28, 2019
    • Cristián Donoso's avatar
      [fx debug] Updated run to use the pkg naming. · 7d4da804
      Cristián Donoso authored
      Before is was relying on the deprecated "bare_package_url"
      
      CF-327  # Done
      
      TEST=Manual
      
      Change-Id: Iae9398ddba78d3f104e2a269d1f5581d00799e2b
      7d4da804
    • James Tucker's avatar
      [fx set] run in $FUCHSIA_DIR, new invariant · 2a70d8c5
      James Tucker authored
      There have been several bugs stemming from the fact that set was not changing
      it's directory. It produces GN arguments, many of which want to be relative
      to $FUCHSIA_DIR, rather than absolute. The build has similar invariants, with
      // being $FUCHSIA_DIR, and the build directory being the working directory
      during build execution.
      
      Test: fx set from sub-directory of root picks up a board file.
      Bug: BLD-352 #done
      Change-Id: If6a0e351ce4c5f52e1a6011387ce2fca27156934
      2a70d8c5
  5. Jan 27, 2019
  6. Jan 26, 2019
    • James Tucker's avatar
      [fx run] add //.ssh/authorized_keys before booting · fdce3091
      James Tucker authored
      This enables SSH into qemu instances that have networking, without having to
      bake SSH keys into the build artifacts.
      
      Change-Id: I19aa146cd752622ab79018180cfdc06aee1f2a7c
      fdce3091
    • James Tucker's avatar
      [fx set] add docs and deprecations · abeca9d4
      James Tucker authored
      --build-dir is now removed. It has been deprecated with notice for a long time.
      --{product,board,package}s are deprecated flags, no have messages.
      
      Additional documentation for --{board,product,monolith,preinstall,available}
      --netboot is documented.
      
      Example usage added.
      
      Change-Id: Ie8a3d4f2602c1f98d9c93bd35d9586a9c7b2c94f
      abeca9d4
  7. Jan 25, 2019
  8. Jan 24, 2019
    • Dale Sather's avatar
      [scripts] clarify dependency error in verify_layer.py · 6a8c9c5f
      Dale Sather authored
      This CL changes an error message produced by verify_layer.py. The
      message is generated when an 'all' package doesn't contain a
      package that was found in the packages/prod directory. The message
      was:
      
          Missing dependency in <all>: <package>
      
      This can be misinterpreted to mean that <package> is imported in
      <all> and doesn't exist. The new message is:
      
          The "all" package <all> does not import package <package>
      
      TEST: ./scripts/packages/verify_layer.py --layer garnet \
            --json-validator ./out/x64/host_x64/json_validator
      Change-Id: Id86a3f9dfd98ba3697f756f1b0957b295baa94ac
      6a8c9c5f
  9. Jan 22, 2019
  10. Jan 18, 2019
    • James Tucker's avatar
      [run-test] delegate all arguments to runtests · 18556910
      James Tucker authored
      This approach prevents argument escaping / corruption problems by largely
      avoiding parsing any extra arguments. This also enables access to more
      runtests arguments, such as those associated with asan and so on.
      
      Change-Id: I7662ac43a45013d054f8965252fa6f5c4cd8f0fa
      18556910
    • Gabriel Kerneis's avatar
      [fx] Do not split --flag=option after a -- separator · 4a30db15
      Gabriel Kerneis authored
      This is necessary for `fx run-test foo -- --gtest_filter=Foo.*` to work
      correctly. Otherwise, the command invokes:
        run_test_component fuchsia-pkg://foo --gtest_filter Foo.*
      and gtest cannot parse the split parameter.
      
      Tested: fx run-test
      Change-Id: I161bd54ae914c9d5190287f31f9caf55ea3c817e
      4a30db15
    • Xo Wang's avatar
      [fx][run-test] Don't strip = from forwarded test args · c7733f03
      Xo Wang authored
      fx-standard-switches strips = from arguments past --, which should be
      left intact and passed to the test invocation. Instead, filter the
      arguments directly from the run-test arguments.
      
      CF-324
      Test: (pending local changes component-izing Bluetooth tests)
      fx run-test bluetooth_tests -t bt-host-unittests -- --gtest_filter=\*
      
      Change-Id: I235d5d18f4b23a5083c38dc404a8b4501ddd451d
      c7733f03
    • Kevin Wells's avatar
      [fx][delta] Invoke pm directly · 9f6285c0
      Kevin Wells authored
      Invoke pm directly instead of proxying through fx, similar to how
      serve-updates invokes it.  When building product configs that don't
      include pm, "fx pm" fails to find the binary.
      
      Test: manual
      Change-Id: Id585f52de81ca9c1cdd94ec127e5a0f5126c7763
      9f6285c0
  11. Jan 17, 2019
    • James Robinson's avatar
      [blobstats] Update blob stats script to use paths within packages · a7daf11c
      James Robinson authored
      This updates the blobstats script to display the paths to blobs based
      on the path name used by the package containing them. The underlying
      storage charges and proportional counts are still computed on a
      blob-by-blob bases, based off of their hash. This uses the blobs.json
      metadata file generated by the build to determine the paths within
      packages.
      
      Also restructures the internals of blobstats to reflect that blobs
      don't have a meaningful path outside the context of a particular
      package, and avoids recomputing hashes of blobs to speed up the
      calculations and simplify the code.
      
      Also marks unique blobs as unique.
      
      Test: run 'fx blobstats' on builds including prebuilt_package entries
      BLD-342 #done
      
      Change-Id: I0a6a8d40ae8ad77d362068b5fc58fcd7390b83d2
      a7daf11c
  12. Jan 16, 2019
  13. Jan 15, 2019
  14. Jan 11, 2019
  15. Jan 10, 2019
  16. Jan 09, 2019
    • Gary Miguel's avatar
      [dart] Update report_coverage to work, somewhat. · 80955b55
      Gary Miguel authored
      Note some tests still report no coverage data, tracked by
      https://github.com/flutter/flutter/issues/20551.
      
      Test: Built topaz, ran scripts/report_coverage.py
      Change-Id: I6d58dc0b3ead74644c32e710f8f7e76e6a73724c
      80955b55
    • Aidan Wolter's avatar
      Revert "Add argument for specifying qemu disk size" · 4aa281e8
      Aidan Wolter authored
      This reverts commit 4b45a9a8.
      
      Reason for revert: We should use `fvm_image_size` instead.
      
      Original change's description:
      > Add argument for specifying qemu disk size
      > 
      > `-S <size>` can now be used immediately after `fx run` to specify the
      > qemu disk size. Acceptable sizes are anything that qemu-img accepts.
      > 
      > We have also added a help text for `run` that describes this new option.
      > `fx help run` and `fx run -h` both show this help text.
      > 
      > Argument to pass to `run-zircon` now need to be separated by a `--`, and
      > arguments to pass to `qemu` by `-- --`.
      > 
      > Bug: None
      > Test: `fx run -- -k`, `fx run -S 2G`, `fx run -S 2G -- -k`, `fx run -h`, `fx run -- -h`
      > Change-Id: Idebb7466890bf59f8b9dbb90de34adfdec54391b
      
      TBR=mcgrathr@google.com,raggi@google.com,porce@google.com,awolter@google.com
      
      # Not skipping CQ checks because original CL landed > 1 day ago.
      
      Bug: None
      Change-Id: Id166dd872b031872f31752893e13d69454b7176e
      4aa281e8
  17. Jan 07, 2019
    • Rich Kadel's avatar
      Improved xcode-select check. · 2e1215c3
      Rich Kadel authored
      Fixed typo ("xcode-select install" does not work. The command should be:
      "xcode-select --install".)
      
      Added logic to check for the need to install the xcode command line
      tools, and a new check for possible need to "switch" xcode-select
      to the command line tools. (CommandLineTools directory contains
      /usr/include and C++ header files, but the XCode application
      developer directory does not.)
      
      Added new info message to let the user know that their environment
      looks good, if there were no issues found.
      
      Change-Id: I37aab02d33145e34c51b87a3feca959324187fd7
      2e1215c3
    • Ankur Mittal's avatar
      [run-test] Allow dev to pass args to test · 077ad05a
      Ankur Mittal authored
      Also remove device flag because it no longer works
      
      Change-Id: I059c9c418136c34202a09dfdc2903e6e7b6a5684
      077ad05a
    • Rich Kadel's avatar
      Added "check_cd" function to "fx doctor" · afee8afa
      Rich Kadel authored
      verify "cd" does not output anything to stdout, since many
      other scripts assume this.
      
      Note that check_cd optionally prints recommendations for
      resolving the issue within the developer's shell environment.
      
      For bash users only, doctor calls
      scripts/devshell/lib/bashrc_checkup.sh,
      which will attempt to load their ~/.bashrc
      file, to allow doctor to check for conflicts in the interactive
      shell environment (e.g., functions like overriding "cd").
      
      For users using non-bash shells (like zsh) this current iteration
      of "doctor" will still check environment variables and files
      through the non-interactive bash script, but we may want to add
      a "zshrc_checkup.zsh" script as well if we want to check for zsh-specific
      interactive shell conflicts. (The bash "doctor" could still
      launch other non-bash shell checks.)
      
      Updated "doctor" script format and error handling a bit. Needs more
      work to be easier to use and easier to add more checks.
      
      Added --indent flag to style.sh and moved common terminal output
      style functions, originally in doctor, to
      devshell/lib/common_term_styles.sh, for reusability.
      
      Change-Id: I3b054609e87274f49479c93c3a6c2e29bb7136eb
      afee8afa
  18. Jan 04, 2019
  19. Jan 03, 2019
  20. Dec 23, 2018
    • Rich Kadel's avatar
      Improved style.sh · 49ef691a
      Rich Kadel authored
      Better reverse video for multiline text.
      
      Usage and help including option to list style options.
      
      Visual test script in //scripts/tests
      
      Also added an automated test and "expected" files
      
      Change-Id: Ie095c31e01bc3ebdc384d3d13d5d7fb151f948ce
      49ef691a
  21. Dec 22, 2018
    • Rich Kadel's avatar
      Adds a new utility to print styled & colored text · 1d10d2f1
      Rich Kadel authored
      Patched with some code optimizations. Output file descriptor is
      now parameterized (figured out how to make this work without eval).
      All stylized output is now combined into a single printf call.
      
      Patched to allow user to override standard styles for error,
      warning, info, and link, to accommodate preferences and different
      screen backgrounds (dark and light).
      
      Change-Id: Ib443044fb42dc85ad55a863b8284304f5af0a35d
      1d10d2f1
Loading