Skip to content
Snippets Groups Projects
  1. Apr 30, 2019
    • Alex Legg's avatar
      [ddk] Remove open_at device hook · 5c933238
      Alex Legg authored
      The DirectoryOpen handler will be removed along with resulting changes
      to devfs in a follow up CL.
      
      Change-Id: I37df4c6bdf2aba84575a5ab6b692b2da5f362185
      5c933238
    • Bryan Henry's avatar
      [OWNERS] Add OWNERS for //src/sys · 15388e3f
      Bryan Henry authored
      Change-Id: I66ba34b62e687aab5a48b9b78f09515535cc210f
      15388e3f
    • Kiet Tran's avatar
      [wlan][sme] Log BSSIDs when rejecting EAPOL from foreign BSS · 0ce60691
      Kiet Tran authored
      Test: Only logging change
      Change-Id: Ifd2c2c5c60a12989f12b9a5146dc020cb61fe700
      0ce60691
    • Aaron Green's avatar
      [scripts][fuzzing] Replace .config with .fx-build-dir · f8e92301
      Aaron Green authored
      This CL brings 'fx fuzz' into alignement with the 'frankenbuild', in
      particular it updates how to find the build directory and the zircon
      host tools.
      
      Bugs: SEC-274
      Test: scripts/fuzzing/test/host_test.py
      Change-Id: I3b9c36a8d79d15eb69a2a6d0133e270847b2ed49
      f8e92301
    • docs-roller's avatar
      [gndoc] Update GN build arguments documentation · e7aa9c93
      docs-roller authored
      Test: CQ
      
      Change-Id: Ia9018276eb268edbd26eeb3e9d3545335fb3dcd0
      e7aa9c93
    • Kevin Lindkvist's avatar
      [component_manager] Move Rust io_utils into a separate library · 81ba24ba
      Kevin Lindkvist authored
      Change-Id: I831b5b57d2ff2e3507331b239e7c283cb817812c
      81ba24ba
    • Dale Sather's avatar
      [mdns] transition to new fuchsia.net.mdns FIDL API · dca69da3
      Dale Sather authored
      This CL removes the fuchsia.mdns FIDL API definition and transitions
      the implementation and all clients to the new fuchsia.net.mdns API.
      
      This change breaks the ability to generate traffic logs, the
      SetVerbose method being absent from the new FIDL definition. This
      capability will be restored, probably via /hub.
      
      TEST: no behavior change, multiple regression tests in CQ
      
      Change-Id: I6438f0a8fd316efa33a87908d41b8f9961e523d6
      dca69da3
    • Manali Bhutiyani's avatar
      [minfs] disk-inspector Part 1: Define the inspector interface · 21712cb4
      Manali Bhutiyani authored
      This change defines the disk inspector interface and also implements
      basic datatypes like int32,in64, uint32,uint64, as well as uint32[] and uint64[]
      
      Tests: Added tests to verify the behavior of the inspector library.
      
      Change-Id: Ia87f490bb0ab52ce673785e4881f7f8caa6e53bb
      21712cb4
    • Kevin Wells's avatar
      [amber][pkg_resolver][pkg_cache] Refactor BUILD.gn · cce759bd
      Kevin Wells authored
      This change modifies the package() template parameters for amber,
      amber_tools, pkg_resolver, and pkg_cache to first invoke one or more
      fuchsia_component templates and then aggregate those components into the
      final packages.  This change is a no-op for now, but it will allow later
      test cases to also aggregate these components into the test package.
      
      PKG-604 #comment extract fuchsia_component templates
      
      Change-Id: I3dae02ffd33ee410962ed622e6e664aaf309923c
      cce759bd
    • Leo Lung's avatar
      [component_index][locate] Add locate tool · 370367ed
      Leo Lung authored
      Supports matching of exactly one component, or --list to match more than
      one component.
      
      CF-162 #comment
      
      TEST=
      fx run-test locate_integration_test
      
      locate tiles_ctl
      fuchsia-pkg://fuchsia.com/tiles_ctl#meta/tiles_ctl.cmx
      
      locate ctl
      fuchsia-pkg://fuchsia.com/stash_ctl#meta/stash_ctl.cmx
      fuchsia-pkg://fuchsia.com/tiles_ctl#meta/tiles_ctl.cmx
      ...
      Error: "ctl" matched more than one component. Try `locate --list` instead.
      
      locate --list ctl
      fuchsia-pkg://fuchsia.com/stash_ctl#meta/stash_ctl.cmx
      fuchsia-pkg://fuchsia.com/tiles_ctl#meta/tiles_ctl.cmx
      ...
      
      locate --list tiles_ctl
      fuchsia-pkg://fuchsia.com/tiles_ctl#meta/tiles_ctl.cmx
      
      locate leolung
      Error: "leolung" did not match any components.
      
      locate
      locate foo bar
      locate --list foo bar
      locate --list
      Usage: locate [--list] <search_keyword>
      
      Locates the fuchsia-pkg URL of <search_keyword>.
      
      Options:
        --list    Allows matching of more than one component.
      Error: Unable to parse args.
      
      locate rolldice
      fuchsia-pkg://fuchsia.com/rolldice#meta/rolldice.cmx
      
      run `locate rolldice`
      +---+
      |* *|
      |* *|
      |* *|
      +---+
      
      Change-Id: Iafa1cc048b2940967e08b3c4f244a1945b6bea00
      370367ed
    • Cristián Donoso's avatar
      [debugger] Unified breakpoint/watchpoint IPC. · 4c746ff0
      Cristián Donoso authored
      Breakpoints and Watchpoint have a lot of overlap, especially in the
      client. Having a separate IPC type would duplicate a lot of handling
      within the client and console. This will permit to reuse a lot of that
      code.
      
      TEST=Updated the protocol unit tests.
      
      Change-Id: I02214064a71527cf147155280e15e18fb4f90336
      4c746ff0
    • Dan Johnson's avatar
      [amber] add OpenRepository support to amber · ff3b5d60
      Dan Johnson authored
      Bug: PKG-661
      Change-Id: I06bc2b3bedae9064804a8d0f0d181a5d954af1ff
      ff3b5d60
    • David Pursell's avatar
      [handle][vcpu] Create() KernelHandles · caba7bd8
      David Pursell authored
      No behavior change, just moving from raw Dispatchers to KernelHandles to
      ensure we properly clean up on errors.
      
      ZX-3612
      
      Test: runtests
      Test: scripts/run-zircon-x64 -C -b -k -z build-clang/core-tests-x64.zbi
      Change-Id: I113c354a86f07331d79bfea98dbcb798b4f80f79
      caba7bd8
    • John Sheu's avatar
      [zircon][gn][banjo] Generalize C/C++ generation and fix include paths · 4ebed34b
      John Sheu authored
      The present Banjo invocation through GN have hard-coded logic for Banjo
      files in the ddk.protocol.* namespace, in that:
      
      * It uses this namespace to distinguish the "dummy" targets (outside of
        this namespace) that shadow manually-written headers elsewhere in the
        DDK.
      * The banjo/c.gni and banjo/cpp.gni sub-implementations also hard-code
        assumptions that the generated files will live in ddk/protocol/*
        subdirectories in the generated output.
      
      This change removes the hard-coded assumption for ddk/protocol/* from
      banjo/c.gni and banjo/cpp.gni, as well as laying the groundwork for
      supporting an additional set of non-dummy Banjo files in the ddk.hw.*
      namespace.
      
      Change-Id: Ie5cf0e2001baffb27bd4f6dbcf38321a69d71dce
      4ebed34b
    • Shac Ron's avatar
      [ahci] cppify sata.cpp · a376728d
      Shac Ron authored
      Improved bind resource handling.
      Added sata_devinfo_response_t for simpler info parsing.
      Correctly print the serial, firmware, and model strings.
      Add unit tests to AHCI.
      
      Test: qemu AHCI disk tests, unit tests success.
      Change-Id: Id6560279eec7e95a1d22c041f9edd568bba3203b
      a376728d
    • Gabriel Schine's avatar
      [fx] Add fx make-integration-patch · 27b43ddd
      Gabriel Schine authored
      Sample output:
      INSTRUCTIONS:
      
      For each change you wish to test with global integration:
        1) Navigate to the change in Gerrit's web UI
        2) Click on Download Patch (in the menu at the top right)
        3) Copy any of the download options
        4) Paste it here followed by a newline
      
      When all changes have been added, type ^D
      
      ... GO!
      
      git fetch "https://fuchsia.googlesource.com/fuchsia" refs/changes/08/272008/11 && git checkout FETCH_HEAD
      git fetch "https://fuchsia.googlesource.com/fuchsia" refs/changes/08/272008/11 && git checkout FETCH_HEAD
      
      I'm about to write /usr/local/google/home/thatguy/src/fuchsia/integration/patches.json with the following contents
      and then upload the patch file to Gerrit:
      
      [
        {
          "ref": "refs/changes/68/275868/2",
          "host": "fuchsia.googlesource.com",
          "project": "fuchsia"
        },
        {
          "ref": "refs/changes/68/275868/2",
          "host": "fuchsia.googlesource.com",
          "project": "fuchsia"
        }
      ]
      
      Do you want to continue? [yN] y
      <snip>
      
      Change-Id: I1eb2ad78f492eeb75eea0fb997f0e0e930a35d6d
      27b43ddd
    • Pascal Perez's avatar
      [fidlc] Filter out zx when checking unused libs · 2d2bab53
      Pascal Perez authored
      Without filtering, the output was confusing:
      
          $ cat useszx.fidl
          library usesszx;
          using zx;
          struct Foo { zx.status status; };
          $ cat doesnotusezx.fidl
          library doesnotusezx;
          $ fidlc --files useszx.fidl --files doesnotusezx.fidl
          warning: Unused libraries provided via --files: usesszx, zx
      
      Change-Id: Ia63ad15c3f047839c7c07218cddf627bafd062e6
      2d2bab53
    • Craig Stout's avatar
      [magma] Fix gn unused variable · 5450dabe
      Craig Stout authored
      Test:
      fx set core.arm64 --args build_libvulkan_qcom_adreno=[<path>]
      
      Change-Id: I6f8dac9174f3dbba0c03fad86203075b49de44e0
      5450dabe
    • Pat Erley's avatar
      [e2e][audio] Write canary values to vmo after reading · 25f27468
      Pat Erley authored
      There is still some interesting glitching in the e2e test.  Write a
      canary value to the vmo after reading to see where the glitchy audio
      is coming from.
      
      Test: Ran e2e test locally, confirmed it still works.
      Change-Id: I83ab3c29c989317d9b98a29996d37fcee44b782a
      25f27468
    • Pascal Perez's avatar
      [fidlc] Adding JSON generation tests for constants · 34e9d91c
      Pascal Perez authored
      Constants can appear as constants, in enums, bits, or on default values.
      
      Change-Id: I89d05b585201aed9e09be24456d5f33b48c4259a
      34e9d91c
    • David Pursell's avatar
      [handle][suspend] Create() KernelHandles · fb4c34dc
      David Pursell authored
      No behavior change, just moving from raw Dispatchers to KernelHandles to
      ensure we properly clean up on errors.
      
      ZX-3612
      
      Test: runtests
      Change-Id: I49adeedd337f1b624ec3b8a83f2814128a66c424
      fb4c34dc
    • David Pursell's avatar
      [handle][socket] Create() KernelHandles · bbc9ef50
      David Pursell authored
      No behavior change, just moving from raw Dispatchers to KernelHandles to
      ensure we properly clean up on errors.
      
      ZX-3612
      
      Test: runtests -t socket-test
      Change-Id: Ief6a571c1c9f90ef9aefa0495cc4a56ae163d253
      bbc9ef50
    • Sen Jiang's avatar
      [omaha-client] Read Apps and Config from build-info. · a4a7b613
      Sen Jiang authored
      /config/build-info/omaha_product_id for app id and
      /config/build-info/omaha_build_id for app version.
      These two files will be generated by console and they currently do not
      exist in any build yet.
      
      Bug: PKG-678 #done
      Test: fx shell run fuchsia-pkg://fuchsia.com/omaha_client#meta/omaha_client_service.cmx
      Change-Id: Icf2267beb0dcf2719e5f02899053a53c215bba1c
      a4a7b613
    • Rob Krten's avatar
      [docs][inspect] Change Object -> Node · 0ec59536
      Rob Krten authored
      Rename "object" to "node" including diagrams and code examples.
      
      Change-Id: Ic03171bf37655a5131748fba529ee48fd6d5d8d3
      0ec59536
    • Arman Uguray's avatar
      [bt][hci] Use correct local address when connecting · 56e658a7
      Arman Uguray authored
      The locally initiated LE connection procedure now obtains the local
      address type from the LE address manager. When privacy is enabled, the
      bt-host now creates connections using a RPA.
      
      This also fixes an issue with RemoteDevice expiration during a long
      running connection attempt by marking the peer as non-temporary during
      the initialization. This issue was surfaced by an integration test in the
      GAP_AdapterTest tests that exercises the RPA timeout with a hanging
      connection request.
      
      BT-739 #done
      Test: 1. bt-host-unittests, bt-integration-tests
            2. Pair with a LE keyboard while privacy is enabled.
               Reconnection after a disconnect should succeed.
      	 Confirm that a random address was used to initiate
      	 the connection by looking at the snoop logs.
      
      Change-Id: I76e131dabc18a39aa684b9e87b02eb19ddf69cb6
      56e658a7
    • Allan MacKinnon's avatar
      [graphics][compute] Add graphics/lib/compute/common and common/vk to build · 3d49b2fe
      Allan MacKinnon authored
      Test: fx build src/graphics/lib/compute/common
      
      Change-Id: I6e49f2a9dec89515e00dd863d988bb26af207a86
      3d49b2fe
    • Mark Schott's avatar
      [fbl] Add type check to macros.h · ec17cc79
      Mark Schott authored
      You can currently test for the existence of member functions with the
      fbl macros, but not arbitrary member classes or typedefs. This CL adds
      support for that.
      
      It also adds tests for all of macros.h since those previously didn't
      exist.
      
      TEST: new file macro_tests.cpp
      Change-Id: If751e56a562ee37e89fb1962b124bf89b7d3de86
      ec17cc79
    • Jaeheon Yi's avatar
      [zircon][doc] Don't refer to Event objects in zx_object_signal_peer. · 6561adf3
      Jaeheon Yi authored
      This patch removes references to Event objects in zx_object_signal_peer,
      since Event objects don't have a peer.
      
      TEST: View in gtiles link.
      Change-Id: I7ca0bcf36ae0043b6b887a1ad86f72cc3aa15d80
      6561adf3
    • Mark Seaborn's avatar
      [benchmarks] Speed up the block IO performance test (biotime) · 8a556443
      Mark Seaborn authored
      Pass an option to biotime to reduce the time it takes.  Without
      passing this option, biotime reads the entire 111GB device, which is
      excessive and takes 3.9 minutes!
      
      Rename the "-tt" option to "-total-bytes-to-transfer" to make the code
      more self-documenting.
      
      Bug: PT-142
      Test: garnet-x64-perf-dawson_canyon trybot
        + check time taken shown in bot log
      Change-Id: I5f4b78179215e88a20dd914c832dcc77c37eb657
      8a556443
    • Christopher R. Johnson's avatar
      [libiquery] Reenable most tests, leaving out flaky ones. · 699af6d5
      Christopher R. Johnson authored
      Still investigating FLK-186, this change disables only affected tests.
      
      FLK-186: #comment
      Change-Id: Icf5831c0b3b161f38a8c7a126cc0723b9de30d95
      699af6d5
    • Venkatesh's avatar
      [kernel][x86] Introduce write_msr_on_cpu · 572b3510
      Venkatesh authored
      write_msr_on_cpu is a helper to write a value to an MSR on a particular
      CPU. The write must not cause a #GP fault as it is executed from a
      context that handles IPI functions.
      
      Tested:
      1) See succesor CR which adds k cpu rdmsr/wrmsr commands.
      
      2) Unit tests (x64_platform_tests) on qemu tcg, qemu kvm x64.
      
      ZX-3359
      
      Change-Id: I700a1997d47494904eda823f611eec253b8dace3
      572b3510
    • Ankur Mittal's avatar
      [libsys][testing] Fix Instructions in header. · 0a21e8fa
      Ankur Mittal authored
      Change-Id: Ia46e1a0848a1afe5ff467fcf87f13e0bd753458b
      0a21e8fa
    • Francois Rousseau's avatar
      [feedback] increase log collection timeout in test case · 8be4f991
      Francois Rousseau authored
      while it never fails locally for me (--gtest_repeat=10000), it seems that 1ms might be sometimes too short on the bots and the stub doesn't even have the time to send its first message
      
      FLK-206 #done #comment
      
      Change-Id: Iccedcfe592c654d4a999553214c4e853000d4f4f
      8be4f991
    • Vikram Auradkar's avatar
      [blobfs] Print info on finding invalid headers · 11db329e
      Vikram Auradkar authored
      Test: Ran blobfs-test to see the printed messages
      
      Change-Id: I44a4bf57d1414f285867653297415665e6c4be36
      11db329e
    • Robert Hahn's avatar
      [wlan][driver] Request SME channel in Start func. · 32eba8da
      Robert Hahn authored
      wlanmac and wlanif drivers request a channel to the SME from
      their parent when notifying those via the Start(...) callback
      in the respective protocol.
      The returned channel might be ZX_HANDLE_INVALID if the driver
      does not support the new approach.
      
      WLAN-927 #comment
      
      Test=Sanity check broadcom and ath10k
      
      Change-Id: I4bc2b7d1188964685c0321b0b638e9d90f523204
      32eba8da
    • Julie Hockett's avatar
      [fx][build] Generate the compilation database. · a1babf57
      Julie Hockett authored
      Fixes fx set/compdb and the build-zircon script to properly generate
      the compdb
      
      Change-Id: Ie4f32b66337349967036280e58780f41836827ec
      a1babf57
    • Pascal Perez's avatar
      [fidlc] Detect uneeded libraries provided to fidlc · d8403769
      Pascal Perez authored
      FIDL-600 #comment
      
      Change-Id: Ia850cc08a3a0757ea509216be8c1d5d302480ab4
      d8403769
    • Steffen Meschkat's avatar
      [e2e] add end to end test for the terminal product · f7c638ef
      Steffen Meschkat authored
      The test verifies that after reboot, the screen is not
      black. It could be used for more than one product, but is configured
      for now to test the terminal product.
      
      The test is in the directory src/end_to_end_tests. The directory
      src/ is organized by areas, but end to end tests by definition span
      areas, so they get their own area under src.
      
      That the test is added to the terminal product for now only makes it
      build when the build configuration is terminal.*. It doesn't cause
      the test to be executed by a CI/CQ builder of that product. That requires
      that the builder is configured to pick up tests with the label assigned
      to the test, e2e-terminal.
      
      How to execute the test on a linux workstation:
      
        fx set terminal.astro
        fx build
        fx reboot -r
        fx pave -1
        FUCHSIA_IPV4_ADDR=$(buildtools/linux-x64/dev_finder list) \
        FUCHSIA_SSH_KEY=${PWD}/.ssh/pkey \
        FUCHSIA_TEST_OUTDIR=${PWD}/outdir \
        ./out/default/host_x64/screen_is_not_black_test
      
      This is the output:
      
        00:00 +0: screen_is_not_black_test the startup screen is not black
        Target device: 192.168.1.231
        Try 0 at starting sl4f.
        Running over ssh: run fuchsia-pkg://fuchsia.com/sl4f#meta/sl4f.cmx
        SL4F has started.
        Saw a screen that is not black.
        Running over ssh: killall sl4f.cmx
        00:05 +1: All tests passed!
      
      INTK-1031 #comment This change adds the test to run in the new builder.
      
      Change-Id: I9bfe3055f12fd3dc58f94d57f82d15eadbb3137a
      f7c638ef
    • Kiet Tran's avatar
      [wlanstack] Migrate to Cobalt 1.0 · 1d2f41e6
      Kiet Tran authored
      Test:
      1. Manually verify that events are logged by Cobalt by setting
         also_log_locally flag in Cobalt config
      2. fx run-test wlanstack2-tests
      3. Metrics tables for connectivity_wlan contain data from April 25th
      
      Change-Id: I9a46fb991fddfdd73e73bc2774f9b2e116477d66
      1d2f41e6
    • Nick Cook's avatar
      [docs] Remove link to deprecated codelab. · 3241bfa1
      Nick Cook authored
      DX-1454
      
      Change-Id: I9594abd184836865e4bd6a2d53660acb32b355b2
      3241bfa1
Loading