- Sep 26, 2018
-
-
Craig Tiller authored
(And a flaky test) Test: Added a (deterministically) broken test and fixed it. Change-Id: Ic16eb0baeb611cc6180e2ca3cc18611eceedfebb
-
Christopher R. Johnson authored
Constructing fit::deferred_action() properly set pending to false, but constructing fit::deferred_action(nullptr) created a new pointer to a null target, setting pending to true. This caused a crash on deferred actions in peridot, where we previously initialized a null autocall. TEST=fit-test Change-Id: I63ee00704b1a3b635834b01c79aa02d0c0e25b89
-
Doug Evans authored
Adds source to the disassembly output. Tested: GDB=/path/to/gdb-8.2 fx symbolize --gdb=$GDB <foo.log fx symbolize --gdb=$GDB -d <foo.log fx symbolize --gdb=$GDB -S <foo.log fx symbolize --gdb=$GDB -d -S <foo.log Change-Id: I2f34c5b0a8a7dcb9b9d03f1225d20ce1806459ed
-
Aaron Green authored
This CL applies the fix from upstream located at: https://git.musl-libc.org/cgit/musl/diff/src/string/memmem.c?id=51bdcdc42 SEC-130 #done Tests: Ran runtests Change-Id: Ic90032f83ec685ded5bf67e34484019290bb6c92
-
Andres Oportus authored
The TPM driver uses I2C IOCTL_I2C_SLAVE_IRQ IOCTL. This change removes this in favor of the I2C protocol call i2c_get_interrupt(). This is a step towards removing IOCTL based communication between drivers. ZX-2621 #comment Use I2C protocol instead of I2C get IRQ IOCTL in TPM Test: 'tpmctl save' runs with no error on Pixelbook. Change-Id: Ie77bb3a0389b9f04bae519723eb890a9b60bb0fd
-
Ankur Mittal authored
ZX-2207 #done TEST=exception_tests Change-Id: I305d3bf9088dff7f0b6f6c9e824d5ecb8f2c3e36
-
Garratt Gallagher authored
With this CL, Sysmem can now be used to allocate basic bufffer collections through the AllocateCollection function. BufferUsages are currently ignored, and multiplanar formats are not supported. This is really just to test out the basics of Sysmem. A client library with unit tests is broken out into the next CL. TEST = CQ Change-Id: I851c71e41373a577eab59f7872c25856ae409cb9
-
Travis Geiselbrecht authored
Move from returning a status and the page pointer and/or physical address in an argument. Tested: build and runtests on both x86 and arm Change-Id: If10d877f152d355bfa1359338cd71f5aefbccfb4
-
Brijen Raval authored
Test: Boot up on astro, and "clkctl measure" Change-Id: I01c45eb65cf466cd0fdf60ed0d196e34cabb3a45
-
Travis Geiselbrecht authored
Was never used anyway, clean up the api. Tested: build and runtests on both x86 and arm Change-Id: I6880cace4ee20a89f6f4d50f1192eb3bcb56cead
-
Andres Oportus authored
Before this change 'tpmctl save' would fail on Pixelbook because we would create 2 tpm devices as in: $ lsdev /dev/class/tpm/000 topological path for /dev/class/tpm/000: /dev/sys/pci/00:15.1/i2c-bus-9d61/0050 $ lsdev /dev/class/tpm/001 topological path for /dev/class/tpm/001: /dev/sys/pci/00:15.1/i2c-bus-9d61/0050/tpm and tpmctl is hardcoded to look for /dev/class/tpm/000. We were creating these 2 devices, one for the I2C slave added with protocol ZX_PROTOCOL_TPM as part of the controller binding and one added by the TPM driver binding due to the PCI_VID/PCI_DID/I2C_ADDR rules in dev/misc/bind.c. The device representing the I2C slave should not implement the TPM protocol, hence this change removes that. Test: 'tpmctl save' runs with no error on Pixelbook. Change-Id: Ibdeee830453c4e5659b17ad20618eb98460b872d
-
Jocelyn Dang authored
If the client terminated early, the xdc-server would crash writing to their socket. Now we will be returned an error instead. TEST= terminate xdc client program early. Change-Id: I33f712bdcddeb690ece53bcc9f45751fc8893304
-
Aaron Green authored
This CL add the 'fuzz stop' command, which will kill a running fuzz task. SEC-103 Tests: Added unit test. Change-Id: Id97dfc3012b514eb7cbdc09a0f07e98f9c794bf3
-
Andres Oportus authored
The Intel I2C driver supports IOCTLs that are used by other drivers, this change replaces drivers calls to IOCTL_I2C_SLAVE_IRQ with a new I2C protocol call i2c_get_interrupt(). This is a step towards removing IOCTL based communication between drivers. ZX-2621 #comment Use I2C protocol instead of I2C get IRQ IOCTL Test: 'hidtouch' in Acer12 (touch panel HID support gets an I2C IRQ) Change-Id: I742201ce81ed20b84622e736df4ca29804a37e65
-
Sean Klein authored
Deprecating this path ensures that VnodeFiles always create their own VMOs, which simplifies their accounting. Test: CQ Change-Id: Ibcf7da9c0839e03e7dfa12ee066f226f3d9ea69a
-
Andres Oportus authored
The Intel I2C driver supports IOCTLs that are used by other drivers, this change replaces drivers calls to IOCTL_I2C_SLAVE_TRANSFER with the I2C protocol's calls i2c_transact() and friends. This is a step towards removing IOCTL based communication between drivers. ZX-2621 #comment Use I2C protocol instead of I2C transfer IOCTL Test: 'hidtouch' and 'audio' uapps in Pixelbook (touch panel and audio use I2C) and 'hidtouch' in Acer12 (touch panel uses I2C) Change-Id: Ic10ed2acc2ac69ed1ec2172f48392180aa0c37e6
-
Adam Barth authored
Many of these are unused. The rest can use the declarations generated by FIDL. Test: No behavior change Change-Id: I16e3834b6226c3739b7266d558c8e5ea4970a1ac
-
Eric Holland authored
TEST: Tested on astro hardware (clkctl measure) Change-Id: I6a223e0eef1cb728e772d3aabf7c91291e93b7d1
-
Benjamin Lerman authored
This is useful for test to be able to simulate time advancing while doing operations. TEST=TimeIsAdvanced in test_loop_tests.cpp Change-Id: Icd3e78d8869e1e8efd53a9a993bd936bc90373d9
-
Benjamin Lerman authored
This will allow tests to use the same seed for the test loop and any other randomness they might use. TEST=No change of behavior. Change-Id: Ied7c86ce4b46f1f690e647b2f10b83bc9d49633e
-
Sean Klein authored
Additionally... - Fix the FVM Query API (the partition manager and individual partitions should return the same info). - Export a constant from Minfs identifying the minimal number of slices allocated to a MinFS partition. - Expand the minfs "query info" tests, deriving expected values rather than relying on magic numbers. Test: /boot/test/fs/fs-test (test-minfs expanded) ZX-2165 #comment In Progress Change-Id: Ic72d595a97d06573d979df3999821ddddbfb1659
-
Sean Klein authored
This patch allows "ioctl" to be removed from the C++ VFS Vnode interface. IOCTL_VFS_MOUNT_FS -> Mount() IOCTL_VFS_UNMOUNT_FS -> Unmount() IOCTL_VFS_UNMOUNT_NODE -> UnmounteNode() IOCTL_VFS_QUERY_FS -> QueryFilesystem() IOCTL_VFS_MOUNT_MKDIR_FS -> MountAndCreate() IOCTL_VFS_GET_DEVICE_PATH -> GetDevicePath() IOCTL_VFS_WATCH_DIR -> WatchDir() Test: fs-management / fs / blobfs / fvm tests, df manually Change-Id: Iefe8ec251ca6b8f4e4578ceb61bae6dff7a59e3d
-
Sean Klein authored
Fixfs was a useful utility in the early Zircon days, but now paving exists as a more convenient way to overwrite system partitions. Test: None Change-Id: I57b57e69b387b516c0b1c50be970267b8bc85cf0
-
George Kulakowski authored
ZX-2184 #comment Test: duplicated the existing zx::log tests Change-Id: I538bbd3486717578159d23b233f721aa237b7680
-
Adam Barth authored
Test: No behavior change Change-Id: Id0d174229deda2eecdb3ba5ccdfc028053f20d37
-
Adam Barth authored
This structure is unused. Test: No behavior change. Change-Id: I220eb6493c2f2200f5d8e323ff05e9f9482e1690
-
Jocelyn Dang authored
Forgot to set write_complete callback for write transfers. The transfers weren't being added back to the pool on completion and causing many allocs. TEST= ran xdc-server and xdc-test app Change-Id: I682592d94e6de2012a07836e224728ae82a5cb16
-
- Sep 25, 2018
-
-
Suraj Malhotra authored
This reverts commit f4d34248. Reason for revert: Broke boot. Original change's description: > [aml-sd-emmc] Migrate to use mmio_buffer_t. > > Tested: It compiles. > Change-Id: Ib3cbfbabc3952c4a237e477088543509158f3ab6 TBR=voydanoff@google.com,ravoorir@google.com,surajmalhotra@google.com Change-Id: Id10e4b0026392852ca7746caab65d106e1a09b29 No-Presubmit: true No-Tree-Checks: true No-Try: true
-
George Kulakowski authored
Test: CQ Change-Id: Ida54742cc85df8d1a192771026e7303e6dec53d5
-
George Kulakowski authored
Test: cq Change-Id: Ib9b03319e698829b371cdc32dc76c974f184be06
-
Suraj Malhotra authored
Tested: compiles. Change-Id: I941e2cc5746b3268079efef7891d298e3bf01954
-
Jocelyn Dang authored
TEST= patched in usb handler changes and ran a xdc transfer Change-Id: I6ef632f3b729d1ee7ca93c1a8628a5f9e65328b5
-
Craig Tiller authored
Test: ran it Change-Id: I4ca449bfc95da0ded9e8050228fd8292d3b2d6ab
-
John Bauman authored
It's possible this is causing clock issues. Test: boot astro ZX-2612 Change-Id: Ia0ef321ce0b9b0db5e9a3c1c2900bc1b530f5849
-
Travis Geiselbrecht authored
Templatize some of the specialized routines Run formatter Change-Id: I56a0997213e64b3c0e894abac8ce9195508f85a4 Tested: boot in qemu with graphics enabled, 'k crash' to get a kernel crash dump.
-
Ross Wang authored
This is a utility that captures elements of interest from a function-like type. MI4-1277 #comment Test: unit and compile-time tests It looks like fit-test is not deployed to zircon right now, but verified that the compile-time tests work. Change-Id: I2cb5eba9e20bc363e5c34153a7b4c636b0313d5e
-
Payam Moradshahi authored
With this change, Astro display driver is completely independent of u-boot display initialization. The OSD driver is still very rigid. Next step will include writing a proper OSD driver with its own protocol that could be used by all AmLogic platforms that use the OSD channel. The VPU related code contains lots of magic and hardcoded values from U-Boot due to lack of documentation. Test: Tested on Astro EVT and P2. Also tested over netboot. Also tested using various flavors of U-Boot with display initialization ranging from 0 display support to 100% support to make sure what we do on Astro is truly independent of U-Boot. Change-Id: Ia02c422bcb462de2774774b6f3c9c6a1661d92bf
-
Adam Barth authored
This CL is a minor cleanup of some function and argument names to prepare for zxio abstracting over both channels and sockets. I'm sending this CL separately because the diff is noisy. Test: No behavior change Change-Id: I13290fcb14729ac187c5481c0fecd89c68b12480
-
George Kulakowski authored
Also fix the comments referring to an incorrect spelling of the ZX_RSRC_KIND_COUNT constant. ZX-2419 #comment Test: CQ Change-Id: I974e8d178b8bd2bd1a9fb75110cd3b2e51e16d4a
-
George Kulakowski authored
Test: CQ Change-Id: Ic0a311b683eb400746ce1ab7dad7ca01b3e66345
-