Skip to content
Snippets Groups Projects
  1. Dec 10, 2018
  2. Dec 09, 2018
    • Abdulla Kamar's avatar
      Revert "[usb proto]Add complete cb as a parameter" · 722ab03b
      Abdulla Kamar authored
      This reverts commit 9b5ac003.
      
      Reason for revert: This breaks global integration, due to the Broadcom drivers in Garnet.
      
      ../../garnet/drivers/wlan/third_party/broadcom/brcmfmac/usb.c:271:44: error: too few arguments to function call, expected 4, have 2
          usb_request_queue(usb_proto, urb->zxurb);
          ~~~~~~~~~~~~~~~~~                      ^
      ../../zircon/system/ulib/ddk/include/ddk/protocol/usb.h:191:1: note: 'usb_request_queue' declared here
      static inline void usb_request_queue(const usb_protocol_t* usb, usb_request_t* usb_request,
      ^
      1 error generated.
      
      Original change's description:
      > [usb proto]Add complete cb as a parameter
      > 
      > With usb request having private regions for each layer in the stack,
      > the complete callback and their contexts should not be part of the public
      > part of the usb-request. This changeset modifies usb protocol so that
      > the complete_cb and its context are passed in as parameters.
      > 
      > Test: zircon build. Will be changing garnet also and then will do basic
      > sanity test.
      > 
      > Change-Id: I42ab688b3db2aaca56f05d67a69d94b61199c256
      
      TBR=voydanoff@google.com,jocelyndang@google.com,ravoorir@google.com,surajmalhotra@google.com
      
      # Not skipping CQ checks because original CL landed > 1 day ago.
      
      Change-Id: I886923ac032e3713a9426b992a2dd542357c25c9
      722ab03b
    • Abdulla Kamar's avatar
      [arm64][hypervisor] Be more conservative for prio · 85f23c7e
      Abdulla Kamar authored
      We may have as few as 16 priority levels, so we should appropriately set
      the priority level.
      
      MAC-180
      
      Test: Ran "zircon_guest" on a VIM2.
      Change-Id: Iaf30b9d0eeb8a9a9b1dda1e16acc93b806ba1b8b
      85f23c7e
    • Abdulla Kamar's avatar
      Revert "[fdio] do not accept sockets with a full fd table" · bbdb4a51
      Abdulla Kamar authored
      This reverts commit bcc6f70f.
      
      Reason for revert: This is causing NetStreamTest.BlockingAcceptWrite to timeout.
      
      Original change's description:
      > [fdio] do not accept sockets with a full fd table
      > 
      > If the fd table is full, pulling sockets from the control channel results in
      > consuming the incoming connection, but being unable to actually service it -
      > we then immediately close (which then ends up in linger). Other processes
      > would then not be able to pull these sockets (in a load balance scenario),
      > and netstack also potentially loses the ability to apply policy from having a
      > full listen queue. Instead, try to allocate an fd up front, and only if found
      > accept the socket from the control channel. This is more conformant with
      > common accept behaviors.
      > 
      > Test: install a package with 5500 blobs with a package server routed via a remote port forward over ssh. Observe successful install rather than failure.
      > Bug: PKG-371 #comment fdio: do not accept sockets with a full fd table
      > Change-Id: Idb5513ada590b0d8da2f5cd68b4d734765e438d4
      
      TBR=jamesr@google.com,mcgrathr@google.com,raggi@google.com,marshallk@google.com
      
      # Not skipping CQ checks because original CL landed > 1 day ago.
      
      Bug: PKG-371 #comment fdio: do not accept sockets with a full fd table
      Change-Id: I31716bafa4cee2116cca16541d4348025c571e56
      bbdb4a51
    • Abdulla Kamar's avatar
      [zx] Make all zx::interrupt methods const · f3a042ed
      Abdulla Kamar authored
      Only C++ const-correctness is important, not whether the underlying
      kernel object is mutated.
      
      Test: Ran system/utest/core/interrupt.
      Change-Id: I72529d61063ce2c360e6b13c429902a521e2133a
      f3a042ed
    • Abdulla Kamar's avatar
      [zx] Make all zx::guest and zx::vcpu methods const · 01f47155
      Abdulla Kamar authored
      Since we only care about C++ const-correctness, and not whether the
      operation is mutating the kernel object, we should mark these methods as
      const.
      
      Test: Ran system/utest/hypervisor.
      Change-Id: Ic10e9b86a24dd7a91a49d88efc2c4f98a78ce756
      01f47155
  3. Dec 08, 2018
    • Ruchira Ravoori's avatar
      [usb proto]Add complete cb as a parameter · 9b5ac003
      Ruchira Ravoori authored
      With usb request having private regions for each layer in the stack,
      the complete callback and their contexts should not be part of the public
      part of the usb-request. This changeset modifies usb protocol so that
      the complete_cb and its context are passed in as parameters.
      
      Test: zircon build. Will be changing garnet also and then will do basic
      sanity test.
      
      Change-Id: I42ab688b3db2aaca56f05d67a69d94b61199c256
      9b5ac003
    • Sean Klein's avatar
      [block] Re-write block FIFO thread as ServerManager · a5d6e4fd
      Sean Klein authored
      - Drastically simplify lifetime management of the FIFO
      server, removing a "lock, completion signal, threadcount,
      and boolean" with a ServerManager class that provides
      a simple API.
      - ServerManager utilizes a thrd_t and an atomic to identify
      if a FIFO server is running, and if so, in what state. The
      most notable improvement comes from ServerManager's ownership
      of the background thread, rather than detaching it after
      launching.
      - Isolating this logic into a "ServerManager" class will
      make this API trivial to unit-test, as soon as the "blockserver_*"
      APIs are abstracted.
      
      Test: /boot/test/sys/ramdisk-test
      
      Change-Id: I07c951db31c663b0aab68da2794b77408723ef07
      a5d6e4fd
    • Sean Klein's avatar
      [block] Re-write the core block driver in safe C++ · 99b1a56e
      Sean Klein authored
      This enables:
      - RAII wrappers around handles, memory.
      - DDKTL usage, to avoid casting between "void*".
      - Automatically initialized mutexes.
      - Lock thread-annotations for safety.
      
      In the future, this will also enable improved encapsulation of the
      BlockDevice object, but structural changes have been minimized for
      the current patch.
      
      Test: /boot/test/sys/ramdisk-test
      
      Change-Id: Id041bd4cc5f541620e4829427fac3c964700b13b
      99b1a56e
    • Sean Klein's avatar
      [banjo][block] Remove GetStats from banjo protocol · bc809d2b
      Sean Klein authored
      GetStats is handled by the block core driver, not implementation
      drivers.
      
      Test: CQ
      
      Change-Id: Iec7f3cd8c00af4c175b7f0b72610931ffcd91f4e
      bc809d2b
    • Sean Klein's avatar
      [block] Copy block.c to block.cpp · d216c761
      Sean Klein authored
      This makes the diff from C --> C++ easier to see.
      The current block.cpp is an exact copy.
      
      Test: None (dependency not added to build)
      
      Change-Id: Ifec4f559f0f012f094784d61bbe6f836d80ddf34
      d216c761
    • Scott Graham's avatar
      [rights][docs] Generate some SYNOPSIS sections from abigen · 99c61a3e
      Scott Graham authored
      This is not applied to all syscalls yet, as there are many where the
      argument name in abigen doesn't match that in existing documentation.
      
      So for now, use a whitelist to only update ones where the argument names
      match. This fixes a few typos and missing 'const's but otherwise doesn't
      change the SYNOPSIS section for whitelisted syscalls.
      
      ZX-968 #comment [rights][docs] Generate some SYNOPSIS sections from abigen
      ZX-2399 #comment [rights][docs] Generate some SYNOPSIS sections from abigen
      ZX-3106 #comment [rights][docs] Generate some SYNOPSIS sections from abigen
      
      Test: CQ
      Change-Id: I74acd98a13ad5b78bf2499657824cda35d0b6a4e
      99c61a3e
    • Bruce Mitchener's avatar
      [zxio] Typo fixes. · a5434bf8
      Bruce Mitchener authored
      TEST: No behavior change
      Change-Id: I6b907e1d36432ae5fdea422e81faaa727e062f9a
      a5434bf8
    • James Tucker's avatar
      [fdio] do not accept sockets with a full fd table · bcc6f70f
      James Tucker authored
      If the fd table is full, pulling sockets from the control channel results in
      consuming the incoming connection, but being unable to actually service it -
      we then immediately close (which then ends up in linger). Other processes
      would then not be able to pull these sockets (in a load balance scenario),
      and netstack also potentially loses the ability to apply policy from having a
      full listen queue. Instead, try to allocate an fd up front, and only if found
      accept the socket from the control channel. This is more conformant with
      common accept behaviors.
      
      Test: install a package with 5500 blobs with a package server routed via a remote port forward over ssh. Observe successful install rather than failure.
      Bug: PKG-371 #comment fdio: do not accept sockets with a full fd table
      Change-Id: Idb5513ada590b0d8da2f5cd68b4d734765e438d4
      bcc6f70f
    • Bruce Mitchener's avatar
      [iochk] Typo fix. · 9c9f7df9
      Bruce Mitchener authored
      TEST: No behavior change
      Change-Id: Ie4e1292a13d095e534bc43b3f0fa2ad9f9501367
      9c9f7df9
    • Abdulla Kamar's avatar
      [zx] Add zx::interrupt::bind_vcpu · 71ec5802
      Abdulla Kamar authored
      This exposes the zx_interrupt_bind_vcpu syscall through the
      zx::interrupt object.
      
      MAC-180
      
      Test: N/A
      Change-Id: I3353d6546f6471aee179b74086343f570bcedf59
      71ec5802
    • George Kulakowski's avatar
      [docs][syscall] Correct the definition of zx_port_packet_t · e6c16a11
      George Kulakowski authored
      Also leave a note to discuss the many other port packet types in a
      subsequent CL.
      
      Test: no functional change
      Change-Id: Ie242767af1d7f37ce3db099a73fe9587fd41eab3
      e6c16a11
    • Scott Graham's avatar
      [rights][docs] Move NAME short description to abigen · 226592e2
      Scott Graham authored
      Fixes a few small inconsistencies. (zx_ vs. not prefix, '## NAME'
      missing in few files, missing spaces.)
      
      I didn't take a position (yet) on "lower case no period" vs. "Proper
      sentence with trailing period.", but my left eye was twitching.
      
      ZX-968 #comment [rights][docs] Move NAME short description to abigen
      ZX-2399 #comment [rights][docs] Move NAME short description to abigen
      ZX-3106 #comment [rights][docs] Move NAME short description to abigen
      
      Test: CQ, no intended functionality change
      Change-Id: I3a74062e7c599701ca5608731eb3fc27446ad044
      226592e2
    • Bruce Mitchener's avatar
      [vmo][test] Typo fixes. · d043a8fe
      Bruce Mitchener authored
      TEST: No behavior change
      Change-Id: I3264c2014e2a27fc0a14f11885428269479404bb
      d043a8fe
    • Scott Graham's avatar
      [rights][docs] Handle arrays and structs (just barely) in doc gen · 00176250
      Scott Graham authored
      ZX-968 #comment [rights][docs] Handle arrays and structs (just barely) in doc gen
      ZX-2399 #comment [rights][docs] Handle arrays and structs (just barely) in doc gen
      
      Test: CQ
      Change-Id: I8e63044830b48c315e3fc6c8dd766609fc2c161f
      00176250
    • Abdulla Kamar's avatar
      [zx] Use zx::port in zx::interrupt::bind · d64283db
      Abdulla Kamar authored
      Use the zx::port object, rather than the raw handle, when binding the
      interrupt.
      
      MAC-180
      
      Test: Booted on a VIM2, but don't have a mt8167 to test with.
      Change-Id: Idd9e8cc20359fcccb792b71a9a68ef267df15d92
      d64283db
Loading