Skip to content
Snippets Groups Projects
  1. Mar 19, 2019
    • Jean-François Geyelin's avatar
      [docs] Merge workflow_faq and workflow_tips · a60ec0e3
      Jean-François Geyelin authored
      Also, update the script directory from /script to /script/git.
      
      Change-Id: Ia3209a51fe096b525a878554cee800be3967ec1b
      a60ec0e3
    • Jean-François Geyelin's avatar
      [ledger][docs] Fix path to coroutine readme · f3ed37cf
      Jean-François Geyelin authored
      Change-Id: Id24b95dc3666fd384f934e805f9208900fa74c4b
      f3ed37cf
    • Doug Evans's avatar
      [utest/async-loop] Fix waiting for exception packet to be processed · b8f701e2
      Doug Evans authored
      Previously we might call RunUntilIdle in between when a thread enters
      the "in-exception" state and when the exception packet gets sent. It would
      immediately return causing test failures. Instead wait for the packet
      to be received.
      
      All of this will need to be rewritten when exceptions-as-separate-objects
      lands (where, for example, we might wait for the channel to be readable).
      So instead of getting fancy, KISS.
      
      FLK-78 #done
      
      Change-Id: I322b0f9a131f9b4b1823c176b898e6f8edb1d476
      b8f701e2
    • Etienne J. Membrives's avatar
      [ledger] Full commits are returned for GetHeadCommits · 272d878c
      Etienne J. Membrives authored
      In PageStorage, we now return the full Commit object instead of just
      returning the commit ID. Now that commits remain in memory, it costs a
      lot less to do this, and saves a round-trip to the database when we
      actually had to get the full commit.
      
      Change-Id: Ie98903bb5735f2d79e294d2ca37f862fdfd565e3
      272d878c
    • Christopher R. Johnson's avatar
      [inspect] Fix bugs with reader use after free. · 64f5a140
      Christopher R. Johnson authored
      We keep a stack of pairs of (parent*, index) to drive attaching children
      to parents, however, the pointer is wrapped by a unique_ptr that has
      values moved out of it.
      
      This change replaces the pointer element in the pair with a block index
      itself, and we add a new unordered map to map these block indices to the
      parent ObjectHierarchy that is already in its final location (hence the
      pointer is stable).
      
      TEST=fx run-test inspect_unittest
      
      Change-Id: Id577e5e560467266be65c1b0c5d4bfe3e910f821
      64f5a140
    • Carl Norum's avatar
      [fdio] support isatty · 2d11eda5
      Carl Norum authored
      - add a TTY-specific field to the NodeInfo union
      - have isatty implementation check the node type instead of blindly making assumptions
      
      Change-Id: I7ac854bbf1a03fb890478b2efd935d1b488faa28
      2d11eda5
    • Renato Mangini's avatar
      [docs] Remove link to deleted file · b26063bf
      Renato Mangini authored
      File was deleted in https://fuchsia.googlesource.com/fuchsia/+/60dbd004b4836d2e8570c4878fc842cb5cfacd14
      
      PiperOrigin-RevId: 239079312
      Change-Id: Ib4a9beb1a34f8ee429a62a3e0742835d19f13dc3
      b26063bf
    • Erick Tryzelaar's avatar
      [rust_crates] Import ct-logs and hyper-rustls · f547cb38
      Erick Tryzelaar authored
      This imports the last set of dependencies in order to get
      hyper working with rustls for a rust TLS stack.
      
      It also imports tokio-rustls 0.9.1 as a transitive dependency.
      
      Test: Verified Fuchsia compiles
      Bug: OSRB-124 #comment landed ct-logs, tokio-rustls, and hyper-rustls
      Change-Id: Ifd2c23385f6fe2d429a90efe2a9fcf3ac5dfbfac
      f547cb38
    • Wez .'s avatar
      Revert "[scenic] Remove Present2" · 22376cb8
      Wez . authored
      This reverts commit 69ddd85b.
      
      Reason for revert: Present2() is still in-use by Chromium (crbug.com/943604).
      
      Original change's description:
      > [scenic] Remove Present2
      > 
      > Test: present_view tile_view; present_view simplest_embedder
      > SCN-1289 #done
      > 
      > Change-Id: I3dee35a0c4f8f4d4b9d342d2f33eb2ce2abc716c
      
      TBR=jjosh@google.com,mikejurka@google.com,jaeheon@google.com,dworsham@google.com,adamgousetis@google.com
      
      Change-Id: Ib519320ea0d361f844ea5b431b87aca07a3dd04a
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      22376cb8
    • Martin Puryear's avatar
      [media][tests][e2e] Collapse VAD class hierarchy · eea1760d
      Martin Puryear authored
      To address code review feedback and make a cleaner implementation,
      this CL moves consolidates ConfigImpl, DeviceImpl, InputImpl and
      OutputImpl into a unified DeviceImpl. The Input and Output protocols
      are composed of Config and Device, but to have a single implementation
      with no forwarders between child and parent classes, it is cleaner to
      put the implementation for both protocols into the one class.
      Although it is an important part of our e2e testing efforts, the VAD
      is test-only; this CL contains no product changes.
      
      Test: build, CQ, overnight loops on various QEMU flavors (debug and
      release) and NUC.
      
      Change-Id: I5953cdcf9126550166bd21be51dc0a79f9f3bdc8
      eea1760d
    • Dale Sather's avatar
      [media] remove .gitignore for old ffmpeg prebuilt · e6a734d8
      Dale Sather authored
      This CL removes the .gitignore for the old ffmpeg prebuilt directory.
      This is no longer needed as the actual prebuilts have moved to
      //prebuilts/third_party/ffmpeg.
      
      TEST: no behavior change
      Change-Id: Idb254b34e0d6ad44e0d4eb89096e833b3e291530
      e6a734d8
    • Zach Bush's avatar
      [cobalt] Move garnet/bin/lib/cobalt/cpp -> src/lib/cobalt/cpp · 05c66a4f
      Zach Bush authored
      Change-Id: Ifef1d2d0cc14a6dff52089bff4667978d3424d90
      05c66a4f
    • Christopher R. Johnson's avatar
      [inspect] Support writing on a VMO behind the facade. · e0ddf6d2
      Christopher R. Johnson authored
      This change creates new types:
      
      Tree represents a single VMO tree, including methods to retrieve a
      reference to the root object of the tree and the underlying VMO.
      
      Inspector is an entrypoint into inspect to be used for creating Trees. A
      future change will add multi-tree management functionality to the
      Inspector.
      
      CF-217: #progress
      
      Change-Id: I7f92e1495f06c055d742bcf05d45231393d62fe9
      e0ddf6d2
    • Benjamin Lerman's avatar
      [ledger] Do not use New(...) methods. · 71d08f58
      Benjamin Lerman authored
      Change-Id: I7af7252766af41f6a6da29e7e54ab220a3307ce7
      71d08f58
    • Jinwoo Lee's avatar
      [doc][sdk] add an example for building an sdk · ed16a3d0
      Jinwoo Lee authored
      Without examples, it was not easy for me to build the SDK locally.
      
      Change-Id: Idee97e1f670593df46292288739a3281e20d0a9e
      ed16a3d0
    • Jean-François Geyelin's avatar
      [ledger][storage] Store watchers in ObserverList · 5e04ad90
      Jean-François Geyelin authored
      Because there's no way to enforce that OnNewCommits does not result in
      watchers being removed or added, store the watchers in an ObserverList.
      This change could fix LE-722.
      
      Change-Id: If160f624ed6a12110b3c20a47228bf9cf385c1ba
      5e04ad90
    • Przemek Pietrzkiewicz's avatar
      [voila] migrate layout to euclid and fix inset · 0374f9d9
      Przemek Pietrzkiewicz authored
      This patch follows
      https://fuchsia-review.googlesource.com/c/fuchsia/+/255074 and changes
      the geometry primitives used in Voila to align with Carnelian.
      
      This is in preparation of extending the layout logic to cover a
      controller toggle for connectivity (to be added in subsequent CLs).
      
      We also fix a bug in inset.
      
      LE-663
      
      Test: tiles_ctl add fuchsia-pkg://fuchsia.com/voila#meta/voila.cmx
      Change-Id: I3885d50914c5d7353356b58d0cca0264508d3ca2
      0374f9d9
    • Przemek Pietrzkiewicz's avatar
      [voila] rename test package to allow running via `fx run-test` · 0e267bc4
      Przemek Pietrzkiewicz authored
      In order to be run as a component by `fx run-test`, test package cannot
      override "package_name".
      
      LE-663
      Test: `fx run-test voila_tests`
      
      Change-Id: I5827747db0d0b118d0cc3798c2df362f6250d363
      0e267bc4
    • Gabriel Kerneis's avatar
      [ledger] Prepare PageDb for storing and retrieving object references · 19ee4fb8
      Gabriel Kerneis authored
      Not actual references are written yet with this commit because
      PageStorage is passing empty references to PageDb.
      
      Bug: LE-697
      Test: fx run-test ledger_tests -t ledger_unittests
      Change-Id: I178b5bdef4ef1396d7db4a13a66bee651ce0e489
      19ee4fb8
    • Benjamin Lerman's avatar
      [ledger] Update error reporting on DeviceSetWatcher · 8f9277c7
      Benjamin Lerman authored
      Instead of having a single method for network error, have a generic
      OnError method that gets the error status.
      
      Change-Id: I23e9205fa4ae59756857d89294085a6d3588b2bf
      8f9277c7
    • Benjamin Lerman's avatar
      [network_stack] Disable flaky NetstackNoNetworkTest.* tests · dab19a91
      Benjamin Lerman authored
      FLK-104 #comment Disabled tests until they are fixed.
      
      Change-Id: Ief0956ae512d4c70b92c1cb508d6a269891bde1c
      dab19a91
    • Benjamin Lerman's avatar
      [ledger] Update Ledger API · e755739c
      Benjamin Lerman authored
      Remove the obsolete method on ledger::Ledger and replace them with ones
      with the same signature as the new method.
      
      Once this is landed, dependencies will be able to call the method with
      their original name.
      
      Change-Id: I87bb9e48ed2385ffb9459ccdd96c023a21cff72e
      e755739c
    • Etienne J. Membrives's avatar
      [ledger] Keep commit objects in memory directly · 1eb50c22
      Etienne J. Membrives authored
      Instead of keeping in memory CommitIds, we keep the Commit objects
      directly. This way, local garbage collection has access to the root node
      ids directly, and commit pruning has access to the generation.
      
      Change-Id: I25b2e57b44c7c7692ef12bc880ef53fd3a628418
      1eb50c22
    • Benjamin Lerman's avatar
      [scripts][vim] Revert "Make :make work in Vim" · da43ac6f
      Benjamin Lerman authored
      This reverts commit ef2e0f2f.
      
      This CL makes vim generate the following error when openeing any file:
      No matching autocommands
      
      Change-Id: I72e81f4254f3b7b37ce1f53ab525810768b44d13
      da43ac6f
    • Benjamin Lerman's avatar
      [ledger] Use new Ledger API. · 9a20a6f2
      Benjamin Lerman authored
      Change-Id: I028dd538d8e7eca0e291bebd47636b026b215f6d
      9a20a6f2
    • Tricia Landers's avatar
      [minfs] Perform pending block swaps in AllocateData · 7d989170
      Tricia Landers authored
      Instead of swapping blocks in the middle of write
      and truncate operations, mark blocks for allocation
      and then swap them all at once. This requires the
      VnodeMinfs to store information about which blocks
      have been queued for allocation (in the
      DataAllocationState), and an AllocateData method
      which performs and commits the swap.
      
      Additionally, start using methods to get/set the
      size and block count of an inode, since in the
      future this may be different for directory and data
      vnodes.
      
      Test: fs-test
      
      Change-Id: I352ef8fb983c6b2ee53e7f463d73d31909ac0133
      7d989170
    • Jinwoo Lee's avatar
      [fx] make gn labels actually work for `fx set` · e4399c83
      Jinwoo Lee authored
      Change-Id: I681865f7554b04b912930b0bc948afd6145da615
      e4399c83
    • Tricia Landers's avatar
      [minfs] Add 'swap' block operation · 566069ca
      Tricia Landers authored
      Previously for allocated blocks, the 'write'
      operation would either return the block (for
      directory vnodes), or swap the existing block
      with a new block (for data vnodes). This patch
      splits the swapping functionality into a new
      'swap' operation.
      
      Additionally, the relative index of the block
      being op'd is now tracked through the BlockOp
      stack.
      
      Test: fs-test
      
      Change-Id: I6b9a4290bd6180ffde4ae412856b0ca8220a83f8
      566069ca
    • Jiwoong Lee's avatar
      [log_listener] Add --begin, --end option · 99cb4523
      Jiwoong Lee authored
      Also refactor to host all suppression-related options into LogListener.
      
      --begin and --end provides block-by-block skip feature.
      --only and --suppress provides line-by-line skip feature.
      
      Usage:
        $ fx syslog --pretty yes --begin wlan
        $ fx syslog --pretty yes --end dhcp
        $ fx syslog --pretty yes --begin <crash_start_marker> --end <crash_end_marker>
      
      Decorator struct now hosts coloring only.
      
      Sample: Pay attention to the skipping timestamp
      
      $ fx syslog --pretty yes --begin welcome,brcm,dhcp --end cpu,usb,route,bt_
      Connecting...
      [00000.000000][0][0][klog] INFO: welcome to Zircon
      [00000.000000][0][0][klog] INFO:
      [00000.000000][0][0][klog] INFO: KASLR: .text section at 0xffffffff00100000
      [00051.861246][1107][4764][klog] INFO: devcoordinator: adding system driver 'brcmfmac' '/system/driver/brcmfmac.so'
      [00051.954206][1107][4764][klog] INFO: devcoordinator: adding system driver 'wlan' '/system/driver/wlan.so'
      [00052.029585][1107][1120][klog] INFO: devcoordinator: driver 'brcmfmac' added
      [00052.029594][1107][1120][klog] INFO: devcoordinator: driver 'rtl88xx' added
      [00052.029604][1107][1120][klog] INFO: devcoordinator: driver 'gpu' added
      [00055.618380][1886039011][0][netstack] INFO: netstack.go(363): NIC ethp001f6: DHCP acquired IP 192.168.42.193 for 24h0m0s
      [00055.618410][1886039011][0][netstack] INFO: netstack.go(364): NIC ethp001f6: Adding DNS servers: [8.8.8.8]
      
      Test: Unit test included
            build and run above usage
      Change-Id: I22b0bb5ddb6b0a06f7b0259aa37f4abe9ab45b92
      99cb4523
    • Adam Barth's avatar
      [fx][set2] Switch to base/cache/universe package set names · 155fa95c
      Adam Barth authored
      This CL makes three changes at once:
      
       * Switches the "fx set2" command to use the new names of the package
         sets. In order to support this change, this CL changes bringup to
         initialize these sets to empty.
      
       * Add no-op assignments for the base and cache package sets. These
         assignments are documentation hooks for people to learn about these
         arguments, based on a previous discussion about using the args.gn
         file to control these values rather than command-line arguments to the
         "fx set2" command itself.
      
       * We no longer echo the "gn gen" command line to the console.
         Previously, we did this to explain what the "fx set2" command was doing.
         However, including the documentation from the previous bullet makes
         this command very verbose.
      
      Change-Id: I4771ab2e562713c977a51ff542e0676aba442cac
      155fa95c
    • Adam Barth's avatar
      [build] Introduce base/cache/universe naming for build args · dd792375
      Adam Barth authored
      This is a reland of de1cdacd
      
      Original change's description:
      > [build] Introduce base/cache/universe naming for build args
      >
      > Supporting both the old monolith/preinstall/available names and the new
      > base/cache/universe names will make it easier to transition to the new
      > names.
      >
      > Change-Id: Ifad1ce4250ab8683a1786e49882c89b43447b5a9
      
      Change-Id: Idb52ecd1ffde3167711e25faee890b9fdb8266dc
      dd792375
    • Ian McKellar's avatar
      [scripts][vim] Make :make work in Vim · ef2e0f2f
      Ian McKellar authored
      When editing Fuchsia source configure :make to run fx full-build and
      also tweak the error parsing a little to make navigating errors in unit
      tests more pleasant and productive.
      
      Change-Id: I73a56b430555214f0d55fa76f0e877d70f49dbdb
      ef2e0f2f
    • Yifei Teng's avatar
      Revert "[fs] Hierarchical directory rights" · ebbab94a
      Yifei Teng authored
      This reverts commit 9996f2e9.
      
      Reason for revert: Broke Global Integration
      
      Original change's description:
      > [fs] Hierarchical directory rights
      > 
      > Implements a hierarchical model of rights for directories.
      > When opening a directory, it is now possible to specify the entire
      > subtree to be read-only, while maintaining a Posix API.
      > When cloning a connection, it is now possible to restrict rights
      > through the FIDL interface.
      > 
      > ZX-1723 #done
      > US-574 #comment
      > 
      > Change-Id: I3b364a7f954af5e24174d0e9900bf69c48da120b
      
      TBR=smklein@google.com,abarth@google.com,raggi@google.com,gevalentino@google.com,yifeit@google.com,ibobyr@google.com
      
      Change-Id: I390ba5d6cd28c8459f33ebce7d3243d8f991294c
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      ebbab94a
    • Brett Wilson's avatar
      [debugger] Add more tokens. · 0831b703
      Brett Wilson authored
      Type parsing needs "&&" for rvalue references so this token is added.
      
      For testing purposes, the "&" token as a binary operator is added. And
      for symmetry | and || are added.
      
      Tokens are added for keywords required for type parsing are added:
      "const", "volatile", "and restrict".
      
      None of these new operators are currently hooked up to any operations.
      
      Change-Id: Ie8784376d551f5c5108e7742f5ef9e8feba4a6bf
      0831b703
    • David Reveman's avatar
      [scenic] Remove host-visible requirement for imported memory · 4683cad3
      David Reveman authored
      This requirement can't be satisfied on non-UMA systems.
      
      Test: scenic runs in aemu when using nvidia hw
      Change-Id: Id67171f97289db69e297a6c0595ecb2490a148d1
      4683cad3
    • Adrian Danis's avatar
      [kernel][x86] Avoid early calls to mp_sync_exec · 029a7570
      Adrian Danis authored
      When performing arch_early_init we cannot use certain higher level functions, including
      mp_sync_exec. This change takes advantage of the knowledge that early init is strictly
      single core and performs explicitly local operations instead.
      
      Test: Kernel unit tests on qemu + NUC
      Change-Id: Ic5854bbbfe675cfe06a092ef081850daff5b56d7
      029a7570
    • Mike Voydanoff's avatar
      [dev][platform-bus] Remove unnecessary C file for binding · a3339893
      Mike Voydanoff authored
      TEST: boot VIM2
      Change-Id: I67cf72595d594d5d9483b7dea54cb14360f2e05f
      a3339893
    • Todd Eisenberger's avatar
      [devcoordinator] Rename test binary to remove redundant suffix · 08a78fca
      Todd Eisenberger authored
      This goes from devcoordinator-test-test to devcoordinator-test
      
      Change-Id: I1dbbbbee091fb4528bea456595c6d247e3d0ea72
      08a78fca
    • Vickie Cheng's avatar
      [sessionmgr] Convert options to use fidl table · 85af2014
      Vickie Cheng authored
      This is a nicety that converts the sessionmgr options to use a fidl table.
      Soon, sessionmgr will read its configs from a file rather than from commandline
      arguments.
      
      TEST=fx run-test modular_tests
      MF-10 #comment Convert sessionmgr options to use fidl table
      
      Change-Id: Ied76c7ecafea96841de66da8a74de508d2312ca9
      85af2014
    • Dan Johnson's avatar
      [pkg_ctl] declare dependency on Launcher service · 9415dac7
      Dan Johnson authored
      Change-Id: I6e085e53ae5cc60b7f9b3ebc84cd38579a9721d9
      9415dac7
Loading