Skip to content
Snippets Groups Projects
  1. Mar 25, 2019
  2. Mar 24, 2019
    • Alex Legg's avatar
      [guest] Handle a PCI interrupt race condition · 253dcf7a
      Alex Legg authored
      PCI interrupts should be asserted continuously until acknowledged and we
      attempt to handle that by tracking pending interrupts. The best method we
      have to do this in the base PCI class is to track interrupts that we
      tried to send while interrupts were disabled and resend them when
      interrupts are enabled again. This is racy in the sense that interrupts
      may be disabled after we send the interrupt to the guest but before the
      guest has handled the interrupt.
      
      This patch removes that behavior and requires derived classes to define
      an interrupt pending condition. In the case of VirtioPci this is the
      IsrStatus register. This eliminates the race condition for virtio devices.
      
      FLK-99 #done
      FLK-88 #done
      MAC-240 #done
      
      TEST=guest_integration_tests
      
      Change-Id: I2fa0c13591e2a4d5fc87835f625a5365f83dfeca
      253dcf7a
    • Doug Evans's avatar
      [lib/debugger_utils] Add a helper to simplify common process builder use case · b0644ed5
      Doug Evans authored
      ... and split out argv support to separate file.
      
      Change-Id: Ia06bc552ed49256834defbd38af201f0a20b5d8d
      b0644ed5
    • Doug Evans's avatar
      [lib/inferior_control] Split out Process::Delegate to separate file · 1d87e00f
      Doug Evans authored
      Change-Id: Id3f3dfcec6cc584f732ac36c8127d650e59ea1d7
      1d87e00f
  3. Mar 23, 2019
    • Benjamin Brittain's avatar
      [zircon][gn] Make a generic prebuilt host tool template · 3c1cfe07
      Benjamin Brittain authored
      Change-Id: Id1fe296cfaa03835ad2c4ef6389b51f4fa2e0ba5
      3c1cfe07
    • Roland McGrath's avatar
      [prebuilt] Roll banjo compiler · 11ba77dc
      Roland McGrath authored
      This brings in the -Wextra-semi cleanup in emitted C headers.
      
      Change-Id: I405a39b3ebfc0e13e6a2a560dbbb90774927b540
      11ba77dc
    • Corey Tabaka's avatar
      [utest][ffl] Introduce in-progress fixed-point library tests. · 325cf5cb
      Corey Tabaka authored
      - Add minimal tests for fixed point library. More are being ported
        from a gtest on workstation.
      - Minor tweaks to FFL library from tests and running the stricter
        compiler building host tests.
      
      Bug: ZX-3777
      Test: Test passes; observe fair scheduler traces.
      Change-Id: I539d02ab89b4daaa75693960184f2031eefbf60d
      325cf5cb
    • Roland McGrath's avatar
      [banjo] Remove extra `;` characters from C header template · fbb92583
      Roland McGrath authored
      Test: fx run-host-tests banjo_unittests_lib_test
      
      Change-Id: I88596b88096c2f39a95686ea3d26704e219aa638
      fbb92583
    • Doug Evans's avatar
      [lib/debugger_utils,inferior_control test_helper] Fix waiting for thread exit · d636e018
      Doug Evans authored
      Previously the last thread may not get to waiting for the event to close
      before it gets closed.
      
      Tested: fx shell runtests -t inferior_control_tests -- --gtest_filter=RefreshTest* --gtest_repeat=1000 2>&1 | grep -c "FAILED TEST"
      The before case showed varying numbers of failures, after zero.
      
      FLK-117 #done
      
      Change-Id: I8bac1e7d9dd344427a370152db135513a49e6780
      d636e018
    • Mike Voydanoff's avatar
      [dev][gpio] Add generic GPIO driver · fdcc3aef
      Mike Voydanoff authored
      This driver maps the ZX_PROTOCOL_GPIO protocol to
      ZX_PROTOCOL_GPIO_IMPL based on metadata provided by the board driver.
      Currently this functionality happens in the platform bus driver,
      but we will incrementally move to using this driver instead.
      
      Add this driver to the platform-bus-test board driver.
      Now the composite device binds against a device created by generic GPIO
      rather than child-2.
      
      TEST: Boot astro into full UI, runtests -t platform-bus-test
      Change-Id: I08996015f5b3e15f0c7d6d3f38ec6cc75b21ed18
      fdcc3aef
    • Francois Rousseau's avatar
      [ktrace_provider] fix argument ordering in log importer · 251d4074
      Francois Rousseau authored
      * https: //fuchsia-review.git.corp.google.com/c/garnet/+/238440 switched to zx::debuglog, but the first and last argument of read() are swapped between the two libraries
      * using named arguments to catch things like this once http://clang.llvm.org/extra/clang-tidy/checks/bugprone-argument-comment.html is enabled
      
      Change-Id: Ic626d89e2da962069a4d3f0beb3732eb325e608e
      251d4074
    • Ian McKellar's avatar
      [fidl][dangerous-idents] Prepare for Dart support · 9bf3c7b2
      Ian McKellar authored
      So that a Dart test can be added to //topaz:
       - add a GN group containing all the test FIDL targets
       - add some Dart-related identifiers to the list
      
      FIDL-438
      FIDL-259
      
      Change-Id: I0faf594701ee1a5a8a1905938a1215bf827aaaf8
      9bf3c7b2
    • Roland McGrath's avatar
      [zircon][build] Download and use all Linux sysroots · 1d65fa49
      Roland McGrath authored
      Also update to the sysroot versions //build/cipd.ensure is using.
      
      This makes it possible to cross-compile host tools for Linux/ARM64
      out of the box.
      
      Test: scripts/download-prebuilt --no-cipd && ninja tools-linux-{arm64,x64}
      Change-Id: Ic18b9ad73f79cb15db3494ce2698633905361475
      1d65fa49
    • Roland McGrath's avatar
      [zbi] Use std::filesystem::path · 1db77a76
      Roland McGrath authored
      Change-Id: I2acc5c686e5ac2e3fc1e4fff0f1324f92159b87f
      1db77a76
    • Roland McGrath's avatar
      [zircon][gn] Fix static-libc++ config for Fuchsia case · 8096f094
      Roland McGrath authored
      The change to fix it for macOS broke it for Fuchsia.
      
      Change-Id: I37673fd63ec3c543a441003ce8cb55b0320c3f84
      8096f094
    • Martin Puryear's avatar
      [media][tests] virtual_audio (CLI util) updates · a421d96c
      Martin Puryear authored
      This CL updates the CLI virtual_audio utility to include the recently-
      added interfaces for retrieval and notification of format, gain, ring
      buffer, and position, as well as notification of start and stop, plus
      more flexibility in setting supported formats.
      
      This utility is only installed as a part of the tests/media packages.
      This CL contains no product changes.
      
      Test: build, CQ, functionality verified on all archs and flavors
      
      Change-Id: Ic69128098b6d1e7b0d66984b2f66bdec1a275188
      a421d96c
    • Benjamin Brittain's avatar
      [banjo] add script to regenerate banjo golden files · bdb39715
      Benjamin Brittain authored
      Test: fx run-host-tests banjo_unittests_lib_test
      
      Change-Id: Idce0a9b3ebdc91fff244ce2edf12be100f0cc163
      bdb39715
    • Corey Tabaka's avatar
      [zircon][docs] Fix spelling and formatting issues. · 57e4d9fe
      Corey Tabaka authored
      Bug: ZX-2885
      Test: N/A
      Change-Id: I20453c376409cec6a1b1d0ae9a6d5a4524ca5008
      57e4d9fe
    • Corey Tabaka's avatar
      [zircon][docs] Add markup document for the fair scheduler. · 8bf39aeb
      Corey Tabaka authored
      This document discusses how to enable the new fair scheduler prior
      to rollout, how to enable and use detailed scheduler tracing, and
      outlines the theory of operation.
      
      Bug: ZX-2885
      Test: Read it.
      Change-Id: I50a1df1b91da2946a74d634ff20a6f74cb5b06b8
      8bf39aeb
    • Martin Puryear's avatar
      [media][tests][e2e] Additional virtualaudio FIDL interfaces · c374f537
      Martin Puryear authored
      This CL adds methods and events to fuchsia.virtualaudio.Configuration
      and fuchsia.virtualaudio.Device, as needed to support the end-to-end
      testing push. This includes notifications to the client upon SetGain,
      SetFormat, GetBuffer, Start, Stop, and PositionNotify, as well as the
      ability to retrieve current values for format, gain, buffer and
      position.
      
      This also adds a method to remove the added-by-default format range.
      
      Test: build, CQ, new test cases,
      
      Change-Id: I02df1e9d56eb5b7ba114a35701835950e4a4b4da
      c374f537
    • Jeremy Manson's avatar
      [fidl] Avoid API Review for examples, testcases. · 31b42a79
      Jeremy Manson authored
      I'm sure it's okay to avoid API review for the test cases.  I'm not sure
      about the examples.  I'll take guidance from reviewers on whether that's
      a good idea.
      
      Change-Id: Icf1df0c02fbb95292a417fa2ab0bd37103fc1ef1
      31b42a79
    • Bryan Henry's avatar
      [persistent-storage] Fix partially broken allowlist mechanism · bfe77958
      Bryan Henry authored
      For real this time. fxr/262164 fixed it for almost everything but I
      forgot to update the fuchsia_component template with the same fix.
      
      Also renames the "whitelist" to an "allowlist", adds the log_listener
      component that I missed adding to that list initially, and deletes other
      stale (already migrated) entries from the list.
      
      Change-Id: Ifa91d3ddbe0b6f05042bc7147dc77180af5dc660
      bfe77958
    • Dave Moore's avatar
      [scudo] Adjust the reserved size for each Region to 1GB. · 637498e1
      Dave Moore authored
      Test: CQ
      
      We had a test case where we were running out of	virtual	space in a region.
      This change increases that space by 4X.
      
      Also adds some extra debug info if this happens again.
      
      Issue: MA-572
      Change-Id: Ide8bdbb758c7d9153169c9ead16288be0dfd76bb
      637498e1
    • Bryan Henry's avatar
      [zircon][qemu] Use iptools instead of uml-utilities for creating TAP interface · ca5397b8
      Bryan Henry authored
      Change-Id: I9fed739794c7f195a64e67d2725cfd3c88573004
      ca5397b8
    • Joshua Seaton's avatar
      [test-spec] Delete last mentions of labels · 04a1462f
      Joshua Seaton authored
      This is now referred to as "tags".
      
      Change-Id: Ibfa4becd705dc570d4be892b53cd907795513c62
      04a1462f
    • Ian McKellar's avatar
      [fidl][c++] allow method arg named `controller` · 6984694c
      Ian McKellar authored
      Make sure the words `controller`, `proxy`, `set_controller` and `stub`
      work.
      
      Update the dangerous identifiers test to check dangerously named
      protocols, methods, request arguments, response arguments and event
      arguments.
      
      Change-Id: I920e773a9731e256ab5c20638ab7804d0bee23cf
      6984694c
    • Michael Brunson's avatar
      [mtd] Enable mtd test on host. · b4480ea7
      Michael Brunson authored
      Change-Id: Ibd3c8638e8e24c80139f6e2bb861d4be49aad0b3
      b4480ea7
    • Nick Pollard's avatar
      [bt][bt-gap] Correctly send OnAdapterRemoved message when removing a host · 3b9322fb
      Nick Pollard authored
      The Control interface served by bt-gap declares 'OnAdapterRemoved'
      events which should be sent to indicate that a bt-host adapter has been
      removed. Previously we incorrectly did not send these messages, now we do.
      
      test: Run `bt-cli`. In another shell, run `bt-fake-hci add`, then
      `bt-fake-hci rm {adapter}` to remove the fake adapter. bt-cli should now
      print an 'Adapter {} removed' message - previously it did not.
      
      Change-Id: Ida6c0d1db06171ee572d07255d37cab1f33d5306
      3b9322fb
    • James Tucker's avatar
      [wlan-hw-sim-tests] no longer target QEMU · 9f1cc3ad
      James Tucker authored
      The wlan team informs me that this test passes consistently on NUC, coverage
      on QEMU is no longer useful.
      
      Bug: FLK-114 #done no longer runs under qemu
      Change-Id: I2ccb644c5999998102ff2411ee63587496eb6358
      9f1cc3ad
    • Nick Pollard's avatar
      [bt][tests] Disable Integration tests that use bt-gap to prevent flake · 49524483
      Nick Pollard authored
      Some of the new bluetooth integration tests have flaked in CI; This CL
      disables those whilst we investigate a full fix.
      
      FLK-106
      
      Change-Id: I8fd4631c0984ce91aeb6472bfc9f92d56a2d1af2
      49524483
    • Ariana Mott's avatar
      Revert "[scenic] Collect all waiting frames into a single instance" · d32ea9cf
      Ariana Mott authored
      This reverts commit cff62a0c.
      
      Reason for revert: Device is freezing up.
      
      Original change's description:
      > [scenic] Collect all waiting frames into a single instance
      > 
      > Make sure we only have a single async wait happening at a time in DefaultFrameScheduler.
      > This prevents the bug (SCN-1306) where a delayed frame can cause a second frame to
      > start rendering at the same time. It also makes it easier to reason about scheduling.
      > 
      > SCN-1306 #done
      > 
      > Change-Id: I9bc0fb4f077db9f6c7f346669785b744fc3113d7
      
      TBR=jjosh@google.com,mikejurka@google.com,jaeheon@google.com,dworsham@google.com,amott@google.com,adamgousetis@google.com,mikaelpessa@google.com
      
      # Not skipping CQ checks because original CL landed > 1 day ago.
      
      Change-Id: I4be79a683bac4f987fe6259e225c2f7eb5ec5daa
      d32ea9cf
    • Alex Min's avatar
      [modular] Give sessions a device-local unique identifier. · 21e3874b
      Alex Min authored
      - For now it takes the value of the account ID, such that re-authentication is
      not required for existing users.
      
      - The ID is not explicitly stored anywhere, the uniqueness is guaranteed
      by the fact that we can only have one session running at a time. Even if
      we had multiple sessions, the uniqueness is guaranteed by the account
      ID uniqueness from DB.
      
      - Also renamed some variables in sessionmgr_impl
      
      Change-Id: I73f150ddc874a49ffe9975c2f2fe16f1d8a5732c
      21e3874b
    • Joshua Seaton's avatar
      [test spec] s/label/tags · 8df517a2
      Joshua Seaton authored
      This is to avoid confusion with GN's labels and to provide a list instead
      of a single string.
      
      Change-Id: I25e402c67d79441e057f69f2919eedd477226d37
      8df517a2
    • James Tucker's avatar
      [pm publish] add clean option and use in build · b3a6d4b3
      James Tucker authored
      This is a DX feature request to reduce confusion that comes from having a
      build-controlled repository. The user intention is that the repository
      contains only the packages specified by the build. It should not contain
      packages that are not included in the build configuration.
      
      Test: pm publish -a -f mypkg-0.far; then pm publish -ps -f /dev/null -C
      Change-Id: Ie257ba4aeb4c017b57a0faff6cadf1f20048ceae
      b3a6d4b3
    • John Grossman's avatar
      [test][futex_core] Fix a test flake. · 64ea1cd0
      John Grossman authored
      See ZX-3770 for details.
      
      ZX-3770 #done
      
      Change-Id: I0cadb9f551db1dd8c972e04920367373ef12bfb1
      64ea1cd0
Loading