Fetch Linux sysroot that we use for all Linux targets.

TC-312

Change-Id: I5af3fa3e36f1703ee4f3f532f846487603ae1aa5

Also stop producing vboot images for arm64, which doesn't use them.

Bug: BLD-269 #done
Test: CQ & manual booting of Pixelbook with new fuchsia.vboot
Change-Id: I654900260b402dfe463932eaa07d6fdb9688c2db

This changes the logic to only add NUC and Vim2 environments to a test
if it does not specify an environment.

Change-Id: I61a80608deb702ae3221bdd25873935948c574fc

This tool has been moved to tools.

TC-312

Change-Id: I976895cef07ce1d7b9f14a7cae40c29d62a5835c

- Functions that return an error return a custom Error instead of
failure::Error. This will make it possible to have separate error types
for errors generated within the cmx code.
- Added `common` module as a place for the error type and constants
(currently just CMX_SCHEMA)
- Tests are converted to macros to make them more convenient to write
and to make it so Rust will report the name of the test that failed.

TESTED=./out/x64/host_x64/cmx_bin_test_rustc

Change-Id: Icc6dc2e30ce8f3f0db9fdcc00c811373cb38649b

Currently, the kernel corresponds to a positional bootserver argument,
represented by "" in images.json. This fixes that to pass the kernel
under --boot.

Test: images.json as expected (no ""'s); pave.sh and netboot.sh as
expected.

Change-Id: I5a4f786278b75114e234624a65036677d762fab7

Change-Id: Id9a1662c80903d6d1aa73ebf261b9d41bd4115a9

Whitelist all packages that have cmx's to be able to launch with bare
package URLs.

TESTED=
List generated with:
print(get_path_info(get_label_info(target_name,"dir"), "dir"))
in assert_cmx.gni when a cmx is found

fx set x64 --packages=garnet/packages/kitchen_sink,peridot/packages/kitchen_sink,topaz/packages/kitchen_sink

CF-156 #comment

Change-Id: I909a78f1bbdc351a1b5b94b707e70e366164a71b

The go vet command has a special invokation mode for which it can be
directed to vet the go source tree itself. This mode allows one to
specify whitelists for checks to ignore. When running go vet on a random
package, these whitelists can't be used.

Because we currently build go tests as separate packages to run on
Fuchsia targets, we cannot make use of this go vet mode for our
packages.

The CPU pprof test relies on the runtime's pprof package, which has one
of these go vet exceptions. Since the whitelist can't be used, we can't
detect this exception. The simplest path forward is to allow skipping go
vet for GN targets. This flag should not be used for anything outside
the go source tree.

Test: pprof patch succeeds building
Change-Id: I7c168ef3b166e1773aa368608485b48a2742a8c3

Test: compiled
Change-Id: I28e898dbcbf912e06192538422584ece81d26cc5

Now that deprecated-bare-package-url is merged in at build time in GN
with a build flag, but *after* cmx validation, we can get rid of this.
This prevents developers from manually adding the flag to their cmx
files.

Possible concerns:
- missed cases during flag flip, one less possible hot fix path.
- google3/outside of GN don't have cmx valildation (check with dgonyeo);
  if they have, then we'd need to keep an eye on that copy of the schema.

TESTED=fx set x64; fx full-build

CF-156 #comment

Change-Id: I68851d46b1af2a7b50d07f1797ca042b66e628a9

Schema file for cmx validation is now located at tools/cmx/schema.json.
This file should have been deleted when that file was added, so delete
it now.

TEST: can still build fuchsia successfully
Change-Id: Idf17f206e4a35879cb73fb6e4beb8518716aad39

Test: switched the fuchsia-async-macro crate over to
use this template rather than being built as part of
the third-party build, compiled.

Change-Id: Ic652a80b18fb82b14c838bfff12f10e0d1e3caef

Valico isn't consistent in the ordering of error messages, so sort
errors before assembling the final message such that tests have reliable
output.

TEST: while [ 0 -eq $? ]; do ./out/x64/host_x64/cmx_bin_test_rustc; done
Change-Id: I96897ee42344afd9dd2c2e473c1bb6488ada20f5

TESTED=
built with the flag on token_manager.cmx
booted topaz
fx shell 'cat /pkgfs/packages/token_manager_factory/0/meta/token_manager_factory.cmx'
fx shell 'cat /pkgfs/packages/sysmgr/0/meta/sysmgr.cmx'
also observed that there is a complaint for token manager with bare
package urls

CF-156 #comment

Change-Id: I491c922255ec4517f4fa43d54efe8525946cf1a1

C/C++ builds in GN doing stripping now use llvm-objcopy's new features
to populate the .build-id/ hierarchy with links to the stripped file
and the debug (i.e. unstripped) file.  Rust and Go links still need to
be taught to do the same.

To get all of the Zircon binaries into the GN-produced .build-id/
hierarchy, we use //scripts/build_id_conv.py to populate it based on
Zircon's ids.txt files.

Bug: TC-303 #comment Fuchsia GN populates .build-id for C/C++ binaries and Zircon
Test: CQ & manual inspection of .build-id/ contents
Change-Id: I433e299969dd776d5f0c4be5390350572a966be5

This reverts commit 850bcb51.

Reason for revert: Now the buildtools/fuchsia.ensure points to the correct revision number of tools/dump_breakpad_symbol, so the '-tar-file' flag is ready to use now

Original change's description:
> Revert "[gn] Have the dump_breakpad_symbols produced an archive of breakpad symbols"
> 
> This reverts commit 43b90d08.
> 
> Reason for revert: This is breaking the release builders; Ninja build executes this command and the '-tar-file' flag is not defined
> 
> Original change's description:
> > [gn] Have the dump_breakpad_symbols produced an archive of breakpad symbols
> > 
> > IN-851 #comment
> > 
> > Change-Id: I123dcc5bdd7bfe712d032ec9ddfc64b794812ba3
> 
> TBR=joshuaseaton@google.com,tonglisayhi@google.com
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Change-Id: Idbadce5b8e4f27842e81f83a40a35ee026b5a197

TBR=kjharland@google.com,joshuaseaton@google.com,tonglisayhi@google.com

Change-Id: Ic61cd30014b3e0feea4d51a0b2c006969cd293ed
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

This reverts commit 43b90d08.

Reason for revert: This is breaking the release builders; Ninja build executes this command and the '-tar-file' flag is not defined

Original change's description:
> [gn] Have the dump_breakpad_symbols produced an archive of breakpad symbols
> 
> IN-851 #comment
> 
> Change-Id: I123dcc5bdd7bfe712d032ec9ddfc64b794812ba3

TBR=joshuaseaton@google.com,tonglisayhi@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Idbadce5b8e4f27842e81f83a40a35ee026b5a197

This tool simplifies storage debugging from Zedboot.

Test: manual
Change-Id: I7ffe2fa155f032baaa2393b947535d5d982c23c1

This reverts commit f07f6271.

Reason for revert: Had Code-Review -1 before landing.

Original change's description:
> [fidl][overnet] Allow extra C++ dependencies
> 
> Allows additional C++ dependencies to be listed for FIDL libraries, in
> turn enabling additional code generation options.
> 
> Test: utilized on an upcoming garnet CL
> 
> Change-Id: I13a6063411ebfbb76d6ce3d02c1f98f5f5e92007

TBR=abarth@google.com,ctiller@google.com,pascallouis@google.com

Change-Id: Ic62f59620275ac3e2628a5bc1423bf309b574a84
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Allows additional C++ dependencies to be listed for FIDL libraries, in
turn enabling additional code generation options.

Test: utilized on an upcoming garnet CL

Change-Id: I13a6063411ebfbb76d6ce3d02c1f98f5f5e92007

Change-Id: I6fc673a1a9ee35ec6acba45edfef9a4094478dd4

Test: `gn gen` yields test specs with vim2 environments with label
"vim2"
Bug: IN-571

Change-Id: I00d182ea8b0c3ccdbcbeddae2ac90983f3344586

IN-851 #comment

Change-Id: I123dcc5bdd7bfe712d032ec9ddfc64b794812ba3

TESTED=cq, compiled a cmx file with the param.

CF-156 #comment

Change-Id: I204e4b2686b1127db8b02d6f5e157aaa14fafdc2

MAC-182

TEST=guest_integration_tests

Change-Id: I7da7bd66ac6e6d60fc4352c15ddb9516460807d6

Launching components without a fuchsia-pkg URI is no longer supported,
so update the string used to generate log persistence configs

Change-Id: I369ebef3c67875114981355174e8c76f001a0ab9

fuchsia_component will now look for manifest in "meta" folder if it is
not provided.

Change-Id: Ic18b06715d6209e5b044773fb44e80a68a4a5b4a

Before this is submitted, deprecated-all-services will be removed from
the two remaining cmx that have it

TESTED=builds

Change-Id: Ida4d5e3807dd50cb0e5892b3c718581ab2563766

Tidy up the test_spec template and make more idiomatic.

Test: CQ
Change-Id: I337cb018c852200ef5c6806c3ad8aa2ff29486c8

Currently fuchsia_packages are added to monolith by way of the
preprocess_products.py script. This layer of indirection isn't necessary
and we may add them to monolith directly before processing.

Also, tidied contradictory documentation.

Change-Id: Idb48e60f3cc273aac2f04c2cf939318d5153ea8c

This change mimic's the package templates behavior when the current
toolchain and the target toolchain are not the same.

Test: build with no variants and "asan" variant

BLD-329 #done

Change-Id: I2b81e6522472b6ec9f102310ada4e856471977a3

This tool can format, validate, and merge CMX files. Add build rules
that perform these actions as appropriate. Add //build/rustfmt.toml to
support rustfmt'ing code in //build.

CP-85 #comment
CP-86 #done
CP-119 #done

Change-Id: Ibd9f3f76a6cd4279b583d8205ebceed7fd0722e4

At this point the pre-flower workflows are not supported or functional,
so we don't need to carry this code around any more.

Test: manual
Change-Id: Iccf3ea702d57ff60bb7827033ffdefa92b06b534

It doesn't do anything anymore. Instead add a comment about changing
fvm_image_size.

Test: CQ
Change-Id: I5d5457a1b3048e2d11311c24a2775c2409e83ef1

Change-Id: Ib3cf3acc36c99e7f6653adc42ad966141b4aabb3

The process launcher expects #!resolve VMOs to end in a newline.

Previously, this happened to work because the VMO was padded with \0's,
which meant that the resource name passed to the Resolve call was
interpreted as the right string (albeit with the wrong length).

However, for other languages that do not use C-strings (such as Rust),
this causes problems, particularly when the string is checked when
passed through a C ABI boundary.

TESTED=logged that the resource name had the right length

Change-Id: I6ed94c24bf446958d0546c1d96cb5f7a06aa93fb

Test: manually verified that the libraries were in the correct location in SDK archives
Bug: DX-401
Change-Id: I8874adad24f82e2e831d9079770bb4a1d12d8d41

This makes it possible to add prebuilt packages to the
available/preinstall set and have the correct indices computed.

Test: fx set with topaz/packages/prod/chromium in --available and
--preinstall and --args=enable_chromium=true

Change-Id: I7ef8b12a5066b72cef98267ac4a6abf5e337e3d6

The fuzzing build macro was elided at some point in the development of
the fuzz target GN tempate.  This CL adds it back.

SEC-44

Tests: Confirmed flag is set on ninja invocation for fuzz targets
Change-Id: I22f141f5c7a606fae0f3f11b5b0acc5e95445fc8