Move the declaration of window.gettext and window.format into gettext.

* This makes it available before any gettext calls are done in wait-messages and error-messages.
* Create's only a single instance that is used universally.

resources/static/shared/gettext.js

+/*globals json_locale_data: true */
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-function Gettext(params) {
-    return {
-      gettext: function (msgid) {
-        if (json_locale_data && json_locale_data["client"]) {
-        var dict = json_locale_data["client"];
-          if (dict[msgid] && dict[msgid].length >= 2 &&
-              dict[msgid][1].trim() != "") {
-            return dict[msgid][1];
-          }
-      }
-      return msgid;
-      },
-      // See lib/i18n.js format docs
-      format: function (fmt, obj, named) {
-        if (! fmt) return "";
-        if (! fmt.replace) {
-          return fmt;
+(function() {
+  "use strict";
+
+  function Gettext(params) {
+      return {
+        gettext: function (msgid) {
+          if (json_locale_data && json_locale_data["client"]) {
+          var dict = json_locale_data["client"];
+            if (dict[msgid] && dict[msgid].length >= 2 &&
+                dict[msgid][1].trim() != "") {
+              return dict[msgid][1];
+            }
         }
-        if (named) {
-          return fmt.replace(/%\(\w+\)s/g, function(match){return String(obj[match.slice(2,-2)])});
-        } else {
-          return fmt.replace(/%s/g, function(match){return String(obj.shift())});
+        return msgid;
+        },
+        // See lib/i18n.js format docs
+        format: function (fmt, obj, named) {
+          if (! fmt) return "";
+          if (! fmt.replace) {
+            return fmt;
+          }
+          if (named) {
+            return fmt.replace(/%\(\w+\)s/g, function(match){return String(obj[match.slice(2,-2)])});
+          } else {
+            return fmt.replace(/%s/g, function(match){return String(obj.shift())});
+          }
         }
-      }
-    };
-};
\ No newline at end of file
+      };
+  };
+
+  var params = {
+        "domain" : "client",
+        "locale_data" : json_locale_data
+  };
+  var gt = new Gettext(params);
+  window.gettext = gt.gettext.bind(gt);
+  window.format = gt.format.bind(gt);
+
+}());

resources/static/shared/renderer.js

@@ -26,14 +26,6 @@ BrowserID.Renderer = (function() {
         url: "/dialog/views/" + templateName + ".ejs"
       };
     }
-    // TODO(aok) Do caching like EJS below
-    var params = {
-          "domain" : "client",
-          "locale_data" : json_locale_data
-    };
-    var gt = new Gettext(params);
-    window.gettext = gt.gettext.bind(gt);
-    window.format = gt.format.bind(gt);
 
     var template = templateCache[templateName];
     if(!template) {