Merge pull request #1651 from mozilla/issue1558

rework uncaught exception handling: log an error, don't bring the proces...

After reading the referenced article, it makes me wonder whether logging and continuing is the proper approach, a complete process restart does seem too severe.

r+ - an easy change.  

close #1558

lib/logging.js

@@ -40,7 +40,7 @@ exports.logger = new (winston.Logger)({
     timestamp: function () { return new Date().toISOString() },
     filename: filename,
     colorize: true,
-    handleExceptions: !!process.env['LOG_TO_CONSOLE']
+    handleExceptions: true
   })]
 });
 
@@ -51,6 +51,6 @@ exports.enableConsoleLogging = function() {
   });
 };
 
-
-
 if (process.env['LOG_TO_CONSOLE']) exports.enableConsoleLogging();
+
+exports.logger.exitOnError = false;

lib/statsd.js

@@ -29,3 +29,7 @@ if (statsd_config && statsd_config.enabled) {
 
   statsd = new StatsD(options["host"], options["port"]);
 }
+
+process.on('uncaughtException', function(err) {
+  if (statsd) statsd.increment(PREFIX + 'uncaught_exception');
+});