Merge pull request #1902 from zaach/clean_up_bin_jshint_warnings

Clean up jshint warnings in some of the bin processes

bin/browserid

@@ -180,9 +180,9 @@ db.open(config.get('database'), function (error) {
             logger.error("error creating test users - bcrypt encrypt pass: " + err);
             process.exit(1);
           }
-          var want = parseInt(process.env['CREATE_TEST_USERS']);
+          var want = parseInt(process.env['CREATE_TEST_USERS'], 10);
           var have = 0;
-          for (i = 1; i <= want; i++) {
+          for (var i = 1; i <= want; i++) {
             db.addTestUser(i + "@loadtest.domain", hash, function(err, email) {
               if (++have == want) {
                 logger.warn("created " + want + " test users");

bin/dbwriter

@@ -8,13 +8,13 @@ const
 fs = require('fs'),
 path = require('path'),
 url = require('url'),
-http = require('http');
+http = require('http'),
 urlparse = require('urlparse'),
 express = require('express'),
 wsapi = require('../lib/wsapi.js'),
-httputils = require('../lib/httputils.js');
+httputils = require('../lib/httputils.js'),
 secrets = require('../lib/secrets.js'),
-db = require('../lib/db.js');
+db = require('../lib/db.js'),
 config = require('../lib/configuration.js'),
 heartbeat = require('../lib/heartbeat.js'),
 metrics = require('../lib/metrics.js'),
@@ -49,7 +49,7 @@ app.use(express.logger({
 
 var statsd_config = config.get('statsd');
 if (statsd_config && statsd_config.enabled) {
-  logger_statsd = require("connect-logger-statsd");
+  var logger_statsd = require("connect-logger-statsd");
   app.use(logger_statsd({
     host: statsd_config.hostname || "localhost",
     port: statsd_config.port || 8125,
@@ -93,7 +93,7 @@ wsapi.setup({
 
 function doShutdown(readyForShutdownCB) {
   require('../lib/bcrypt.js').shutdown();
-  db.close(readyForShutdownCB)
+  db.close(readyForShutdownCB);
 }
 
 // open the databse

bin/keysigner

@@ -42,7 +42,7 @@ app.use(express.logger({
 
 var statsd_config = config.get('statsd');
 if (statsd_config && statsd_config.enabled) {
-  logger_statsd = require("connect-logger-statsd");
+  var logger_statsd = require("connect-logger-statsd");
   app.use(logger_statsd({
     host: statsd_config.hostname || "localhost",
     port: statsd_config.port || 8125,

bin/router

@@ -8,7 +8,7 @@ const
 fs = require('fs'),
 path = require('path'),
 url = require('url'),
-http = require('http');
+http = require('http'),
 urlparse = require('urlparse'),
 express = require('express');
 
@@ -70,7 +70,7 @@ app.use(express.limit("10kb"));
 
 var statsd_config = config.get('statsd');
 if (statsd_config && statsd_config.enabled) {
-  logger_statsd = require("connect-logger-statsd");
+  var logger_statsd = require("connect-logger-statsd");
   app.use(logger_statsd({
     host: statsd_config.hostname || "localhost",
     port: statsd_config.port || 8125,

bin/verifier

@@ -41,7 +41,7 @@ app.use(express.limit("10kb"));
 
 var statsd_config = config.get('statsd');
 if (statsd_config && statsd_config.enabled) {
-  logger_statsd = require("connect-logger-statsd");
+  var logger_statsd = require("connect-logger-statsd");
   app.use(logger_statsd({
     host: statsd_config.hostname || "localhost",
     port: statsd_config.port || 8125,
@@ -73,7 +73,7 @@ try {
 }
 
 function doVerification(req, resp, next) {
-  req.body = req.body || {}
+  req.body = req.body || {};
 
   var assertion = (req.query && req.query.assertion) ? req.query.assertion : req. body.assertion;
   var audience = (req.query && req.query.audience) ? req.query.audience : req.body.audience;
@@ -124,7 +124,7 @@ function doVerification(req, resp, next) {
       });
     }
   });
-};
+}
 
 app.post('/verify', doVerification);
 app.post('/', doVerification);