Reducing the amount of duplicate HTML, simplifying the way we write the templates.
for the formWrap, always show the favicon and signIn, adding a contents to the appropriate area so that this acts more like the wait and error screens. This helps simplify page_controller and its writing of the templates. Updating the tests for page_controller.
Showing
- browserid/static/dialog/controllers/authenticate_controller.js 0 additions, 2 deletions...erid/static/dialog/controllers/authenticate_controller.js
- browserid/static/dialog/controllers/dialog_controller.js 3 additions, 0 deletionsbrowserid/static/dialog/controllers/dialog_controller.js
- browserid/static/dialog/controllers/page_controller.js 3 additions, 3 deletionsbrowserid/static/dialog/controllers/page_controller.js
- browserid/static/dialog/controllers/pickemail_controller.js 1 addition, 3 deletionsbrowserid/static/dialog/controllers/pickemail_controller.js
- browserid/static/dialog/qunit.html 4 additions, 2 deletionsbrowserid/static/dialog/qunit.html
- browserid/static/dialog/test/qunit/controllers/page_controller_unit_test.js 4 additions, 4 deletions...ialog/test/qunit/controllers/page_controller_unit_test.js
- browserid/static/dialog/views/authenticate.ejs 41 additions, 65 deletionsbrowserid/static/dialog/views/authenticate.ejs
- browserid/static/dialog/views/pickemail.ejs 41 additions, 58 deletionsbrowserid/static/dialog/views/pickemail.ejs
- browserid/views/dialog.ejs 14 additions, 0 deletionsbrowserid/views/dialog.ejs
Loading
Please register or sign in to comment