Beefing up the cookies disabled check so that it handles almost all cases without user interaction.
* Add a new view, cookies_disabled - this is displayed to browsers that do not allow access to localStorage when cookies are disabled (Firefox, Chrome, Fennec) * Add localStorage check in include.js to check for browsers that do not allow write access to localStorage. * Add a Javascript cookie check in network.js->cookiesEnabled using a test cookie with duration of 1 second so it is never sent to the server. * Remove the old cookies_enabled check that was theorized to come from session_context - remove this from the XHR mock as well. issue #835
Showing
- lib/browserid/views.js 4 additions, 0 deletionslib/browserid/views.js
- resources/static/dialog/css/popup.css 1 addition, 1 deletionresources/static/dialog/css/popup.css
- resources/static/dialog/views/error.ejs 6 additions, 1 deletionresources/static/dialog/views/error.ejs
- resources/static/include_js/include.js 38 additions, 6 deletionsresources/static/include_js/include.js
- resources/static/shared/network.js 12 additions, 3 deletionsresources/static/shared/network.js
- resources/static/test/cases/shared/modules/cookie_check.js 0 additions, 14 deletionsresources/static/test/cases/shared/modules/cookie_check.js
- resources/static/test/cases/shared/network.js 1 addition, 8 deletionsresources/static/test/cases/shared/network.js
- resources/static/test/mocks/xhr.js 1 addition, 2 deletionsresources/static/test/mocks/xhr.js
- resources/views/cookies_disabled.ejs 20 additions, 0 deletionsresources/views/cookies_disabled.ejs
- tests/cache-header-tests.js 1 addition, 0 deletionstests/cache-header-tests.js
- tests/page-requests-test.js 1 addition, 0 deletionstests/page-requests-test.js
Loading
Please register or sign in to comment