update hub.js with tested version from PR against stomlinson/message_hub. tested and corrected.

resources/static/lib/hub.js

@@ -26,23 +26,28 @@ Hub = (function() {
 
   function all(callback, context) {
     globalListeners.push({
-      id: currID++,
+      id: currID,
       callback: context ? callback.bind(context) : callback
     });
 
-    return id;
+    return currID++;
   }
 
   function fire(message) {
     var messageListeners = listeners[message];
 
     if(messageListeners) {
+      // XXX: deviation from upstream!  upstream code doesn't pass
+      // 'message' as the first argument.  our code expects it.
+      // at some point we should modify all callers of hub.on() to
+      // not expect first arg to be message.
       for(var i = 0, listener; listener = messageListeners[i]; ++i) {
         listener.callback.apply(null, arguments);
       }
     }
-    
+
     for(var j = 0, glistener; glistener = globalListeners[j]; ++j) {
+      // global listeners get the message name as the first argument
       glistener.callback.apply(null, arguments);
     }
   }
@@ -60,7 +65,7 @@ Hub = (function() {
 
     for(var j = 0, glistener; glistener = globalListeners[j]; ++j) {
       if(glistener.id === id) {
-        globalListeners.splice(i, 1);
+        globalListeners.splice(j, 1);
         break;
       }
     }