Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
P
persona
Manage
Activity
Members
Labels
Plan
Issues
0
Issue boards
Milestones
Wiki
Code
Merge requests
0
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Hexang 息壤平台
persona
Commits
e2cad026
Commit
e2cad026
authored
13 years ago
by
Lloyd Hilaiel
Browse files
Options
Downloads
Patches
Plain Diff
keysigner and verifier should not log /__heartbeat__ requests - closes #537
parent
8c5e67ac
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
bin/keysigner
+3
-2
3 additions, 2 deletions
bin/keysigner
bin/verifier
+6
-7
6 additions, 7 deletions
bin/verifier
with
9 additions
and
9 deletions
bin/keysigner
+
3
−
2
View file @
e2cad026
...
...
@@ -53,6 +53,9 @@ shutdown = require('../lib/shutdown');
// create an express server
var
app
=
express
.
createServer
();
// respond to health checks (before logging)
heartbeat
.
setup
(
app
);
// our server will log
app
.
use
(
express
.
logger
({
format
:
config
.
get
(
'
express_log_format
'
),
...
...
@@ -70,8 +73,6 @@ app.use(function(req, resp, next) {
// parse POST bodies
app
.
use
(
express
.
bodyParser
());
heartbeat
.
setup
(
app
);
// and our single function
app
.
post
(
'
/wsapi/cert_key
'
,
validate
([
"
email
"
,
"
pubkey
"
]),
function
(
req
,
resp
)
{
// parse the pubkey
...
...
This diff is collapsed.
Click to expand it.
bin/verifier
+
6
−
7
View file @
e2cad026
...
...
@@ -53,6 +53,9 @@ logger.info("verifier server starting up");
var
app
=
express
.
createServer
();
// setup health check / heartbeat (before logging)
heartbeat
.
setup
(
app
);
// request to logger, dev formatted which omits personal data in the requests
app
.
use
(
express
.
logger
({
format
:
config
.
get
(
'
express_log_format
'
),
...
...
@@ -65,12 +68,6 @@ app.use(express.logger({
app
.
use
(
express
.
bodyParser
());
// shutdown when /code_update is invoked
shutdown
.
installUpdateHandler
(
app
);
// setup health check / heartbeat
heartbeat
.
setup
(
app
);
app
.
post
(
'
/verify
'
,
function
(
req
,
resp
,
next
)
{
req
.
body
=
req
.
body
||
{}
...
...
@@ -103,9 +100,11 @@ app.post('/verify', function(req, resp, next) {
rp
:
audience
});
});
});
// shutdown when /code_update is invoked
shutdown
.
installUpdateHandler
(
app
);
// shutdown nicely on signals
shutdown
.
handleTerminationSignals
(
app
);
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment