Skip to content
Snippets Groups Projects
Commit f841720e authored by Shane Tomlinson's avatar Shane Tomlinson
Browse files

Merge pull request #1879 from sawyerh/issue_1093_button_spinners

Fixes for issue #868 and issue #1517 and styles/assets for issue #1093

@sawyerh - great work on this.  For the future, it is *much* easier to review pull requests that focus on exactly one item.  This would have been easier to review had it been 3 PR's - one for the spinner, one for the iPad update, and one for the button styles - this is something I am working on myself - @lloyd calls me out on it frequently.

Once I updated the frontend unit tests to include the front-end test branch, all ran as expected.  I manually tested the dialog displayed correctly in the iPad sheet program @st3fan produced, Android 2.3.5 native, Fennec Android 2.3.5 mobile phone, Android 4.0 native, Fennec Nightly on Android 4.0, Chrome on Android 4.0, Opera Mobile on Android 4.0, iOS 5 iPod, and iOS5 iPad.

The loader gif still needs hooked up - but it looks great on our buttons.

close #868
close #1517
issue #1093

r+
parents e105fab9 4fa0d62f
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment