Merge pull request #1879 from sawyerh/issue_1093_button_spinners
Fixes for issue #868 and issue #1517 and styles/assets for issue #1093 @sawyerh - great work on this. For the future, it is *much* easier to review pull requests that focus on exactly one item. This would have been easier to review had it been 3 PR's - one for the spinner, one for the iPad update, and one for the button styles - this is something I am working on myself - @lloyd calls me out on it frequently. Once I updated the frontend unit tests to include the front-end test branch, all ran as expected. I manually tested the dialog displayed correctly in the iPad sheet program @st3fan produced, Android 2.3.5 native, Fennec Android 2.3.5 mobile phone, Android 4.0 native, Fennec Nightly on Android 4.0, Chrome on Android 4.0, Opera Mobile on Android 4.0, iOS 5 iPod, and iOS5 iPad. The loader gif still needs hooked up - but it looks great on our buttons. close #868 close #1517 issue #1093 r+
No related branches found
No related tags found
Showing
- resources/static/common/css/style.css 60 additions, 27 deletionsresources/static/common/css/style.css
- resources/static/common/fonts/LICENSE.txt 203 additions, 203 deletionsresources/static/common/fonts/LICENSE.txt
- resources/static/common/i/button-arrow-active.png 0 additions, 0 deletionsresources/static/common/i/button-arrow-active.png
- resources/static/common/i/button-arrow-hover.png 0 additions, 0 deletionsresources/static/common/i/button-arrow-hover.png
- resources/static/common/i/button-loader.gif 0 additions, 0 deletionsresources/static/common/i/button-loader.gif
- resources/views/dialog_layout.ejs 1 addition, 1 deletionresources/views/dialog_layout.ejs
Loading
Please register or sign in to comment