Skip to content
Snippets Groups Projects
  1. May 10, 2012
  2. May 09, 2012
  3. May 08, 2012
    • Shane Tomlinson's avatar
      Fix the IE6 and IE7 black screens on the main site. · b5872282
      Shane Tomlinson authored
      * css/style.css - where relevant and opacity's are used, use filters for IE6 and IE7.
      * shared/storage.js - when clearing localStorage if the user is not authenticated, call removeItem for the emails.  The call to JSON.stringify was blowing up.
      
      issue #1529
      b5872282
    • Shane Tomlinson's avatar
      Merge pull request #1549 from mozilla/issue1546-kpi-storage · e53ade9a
      Shane Tomlinson authored
      @ozten - Nice work on the cleanup.  What if we created one logger that we could use to universally log these sorts of things?  If we consolidated all of the logging into one module, we could add/remove/turn on or off functionality we use for logging.
      
      For the removed "delete" statement, it is safer to use localStorage.removeItem.  I forgot which browser was giving us problems with that, in the end I wrote a load of unit tests and did a browser comparison blog post (http://www.shanetomlinson.com/2012/localstorage-bugs-inconsistent-removeitem-delete/) - the trouble with delete came from IE8.  
      
      In IE8, if the item you are trying to call delete on is not already in localStorage, it will throw an exception.  IE8 does not have this problem with localStorage.removeItem.
      
      r+ - Merging.
      
      close #1546
      e53ade9a
    • Shane Tomlinson's avatar
      Replace the removed `delete storage.interactionData` with... · 8168451f
      Shane Tomlinson authored
      Replace the removed `delete storage.interactionData` with localStorage.removeItem("interactionData") to avoid IE8 exceptions.
      8168451f
  4. May 04, 2012
  5. May 07, 2012
  6. May 05, 2012
  7. May 04, 2012
  8. May 03, 2012
  9. May 04, 2012
  10. May 03, 2012
  11. May 04, 2012
Loading