Skip to content
Snippets Groups Projects
  1. May 23, 2012
    • Shane Tomlinson's avatar
      Move the requiredEmail checks from resources/state.js to controllers/dialog.js. Add more tests. · 4ddbd3fa
      Shane Tomlinson authored
      * Add the startExternalDependencies option when initializing the dialog controller, if set to false, no external dependencies are loaded.  Used for testing.
      * Add a new test to check for script containing emails.
      * Add unit tests for tosURL and privacyURL.
      * Add a testHelpers.testErrorNotVisible
      * Removed the actions.js->doError and its tests, it is no longer used.
      4ddbd3fa
    • Brian Warner's avatar
      Move requiredEmail validation from state.js to dialog.js . Tests fail. · 80d83831
      Brian Warner authored
      Since validation is done earlier, invalid addresses are reported as with
      renderError() instead of startAction("doError"). So the tests which
      watch for doError are now failing (the frontend tests named
      "resources/state: start with invalid requiredEmail - print error screen"
      and "resources/state: start with empty requiredEmail - prints error
      screen". I don't know how to make them watch for renderError() instead.
      
      One upside of this patch is that @stomlinson told me the three-argument
      to startAction("doError"..) in state.js was a bug, as it only accepts
      two real arguments. Removing it is even easier than fixing it.
      80d83831
  2. May 22, 2012
  3. May 21, 2012
  4. May 20, 2012
  5. May 17, 2012
  6. May 15, 2012
  7. May 07, 2012
  8. May 14, 2012
  9. May 11, 2012
  10. May 10, 2012
  11. May 09, 2012
Loading