Skip to content
Snippets Groups Projects
Commit b2b5cc80 authored by Natalie Weizenbaum's avatar Natalie Weizenbaum
Browse files

Get the proper default settings for Firefox and IE

We were using Dartium settings due to what I assume was a copy-paste
error on my part. I don't think this actually affected anything but
tests, since when running tests we never used the default
ExecutableSettings.
parent 6bc67cc3
No related branches found
No related tags found
No related merge requests found
...@@ -35,7 +35,7 @@ class Firefox extends Browser { ...@@ -35,7 +35,7 @@ class Firefox extends Browser {
/// Starts a new instance of Firefox open to the given [url], which may be a /// Starts a new instance of Firefox open to the given [url], which may be a
/// [Uri] or a [String]. /// [Uri] or a [String].
static Future<Process> _startBrowser(url, ExecutableSettings settings) async { static Future<Process> _startBrowser(url, ExecutableSettings settings) async {
settings ??= defaultSettings[TestPlatform.dartium]; settings ??= defaultSettings[TestPlatform.firefox];
var dir = createTempDir(); var dir = createTempDir();
new File(p.join(dir, 'prefs.js')).writeAsStringSync(_preferences); new File(p.join(dir, 'prefs.js')).writeAsStringSync(_preferences);
......
...@@ -22,7 +22,7 @@ class InternetExplorer extends Browser { ...@@ -22,7 +22,7 @@ class InternetExplorer extends Browser {
/// Starts a new instance of Internet Explorer open to the given [url], which /// Starts a new instance of Internet Explorer open to the given [url], which
/// may be a [Uri] or a [String]. /// may be a [Uri] or a [String].
static Future<Process> _startBrowser(url, ExecutableSettings settings) { static Future<Process> _startBrowser(url, ExecutableSettings settings) {
settings ??= defaultSettings[TestPlatform.dartium]; settings ??= defaultSettings[TestPlatform.internetExplorer];
return Process.start(settings.executable, return Process.start(settings.executable,
['-extoff', url.toString()]..addAll(settings.arguments)); ['-extoff', url.toString()]..addAll(settings.arguments));
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment