Skip to content
Snippets Groups Projects
  1. Sep 13, 2018
  2. Sep 11, 2018
  3. Sep 05, 2018
  4. Aug 23, 2018
  5. Aug 14, 2018
  6. Aug 13, 2018
  7. Jul 30, 2018
  8. Jul 26, 2018
    • Nate Bosch's avatar
      Fix some style nits in parse_metadata and test (#917) · 275cf5e3
      Nate Bosch authored
      - Use `??`, `??=`, and `?.` instead of explicit `== null`.
      - Use consistent single quotes
    • Nate Bosch's avatar
      Remove explicit checks for syntax errors (#916) · 3d0274b3
      Nate Bosch authored
      Towards #915
      
      The CFE will already reject this code if it is incorrect, we don't need
      to also check for syntax errors.
      
      - Remove the explict checks for `const`
      - Remove the explicit checks for using valid constructor names and
        argument types.
      - Update test to remove most of the `const` in examples. Retain const
        constructor calls since we can't yet parse the resulting expression if
        it is omitted.
      - Remove tests for the removed explicit checks.
  9. Jul 20, 2018
    • Lasse R.H. Nielsen's avatar
      Strengthen UTF-8 decoding. (#911) · 769f0dd9
      Lasse R.H. Nielsen authored
      Decoding input bytes by doing `.map(utf8.decode)` assumes that input byte chunks are split at encoded code-unit boundaries.
      It's safer to use `.transform(utf8.decoder)` which allows encodings to be split accross input chunks.
      
      Also changed `.listen(f).asFuture()` to the equivalent `.forEach(f)`.
      769f0dd9
  10. Jul 19, 2018
  11. Jul 16, 2018
  12. Jul 09, 2018
  13. Jun 27, 2018
  14. Jun 20, 2018
  15. Jun 18, 2018
  16. Jun 15, 2018
  17. Jun 14, 2018
  18. Jun 13, 2018
  19. Jun 12, 2018
  20. Jun 11, 2018
    • Gary Roumanis's avatar
    • Nate Bosch's avatar
      Fix implicit casts in lib directory (#861) · 00e2e7d7
      Nate Bosch authored
      There are still errors in tests which may be harder to fix so we can't
      check in the change to analysis options.
      
      This should make it easier to diagnose Dart 2 semantic issues as more of
      the places where there can be failures are explicit.
      
      Most of the changes are just adding explicit `as` statements and keeping
      the semantics that already existed. In a few places an uninitialized
      `var` is given a type, and in others a reused variable name with
      different types is split into multiple variables.
      
      The changes in the frontend code are the most risky, since some users
      might still be using that code in a non Dart 2 runtime and relying on
      looseness which is lost with an explicit cast.
      
      Pin to the dev.60 SDK for now since there are failures on the newer SDK.
    • Nate Bosch's avatar
      Drop AsyncFunction typedef (#859) · 4302ce42
      Nate Bosch authored
      The typedef was misused to mean either `Function` or `Function()` in
      various places and worked because the difference was not checked. The
      doc comment was also incorrect because there were places it was used
      where a return value was explicitly necessary. Replace with an inline
      function type definition using the appropriate choice for the location.
      
      Where possible also replace with Function types that flow through the
      required return types.
  21. Jun 08, 2018
  22. Jun 07, 2018
Loading