Skip to content
Snippets Groups Projects
  1. Jun 28, 2017
  2. Jun 27, 2017
  3. Jun 20, 2017
  4. Mar 15, 2017
  5. Dec 07, 2016
  6. Aug 01, 2016
  7. Jun 23, 2016
  8. Jun 20, 2016
    • Natalie Weizenbaum's avatar
      Refactor Source and SourceRegistry. · 3fb39388
      Natalie Weizenbaum authored
      This splits Source into two classes, Source and LiveSource. The former
      is completely independent of the system cache directory, and mostly
      contains source metadata and logic about manipulating descriptions.
      
      SourceRegistry now deals strictly in Sources, with LiveSources being
      handled by SystemCache. This means that classes like Pubspec and
      LockFile no longer have transitive references to the system cache
      directory.
      
      This will also make it possible to clean up PackageName equality logic
      by making PackageNames track their concrete Sources rather than just
      their source names.
      
      See #912
      
      R=rnystrom@google.com
      
      Review URL: https://codereview.chromium.org//2044253003 .
      3fb39388
  9. Jan 13, 2016
  10. Jan 04, 2016
  11. Dec 17, 2015
    • Natalie Weizenbaum's avatar
      Clean up the semantics of package descriptions. · a69f0c9c
      Natalie Weizenbaum authored
      This folds the distinction between "resolved" and "unresolved"
      descriptions into the distinction between PackageIds and PackageRefs. In
      other words, all PackageIds now have resolved descriptions and all
      PackageRefs now have unresolved descriptions. This makes it easier to
      track which descriptions are resolved and express resolution constraints
      via the type system.
      
      This also restricts the creation of PackageRefs and PackageIds to source
      classes, which helps ensure that the description format—which is an
      implementation detail—doesn't leak into surrounding code.
      
      R=rnystrom@google.com
      
      Review URL: https://codereview.chromium.org//1528523003 .
      a69f0c9c
  12. Aug 07, 2015
    • Natalie Weizenbaum's avatar
      Make Source.getDirectory synchronous. · a552a06b
      Natalie Weizenbaum authored
      It never really made sense for this to be asynchronous; most sources
      didn't even do any IO to determine the directory. The only exception was
      the git source, which would actually *clone a repository* if one didn't
      exist yet. This heavyweight behavior wasn't a good fit for what looks
      like a lightweight method anyway.
      
      Making this synchronous has a ripple effect of making a bunch of other
      methods synchronous, too. Hooray for synchrony!
      
      R=rnystrom@google.com
      
      Review URL: https://codereview.chromium.org//1276673006 .
      a552a06b
  13. Jul 15, 2015
  14. May 14, 2015
Loading