- Jun 28, 2017
-
-
Natalie Weizenbaum authored
-
- Jun 20, 2017
-
-
Natalie Weizenbaum authored
These classes are largely independent of the Package class.
-
- May 27, 2017
-
-
Jacob MacDonald authored
-
- Mar 15, 2017
-
-
Jacob MacDonald authored
-
- Oct 04, 2016
-
-
Kevin Moore authored
-
- Jul 22, 2016
-
-
Natalie Weizenbaum authored
We still need to verify that a Flutter SDK constraint is only used with an appropriate Dart SDK constraint. See #1432 R=rnystrom@google.com Review URL: https://codereview.chromium.org//2165423002 .
-
- Jun 23, 2016
-
-
Natalie Weizenbaum authored
This allows PackageName equality to include description equality, and it substantially cleans up other logic dealing with sources. See #912 R=rnystrom@google.com Review URL: https://codereview.chromium.org//2079303003 .
-
- Jun 20, 2016
-
-
Natalie Weizenbaum authored
This splits Source into two classes, Source and LiveSource. The former is completely independent of the system cache directory, and mostly contains source metadata and logic about manipulating descriptions. SourceRegistry now deals strictly in Sources, with LiveSources being handled by SystemCache. This means that classes like Pubspec and LockFile no longer have transitive references to the system cache directory. This will also make it possible to clean up PackageName equality logic by making PackageNames track their concrete Sources rather than just their source names. See #912 R=rnystrom@google.com Review URL: https://codereview.chromium.org//2044253003 .
-
- Jan 13, 2016
-
-
Natalie Weizenbaum authored
R=rnystrom@google.com Review URL: https://codereview.chromium.org//1585513002 .
-
- Jan 05, 2016
-
-
Natalie Weizenbaum authored
R=rnystrom@google.com Review URL: https://codereview.chromium.org//1556243002 .
-
- Dec 17, 2015
-
-
Natalie Weizenbaum authored
This folds the distinction between "resolved" and "unresolved" descriptions into the distinction between PackageIds and PackageRefs. In other words, all PackageIds now have resolved descriptions and all PackageRefs now have unresolved descriptions. This makes it easier to track which descriptions are resolved and express resolution constraints via the type system. This also restricts the creation of PackageRefs and PackageIds to source classes, which helps ensure that the description format—which is an implementation detail—doesn't leak into surrounding code. R=rnystrom@google.com Review URL: https://codereview.chromium.org//1528523003 .
-
- Oct 21, 2015
-
-
Natalie Weizenbaum authored
We didn't properly check for no sources in a dependency, which caused a crash for some invalid pubspecs. Closes #1348 R=rnystrom@google.com Review URL: https://codereview.chromium.org//1417993002 .
-
- Aug 07, 2015
-
-
Natalie Weizenbaum authored
It never really made sense for this to be asynchronous; most sources didn't even do any IO to determine the directory. The only exception was the git source, which would actually *clone a repository* if one didn't exist yet. This heavyweight behavior wasn't a good fit for what looks like a lightweight method anyway. Making this synchronous has a ripple effect of making a bunch of other methods synchronous, too. Hooray for synchrony! R=rnystrom@google.com Review URL: https://codereview.chromium.org//1276673006 .
-
- Jun 27, 2015
-
-
Natalie Weizenbaum authored
R=rnystrom@google.com Review URL: https://codereview.chromium.org//1215833002.
-
- May 22, 2015
-
-
Natalie Weizenbaum authored
R=rnystrom@google.com Review URL: https://codereview.chromium.org//1153643002
-
- May 14, 2015
-
-
nweiz@google.com authored
We were validating that the dependencies and dev_dependencies had no overlap whenever we accessed [Pubspec.dependencies], but this meant that we had to parse the dev_dependencies even if they were going unused. If that parse failed, it could stop an entire "pub get" from working. Now we only do this validation when [Pubspec.devDependencies] is accessed. This also fixes a bug in where, if a pubspec from outside the filesystem (e.g. a hosted dependency) has a relative path dependency, [PathSource.parseDescription] would crash. Although this shouldn't happen since we don't parse the dev dependencies anymore, [PathSource] will now handle it more gracefully if it does. Finally, this also works around an async_await bug that was causing stack traces to be truncated. R=rnystrom@google.com BUG=22194 Review URL: https://codereview.chromium.org//887483002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@43267 260f80e4-7a28-3924-810f-c04153c831b5
-
srawlins@google.com authored
BUG= https://code.google.com/p/dart/issues/detail?id=21229 Example: $ cat pubspec.yaml name: Name description: A sample command-line application version: 1.0 $ pub get Resolving dependencies... Error on line 3, column 10 of pubspec.yaml: "version" field must have three numeric components: major, minor, and patch. Instead of "1.0", consider "1.0.0". version: 1.0 ^^^ also $ cat pubspec.yaml name: Name description: A sample command-line application version: 1 $ pub get Resolving dependencies... Error on line 3, column 10 of pubspec.yaml: "version" field must have three numeric components: major, minor, and patch. Instead of "1", consider "1.0.0". version: 1 ^ R=rnystrom@google.com Review URL: https://codereview.chromium.org//632483002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40971 260f80e4-7a28-3924-810f-c04153c831b5
-
rnystrom@google.com authored
R=nweiz@google.com Review URL: https://codereview.chromium.org//602253002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40849 260f80e4-7a28-3924-810f-c04153c831b5
-
rnystrom@google.com authored
BUG=https://code.google.com/p/dart/issues/detail?id=18539 R=nweiz@google.com Review URL: https://codereview.chromium.org//566093003 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@40471 260f80e4-7a28-3924-810f-c04153c831b5
-
rnystrom@google.com authored
R=nweiz@google.com Review URL: https://codereview.chromium.org//463203002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@39183 260f80e4-7a28-3924-810f-c04153c831b5
-
rnystrom@google.com authored
RELNOTE=Pubspecs can have a "publishTo" field which is either a URL to specify the default server that publishing should use or "none" to specify that the package is private and cannot be published. BUG=https://code.google.com/p/dart/issues/detail?id=20046 R=nweiz@google.com Review URL: https://codereview.chromium.org//417043005 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@38880 260f80e4-7a28-3924-810f-c04153c831b5
-
rnystrom@google.com authored
BUG=https://code.google.com/p/dart/issues/detail?id=18538 R=nweiz@google.com Review URL: https://codereview.chromium.org//331593012 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@37832 260f80e4-7a28-3924-810f-c04153c831b5
-
nweiz@google.com authored
This uses the source spans exposed by the yaml package to associate pubspec errors visually with the section of the pubspec that caused them. R=rnystrom@google.com BUG=14999 Review URL: https://codereview.chromium.org//351703004 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@37675 260f80e4-7a28-3924-810f-c04153c831b5
-
rnystrom@google.com authored
This is prep work for global packages, which need to ensure their dependencies are local, but do not want to create symlinks for them. R=nweiz@google.com Review URL: https://codereview.chromium.org//357483004 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@37672 260f80e4-7a28-3924-810f-c04153c831b5
-
nweiz@google.com authored
Previously, two transformers from the same library but with different configuration was considered completely different from one another. This was not only inefficient but incorrect: it meant that a transformer could be loaded with the wrong code. R=rnystrom@google.com BUG=19261 Review URL: https://codereview.chromium.org//344673002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@37511 260f80e4-7a28-3924-810f-c04153c831b5
-
rnystrom@google.com authored
R=nweiz@google.com Review URL: https://codereview.chromium.org//243683002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@35344 260f80e4-7a28-3924-810f-c04153c831b5
-
rnystrom@google.com authored
BUG=https://code.google.com/p/dart/issues/detail?id=14594 R=nweiz@google.com Review URL: https://codereview.chromium.org//169223010 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@33089 260f80e4-7a28-3924-810f-c04153c831b5
-
rnystrom@google.com authored
BUG=https://code.google.com/p/dart/issues/detail?id=15841 R=nweiz@google.com Review URL: https://codereview.chromium.org//164753002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@32681 260f80e4-7a28-3924-810f-c04153c831b5
-
rnystrom@google.com authored
- Parse them in pubspec. - Pass them to solver. - Warn when they are used. - Error on publish. BUG=https://code.google.com/p/dart/issues/detail?id=8566 R=nweiz@google.com Review URL: https://codereview.chromium.org//74013007 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@30376 260f80e4-7a28-3924-810f-c04153c831b5
-
nweiz@google.com authored
R=rnystrom@google.com BUG=14636 Review URL: https://codereview.chromium.org//59383009 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@30007 260f80e4-7a28-3924-810f-c04153c831b5
-
nweiz@google.com authored
The user-visible effect of this is to make operations that only look at part of a pubspec work if other parts of the pubspec are somehow invalid. This is particularly important for the following scenario: 1. We release a version of pub in SDK 1.0.0 that parses pubspec field "foo" as an integer. 2. Sally uploads version 0.1.0 of her package, libsally. 3. We release a new version of pub in SDK 1.1.0 that supports strings in "foo". 4. Sally uploads libsally 0.2.0, which uses a string in "foo". The new version of libsally has an SDK constraint of ">= 1.1.0", since it uses the new "foo" feature. 5. Tom is using SDK 1.0.0 and runs "pub install" in a package that depends on libsally. Everyone's done everything right here; we made a backwards-compatible pubspec change, Sally chose the correct SDK constraint, and Tom has a dependency on a package that has a compatible version available. However, prior to this change, Tom's "pub install" would crash. His outdated version of pub would try and fail to parse libsally 0.2.0's "foo" field, and his version resolution would crash. With this change, it will only attempt to parse the SDK constraint portion of Sally's pubspec, and ignore anything else it doesn't understand. R=rnystrom@google.com BUG= Review URL: https://codereview.chromium.org//24246002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@27784 260f80e4-7a28-3924-810f-c04153c831b5
-
nweiz@google.com authored
This also requires that transformer plugins define an [asPlugin] named constructor in order to be loaded as plugins. R=rnystrom@google.com Review URL: https://codereview.chromium.org//23522029 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@27444 260f80e4-7a28-3924-810f-c04153c831b5
-
rnystrom@google.com authored
BUG=https://code.google.com/p/dart/issues/detail?id=12300 R=nweiz@google.com Review URL: https://codereview.chromium.org//22825024 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@26543 260f80e4-7a28-3924-810f-c04153c831b5
-
rnystrom@google.com authored
BUG=https://code.google.com/p/dart/issues/detail?id=11046 R=nweiz@google.com Review URL: https://codereview.chromium.org//23295025 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@26541 260f80e4-7a28-3924-810f-c04153c831b5
-
rnystrom@google.com authored
BUG= R=nweiz@google.com Review URL: https://codereview.chromium.org//22941002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@26040 260f80e4-7a28-3924-810f-c04153c831b5
-
rnystrom@google.com authored
BUG=https://code.google.com/p/dart/issues/detail?id=10190 R=nweiz@google.com Review URL: https://codereview.chromium.org//15347004 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@22913 260f80e4-7a28-3924-810f-c04153c831b5
-
nweiz@google.com authored
This also converts pub to a more package-like layout, which will help in the eventual exposing of pub internals as a library. Since pub's sources are now in lib/src, this also makes them importable from the tests and entrypoint using "package:" imports. BUG=6619 Review URL: https://codereview.chromium.org//14297021 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@21907 260f80e4-7a28-3924-810f-c04153c831b5
-
- Mar 28, 2013
-
-
nweiz@google.com authored
This also changes the SDK layout by replacing the "pkg" directory, which contained the full source of all the packages needed by pub and dartdoc, with a "packages" directory that contains only their lib directories. This directory is used as the package root for pub and dartdoc when run from the SDK. BUG=6745 Review URL: https://codereview.chromium.org//12782016 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@20640 260f80e4-7a28-3924-810f-c04153c831b5
-
- Mar 13, 2013
-
-
rnystrom@google.com authored
BUG=dartbug.com/5358 Review URL: https://codereview.chromium.org//12433014 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@19966 260f80e4-7a28-3924-810f-c04153c831b5
-
- Feb 19, 2013
-
-
rnystrom@google.com authored
BUG=http://code.google.com/p/dart/issues/detail?id=8527 Review URL: https://codereview.chromium.org//12285010 Review URL: https://codereview.chromium.org//12294039 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge@18715 260f80e4-7a28-3924-810f-c04153c831b5
-