- Jul 26, 2016
-
-
Jungshik Shin authored
Add big endian (mips and mips64) support to BUILD.gn - icudt[lb]_dat.S (assembly source) is generated at build-time from icudt[lb].dat (data bundle) when icu_use_data_file is false. - icudt[lb].dat is copied depending on the endinaness when icu_use_data_file is true. Part 1: https://codereview.chromium.org/2162393003 Part 2: https://codereview.chromium.org/2165403003 It works on Linux (both Chrome and v8) and Mac (v8). Android was also tested by building base_unittests target with icu_use_data_file=true/false. v8 does not yet support mips/mips64 in GN so that this CL cannot be tested with target_cpu={mips,mips64}. With Chrome on Mac, TEST below has to be done with https://codereview.chromium.org/2181043003 for http://crbug.com/630929. Windows should not be affected at all. BUG=v8:4828 TEST='gn args <builddir>' with icu_use_data_file set to true or false TEST=build base_unittests and run with --gtest_filter=ICU* TEST=build base_unittests and run with --gtest_filter=Message*ormat* TEST=build 'd8' (v8) and try `(new Date()).toLocaleString("de")` R=machenbach@chromium.org Review URL: https://codereview.chromium.org/2174993002 .
-
- Jul 08, 2016
-
-
John Budorick authored
BUG=pdfium:38 R=jshin@chromium.org Review URL: https://codereview.chromium.org/2119023002 .
-
- May 18, 2016
-
-
Sami Kyostila authored
BUG=610673 R=alexclarke@chromium.org, dpranke@chromium.org Review URL: https://codereview.chromium.org/1991833002 .
-
- Mar 25, 2016
-
-
Jungshik Shin authored
1. Update the IANA tz data to 2016c What's new in 2016b and 2016c are found at http://mm.icann.org/pipermail/tz-announce/2016-March/000036.html (2016b) http://mm.icann.org/pipermail/tz-announce/2016-March/000037.html (2016c) 2. Locale data fixes - en-AU date format fix from the upstream - ar and fa: Prepend 'percent sign' with RTL mark (U+200F). From Android. - tr: Use ₺ (U+20BA; Turkish Lira Sign) instead of 'TL'. This is to revert a locale patch picked up from Google's internal build of ICU. (Android also uses U+20BA). In addition, icudtl.dat (the prebuilt ICU data file for platforms other than Android is moved out of source/data/in to common/. This way, the data build steps for non-Android and Android can be unified and a bit more streamlined. icu.gyp and BUILD.gn are updated accordingly as well as README.chromium. BUG=598000 TEST=See bug comment 0 and comment 1 R=mark@chromium.org Review URL: https://codereview.chromium.org/1823293002 .
-
- Mar 18, 2016
-
-
Jungshik Shin authored
ICU in Chromium is compiled with exception disabled [1], but U_NOEXCEPT is set to 'noexcept' regardless of whether _HAS_EXCEPTION is set to 0 or (in source/common/unicode/platform.h ). [2]. Set U_NOEXCEPT to empty in our build files to avoid this issue. [1] http://bugs.icu-project.org/trac/ticket/8343 [2] http://bugs.icu-project.org/trac/ticket/12406 BUG=575007 TEST=Build on Windows with MSVS 2015 succeeds. R=thakis@chromium.org Review URL: https://codereview.chromium.org/1816673002 .
-
- Mar 11, 2016
-
-
Sylvain Defresne authored
BUG=297668 R=dpranke@chromium.org Review URL: https://codereview.chromium.org/1755473004 .
-
- Feb 02, 2016
-
-
Jungshik Shin authored
MSVC complains about '*/* foobar */'. Add a space between '*' and '/'. ICU uses a deprecated API internally and '-Wno-deprecated...' flag has to be turned on on Android as well as on Linux. Do not use ''-Wno-reorder' any more because it's not necessary. BUG=575007 TEST=Once rolled, Android and Windows build go through. R=thakis@chromium.org Review URL: https://codereview.chromium.org/1646623006 .
-
- Jan 29, 2016
-
-
Jungshik Shin authored
* Update the pre-built ICU data files for all platforms source/data/in/icudtl.dat for non-Android platforms {linux,mac}/icudt*.S for linux/mac android/icudtl.dat and android/icudt*.S for Android windows/icudt.dll for Windows * Update Android data trimming script 1. Make sure that 'default' calendar is kept in locales where it's relevant : root, th, fa, ar_SA, etc. 2. Add a minimal region data to work around a bug in ICU with pool.res handling * Update gn and gyp files * And add a TODO comment to update.sh to automate the build file update. * Add it_CH to the locale list. * Add sr_Latn to unit/reslocal.mk (required by sh) and line_normal_fi to brkitr/brklocal.mk (referred to in brkitr/fi.txt) in place of line_fi. * Update and add scripts for data building * Completely rewrite README.chromium * Check-in the prebuilt ICU data files/assembly sources for Linux,Mac,Windows,Chrome OS and Android. BUG=575007 TEST=Blink layout tests, webkit unittests TEST=All bots can build successfully TEST=net_unittests --gtest_filter="*ilenameUtil*" TEST=net_unittests --gtest_filter="*IDN*" (pending bug 336973) TEST=base_unittests --gtest_filter="*Conv*" TEST=browser_tests --gtest_filter="*ncoding*" TEST=base_unittests --gtest_filter="*essage*" TEST=ui_base_unittests --gtest_filter="*ormat*" TEST=ui_base_unittests --gtest_filter="L10n*" R=mark@chromium.org Review URL: https://codereview.chromium.org/1639543006 .
-
- Nov 03, 2015
-
-
Peter Kotwicz authored
The new GN rule will enable removal of code which copies icudtl.dat in Android GN code (for instance "copy_content_shell_assets"). BUG=547162 R=dpranke@chromium.org Review URL: https://codereview.chromium.org/1419583008 .
-
- Oct 01, 2015
-
-
Brett Wilson authored
Previously GN would implicitly make a group's deps public. I'm making this behave like other target types, so ICU's group's deps need to be public to forward the build information to dependents. TBR=dpranke@chromium.org Review URL: https://codereview.chromium.org/1374173003 .
-
- Aug 18, 2015
-
-
Nico Weber authored
Also add a few comments to the .gn file. BUG=505316 R=jshin@chromium.org Review URL: https://codereview.chromium.org/1301493002 .
-
- Aug 05, 2015
-
-
Brett Wilson authored
The Chromium build currently defines both is_component_build (boolean) and component_mode (a string). We're trying to standardize on the boolean. TBR=jshin Review URL: https://codereview.chromium.org/1273843002 .
-
- Jul 06, 2015
-
-
https://codereview.chromium.org/1224463003/Nico Weber authored
No intended behavior change (except fewer duplicated compiler flags). BUG=505319 TBR=mgiuca@chromium.org Review URL: https://codereview.chromium.org/1220363002.
-
- Jul 03, 2015
-
-
Matt Giuca authored
This warning is currently globally suppressed in Chromium, but this suppression will be switched off, making a local suppression necessary. BUG=505319 R=thakis@chromium.org Review URL: https://codereview.chromium.org/1224463003.
-
- Jul 01, 2015
-
-
Sam McNally authored
BUG=505304 R=thakis@chromium.org Review URL: https://codereview.chromium.org/1215103002.
-
- Jun 30, 2015
-
-
Daniel Cheng authored
Some Windows-specific ICU code uses this pattern, which triggers a clang warning. BUG=505302 R=thakis@chromium.org Review URL: https://codereview.chromium.org/1209413007.
-
- Jun 23, 2015
-
-
Dirk Pranke authored
R=brettw@chromium.org, dpranke@chromium.org Review URL: https://codereview.chromium.org/1183493003.
-
- Jun 09, 2015
-
-
Dirk Pranke authored
This allows targets that use GN to correctly note that they need the .dat file to be included in .isolates. R=brettw@chromium.org, jshin@chromium.org BUG= Review URL: https://codereview.chromium.org/1167613003.
-
Nico Weber authored
I hang my head in shame. BUG=498033 TBR=hans@chromium.org Review URL: https://codereview.chromium.org/1177533002.
-
Nico Weber authored
This ports https://codereview.chromium.org/515263002/ and https://codereview.chromium.org/508343002/ I don't see these warnings locally, but they do show up on the bots for some reason. Probably good to have gyp and gn match anyways. BUG=498033 R=hans@chromium.org Review URL: https://codereview.chromium.org/1171153002
-
- Jun 01, 2015
-
-
Jungshik Shin authored
1. -Wno-return-type-c-linkage - became unnecessary with ICU bug 9504 fixed 3 years ago. - remove from both BUILD.gn and icu.gyp 2. -Wnoheader-hygine - became unnecessary a long time ago. - remove from BUILD.gn (icu.gyp does not have it) 3. -Wstring-conversion and -Wheader-hygine - add to BUILD.gn by NOT excluding clang:extra_warnings BUG=114660 TEST=Build icuuc/icui18n targets (both gyp and GN) after regenerating build files. R=brettw@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/1158933005
-
- May 11, 2015
-
-
Brett Wilson authored
The GYP and GN build's defines have diverged. THis brings GN's defines in line with GYP's current set. R=jshin@chromium.org Review URL: https://codereview.chromium.org/1130383003
-
- Mar 21, 2015
-
-
Jungshik Shin (jungshik at google) authored
1. Cherry-pick security patches from the upstream. a. BiDi: integer overflow http://bugs.icu-project.org/trac/ticket/11451 http://crbug.com/451799 bidi.patch was updated to include patches for this issue. b. data race in cmemory; remove an unnecessary check with a global variable. http://bugs.icu-project.org/trac/ticket/11538 http://crbug.com/223352 cmemory.patch was added c. Locale::getBaseName() thread-safety http://bugs.icu-project.org/trac/ticket/11547 http://crbug.com/467836 locid.patch was updated to include patches for this issue. 2. Add UCONFIG_NO_NON_HTML5_CONVERSION=1 to BUILD.gn 3. Clean up a. Update README.chromium to flag patches that are already in the upstream. b. Split pkg_gen.patch from data.build.patch. pkg_gen.patch was already in the upstream while the rest of data.build.patch is Chromium-specific. c. Delete an unused converters.patch. BUG=223352,451799,467836 TEST=See bugs 223352, 467836, 468716, and 466838 R=jyasskin@chromium.org, mark@chromium.org Review URL: https://codereview.chromium.org/1020303002
-
- Mar 19, 2015
-
-
Jungshik Shin (jungshik at google) authored
I forgot to include this change in https://codereview.chromium.org/984233002 TBR=jochen@chromium.org BUG=NONE Review URL: https://codereview.chromium.org/1021673003
-
Jochen Eisinger authored
BUG=none R=dpranke@chromium.org Review URL: https://codereview.chromium.org/1014393002
-