Skip to content
Snippets Groups Projects
  1. May 31, 2017
  2. May 15, 2017
  3. May 14, 2017
    • Jungshik Shin's avatar
      Update ICU to 59.1 · 87232d8d
      Jungshik Shin authored
      * Highlights:
        - Emoji 5.0 data (partial; Emoji_Component property not included)
        - CLDR 31.0.1 (http://blog.unicode.org/2017/03/cldr-version-31-released.html)
          UTC and GMT are treated as distinct)
        - New case mapping API for styled text
        - C++ 11 is required
        - char16_t for UChar (UTF-16)
        - Source code is in UTF-8
      
      * Size changes
      
        common: 10,130,560 => 10,175,056
        android: 6,573,872 => 6,616,864
        iOS: 6,562,352 => 6,605,152
      
      On top of ICU 59.1 from the upstream, the following changes were applied.
      See https://chromium.googlesource.com/chromium/deps/icu/+log/chromium/59staging
      
        - Fix C++ 11 string literal assignment issue (upstream bug: 13192)
        - Fix C4229 warning by MSVC
        - Apply utf32.patch and include unistr.h in fuzzer_util
        - Update ICU data files
        - Fix wpo.patch
        - Apply Google locale patch and locale1.patch
        - update readme
        - Apply breakiterator related patches
        - Apply and update wpo.patch
        - Drop unused patch, apply data.build.win.patch, update README.chromium
        - Add /utf-8 flag for Windows/Visual Studio
        - Update BUILD.gn for UChar, stubdata and apply data_sym.patch
        - use stubdata.cpp instead of stubdata.c in icu.gyp
        - Update icu.gyp* files for v8
        - Update BUILD.gn, apply data.build.patch and vscomp.patch
        - Add new files in ICU 59.1
        - Get a fresh copy of ICU 59.1 from the upstream
        - Update update.sh script
      
      TBR=drott@chromium.org, yangguo@chromium.org
      Bug:699469
      TEST: layout tests, all unittests, browser tests
      Change-Id: Ie1e77323aa0c7f872153680c4deca6471a771a5c
      Reviewed-on: https://chromium-review.googlesource.com/505173
      
      
      Reviewed-by: default avatarJungshik Shin <jshin@chromium.org>
      87232d8d
  4. May 05, 2017
    • Jungshik Shin's avatar
      Customize the ICU data for iOS · 4b06aadd
      Jungshik Shin authored
      Add ios/icudtl.dat and ios/patch_locale.sh.
      
      Update README.chromium and BUILD.gn accordingly.
      Update scripts/copy_data.sh to take (ios|common|android).
      
      At the moment, iOS data is almost identical to that of Android, but in the future
      more cuts may be made (e.g. dictionary data for breakiterator).
      
      Bug: 718955
      TEST: iOS Chrome works as before.
      Review-Url: https://codereview.chromium.org/2743123002 .
      4b06aadd
  5. Dec 12, 2016
  6. Nov 17, 2016
  7. Nov 15, 2016
    • Bruce Dawson's avatar
      Return to suppressing deprecation warnings · 4d136324
      Bruce Dawson authored
      The previous change re-enabled warnings too aggressively. While the icu
      target built correctly the icu nacl targets (such as
      irt_x64/obj/third_party/icu/icuuc/uidna.o on Windows and
      newlib_pnacl/obj/third_party/icu/icuuc/uidna.o on other platforms)
      failed to compile due to deprecation warnings. This change adds back
      suppression of that one warning.
      
      BUG=21515
      R=thakis@chromium.org
      
      Review URL: https://codereview.chromium.org/2504463002 .
      4d136324
  8. Nov 14, 2016
    • Bruce Dawson's avatar
      Re-enable as many clang warning as possible · 3c89207b
      Bruce Dawson authored
      ICU has historically had many clang warnings disabled, but some of the
      underlying causes have been fixed. One of the VC++ specific warning
      disables was recently removed (crrev.com/2494793002) and this change
      removes a bunch more, for clang and VC++. For some of them there are
      specific icu bugs that have been fixed that allow this, and for others
      I just have the evidence that on Linux and Windows icu compiles with
      clang and VC++ with these changes.
      
      BUG=21515
      R=thakis@chromium.org
      
      Review URL: https://codereview.chromium.org/2492553006 .
      3c89207b
  9. Nov 11, 2016
  10. Oct 28, 2016
    • Jungshik Shin's avatar
      ICU update to 58 part 2 · e0d9b90c
      Jungshik Shin authored
      Follw-up to https://chromium.googlesource.com/chromium/deps/icu/+/5feb9ad5
      (due to a rietveld issue, part 1 was manually pushed).
      
      Update ICU to 58.1 release from ICU 56.1 part2.
      
      Listed below a tiny subset of what's new in 58.1:
      
        1. Unicode 9.0 from Unicode 8.0
          - Updated character properties including Emoji data up to 4.0beta.
          - Updated grapheme/word/line breaking rules for Emoji sequences and others.
      
        2. CLDR 30.0.2 from CLDR 28
          - Numerous locale data updates/improvements
      
        3. Spoofing API changes
        4. Greek uppercasing support as a part of regular case-mapping API.
        5. Line breaking rule file format optimization. This change enables me
           to add CJ loose line breaking rules back (previously, it's dropped
           to save space) so that Blink can use it for CJ.
      
      See http://site.icu-project.org/download/58 for more details on ICU 58.1
      and http://site.icu-project.org/download/57 for more details on ICU 57.1
      
      For CLDR 30, see http://cldr.unicode.org/index/downloads/cldr-30 .
      
      The size impact:
         Non-Android: 10,127,200 => 10,128,624 (delta = 1,424 / 0.014%)
         Android: 6,563,152 => 6,571,936 (delta = 8,784 / 0.13%)
      
      Below are the list of changes made on top of the upstream ICU 58.1
      in reverse order. Most of these changes were made in 58staging branch
      to run trybots and cherry-picked back for this CL. See
         https://chromium.googlesource.com/chromium/deps/icu/+/log/chromium/58staging
         https://codereview.chromium.org/2447513002/ : cr+blink update cl with
             58staging branch head.
      
      * Fix a build on Win without std::string (v8)
      * Add ms932 alias to Shift_JIS
      
      * Apply Google-specific locale data patches
      
      * Fix a bug in scriptset
      
      * Update windows-1255 mapping
      
      * Disable C4333 warning by MSVC (harmless)
      
      * Apply and update utf32.patch and README.chromium
      
      * Update and apply vscomp.patch
        stringpiece patch removed. VS2015 seems to be fine with a redefinition.
      
      * Update pre-built ICU data files
         Update *local.mk with a new copyright line
      
      * Apply more patches
        The following patches were applied and updated: data_symb, vscomp, wpo
      
        The unnecessary part was dropped from vscomp
      
      * Update BUILD.gn and icu.gyp* files
      
      * Update android/brkitr.patch
      
      * Update and apply more patches
      
      * Update and apply cjdict.patch
         Apply data.build.patch
      
      * Delete obsolete patches: cmemory,regex
      
      * Update README.chromium and apply brkitr patches
      
        - Update README.chromium
        - Remove obsolete patches
        - Update linebrk.patch and apply it: add back line_loose_cj
      
      * Update wordbrk.patch and apply it
      
      * Update and apply khmer-dictbe.patch
      
      * Update data trimming
      
        - android/patch_locale.sh
        - scripts/trim_data.sh
           ExemplarCh* removed
           charac*Label removed
           relative/relativeTime removed for daysOfWeek and quarter
      
      * Update the following patches
      
        android/brkitr.patch
        patches/linebrk.patch
        patches/data.build.patch
      
      * Update cjdict.patch and linebrk.patch
      
      BUG=637001
      TEST=Layout tests, all unittests, browser tests, ui tests.
      R=jsbell@chromium.org, mark@chromium.org
      
      Review URL: https://codereview.chromium.org/2442923002 .
      e0d9b90c
  11. Aug 17, 2016
  12. Aug 08, 2016
  13. Aug 02, 2016
    • Jungshik Shin's avatar
      List header files explicitly in BUILD.gn · 56680aaa
      Jungshik Shin authored
      Private headers are listed in source[] while public headers are listed
      in public[] for icuuc and icu18n targets.
      
      This change is to let trybot analyze step recompile icuuc or icu18n even
      when the only change in CL is in a header file (public or private).
      
      BUG=632438
      TEST=`gn check <out_dir>` does not complain.
      TEST=`gn ref <out_dir> third_party/icu/source/common/umutex.h` matches icuuc.
      TEST=`gn ref <out_dir> third_party/icu/source/common/unicode/unistr.h`
           matches icuuc.
      
      R=brettw@chromium.org
      
      Review URL: https://codereview.chromium.org/2186343002 .
      56680aaa
  14. Jul 29, 2016
    • Jungshik Shin's avatar
      Fix isolate_tests/clean isolate step · ef5c7353
      Jungshik Shin authored
      Add 'data' to copy() to for swarm-testing to work on trybots.
      Otherwise, the ICU data bundle would not be copied in isolate_tests step and
      all the tests requiring the ICU data would fail on trybots.
      
      BUG=v8:4828
      TEST=base_unittests and many other tests pass on trybots (with test isolation)
      R=machenbach@chromium.org
      
      Review URL: https://codereview.chromium.org/2197523002 .
      ef5c7353
  15. Jul 26, 2016
    • Jungshik Shin's avatar
      Support Big Endian in ICU: part 3 · ec9c1133
      Jungshik Shin authored
      Add big endian (mips and mips64) support to BUILD.gn
      
      - icudt[lb]_dat.S (assembly source) is generated at build-time from
        icudt[lb].dat (data bundle) when icu_use_data_file is false.
      - icudt[lb].dat is copied depending on the endinaness when icu_use_data_file
        is true.
      
      Part 1:  https://codereview.chromium.org/2162393003
      Part 2:  https://codereview.chromium.org/2165403003
      
      It works on Linux (both Chrome and v8) and Mac (v8).
      Android was also tested by building base_unittests target with
      icu_use_data_file=true/false.
      
      v8 does not yet support mips/mips64 in GN so that this CL cannot be
      tested with target_cpu={mips,mips64}.
      
      With Chrome on Mac, TEST below has to be done with
      https://codereview.chromium.org/2181043003 for http://crbug.com/630929.
      
      Windows should not be affected at all.
      
      BUG=v8:4828
      TEST='gn args <builddir>' with icu_use_data_file set to true or false
      TEST=build base_unittests and run with --gtest_filter=ICU*
      TEST=build base_unittests and run with --gtest_filter=Message*ormat*
      TEST=build 'd8' (v8) and try `(new Date()).toLocaleString("de")`
      R=machenbach@chromium.org
      
      Review URL: https://codereview.chromium.org/2174993002 .
      ec9c1133
  16. Jul 08, 2016
  17. May 18, 2016
  18. Mar 25, 2016
  19. Mar 18, 2016
  20. Mar 11, 2016
  21. Feb 02, 2016
  22. Jan 29, 2016
    • Jungshik Shin's avatar
      ICU 56 step 6:Check in the pre-built ICU data · d2c18300
      Jungshik Shin authored
      * Update the pre-built ICU data files for all platforms
      
        source/data/in/icudtl.dat for non-Android platforms
        {linux,mac}/icudt*.S for linux/mac
        android/icudtl.dat and android/icudt*.S for Android
        windows/icudt.dll for Windows
      
      * Update Android data trimming script
      
        1. Make sure that 'default' calendar is kept in locales where it's relevant
          : root, th, fa, ar_SA, etc.
        2. Add a minimal region data to work around a bug in ICU with pool.res
           handling
      
      * Update gn and gyp files
      * And add a TODO comment to update.sh to automate the build file update.
      * Add it_CH to the locale list.
      * Add sr_Latn to unit/reslocal.mk (required by sh) and
        line_normal_fi to brkitr/brklocal.mk (referred to in brkitr/fi.txt) in
        place of line_fi.
      
      * Update and add scripts for data building
      * Completely rewrite README.chromium
      * Check-in the prebuilt ICU data files/assembly sources for
        Linux,Mac,Windows,Chrome OS and Android.
      
      BUG=575007
      TEST=Blink layout tests, webkit unittests
      TEST=All bots can build successfully
      TEST=net_unittests --gtest_filter="*ilenameUtil*"
      TEST=net_unittests --gtest_filter="*IDN*" (pending bug 336973)
      TEST=base_unittests --gtest_filter="*Conv*"
      TEST=browser_tests --gtest_filter="*ncoding*"
      TEST=base_unittests --gtest_filter="*essage*"
      TEST=ui_base_unittests --gtest_filter="*ormat*"
      TEST=ui_base_unittests --gtest_filter="L10n*"
      R=mark@chromium.org
      
      Review URL: https://codereview.chromium.org/1639543006 .
      d2c18300
  23. Nov 03, 2015
  24. Oct 01, 2015
  25. Aug 18, 2015
  26. Aug 05, 2015
  27. Jul 06, 2015
  28. Jul 03, 2015
  29. Jul 01, 2015
  30. Jun 30, 2015
  31. Jun 23, 2015
  32. Jun 09, 2015
  33. Jun 01, 2015
    • Jungshik Shin's avatar
      Remove unnecessary clang flags for ICU · dbed54da
      Jungshik Shin authored
      1. -Wno-return-type-c-linkage
       - became unnecessary with ICU bug 9504 fixed 3 years ago.
       - remove from both BUILD.gn and icu.gyp
      
      2. -Wnoheader-hygine
       - became unnecessary a long time ago.
       - remove from BUILD.gn (icu.gyp does not have it)
      
      3. -Wstring-conversion and -Wheader-hygine
       - add to BUILD.gn by NOT excluding clang:extra_warnings
      
      BUG=114660
      TEST=Build icuuc/icui18n targets (both gyp and GN) after regenerating build files.
      R=brettw@chromium.org, thakis@chromium.org
      
      Review URL: https://codereview.chromium.org/1158933005
      dbed54da
  34. May 11, 2015
  35. Mar 21, 2015
  36. Mar 19, 2015
Loading