- May 31, 2017
-
-
Jungshik Shin authored
This is necessary for Chrome OS to calculate sunset time. Bug:chromium:726654 Test: With https://codereview.chromium.org/2887913004 patched in, 'gn Change-Id: Icf6a8cd833f8afcd1a2d0ce874cf1c8c92fcba44 gen <out_dir> --check' does not complain. TBR=afakhry@chromium.org Reviewed-on: https://chromium-review.googlesource.com/520323 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- May 15, 2017
-
-
Michael Achenbach authored
Also add support for host_byteorder logic which is introduced in - https://codereview.chromium.org/2815453004/ R=adamk@chromium.org, dpranke@chromium.org, machenbach@chromium.org BUG=706728 Review-Url: https://codereview.chromium.org/2812173002 .
-
- May 14, 2017
-
-
Jungshik Shin authored
* Highlights: - Emoji 5.0 data (partial; Emoji_Component property not included) - CLDR 31.0.1 (http://blog.unicode.org/2017/03/cldr-version-31-released.html) UTC and GMT are treated as distinct) - New case mapping API for styled text - C++ 11 is required - char16_t for UChar (UTF-16) - Source code is in UTF-8 * Size changes common: 10,130,560 => 10,175,056 android: 6,573,872 => 6,616,864 iOS: 6,562,352 => 6,605,152 On top of ICU 59.1 from the upstream, the following changes were applied. See https://chromium.googlesource.com/chromium/deps/icu/+log/chromium/59staging - Fix C++ 11 string literal assignment issue (upstream bug: 13192) - Fix C4229 warning by MSVC - Apply utf32.patch and include unistr.h in fuzzer_util - Update ICU data files - Fix wpo.patch - Apply Google locale patch and locale1.patch - update readme - Apply breakiterator related patches - Apply and update wpo.patch - Drop unused patch, apply data.build.win.patch, update README.chromium - Add /utf-8 flag for Windows/Visual Studio - Update BUILD.gn for UChar, stubdata and apply data_sym.patch - use stubdata.cpp instead of stubdata.c in icu.gyp - Update icu.gyp* files for v8 - Update BUILD.gn, apply data.build.patch and vscomp.patch - Add new files in ICU 59.1 - Get a fresh copy of ICU 59.1 from the upstream - Update update.sh script TBR=drott@chromium.org, yangguo@chromium.org Bug:699469 TEST: layout tests, all unittests, browser tests Change-Id: Ie1e77323aa0c7f872153680c4deca6471a771a5c Reviewed-on: https://chromium-review.googlesource.com/505173 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- May 05, 2017
-
-
Jungshik Shin authored
Add ios/icudtl.dat and ios/patch_locale.sh. Update README.chromium and BUILD.gn accordingly. Update scripts/copy_data.sh to take (ios|common|android). At the moment, iOS data is almost identical to that of Android, but in the future more cuts may be made (e.g. dictionary data for breakiterator). Bug: 718955 TEST: iOS Chrome works as before. Review-Url: https://codereview.chromium.org/2743123002 .
-
- Dec 12, 2016
-
-
Tomasz Śniatowski authored
https://codereview.chromium.org/2504463002 added suppresion of deprecation warnings in an "if clang" block, but gcc also warns about these, as can be seen on Chrome-Android waterfall for example. Fix by moving the supression to an if linux||android block. BUG=21515 R=thakis@chromium.org Review URL: https://codereview.chromium.org/2571433002 . Patch from Tomasz Śniatowski <tsniatowski@opera.com>.
-
- Nov 17, 2016
-
-
Bruce Dawson authored
In crrev.com/2492553006 I accidentally deleted a comment line from BUILD.gn. This change restores that comment, per reviewer request. TBR=jshin@chromium.org BUG=21515 Review URL: https://codereview.chromium.org/2503833003 .
-
- Nov 15, 2016
-
-
Bruce Dawson authored
The previous change re-enabled warnings too aggressively. While the icu target built correctly the icu nacl targets (such as irt_x64/obj/third_party/icu/icuuc/uidna.o on Windows and newlib_pnacl/obj/third_party/icu/icuuc/uidna.o on other platforms) failed to compile due to deprecation warnings. This change adds back suppression of that one warning. BUG=21515 R=thakis@chromium.org Review URL: https://codereview.chromium.org/2504463002 .
-
- Nov 14, 2016
-
-
Bruce Dawson authored
ICU has historically had many clang warnings disabled, but some of the underlying causes have been fixed. One of the VC++ specific warning disables was recently removed (crrev.com/2494793002) and this change removes a bunch more, for clang and VC++. For some of them there are specific icu bugs that have been fixed that allow this, and for others I just have the evidence that on Linux and Windows icu compiles with clang and VC++ with these changes. BUG=21515 R=thakis@chromium.org Review URL: https://codereview.chromium.org/2492553006 .
-
- Nov 11, 2016
-
-
Jungshik Shin authored
Update config to use icudtb.dat if the byteorder is big endian, this will work for other big endian platforms such as PPC and s390. Original CL for BE support: https://codereview.chromium.org/2162393003 R=jshin@chromium.org BUG=v8:5567 Review URL: https://codereview.chromium.org/2434153002 .
-
- Oct 28, 2016
-
-
Jungshik Shin authored
Follw-up to https://chromium.googlesource.com/chromium/deps/icu/+/5feb9ad5 (due to a rietveld issue, part 1 was manually pushed). Update ICU to 58.1 release from ICU 56.1 part2. Listed below a tiny subset of what's new in 58.1: 1. Unicode 9.0 from Unicode 8.0 - Updated character properties including Emoji data up to 4.0beta. - Updated grapheme/word/line breaking rules for Emoji sequences and others. 2. CLDR 30.0.2 from CLDR 28 - Numerous locale data updates/improvements 3. Spoofing API changes 4. Greek uppercasing support as a part of regular case-mapping API. 5. Line breaking rule file format optimization. This change enables me to add CJ loose line breaking rules back (previously, it's dropped to save space) so that Blink can use it for CJ. See http://site.icu-project.org/download/58 for more details on ICU 58.1 and http://site.icu-project.org/download/57 for more details on ICU 57.1 For CLDR 30, see http://cldr.unicode.org/index/downloads/cldr-30 . The size impact: Non-Android: 10,127,200 => 10,128,624 (delta = 1,424 / 0.014%) Android: 6,563,152 => 6,571,936 (delta = 8,784 / 0.13%) Below are the list of changes made on top of the upstream ICU 58.1 in reverse order. Most of these changes were made in 58staging branch to run trybots and cherry-picked back for this CL. See https://chromium.googlesource.com/chromium/deps/icu/+/log/chromium/58staging https://codereview.chromium.org/2447513002/ : cr+blink update cl with 58staging branch head. * Fix a build on Win without std::string (v8) * Add ms932 alias to Shift_JIS * Apply Google-specific locale data patches * Fix a bug in scriptset * Update windows-1255 mapping * Disable C4333 warning by MSVC (harmless) * Apply and update utf32.patch and README.chromium * Update and apply vscomp.patch stringpiece patch removed. VS2015 seems to be fine with a redefinition. * Update pre-built ICU data files Update *local.mk with a new copyright line * Apply more patches The following patches were applied and updated: data_symb, vscomp, wpo The unnecessary part was dropped from vscomp * Update BUILD.gn and icu.gyp* files * Update android/brkitr.patch * Update and apply more patches * Update and apply cjdict.patch Apply data.build.patch * Delete obsolete patches: cmemory,regex * Update README.chromium and apply brkitr patches - Update README.chromium - Remove obsolete patches - Update linebrk.patch and apply it: add back line_loose_cj * Update wordbrk.patch and apply it * Update and apply khmer-dictbe.patch * Update data trimming - android/patch_locale.sh - scripts/trim_data.sh ExemplarCh* removed charac*Label removed relative/relativeTime removed for daysOfWeek and quarter * Update the following patches android/brkitr.patch patches/linebrk.patch patches/data.build.patch * Update cjdict.patch and linebrk.patch BUG=637001 TEST=Layout tests, all unittests, browser tests, ui tests. R=jsbell@chromium.org, mark@chromium.org Review URL: https://codereview.chromium.org/2442923002 .
-
- Aug 17, 2016
-
-
Jungshik Shin authored
Make icu depend on //buildtools/third_party/libc++abi on mac for sanitizer builds. BUG=636127 TEST=Libfuzzer Upload Mac ASan builds R=mmoroz@chromium.org Review URL: https://codereview.chromium.org/2247953005 .
-
- Aug 08, 2016
-
-
Jungshik Shin authored
BUG=626078 TEST=trybot succeeds on non-Windows. R=rsesek@chromium.org Review URL: https://codereview.chromium.org/2218673002 .
-
- Aug 02, 2016
-
-
Jungshik Shin authored
Private headers are listed in source[] while public headers are listed in public[] for icuuc and icu18n targets. This change is to let trybot analyze step recompile icuuc or icu18n even when the only change in CL is in a header file (public or private). BUG=632438 TEST=`gn check <out_dir>` does not complain. TEST=`gn ref <out_dir> third_party/icu/source/common/umutex.h` matches icuuc. TEST=`gn ref <out_dir> third_party/icu/source/common/unicode/unistr.h` matches icuuc. R=brettw@chromium.org Review URL: https://codereview.chromium.org/2186343002 .
-
- Jul 29, 2016
-
-
Jungshik Shin authored
Add 'data' to copy() to for swarm-testing to work on trybots. Otherwise, the ICU data bundle would not be copied in isolate_tests step and all the tests requiring the ICU data would fail on trybots. BUG=v8:4828 TEST=base_unittests and many other tests pass on trybots (with test isolation) R=machenbach@chromium.org Review URL: https://codereview.chromium.org/2197523002 .
-
- Jul 26, 2016
-
-
Jungshik Shin authored
Add big endian (mips and mips64) support to BUILD.gn - icudt[lb]_dat.S (assembly source) is generated at build-time from icudt[lb].dat (data bundle) when icu_use_data_file is false. - icudt[lb].dat is copied depending on the endinaness when icu_use_data_file is true. Part 1: https://codereview.chromium.org/2162393003 Part 2: https://codereview.chromium.org/2165403003 It works on Linux (both Chrome and v8) and Mac (v8). Android was also tested by building base_unittests target with icu_use_data_file=true/false. v8 does not yet support mips/mips64 in GN so that this CL cannot be tested with target_cpu={mips,mips64}. With Chrome on Mac, TEST below has to be done with https://codereview.chromium.org/2181043003 for http://crbug.com/630929. Windows should not be affected at all. BUG=v8:4828 TEST='gn args <builddir>' with icu_use_data_file set to true or false TEST=build base_unittests and run with --gtest_filter=ICU* TEST=build base_unittests and run with --gtest_filter=Message*ormat* TEST=build 'd8' (v8) and try `(new Date()).toLocaleString("de")` R=machenbach@chromium.org Review URL: https://codereview.chromium.org/2174993002 .
-
- Jul 08, 2016
-
-
John Budorick authored
BUG=pdfium:38 R=jshin@chromium.org Review URL: https://codereview.chromium.org/2119023002 .
-
- May 18, 2016
-
-
Sami Kyostila authored
BUG=610673 R=alexclarke@chromium.org, dpranke@chromium.org Review URL: https://codereview.chromium.org/1991833002 .
-
- Mar 25, 2016
-
-
Jungshik Shin authored
1. Update the IANA tz data to 2016c What's new in 2016b and 2016c are found at http://mm.icann.org/pipermail/tz-announce/2016-March/000036.html (2016b) http://mm.icann.org/pipermail/tz-announce/2016-March/000037.html (2016c) 2. Locale data fixes - en-AU date format fix from the upstream - ar and fa: Prepend 'percent sign' with RTL mark (U+200F). From Android. - tr: Use ₺ (U+20BA; Turkish Lira Sign) instead of 'TL'. This is to revert a locale patch picked up from Google's internal build of ICU. (Android also uses U+20BA). In addition, icudtl.dat (the prebuilt ICU data file for platforms other than Android is moved out of source/data/in to common/. This way, the data build steps for non-Android and Android can be unified and a bit more streamlined. icu.gyp and BUILD.gn are updated accordingly as well as README.chromium. BUG=598000 TEST=See bug comment 0 and comment 1 R=mark@chromium.org Review URL: https://codereview.chromium.org/1823293002 .
-
- Mar 18, 2016
-
-
Jungshik Shin authored
ICU in Chromium is compiled with exception disabled [1], but U_NOEXCEPT is set to 'noexcept' regardless of whether _HAS_EXCEPTION is set to 0 or (in source/common/unicode/platform.h ). [2]. Set U_NOEXCEPT to empty in our build files to avoid this issue. [1] http://bugs.icu-project.org/trac/ticket/8343 [2] http://bugs.icu-project.org/trac/ticket/12406 BUG=575007 TEST=Build on Windows with MSVS 2015 succeeds. R=thakis@chromium.org Review URL: https://codereview.chromium.org/1816673002 .
-
- Mar 11, 2016
-
-
Sylvain Defresne authored
BUG=297668 R=dpranke@chromium.org Review URL: https://codereview.chromium.org/1755473004 .
-
- Feb 02, 2016
-
-
Jungshik Shin authored
MSVC complains about '*/* foobar */'. Add a space between '*' and '/'. ICU uses a deprecated API internally and '-Wno-deprecated...' flag has to be turned on on Android as well as on Linux. Do not use ''-Wno-reorder' any more because it's not necessary. BUG=575007 TEST=Once rolled, Android and Windows build go through. R=thakis@chromium.org Review URL: https://codereview.chromium.org/1646623006 .
-
- Jan 29, 2016
-
-
Jungshik Shin authored
* Update the pre-built ICU data files for all platforms source/data/in/icudtl.dat for non-Android platforms {linux,mac}/icudt*.S for linux/mac android/icudtl.dat and android/icudt*.S for Android windows/icudt.dll for Windows * Update Android data trimming script 1. Make sure that 'default' calendar is kept in locales where it's relevant : root, th, fa, ar_SA, etc. 2. Add a minimal region data to work around a bug in ICU with pool.res handling * Update gn and gyp files * And add a TODO comment to update.sh to automate the build file update. * Add it_CH to the locale list. * Add sr_Latn to unit/reslocal.mk (required by sh) and line_normal_fi to brkitr/brklocal.mk (referred to in brkitr/fi.txt) in place of line_fi. * Update and add scripts for data building * Completely rewrite README.chromium * Check-in the prebuilt ICU data files/assembly sources for Linux,Mac,Windows,Chrome OS and Android. BUG=575007 TEST=Blink layout tests, webkit unittests TEST=All bots can build successfully TEST=net_unittests --gtest_filter="*ilenameUtil*" TEST=net_unittests --gtest_filter="*IDN*" (pending bug 336973) TEST=base_unittests --gtest_filter="*Conv*" TEST=browser_tests --gtest_filter="*ncoding*" TEST=base_unittests --gtest_filter="*essage*" TEST=ui_base_unittests --gtest_filter="*ormat*" TEST=ui_base_unittests --gtest_filter="L10n*" R=mark@chromium.org Review URL: https://codereview.chromium.org/1639543006 .
-
- Nov 03, 2015
-
-
Peter Kotwicz authored
The new GN rule will enable removal of code which copies icudtl.dat in Android GN code (for instance "copy_content_shell_assets"). BUG=547162 R=dpranke@chromium.org Review URL: https://codereview.chromium.org/1419583008 .
-
- Oct 01, 2015
-
-
Brett Wilson authored
Previously GN would implicitly make a group's deps public. I'm making this behave like other target types, so ICU's group's deps need to be public to forward the build information to dependents. TBR=dpranke@chromium.org Review URL: https://codereview.chromium.org/1374173003 .
-
- Aug 18, 2015
-
-
Nico Weber authored
Also add a few comments to the .gn file. BUG=505316 R=jshin@chromium.org Review URL: https://codereview.chromium.org/1301493002 .
-
- Aug 05, 2015
-
-
Brett Wilson authored
The Chromium build currently defines both is_component_build (boolean) and component_mode (a string). We're trying to standardize on the boolean. TBR=jshin Review URL: https://codereview.chromium.org/1273843002 .
-
- Jul 06, 2015
-
-
https://codereview.chromium.org/1224463003/Nico Weber authored
No intended behavior change (except fewer duplicated compiler flags). BUG=505319 TBR=mgiuca@chromium.org Review URL: https://codereview.chromium.org/1220363002.
-
- Jul 03, 2015
-
-
Matt Giuca authored
This warning is currently globally suppressed in Chromium, but this suppression will be switched off, making a local suppression necessary. BUG=505319 R=thakis@chromium.org Review URL: https://codereview.chromium.org/1224463003.
-
- Jul 01, 2015
-
-
Sam McNally authored
BUG=505304 R=thakis@chromium.org Review URL: https://codereview.chromium.org/1215103002.
-
- Jun 30, 2015
-
-
Daniel Cheng authored
Some Windows-specific ICU code uses this pattern, which triggers a clang warning. BUG=505302 R=thakis@chromium.org Review URL: https://codereview.chromium.org/1209413007.
-
- Jun 23, 2015
-
-
Dirk Pranke authored
R=brettw@chromium.org, dpranke@chromium.org Review URL: https://codereview.chromium.org/1183493003.
-
- Jun 09, 2015
-
-
Dirk Pranke authored
This allows targets that use GN to correctly note that they need the .dat file to be included in .isolates. R=brettw@chromium.org, jshin@chromium.org BUG= Review URL: https://codereview.chromium.org/1167613003.
-
Nico Weber authored
I hang my head in shame. BUG=498033 TBR=hans@chromium.org Review URL: https://codereview.chromium.org/1177533002.
-
Nico Weber authored
This ports https://codereview.chromium.org/515263002/ and https://codereview.chromium.org/508343002/ I don't see these warnings locally, but they do show up on the bots for some reason. Probably good to have gyp and gn match anyways. BUG=498033 R=hans@chromium.org Review URL: https://codereview.chromium.org/1171153002
-
- Jun 01, 2015
-
-
Jungshik Shin authored
1. -Wno-return-type-c-linkage - became unnecessary with ICU bug 9504 fixed 3 years ago. - remove from both BUILD.gn and icu.gyp 2. -Wnoheader-hygine - became unnecessary a long time ago. - remove from BUILD.gn (icu.gyp does not have it) 3. -Wstring-conversion and -Wheader-hygine - add to BUILD.gn by NOT excluding clang:extra_warnings BUG=114660 TEST=Build icuuc/icui18n targets (both gyp and GN) after regenerating build files. R=brettw@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/1158933005
-
- May 11, 2015
-
-
Brett Wilson authored
The GYP and GN build's defines have diverged. THis brings GN's defines in line with GYP's current set. R=jshin@chromium.org Review URL: https://codereview.chromium.org/1130383003
-
- Mar 21, 2015
-
-
Jungshik Shin (jungshik at google) authored
1. Cherry-pick security patches from the upstream. a. BiDi: integer overflow http://bugs.icu-project.org/trac/ticket/11451 http://crbug.com/451799 bidi.patch was updated to include patches for this issue. b. data race in cmemory; remove an unnecessary check with a global variable. http://bugs.icu-project.org/trac/ticket/11538 http://crbug.com/223352 cmemory.patch was added c. Locale::getBaseName() thread-safety http://bugs.icu-project.org/trac/ticket/11547 http://crbug.com/467836 locid.patch was updated to include patches for this issue. 2. Add UCONFIG_NO_NON_HTML5_CONVERSION=1 to BUILD.gn 3. Clean up a. Update README.chromium to flag patches that are already in the upstream. b. Split pkg_gen.patch from data.build.patch. pkg_gen.patch was already in the upstream while the rest of data.build.patch is Chromium-specific. c. Delete an unused converters.patch. BUG=223352,451799,467836 TEST=See bugs 223352, 467836, 468716, and 466838 R=jyasskin@chromium.org, mark@chromium.org Review URL: https://codereview.chromium.org/1020303002
-
- Mar 19, 2015
-
-
Jungshik Shin (jungshik at google) authored
I forgot to include this change in https://codereview.chromium.org/984233002 TBR=jochen@chromium.org BUG=NONE Review URL: https://codereview.chromium.org/1021673003
-
Jochen Eisinger authored
BUG=none R=dpranke@chromium.org Review URL: https://codereview.chromium.org/1014393002
-