- May 18, 2017
-
-
Scott Graham authored
Without a Linux-ish define for Fuchsia, neither U_WCHAR_IS_UTF16 nor U_WCHAR_IS_UTF32 are defined, resulting in warnings in ICU code when compiled on Fuchsia. Filed upstream at http://www.icu-project.org/trac/ticket/13202. BUG=706592 R=jshin@chromium.org Review-Url: https://codereview.chromium.org/2885143008 .
-
- May 16, 2017
-
-
Jungshik Shin authored
http://www.icu-project.org/trac/ticket/12333 http://www.icu-project.org/trac/ticket/13189 http://www.icu-project.org/trac/ticket/12635 - patches/ucase_utf8.patch - patches/ucurr_locale.patch - patches/collator_range.patch Bug=chromium:722124 TEST=See the test TBR=inferno@chromium.org Change-Id: I3e754734a1c1121c8059a386ca1b5d0f004adb79 Reviewed-on: https://chromium-review.googlesource.com/506592 Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- May 14, 2017
-
-
Jungshik Shin authored
* Highlights: - Emoji 5.0 data (partial; Emoji_Component property not included) - CLDR 31.0.1 (http://blog.unicode.org/2017/03/cldr-version-31-released.html) UTC and GMT are treated as distinct) - New case mapping API for styled text - C++ 11 is required - char16_t for UChar (UTF-16) - Source code is in UTF-8 * Size changes common: 10,130,560 => 10,175,056 android: 6,573,872 => 6,616,864 iOS: 6,562,352 => 6,605,152 On top of ICU 59.1 from the upstream, the following changes were applied. See https://chromium.googlesource.com/chromium/deps/icu/+log/chromium/59staging - Fix C++ 11 string literal assignment issue (upstream bug: 13192) - Fix C4229 warning by MSVC - Apply utf32.patch and include unistr.h in fuzzer_util - Update ICU data files - Fix wpo.patch - Apply Google locale patch and locale1.patch - update readme - Apply breakiterator related patches - Apply and update wpo.patch - Drop unused patch, apply data.build.win.patch, update README.chromium - Add /utf-8 flag for Windows/Visual Studio - Update BUILD.gn for UChar, stubdata and apply data_sym.patch - use stubdata.cpp instead of stubdata.c in icu.gyp - Update icu.gyp* files for v8 - Update BUILD.gn, apply data.build.patch and vscomp.patch - Add new files in ICU 59.1 - Get a fresh copy of ICU 59.1 from the upstream - Update update.sh script TBR=drott@chromium.org, yangguo@chromium.org Bug:699469 TEST: layout tests, all unittests, browser tests Change-Id: Ie1e77323aa0c7f872153680c4deca6471a771a5c Reviewed-on: https://chromium-review.googlesource.com/505173 Reviewed-by:
Jungshik Shin <jshin@chromium.org>
-
- May 05, 2017
-
-
Jungshik Shin authored
Add ios/icudtl.dat and ios/patch_locale.sh. Update README.chromium and BUILD.gn accordingly. Update scripts/copy_data.sh to take (ios|common|android). At the moment, iOS data is almost identical to that of Android, but in the future more cuts may be made (e.g. dictionary data for breakiterator). Bug: 718955 TEST: iOS Chrome works as before. Review-Url: https://codereview.chromium.org/2743123002 .
-
- Feb 21, 2017
-
-
Jungshik Shin authored
Size increase for affected data files is as follows: android/icudtl.dat 6573776 -> 6610128 bytes common/icudtb.dat 10130464 -> 10166816 bytes common/icudtl.dat 10130464 -> 10166816 bytes This CL supercedes CL 2328013002. CL by riesa@chromium.org. BUG=684609 R=jshin@chromium.org Review-Url: https://codereview.chromium.org/2652023002 .
-
- Dec 07, 2016
-
-
Jungshik Shin authored
Europe/Saratov is a new timezone spun off from Europe/Volgograd. It switched from +03 to +04 on 2016-12-04 at 02:00. For more details, see http://mm.icann.org/pipermail/tz-announce/2016-November/000044.html BUG=473288 TEST=Try the following in d8 or Chrome's JS console: > (new Date("12/04/2016 12:00Z")).toLocaleString("en", {timeZone: "Europe/Saratov"}) "12/4/2016, 4:00:00 PM" > (new Date("12/03/2016 12:00Z")).toLocaleString("en", {timeZone: "Europe/Saratov"}) "12/3/2016, 3:00:00 PM" TBR=mark Review URL: https://codereview.chromium.org/2558183003 .
-
- Nov 17, 2016
-
-
Jungshik Shin authored
BUG=473288 TEST=None Review URL: https://codereview.chromium.org/2511863003 .
-
- Nov 11, 2016
-
-
Jungshik Shin authored
They don't affect Chrome/Blink at the moment, but had better be fixed now. http://www.icu-project.org/trac/ticket/12815 http://www.icu-project.org/trac/ticket/12832 BUG=None Review URL: https://codereview.chromium.org/2499493002 .
-
- Oct 28, 2016
-
-
Jungshik Shin authored
Follw-up to https://chromium.googlesource.com/chromium/deps/icu/+/5feb9ad5 (due to a rietveld issue, part 1 was manually pushed). Update ICU to 58.1 release from ICU 56.1 part2. Listed below a tiny subset of what's new in 58.1: 1. Unicode 9.0 from Unicode 8.0 - Updated character properties including Emoji data up to 4.0beta. - Updated grapheme/word/line breaking rules for Emoji sequences and others. 2. CLDR 30.0.2 from CLDR 28 - Numerous locale data updates/improvements 3. Spoofing API changes 4. Greek uppercasing support as a part of regular case-mapping API. 5. Line breaking rule file format optimization. This change enables me to add CJ loose line breaking rules back (previously, it's dropped to save space) so that Blink can use it for CJ. See http://site.icu-project.org/download/58 for more details on ICU 58.1 and http://site.icu-project.org/download/57 for more details on ICU 57.1 For CLDR 30, see http://cldr.unicode.org/index/downloads/cldr-30 . The size impact: Non-Android: 10,127,200 => 10,128,624 (delta = 1,424 / 0.014%) Android: 6,563,152 => 6,571,936 (delta = 8,784 / 0.13%) Below are the list of changes made on top of the upstream ICU 58.1 in reverse order. Most of these changes were made in 58staging branch to run trybots and cherry-picked back for this CL. See https://chromium.googlesource.com/chromium/deps/icu/+/log/chromium/58staging https://codereview.chromium.org/2447513002/ : cr+blink update cl with 58staging branch head. * Fix a build on Win without std::string (v8) * Add ms932 alias to Shift_JIS * Apply Google-specific locale data patches * Fix a bug in scriptset * Update windows-1255 mapping * Disable C4333 warning by MSVC (harmless) * Apply and update utf32.patch and README.chromium * Update and apply vscomp.patch stringpiece patch removed. VS2015 seems to be fine with a redefinition. * Update pre-built ICU data files Update *local.mk with a new copyright line * Apply more patches The following patches were applied and updated: data_symb, vscomp, wpo The unnecessary part was dropped from vscomp * Update BUILD.gn and icu.gyp* files * Update android/brkitr.patch * Update and apply more patches * Update and apply cjdict.patch Apply data.build.patch * Delete obsolete patches: cmemory,regex * Update README.chromium and apply brkitr patches - Update README.chromium - Remove obsolete patches - Update linebrk.patch and apply it: add back line_loose_cj * Update wordbrk.patch and apply it * Update and apply khmer-dictbe.patch * Update data trimming - android/patch_locale.sh - scripts/trim_data.sh ExemplarCh* removed charac*Label removed relative/relativeTime removed for daysOfWeek and quarter * Update the following patches android/brkitr.patch patches/linebrk.patch patches/data.build.patch * Update cjdict.patch and linebrk.patch BUG=637001 TEST=Layout tests, all unittests, browser tests, ui tests. R=jsbell@chromium.org, mark@chromium.org Review URL: https://codereview.chromium.org/2442923002 .
-
- Oct 23, 2016
-
-
Jungshik Shin authored
* Note that this CL will be followed by CLs with local changes. Until then, ICU should not be rolled in DEPS. See READ_THIS_FIRST for details. * Adjust scripts/update.sh and scripts/data_files_to_preserve.txt - CLDR/ICU added ckb/ast locale data. Drop them from the list to preserve. - source/layout does not exist in 58.1 any more. * Update the tree to ICU 58.1 from the upstream by running scripts/update.sh * Update README.chromium and add READ_THIS_FIRST to warn about the status of the tree. BUG=637001 TEST=None
-
- Oct 21, 2016
-
-
Jungshik Shin authored
There's no need for VS build files. Besides, update scripts/update.sh to post-edit source/configure for missing test/ directory. This clean up is necessary to get 'git cl upload/rietveld' work smoothly in an upcoming ICU update. BUG=637001 TEST=source/runConfigureICU Linux --disable-tests --disable-layout Review URL: https://codereview.chromium.org/2443653002 .
-
- Jul 27, 2016
-
-
Jungshik Shin authored
The only change affecting the current and future time stamp is that Asia/Novosibirsk swiches from +06 to +07. The Egyptian change in 2016f cancelled out the Egyptian change in 2016e. http://mm.icann.org/pipermail/tz-announce/2016-July/000040.html All the pre-built data files are updated except for icudt.dll for Windows (non-default build configuration. The default build configuration on Windows is covered by this CL). BUG=473288 TEST=Try the following in d8 or Chrome's JS console: > (new Date("07/23/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Novosibirsk"}) 7/23/2016, 6:00:00 PM > (new Date("07/24/2016 12:00Z")).toLocaleString("en", {timeZone: "Asia/Novosibirsk"}) 7/24/2016, 7:00:00 PM Review URL: https://codereview.chromium.org/2183313002 .
-
Jungshik Shin authored
Delete three pre-built assembly source files because they're now generated at build-time. Update data build scripts and README.chromium accordingly. Update copy_data.sh and copy_data_android.sh so that the assembly source files are not copied. Besides, convert the little endian data bundle to the big endian data bundle for non-Android platforms. BUG=v8:4828 TEST=Rebuild icu data following the procedure in README.chromium TEST='gn args <builddir>' with icu_use_data_file set to true or false TEST=build base_unittests and run with --gtest_filter=ICU* TEST=build base_unittests and run with --gtest_filter=Message*ormat* TEST=build 'd8' (v8) and try `(new Date()).toLocaleString("de")` Review URL: https://codereview.chromium.org/2182883004 .
-
- May 20, 2016
-
-
Jungshik Shin authored
What's new in 2016d is found at http://mm.icann.org/pipermail/tz-announce/2016-April/000038.html Rebuilt ICU data/assembly files are checked in (not shown in the codereview due to their sizes). While I'm at it, add scripts/LICENSE file that is identical to LICENSE at the top of the Chromium tree. Because LICENSE in third_party/icu is for ICU and is not applicable to files in scripts/. BUG=473288 TBR=mark TEST=In JavaScript console, run the following. apr30_2016_1200 = new Date("04/30/2016 12:00Z") may01_2016_1200 = new Date("05/01/2016 12:00Z") apr30_2016_1200.toLocaleString("en", {timeZone: "America/Caracas"}) may01_2016_1200.toLocaleString("en", {timeZone: "America/Caracas"}) On April 30, 2016, Caracas is 4:30 behind UTC. On May 1, it's 4:00 behind. Review URL: https://codereview.chromium.org/1985243002 .
-
- Apr 05, 2016
-
-
Jungshik Shin authored
Cherry pick http://bugs.icu-project.org/trac/changeset/38183 to add the support for Emoji properties. This will be followed by a Blink change to use the API. ( https://codereview.chromium.org/1856353002 ) There's no need to rebuild ICU data because Unicode character properties are hard-coded in the C++ source files that are patched by the cherry-pick above. source/data/in/{pnames,uprops}.icu are updated just for the record, but they're not actually used. The same is true of files in source/data/unidata. BUG=583378 TEST=None TBR=drott Review URL: https://codereview.chromium.org/1864463002 .
-
- Mar 25, 2016
-
-
Jungshik Shin authored
1. Update the IANA tz data to 2016c What's new in 2016b and 2016c are found at http://mm.icann.org/pipermail/tz-announce/2016-March/000036.html (2016b) http://mm.icann.org/pipermail/tz-announce/2016-March/000037.html (2016c) 2. Locale data fixes - en-AU date format fix from the upstream - ar and fa: Prepend 'percent sign' with RTL mark (U+200F). From Android. - tr: Use ₺ (U+20BA; Turkish Lira Sign) instead of 'TL'. This is to revert a locale patch picked up from Google's internal build of ICU. (Android also uses U+20BA). In addition, icudtl.dat (the prebuilt ICU data file for platforms other than Android is moved out of source/data/in to common/. This way, the data build steps for non-Android and Android can be unified and a bit more streamlined. icu.gyp and BUILD.gn are updated accordingly as well as README.chromium. BUG=598000 TEST=See bug comment 0 and comment 1 R=mark@chromium.org Review URL: https://codereview.chromium.org/1823293002 .
-
- Mar 20, 2016
-
-
Jungshik Shin authored
region.cpp has an unnecessary static initializer for a type UnicodeString and triggers a 'si check' failure. Upstream bug: http://bugs.icu-project.org/trac/ticket/12408 BUG=575007 TEST=`tools/linux/dump-static-initializers.py chrome` (static build) does not have an entry from region.cpp TEST=`tools/linux/dump-static-initializers.py libicui18n.so` (shared build) has no entry. TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/1816843002 .
-
- Feb 08, 2016
-
-
Jungshik Shin authored
Update the copyright years in LICENSE (taken from license.html) and IANA timezone DB version in README.chromium. Incorporate the format fixes made by Mostyn Bramley-Moore <mostynb@opera.com> in https://codereview.chromium.org/1530343003/ BUG=575007 TEST=None TBR=mostynb@opera.com Review URL: https://codereview.chromium.org/1678243002 .
-
- Feb 04, 2016
-
-
Jungshik Shin authored
1. ast,an,wa locale data (minimal) - make up the minimal locale data for 3 languages. - update source/data/{locale,lang}/reslocal.mk to have 3 languages - update scripts/data_file_to_preserve.txt to have files for 3 locales listed. - In chromium, these languages have to be added to the A-L list to show up in the A-L pull-down in settings. 2. IANA timezone db updte to 2016a See http://mm.icann.org/pipermail/tz-announce/2016-January/000035.html for the change. 3. Pre-built-data files are updated. Data (icudtl.dat) size changes between 54.1 and 56.1 non-Android platforms: 10,124,096 bytes (net change: -83,840) Android: 6,560,080 bytes (net change: +291,840 / 4.66%) BUG=575007,474333 R=jsbell@chromium.org Review URL: https://codereview.chromium.org/1665113004 .
-
Jungshik Shin authored
See http://crbug.com/417850 for UTF-32 See http://bugs.icu-project.org/trac/ticket/12147 for C4275 warning from MSVC. BUG=575007 TEST=Layout tests fast/encoding/* TEST=MSVC does not emit C4275 warning any more R=jsbell@chromium.org Review URL: https://codereview.chromium.org/1664293002 .
-
- Feb 02, 2016
-
-
Jungshik Shin authored
Set fLastSetLiteral to U_SENTINEL in the ctor and check if it's still U_SENTINEL before adding the range. BUG=582470 TEST=See comments 13 and 15 in the bug TBR=mmoroz Review URL: https://codereview.chromium.org/1656003004 .
-
Jungshik Shin authored
This is to cherry-pick a fix for http://bugs.icu-project.org/trac/ticket/12130 It's done by merging commit '2b12f877' (for m49 branch) to master. (ICU's m49 branch was fixed first because ICU master was in the middle of upgrading to ICU 56.1). BUG=575206 TEST=See comment 51 in the bug TBR=mmoroz@chromium.org Review URL: https://codereview.chromium.org/1662453002 .
-
Jungshik Shin authored
MSVC complains about '*/* foobar */'. Add a space between '*' and '/'. ICU uses a deprecated API internally and '-Wno-deprecated...' flag has to be turned on on Android as well as on Linux. Do not use ''-Wno-reorder' any more because it's not necessary. BUG=575007 TEST=Once rolled, Android and Windows build go through. R=thakis@chromium.org Review URL: https://codereview.chromium.org/1646623006 .
-
- Jan 29, 2016
-
-
Jungshik Shin authored
* Update the pre-built ICU data files for all platforms source/data/in/icudtl.dat for non-Android platforms {linux,mac}/icudt*.S for linux/mac android/icudtl.dat and android/icudt*.S for Android windows/icudt.dll for Windows * Update Android data trimming script 1. Make sure that 'default' calendar is kept in locales where it's relevant : root, th, fa, ar_SA, etc. 2. Add a minimal region data to work around a bug in ICU with pool.res handling * Update gn and gyp files * And add a TODO comment to update.sh to automate the build file update. * Add it_CH to the locale list. * Add sr_Latn to unit/reslocal.mk (required by sh) and line_normal_fi to brkitr/brklocal.mk (referred to in brkitr/fi.txt) in place of line_fi. * Update and add scripts for data building * Completely rewrite README.chromium * Check-in the prebuilt ICU data files/assembly sources for Linux,Mac,Windows,Chrome OS and Android. BUG=575007 TEST=Blink layout tests, webkit unittests TEST=All bots can build successfully TEST=net_unittests --gtest_filter="*ilenameUtil*" TEST=net_unittests --gtest_filter="*IDN*" (pending bug 336973) TEST=base_unittests --gtest_filter="*Conv*" TEST=browser_tests --gtest_filter="*ncoding*" TEST=base_unittests --gtest_filter="*essage*" TEST=ui_base_unittests --gtest_filter="*ormat*" TEST=ui_base_unittests --gtest_filter="L10n*" R=mark@chromium.org Review URL: https://codereview.chromium.org/1639543006 .
-
Jungshik Shin authored
Below is the list of changes in reverse order. 1. Drop uconv.patch (upstream took my patch) 2. Apply data.build.win and data_sym patches 3. Apply vscomp.patch and update the patch file. update README.chromium about two parts of the patch that are not necessary any more. 4. Apply wpo patch and update the patch file 5. Android brkitr adjustment * Do not apply the patch but just updates the patch * Do not use CJdict on Android to save 2MB in the data size. 6. Clean up brkitr patches * Rename brkitr.patch to wordbkr.patch and keep only word.txt diff * Make a new linebrk.patch with line breaking adjustment (dropping loose rules to save space until the upstream implements space-efficient mechanism for line breaking rule variations) * Update README.chromium * Apply local patches for Khmer dictionary handling and cjdict 7. Adjust line breaking rules. This corresponds to set 2 in https://code.google.com/p/chromium/issues/detail?id=575007#c6 BUG=575007 TEST=None R=mark@chromium.org Review URL: https://codereview.chromium.org/1637683002 .
-
Jungshik Shin authored
1. Apply post-56 patches from the trunk for measure/date format http://bugs.icu-project.org/trac/ticket/11986 http://bugs.icu-project.org/trac/ticket/12031 http://bugs.icu-project.org/trac/ticket/12030 http://bugs.icu-project.org/trac/ticket/12041 2. Generate a combined patch (measure_format.patch) for the above. 3. Split locale_google.patch into 'locale_google.patch' and 'relative_date.patch'. The latter is taken from Android. 4. Update README.chromium Besides, apply two local patches : {tzdetect,xlit..}.patch and adjust gb18030.ucm and the corresponding patch Also, remove obsolte patches and update README.chromium BUG=575007 R=mark@chromium.org Review URL: https://codereview.chromium.org/1621943002 .
-
- Jan 07, 2016
-
-
Jungshik Shin authored
Add scripts/udpate.sh that automates the initial check-out of a new version of ICU. BUG=575007 TEST=None R=mark@chromium.org Review URL: https://codereview.chromium.org/1566043002 .
-
- Dec 14, 2015
-
-
Jungshik Shin authored
* Big5 : https://www.w3.org/Bugs/Public/show_bug.cgi?id=27878 Special case the following four more code points in addition to U+5341, U+5345 that are already special cased. U+2550, U+255E, U+2561, U+256A For those 6 code points, the last pointer instead of the first pointer in index-big5.txt is used for round-trip. The first pointer is for decoding-only. * KOI8-U ( https://www.w3.org/Bugs/Public/show_bug.cgi?id=17053 ) - 0xAE and 0xBE are mapped to U+04[50]E instead of U+255[DC]. - Add an alias KOI8-RU BUG=544228 TEST=1. http://goo.gl/reGQPU : encoding(form) test 2. Layout test: fast/encoding/* R=jsbell@chromium.org Review URL: https://codereview.chromium.org/1514253003 .
-
- Sep 25, 2015
-
-
Jungshik Shin authored
In line 1105 of rbt_pars.cpp, variablesVector.elementAt(j) is cast to |UnicodeSet *|, but sometimes it's |Quantifier *|. Casting to a common parent class |UnicodeFunctor *| seems to work (this patch), but it may hide a deeper issue. Further investigation will be done in the upstream bug: http://bugs.icu-project.org/trac/ticket/11937 This CL was independently made by krasin@ and jshin@. ( https://codereview.chromium.org/1366563006/ ) BUG=528799 TEST=wtf_unittests --gtest_filter="*ToUpp*" and --gtest_filter="*ToLow*" with both regular and cfi build. TBR=krasin@chromium.org Review URL: https://codereview.chromium.org/1369653003 .
-
- Aug 25, 2015
-
-
Nico Weber authored
The warning complains that StringThreadTest is declared in the global namespace, but the friend line says `friend class StringThreadTest;` instead of `friend class ::StringThreadTest`. MSVC doesn't require this ::, but gcc does -- without it, the friend line declares a new class in the namespace containing UnicodeString. Since StringThreadTest was in test/threadtest which isn't built as part of Chromium's build and which was removed in upstream ICU in ICU 37392, just delete the friend line, it has no effect. BUG=505296 R=jshin@chromium.org Review URL: https://codereview.chromium.org/1317603003 .
-
- Aug 18, 2015
-
-
Nico Weber authored
1. In Win32NumberFormat, rename the private format() method to variadicFormat(). It's just an implementation detail of the class. Fixes: ..\..\third_party\icu\source\i18n/winnmfmt.h(146,20) : error(clang): 'icu_54::Win32NumberFormat::format' hides overloaded virtual functions [-Werror,-Woverloaded-virtual] UnicodeString &format(int32_t numDigits, UnicodeString &appendTo, const wchar_t *format, ...) const; ^ ..\..\third_party\icu\source\i18n\unicode/numfmt.h(255,28) : note(clang): hidden overloaded virtual function 'icu_54::NumberFormat::format' declared here: different number of parameters (4 vs 3) virtual UnicodeString& format(const Formattable& obj, ^ ... 2. In Win32DateFormat, remove the two-argument format() function that just forwards to the base class. (If this happens to produce compile errors, the function should be replaced by `using Win32DateFormat::format(UDate, UnicodeString&) const;`) Fixes: ..\..\third_party\icu\source\i18n/windtfmt.h(55,20) : error(clang): 'icu_54::Win32DateFormat::format' hides overloaded virtual functions [-Werror,-Woverloaded-virtual] UnicodeString& format(UDate date, UnicodeString& appendTo) const; ^ ..\..\third_party\icu\source\i18n\unicode/datefmt.h(240,28) : note(clang): hidden overloaded virtual function 'icu_54::DateFormat::format' declared here: different number of parameters (4 vs 2) virtual UnicodeString& format(const Formattable& obj, ^ ... BUG=505301 R=jshin@chromium.org Review URL: https://codereview.chromium.org/1296803002 .
-
- Jul 16, 2015
-
-
Jungshik Shin authored
Upstream CL : http://bugs.icu-project.org/trac/changeset/37670 BUG=508444 TEST=See bug R=inferno@chromium.org Review URL: https://codereview.chromium.org/1233663005 .
-
- Jul 14, 2015
-
-
Jungshik Shin authored
Takes an upstream patch (to be included in 56.x release) and patch our ICU 54. Clang-specific atomic ops will be used when clang is used to compile but C+11 atomic is disabled/unavailable. patch: http://bugs.icu-project.org/trac/changeset/37326 bug: http://bugs.icu-project.org/trac/ticket/11599 BUG=466959,508049,508440 TEST=See bugs R=glider@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/1148463002 .
-
- Jun 18, 2015
-
-
http://bugs.icu-project.org/trac/changeset/36672Nico Weber authored
Else clang's -Winfinite-recursion will warn about filteredbrk.cpp BUG=none R=scottmg@chromium.org Review URL: https://codereview.chromium.org/1191653011.
-
- Jun 09, 2015
-
-
Jungshik Shin authored
Previously, |referenceCounter != (uint32_t)~0| was used to check whether refcounting is used or not. Cherry-pick an upstream change: http://bugs.icu-project.org/trac/changeset/37476 BUG=465175 TEST=see the bug R=jyasskin@chromium.org Review URL: https://codereview.chromium.org/1171203002.
-
- Jun 04, 2015
-
-
Jungshik Shin authored
1. Add a one-way (encoding-only/fromUnicode) mapping for U+2212 to Shift_JIS, EUC-JP and ISO-2022-JP. The last just uses Shift_JIS. See https://www.w3.org/Bugs/Public/show_bug.cgi?id=28661 2. Make GBK aliases list compliant to the encoding spec. 3. Add "xA3xA0 => U+3000" to the GBK (windows-936) and gb18030. This makes it possible to remove the corresponding override in Blink 4. Modify the following to GBK (windows-936). See [1] - Add U+01F9 <=> \xA8\xBF - Drop U+E7C8 <=> \xA8\xBF 5. The following change is put on hold (NOT included in the CL) until the resolution of [1] - Add U+1E3F <=> \xA8\xBC - Drop U+E7C7 <=> \xA8\xBC The corresponding Blink CL is https://codereview.chromium.org/1167523003/ [1] https://www.w3.org/Bugs/Public/show_bug.cgi?id=28740#c3 BUG=425417,493824 TEST=Once ICU is rolled to this CL, Blink layout test fast/encoding/*. R=jsbell@chromium.org Review URL: https://codereview.chromium.org/1162723008
-
- May 26, 2015
-
-
Jungshik Shin authored
A fix by mbarbella@. BUG=444573 TEST=See the bug R=inferno@chromium.org, mbarbella@chromium.org Review URL: https://codereview.chromium.org/1145963004
-
- Apr 06, 2015
-
-
Jungshik Shin (jungshik at google) authored
Due to caching, the 2nd timezone change is not detected properly. Upstream bug: http://bugs.icu-project.org/trac/ticket/11623 BUG=406382 TEST=manual. Call detectHostTimeZone() every time the OS tz is changed on Linux and check if it returns the correct present timezone. R=mark@chromium.org Review URL: https://codereview.chromium.org/1058353002
-
- Apr 03, 2015
-
-
Jungshik Shin (jungshik at google) authored
We need this new API to resolve bug 406382 across platforms. See http://bugs.icu-project.org/trac/ticket/11358 http://bugs.icu-project.org/trac/changeset/37148 BUG=406382 TEST=None R=mark@chromium.org TBR=mark@chromium.org Review URL: https://codereview.chromium.org/1062503003
-
- Apr 02, 2015
-
-
Jungshik Shin (jungshik at google) authored
1. Update the IANA tz db to 2015b. - http://mm.icann.org/pipermail/tz-announce/2015-March/000029.html - Mongolia decided to observe DST again in 2015 starting on the last Sunday in March. - Palestine's DST start date is corrected to be March 28 instead of 27th. 2. Add a script to download the tz database files (update_tz.sh) 3. Check in scripts/make_n_copy_data.sh that I've been using to build ICU data/assembly files and update README.chromium. 4. Update android/patch_locale.sh to apply android/brkitr.patch as well. BUG=473288 TEST=1. In JavaScript console, run the following. mar27_2015_1200 = new Date("03/27/2015 12:00Z") mar28_2015_1200 = new Date("03/28/2015 12:00Z") mar27_2015_1200.toLocaleString("en", {timeZone: "Asia/Gaza"} mar28_2015_1200.toLocaleString("en", {timeZone: "Asia/Gaza"} apr15_2014_1200 = new Date("04/15/2014 12:00Z") apr15_2015_1200 = new Date("04/15/2015 12:00Z") apr15_2014_1200.toLocaleString("en", {timeZone: "Asia/Ulan_Bator"} apr15_2015_1200.toLocaleString("en", {timeZone: "Asia/Ulan_Bator"} In Asia/Gaza, Mar 27 12:00Z should be 2PM and mar28 12:00Z should be 3PM. In Asia/Ulan_Bator, April 15 12:00Z should be 8PM in 2014 and should be 9PM in 2015. Ulan_Bator does not work due to http://crbug.com/364374. R=mark@chromium.org Review URL: https://codereview.chromium.org/1051193002
-