[feedback] switch GetData() to fit::promise
* this allows us to integrate with asynchronous attachment providers (LogListener and Inspect) without having to run a second loop, which seems flaky * we use a fit::bridge to control when and how to complete: success in Done() and failure in FIDL errors or timeout DX-465 #comment FLK-173 #comment TESTED=`fx run-test feedback_agent_tests` TESTED=`fx run-test crashpad_agent_tests` TESTED=`fx crasher` Change-Id: I762a93d6ff8b9164c5cb1eb332aed7061607d7f0
Showing
- src/developer/feedback_agent/BUILD.gn 3 additions, 0 deletionssrc/developer/feedback_agent/BUILD.gn
- src/developer/feedback_agent/attachments.cc 34 additions, 31 deletionssrc/developer/feedback_agent/attachments.cc
- src/developer/feedback_agent/attachments.h 2 additions, 1 deletionsrc/developer/feedback_agent/attachments.h
- src/developer/feedback_agent/feedback_agent.cc 33 additions, 8 deletionssrc/developer/feedback_agent/feedback_agent.cc
- src/developer/feedback_agent/feedback_agent.h 5 additions, 1 deletionsrc/developer/feedback_agent/feedback_agent.h
- src/developer/feedback_agent/log_listener.cc 61 additions, 50 deletionssrc/developer/feedback_agent/log_listener.cc
- src/developer/feedback_agent/log_listener.h 12 additions, 8 deletionssrc/developer/feedback_agent/log_listener.h
- src/developer/feedback_agent/main.cc 2 additions, 1 deletionsrc/developer/feedback_agent/main.cc
- src/developer/feedback_agent/tests/feedback_agent_unittest.cc 20 additions, 59 deletions...developer/feedback_agent/tests/feedback_agent_unittest.cc
Loading
Please register or sign in to comment