Skip to content
Snippets Groups Projects
  1. Apr 26, 2019
  2. Apr 25, 2019
    • Haowei Wu's avatar
      [docs] Correct references to docs. · b6670b73
      Haowei Wu authored
      This patch makes a few corrections of references to the original
      garnet/docs/gen/build_arguments.md. The new location is
      docs/gen/build_arguments.md . This change also add reference
      to docs/development/tracing/README.md .
      
      Bugs: BLD-454
      Test: CQ
      Change-Id: If0cb49f57445484fc9e8270aeaa86b3aeadc9f8d
      b6670b73
    • Adam MacBeth's avatar
      [media][audio] MixerPtr -> std::unique_ptr<Mixer> · d3aa898a
      Adam MacBeth authored
      Cleanup while reading the code.
      
      TEST: No behavior change. fx run-test audio_mixer_tests
      Change-Id: Ic63d36dafe4e8bd122d34a05a8af09ebee943abb
      d3aa898a
    • Dylan Swiggett's avatar
      [wlan][eapol] Enables tests for wlan/lib/eapol. · e5ee8d30
      Dylan Swiggett authored
      These tests have been accidentally disabled for some time. Reenabling in advance
      of more changes within eapol.
      
      Test: Existing tests run and pass
      Change-Id: I816e85db9e7abc58251d93863b4556f49b3d82e7
      e5ee8d30
    • Dustin Green's avatar
      [sysmem] Add min_buffer_count to BufferCollectionConstrants · a9b9cc4f
      Dustin Green authored
      While we don't want participants to be too picky about buffer_count, we
      should be able to support cases where a participant must constrain both
      the min and max buffer count.  This adds min_buffer_count.
      
      This also moves some constraint checks to make sure we don't have any
      constraint checks in the Accumulate* methods, which potentially don't
      run if there's only one participant or only one participant specifying
      buffer constraints or image constraints.
      
      Tested: CQ, test_sysmem_min_buffer_count added
      Change-Id: I1920dc26f92f463c692415e0e1f424fc4e0a16db
      a9b9cc4f
    • Roland McGrath's avatar
      [bundles] Move buildbot to //bundles/buildbot:core · 057da3cc
      Roland McGrath authored
      Also add the new //bundles/buildbot:bringup group.  The new model is
      that for each product whose build is tested by bots, there should be
      a //bundles/buildbot:$product group.  The bot configs will use that,
      so `fx set PRODUCT.BOARD --with-base //bundles/buildbot:PRODUCT` will
      approximate in a local build what the bots will do.
      
      Bug: INTK-1015 #comment Define //bundles/buildbot:{bringup,core} groups
      Change-Id: Iacc19043d34e948bde2215cb5441e91d97c67417
      057da3cc
    • Christopher R. Johnson's avatar
      [libiquery] Disable test due to flake · d9a4f733
      Christopher R. Johnson authored
      Change-Id: I09ad0fb80c7af8eaa94cec3d2f4fce1cd008d03b
      d9a4f733
    • Zach Anderson's avatar
      [zircon] Revert "[zircon] Reformat zxcrypt and minfs partitions when the partition is" · ef6dd7d3
      Zach Anderson authored
      This reverts commit 2dcfdba2.
      
      Reason for revert: Failed boot on vim2
      
      Original change's description:
      > [zircon] Reformat zxcrypt and minfs partitions when the partition is
      > missing. Added a unit test that failed without the changes.
      >
      > Change-Id: Idaf9913bf9006384e021f39047df1e8e8a855369
      
      TBR=smklein@google.com,aarongreen@google.com,abarth@google.com,zarvox@google.com,jseibert@google.com
      
      Change-Id: I0e755d84dc4839e8968308ca753aa1d9c9c5038b
      ef6dd7d3
    • Shac Ron's avatar
      [io-scheduler] Sort ops into streams · 212d3114
      Shac Ron authored
      Insert ops into streams, fetch and issue. Convert SchedulerOp from
      struct to class.
      Scheduler can balance the ordering by streams (currently dummy
      round-robin).
      
      Change-Id: I4b8f3e64eff1360f2334afa67036cbc09db105fc
      212d3114
    • Doug Evans's avatar
      [tracing docs] Move quick-start,trace-format docs to own subdirs · 585bb833
      Doug Evans authored
      ... and add link to tracing-boot.md.
      
      Change-Id: I0818ba4b0de23940b88b9b14b61f77d435077f39
      585bb833
    • Doug Evans's avatar
      [tracing docs] Pass --categories=all in example · 45ea1099
      Doug Evans authored
      Blast the reader with all the potential data that is available.
      
      Also, re-indent, improves cut-n-pastability.
      
      Change-Id: I4944aecc1616c41fc60ed7be13f55586b26b11b6
      45ea1099
    • Roland McGrath's avatar
      [build] Rename zircon/system/banjo/* directories/targets to match library names · cb9ac26e
      Roland McGrath authored
      The old - names were only ever used because of limitations of the
      old Zircon build system, which is no longer an issue.  The target
      name in banjo_library() must always match the library name.  For
      public Banjo libraries, the directory name matches that name too.
      
      Change-Id: Ifff61436ec7d15eb53dfd21349c4367047e691d4
      cb9ac26e
    • David Worsham's avatar
      [media] Remove unused method · a2e2baae
      David Worsham authored
      Migration of mediaplayer to ViewToken is complete.
      
      Tested: CQ; no behavior changed
      SCN-1018 #comment
      SCN-1291 #comment
      
      Change-Id: Iae3446ec6c7ea4eb280c985dbec9d73bfe3e5204
      a2e2baae
    • Roland McGrath's avatar
      [zircon][gn] Move scripts used in the build to where they're used · a69ac806
      Roland McGrath authored
      Test: no effect on the build
      Change-Id: I819338ff6309f7487f0ebe72b63f11031a8c631b
      a69ac806
    • Joe Brennan's avatar
      [sl4f] Made SL4F listen on both IPv6 and IPv4 interfaces · eda5d797
      Joe Brennan authored
      SL4F calls can now be made on the IPv4 and IPv6 interfaces
      
      Bug: CONN-56
      Test: Verifed SL4F could be connected on both IPv4 and IPv6
            interfaces.
      Change-Id: Ia6a68abc3c82a1484a4718f2aec3f8a88b399c77
      eda5d797
    • Arman Uguray's avatar
      [bt][gap] Distribute local identity information during pairing · 98acbbf0
      Arman Uguray authored
      LowEnergyConnectionManager now responds to local identity information
      requests during the feature exchange and key distribution phases of SMP
      pairing.
      
      Bug: BT-243 #done
      Test: 1. Run bt-pairing-tool, bt-le-battery-peripheral, and
               bt-le-peripheral -c -n <NAME> on Fuchsia. This will put Fuchsia
      	 into LE peripheral mode with one GATT service that requires
      	 security.
            2. Connect to Fuchsia from iOS using the nRF Connect app. This
               should trigger LE pairing. Respond to the authentication challenge
      	 using bt-pairing-tool (local passkey entry on ToT). The battery
      	 service characteristic should be readable and notifiable
      	 without any errors.
            3. Pipe the output of bt-snoop-cli to Wireshark and confirm that:
               a. Fuchsia configured advertising using a random address.
      	 b. Local IRK and identity address were distributed over SMP.
      	 Check that the IRK matches what has been persisted in the
      	 stash. Check that the identity address matches the address of
      	 the active adapter (confirm via bt-cli).
            4. Reboot Fuchsia, repeat step #1. Connect again using nRF
               Connect. The battery service should be accessible without
      	 additional pairing errors.
            5. Check the snoop logs to confirm that Fuchsia used a different
               RPA when advertising.
      Change-Id: Ibb78b2de3049f9f351215ed4d878acfcca5569df
      98acbbf0
    • P.Y. Laligand's avatar
      [sdk] Restore a few packages in the tools bundle. · 96cc21c1
      P.Y. Laligand authored
      While several images already contain these packages, some images don't
      and the packages need to be available in the universe set.
      
      Bug: DX-1427 #done
      Change-Id: If10223ec017312c797defca113ab21e30cf159b9
      96cc21c1
    • Pascal Perez's avatar
      [fidlc] Use std::optional for optional handle types · a9459e86
      Pascal Perez authored
      Clearer than using unique_ptr, and makes copying easier, which we need
      for templates.
      
      Change-Id: Ie851ab3c461d8b4c3b58c08c7837685e2865f96c
      a9459e86
    • Mike Voydanoff's avatar
      [imx8] Remove NXP imx8 support · 075be3db
      Mike Voydanoff authored
      There has been no active development in about a year.
      We can resurrect this from the git history if we need it in the future.
      In the mean time, lets eliminate code that is not being used or tested.
      
      TEST: builds without imx8 support
      Change-Id: Ie9b04b476e777e3311bfaec3465804a1e81c350e
      075be3db
    • Mike Voydanoff's avatar
      [board][eagle] Remove support for the eagle board · e9fd82cc
      Mike Voydanoff authored
      TEST: builds, bringup build boots normally on cleo.
      Change-Id: I94227a565ce40b8e93db79aa4457862666466bec
      e9fd82cc
    • P.Y. Laligand's avatar
      [boards] Add definitions for QEMU. · 130d7648
      P.Y. Laligand authored
      Bug: BLD-461
      Change-Id: I60372456d27eebdc5ebcb3e1b1d097b190603d1b
      130d7648
    • Dustin Green's avatar
      [codec] remove deprecated OnOutputConfig event · fd0cfc8b
      Dustin Green authored
      Now that Chromium is handling OnOutputConstraints() and
      OnOutputFormat(), we can remove OnOutputConfig().
      
      Tested: use_h264_decoder_test uses the new events on CQ
      Change-Id: I57bf213ba8fa5d225b5bfe961c5f5fc9772ce601
      fd0cfc8b
    • Mike Voydanoff's avatar
      [boards] Add myself (voydanoff) to the OWNERS file · a9197fd2
      Mike Voydanoff authored
      TEST: n/a
      Change-Id: I5e827e029e61dbc36392f1063dedf64808ff4dea
      a9197fd2
    • Pascal Perez's avatar
      [fidlc] Simplifying name modeling · cf164b41
      Pascal Perez authored
      A name is scoped (by a library), and either has a source location, or an
      anonymous name. Modeling this as a std::variant for clarity, and to
      simplify owning semantics. We can now add a copy constructor with ease.
      
      Change-Id: I7e6602e0abdc5c08535452253e324b13b8b9dade
      cf164b41
    • Christopher R. Johnson's avatar
      [libiquery] Implement reading function. · 97c06257
      Christopher R. Johnson authored
      This new function supports reading an inspect::Location into an
      inspect::Source asynchronously.
      
      CF-714: #progress
      
      Change-Id: Ia7bf90b7b9ba174ebedcabf9303ed9a29b085676
      97c06257
    • Dale Sather's avatar
      [mediaplayer] don't panic if the audio render stalls · ee83f76b
      Dale Sather authored
      This CL changes the behavior of the media player when the audio
      renderer holds on to packets too long, which generally happens due to
      scheduling issues. Because the player has allocated a limited amount
      of space for transferring packets between itself and the renderer,
      that space can be exhausted if the renderer doesn't retire packets
      quickly enough.
      
      The fix is to drop packets instead of panicking. There are a few
      paths that had to be fixed to enable this. Sometimes the memory
      allocation failures occur in a callback from the audio decoder.
      Sometimes audio has to be interleaved after the decoder, and the
      allocation failure is detected there. Sometimes (when no decoder
      is needed) audio needs to be copied from system memory into vmo
      memory, and the failure happens prior to the copy.
      
      Two tests have been added to replicate these failure modes. Those
      tests produced panics before the fixes were introduced.
      
      TEST: new CQ tests
      Change-Id: I26582d19481c6716f6a4141e6717b68670ea44f1
      ee83f76b
    • Jody Sankey's avatar
      [identity] Move account internal FIDL to /src/identity. · 0b1cef55
      Jody Sankey authored
      AUTH-196 #comment
      
      Change-Id: I213f7e4440f104ce27535b685a4da100f0526cbd
      0b1cef55
    • David Worsham's avatar
      [scenic] Fix bad formatting from previous CL · 91feb83e
      David Worsham authored
      Tested: CQ; no behavior change
      SCN-580 #comment
      
      Change-Id: I496893099aef041de0c721b4840bd104adc10781
      91feb83e
    • Alex Min's avatar
      [modular] Remove use_account_manager flag and codepaths · 97982728
      Alex Min authored
      Change-Id: I3df4cbd22b97e362c8c80bcb86e618ba0336cfe0
      97982728
    • Jody Sankey's avatar
      [identity] Remove devstorage.read_write OAuth scope · b40ea487
      Jody Sankey authored
      AUTH-202 #comment
      
      Change-Id: I52c5ed31524d5c50cde393f1c1d56f1a0e97bbe5
      b40ea487
    • Satsuki Ueno's avatar
      [identity] Enforce maximum size on token cache · de2d1d50
      Satsuki Ueno authored
      This places an upper bound on the size of the cache.
      Evicts expired tokens on get/put operations, and evicts a random token
      when needed to make room for another token.
      
      Change-Id: I8a9eb2926ab134c3e756b1f6b152c56e5bd1a199
      de2d1d50
    • P.Y. Laligand's avatar
      [scripts] Remove scripts related to JSON build packages. · ca0e1ff3
      P.Y. Laligand authored
      Bug: BLD-457 #done
      Change-Id: I615d2fb526ff8811f2c94219dbfe7fef2443f480
      ca0e1ff3
    • Rich Kadel's avatar
      [zircon] [scripts] Add continuation to simplify tun/tap after reboot · 1d9c6ccc
      Rich Kadel authored
      To make fx run -N even more friendly, I added "&&" (continue with
      the next command if the first command succeeds) and "\" (continue
      command on the next line) so users can simply copy and paste the
      helpful commands in a single copy-and-paste action.
      
      I find I have to re-enable tun/tap after each reboot of my Linux
      machine. Of course, I don't remember until I try the "fx run" command,
      but "fx run" helpfully prints the suggested commands to do that:
      
        To use qemu with networking on Linux, configure tun/tap:
        sudo ip tuntap add dev qemu mode tap user richkadel
        sudo ifconfig qemu up
      
      Without thinking about it, it might seem like you should be able to
      copy and paste both lines, but this fails because the sudo in the first
      line tries to use the second line as the password.
      
      The change simplifies running the commands, and may be less confusing.
      
      Test: Verified results locally (very minor change)
      Change-Id: I45ebfda917c96ba5704f108119b65a06aaba0ae4
      1d9c6ccc
    • Bruno Dal Bo's avatar
      [netemul] Refactor error codes · 51ae491f
      Bruno Dal Bo authored
      - Sandbox was using fuchsia::sys::TerminationReason for its termination
      codes, refactored termination process to return a netemul-specific
      status code.
      - Unit tests now check for expected status codes.
      
      Change-Id: I7bc48a34da311d8de1f5a5d6caab27f600e3c5ba
      51ae491f
    • Bruno Dal Bo's avatar
      [netemul] Fix race in Sandbox destructor · 037e90c0
      Bruno Dal Bo authored
      - Sandbox was using a default destructor, which could cause race with
      the FIDL bindings error callbacks kept in Sandbox::procs_.
      
      BUG: FLK-178 #done
      Change-Id: I46189bde74fa4d83faec27f503f9ec032c605906
      037e90c0
    • Rich Kadel's avatar
      [tools] Update build command when needed for fidl-format · 1f0a445e
      Rich Kadel authored
      The old build command is no longer working. I believe this change
      addresses the original intent.
      
      Test: tested locally to confirm it works
      
      Change-Id: Ib097f5e713b4794a66daaf9332da2db2c0158cc1
      1f0a445e
Loading