Skip to content
Snippets Groups Projects
  1. Mar 18, 2019
    • Todd Eisenberger's avatar
      [devcoordinator] Create composite devices in devhosts · 44fd341a
      Todd Eisenberger authored
      When all of a composite device's components are ready, the composite is
      created.  In this implementation, we always proxy components, even if
      they're in the same process.  This will be relaxed in a later patch.
      
      Issue: ZX-2648
      Change-Id: I97f5efb311ca18ec830f81158f022f230abc2d5d
      44fd341a
    • James Tucker's avatar
      [shell] only run /boot/bin/* or /bin stubs · e0e56973
      James Tucker authored
      system/bin only contains appmgr, which is launched by full path.
      /pkg/bin is not relevant to the shell, the shell should launch through the
      /bin stubs.
      
      Change-Id: Idd079b12d2afb346a8f4f5dfda7a045c1dbc865d
      e0e56973
    • Eric Wang's avatar
      [wlan-hw-sim] Move minstrel test to its own mod · ef2ce6df
      Eric Wang authored
      Test: Mechnical change
      
      Change-Id: I4a32c5e9f178b2a7202fe0dccecc54661f0198cc
      ef2ce6df
    • Kostya Kortchinsky's avatar
      [ulib] Initial check-in of Scudo standalone · 9eab0650
      Kostya Kortchinsky authored
      The standalone version of Scudo is currently being upstreamed
      in LLVM's compiler-rt, this is meant to provide a temporary way
      for Fuchsia to use it as a replacement for jemalloc in musl.
      
      Some of the files have already been reviewed and commited upstream,
      while others haven't, and are likely to undergo some changes
      during the review process.
      
      The LLVM copyright header is present in all files, even the ones
      that are not yet upstream, which I am not sure is legitimate.
      
      BUILD.gn was provided by David. Note that hardware CRC32 is not
      enabled.
      
      Test: replace jemalloc with scudo in musl, fx full-build & fx run.
      Change-Id: I42d6dbefd25e7c2252a18f712243b72b73b04ed3
      9eab0650
    • Nina Chen's avatar
      [docs] Add to IDE troubleshooting steps: · 46a8b8cf
      Nina Chen authored
      - Include symptoms that indicate troubleshooting is necessary
      - Split troubleshooting steps into subsections
      - Add to subsection about resolving pub errors
      
      Change-Id: I46260e30e4376448c0b3a5ff579dc2245d3b2202
      46a8b8cf
    • Didrik Nordström's avatar
      [auth] Enable AccountListener support in AccountManager · abc0af60
      Didrik Nordström authored
      Integrate AccountEventEmitter into AccountManager, which lets external
      clients subscribe to account changes (such as when an account is added
      or removed) using the AccountListener FIDL interface.
      
      AUTH-144
      Tested=CQ
      
      Change-Id: I82ab51bb6ee54329015b3ea23f7564d53c7f6b0d
      abc0af60
    • P.Y. Laligand's avatar
      [sdk][merger] Add alias for input flags. · 15aad01f
      P.Y. Laligand authored
      Bug: DX-447
      Change-Id: I817c263ec4a3e0d9864e89ac77ee2b607168949c
      15aad01f
    • Gianfranco Valentino's avatar
      [zircon][lib][zxtest] Add OWNERS. · b7aee7fe
      Gianfranco Valentino authored
      Added myself and brettw as owners of the library.
      
      TEST=none
      
      Change-Id: If1a7e7f4e941f015bc4b425ba336e54dd631cdd4
      b7aee7fe
    • Christopher Anderson's avatar
      [upci] Preserve existing BAR allocations · 037606d1
      Christopher Anderson authored
      Some PCI devices like serial consoles and framebuffers are
      brought online by the BIOS/bootloader and have existing BAR
      allocations. For BAR bringup this was not maintained in the
      userspace driver, but for continued work moving forward it
      was necessary.
      
      If the bus driver sees something that could be a valid address
      in the address bits of a given device BAR then it will attempt
      to allocate that address from the upstream allocator, if and only
      if the device has been enabled prior to our probing. Unfortunately,
      at power-on the state of all address bits are indeterminate, so
      the best we can do is preserve any address we see present and then
      attempt to use it. If we can allocate it then we don't need to change
      anything and we can proceed. If not, then we allocate a properly
      sized region from upstream and continue with BAR configuration.
      
      This should match the existing behavior in the kernel PCI bus driver.
      
      ZX-3146
      
      Change-Id: I974d903b9d2a4e99069b874a1a2c0389c9e50630
      037606d1
    • Dale Sather's avatar
      [mediaplayer] don't DCHECK on unnecessary packet request · 37cc76ef
      Dale Sather authored
      The ffmpeg demux node in mediaplayer occasionally gets a request
      (from downstream) for a packet even when it has reported
      end-of-stream on all streams. This happens only rarely.
      
      https://fuchsia-review.googlesource.com/c/fuchsia/+/263095 addressed
      the first-encountered DCHECK. That just got us to the next DCHECK.
      This CL should prevent this failure in CQ going forward.
      
      MTWN-242 #done
      
      TEST: fx shell run_test_component mediaplayer_tests \
            --gtest_repeat=<many>
            # debug build
      Change-Id: I0b070760621d0f8b78124be44aa28a5358b3c2a7
      37cc76ef
    • Rob Tsuk's avatar
      [carnelian] Promote scenic event types to trait methods · 76dcd1b0
      Rob Tsuk authored
      This takes the matching boilerplate out of the apps.
      
      Modified the button sample to respect focus and be closer to Material Design.
      
      Change-Id: I76c4f1b95592a1f45abe731580521cf159e0933e
      76dcd1b0
    • Benjamin Brittain's avatar
      [fidl][rust] Native Result type support for fidl error syntax · 0bbc9a85
      Benjamin Brittain authored
      Change-Id: If58b0c800f79eb6dff5d6bd014723f120cd66233
      0bbc9a85
    • Gianfranco Valentino's avatar
      [zircon][lib][zxtest] README fix. · dde6cbd1
      Gianfranco Valentino authored
      static SetUpTestCase/TearDown must be public.
      
      TEST=zxtest-integration-test
      
      Change-Id: I6ba055b801728e817d6e59ea4b8c0298335b783c
      dde6cbd1
    • Adam Barth's avatar
      [build] Introduce base/cache/universe naming for build args · de1cdacd
      Adam Barth authored
      Supporting both the old monolith/preinstall/available names and the new
      base/cache/universe names will make it easier to transition to the new
      names.
      
      Change-Id: Ifad1ce4250ab8683a1786e49882c89b43447b5a9
      de1cdacd
    • Nathaniel Manista's avatar
      [ledger] Remove unused deprecated private method · e3aeccef
      Nathaniel Manista authored
      Change-Id: Ia7cd416d103a47ec84293ac60a25f4214cb49d1e
      e3aeccef
    • Benjamin Lerman's avatar
      [ledger] Fix callbacks called after the source object has been deleted. · 7993de36
      Benjamin Lerman authored
      When an asynchronous method M is called on an object O, and O is deleted
      before the callback is called, the callback should not be called later.
      
      This fixes a couple of instance where the callback could be called after
      the source object has been deleted.
      
      Change-Id: Iebe3a2a86fd27cab1149567e24192ff34630ee58
      7993de36
    • Vikram Auradkar's avatar
      [blobfs] Use IdAllocator in blobfs · 9e581f61
      Vikram Auradkar authored
      O(logn) alloc and free time complexities.
      
      Use IdAllocator to alloc and free blobfs inodes. The existing code uses
      O(n). Not only allocation take a lot of time but it destroys the cpu
      caches because it is walking array of blobfs_inode_t structure.
      
      Around 128KiB should be sufficient for (1<<20) Ids.
      
      Tested: Ran blobfs-test. Added id-alloc-bitmap test cases.
      
      Performance: Test created 10000 blobs. In a 10000 iteration loop,
      1. unlink first created and last created blobs
      2. create two new blobs.
      
      Creating two blobs would stress FindNode. Total time(ns) spent in
      FindNode on Pixelbook,
      before: 768521344
      after : 45631811
      
      FindNode on Qemu,
      before: 6220833923
      after : 691256103
      
      Change-Id: I3f2619b65c8a63cd8374a541ad3ec1ad385a6bf6
      9e581f61
    • James Tucker's avatar
      [serve] support alternative port numbers · a2446ace
      James Tucker authored
      Change-Id: I17ead26f066be9bc18f4b207acfb5ff43334be48
      a2446ace
    • Francois Rousseau's avatar
      [feedback] add feedback data service to //products/core.gni · 5324a04a
      Francois Rousseau authored
      * we need that service to get feedback data for crash analysis (part of core) and user feedback (up the stack)
      * while this increases the core image, this will be compensated by the removal of several Dart agents up the stack
      * also moving crashpad_agent from //garnet/packages/product:base to //products/core
      
      DX-957 #comment
      
      TESTED=`fx set x64 --product core` && `fx shell crasher`
      
      Change-Id: I16e226aa3bdf0c3664be48f53e6590dd6338f0bb
      5324a04a
    • Craig Tiller's avatar
      [fidl] Fix implicit dependency · 3d1435b3
      Craig Tiller authored
      Change-Id: I67bc1e5503fa0852e2212ce3f52bd711ac612acb
      3d1435b3
    • Dale Sather's avatar
      [media] relocation ffmpeg lib BUILD.gn and use new prebuilt location · 8bc4279c
      Dale Sather authored
      The prebuilt artifacts for the ffmpeg lib are now present at
      //prebuilt/third_party/ffmpeg. This CL moves the BUILD.gn used for
      ffmpeg clients to //src/media/lib/ffmpeg.
      
      References in //garnet/bin/mediaplayer and //garnet/bin/mediasession
      are updated to depend on //src/media/lib/ffmpeg.
      
      The .gitignore in garnet/lib/media/ffmpeg will be removed once the
      prebuilts no longer land there.
      
      TEST: no behavior change
      
      Change-Id: Ic304cc3ebfba78a8b283103d261e27bc674dd26d
      8bc4279c
    • Benjamin Lerman's avatar
      [ledger] Use storage::Status everywhere but at FIDL interfaces. · 2f0503c5
      Benjamin Lerman authored
      The following status are converted from one to the other:
      OK, IO_ERROR, PAGE_NOT_FOUND, KEY_NOT_FOUND, REFERENCE_NOT_FOUND,
      NETWORK_ERROR
      
      Any other status will be converted to an INTERNAL_ERROR.
      
      Change-Id: I36020de7f72eee4784c840a208d2becb5def0b7c
      2f0503c5
    • Sean Klein's avatar
      [disk-pave] Improve logging for missing partitions on fixed-block devices · e08b742d
      Sean Klein authored
      ZX-2948 #comment In Progress
      
      Change-Id: I4b9b963f7ab364d5a0b32c32681545aba3d7b963
      e08b742d
    • Adam Barth's avatar
      [fx][set2] Improve ergonomics of fx set2 · db981728
      Adam Barth authored
      Improves the error message when the caller does not provide a
      PRODUCT.BOARD goal.
      
      Change-Id: I1343510e0dfe0938e4c05e7403948129c1e68717
      db981728
    • Benjamin Lerman's avatar
      [ledger] Fix comment on PageEvictionManagerImpl::EvictPage · f96dcb56
      Benjamin Lerman authored
      Document that the page must exist before trying to call |EvictPage|.
      
      Change-Id: I29322f971fefd0daffd159a4601459e7c028e955
      f96dcb56
    • Zach Bush's avatar
      [cobalt] Implement LogCobaltEvent{,s} · 2f3d20e5
      Zach Bush authored
      Change-Id: Ibc4fe4b606b2c35aa229141389bd851cd24a9ee7
      2f3d20e5
    • Sean Klein's avatar
      [gpt] Add DATA to Known GUID array · 737dc85f
      Sean Klein authored
      Change-Id: Idca9c6d478cede154b7ef568e2101941073c8915
      737dc85f
    • Brian Bosak's avatar
      [zircon][usb-virtual-bus] Move the USB virtual bus into its own devmgr · 6c219559
      Brian Bosak authored
      This patch moves the usb-virtual-bus into its own devmgr, and adds a test binding for it.
      It also removes usb-virtual-bus functionality from usbctl, as this will be tested in an
      automated fashion in a future CL.
      
      In order to control the virtual bus, it is necessary to start an isolated devmgr
       and create a bindable device with BIND_PLATFORM_DEV_VID set to PDEV_VID_TEST and
      BIND_PLATFORM_DEV_PID set to PDEV_PID_USB_VBUS_TEST.
      Then; ioctls can be used to manipulate the virtual bus.
      
      Test: Validate that usbctl no longer contains any virtual bus functionality, and that the virtual
      bus is no longer visible in the device tree.
      
      Change-Id: Ia3ae6eb89c71ecafae95b427b1cb0659da206fb5
      6c219559
    • Gabriel Kerneis's avatar
      [ledger] Store object references as a set · 7001513e
      Gabriel Kerneis authored
      Introducing a distinct type name will ease refactorings.
      Switching to a set makes the pathological split test case fast again.
      A follow-up CL will switch to a map to distinguish lazy and eager
      values.
      
      Test: fx run-test ledger_tests -t ledger_unittest
      Bug: LE-697
      Change-Id: Ifa225f2462ac89b6feb7ee8fcfb2ae77f6b7672a
      7001513e
    • Przemyslaw Pietrzkiewicz's avatar
      [voila] configure replicas · 0f511ab2
      Przemyslaw Pietrzkiewicz authored
      With this patch, Voila reaches a first functional version:
      
       - we now create two isolated replicas and run session shell in each
       - Ledger instances in replicas synchronize via cloud_provider_in_memory
      
      LE-663
      
      Test: tiles_ctl add fuchsia-pkg://fuchsia.com/voila#meta/voila.cmx
      
      Change-Id: I5f8c889fa383c7d9731f071e563705307430f2cd
      0f511ab2
    • Adam Barth's avatar
      [build] Migrate remaining JSON build packages to GN · b2760af9
      Adam Barth authored
      Change-Id: I03463d8a3528f4c31972f678924cd7a643c67d7a
      b2760af9
    • Przemyslaw Pietrzkiewicz's avatar
      [fuchsia-app] add LaunchOptions support for isolated environment · a4608be9
      Przemyslaw Pietrzkiewicz authored
      In a subsequent CL, we'll add similar support to fuchsia-component.
      
      LE-663
      
      Test: see https://fuchsia-review.googlesource.com/c/fuchsia/+/263612
      Change-Id: I14678357e2fba7e51fea27699f88b83ee52f0d20
      a4608be9
    • Adam Barth's avatar
      [build] Replace JSON packages with group targets (part 1) · f06654a3
      Adam Barth authored
      This CL starts the process of replacing the JSON build packages with GN
      group declarations. This CL makes it possible to have a mix fo JSON and
      GN declarations and migrates many of the JSON declarations in this
      repository to GN.
      
      Change-Id: I0ea3fce91da8a289c30d02e7692ee0f7c4d033c1
      f06654a3
    • Nina Chen's avatar
      [docs] Glossary cleanup: · a209ce32
      Nina Chen authored
      - fix broken markdown links by removing the space between the [link text] and (#link url)
      - Flutter can run on "platforms", not "platform" :)
      - link "Channels" as [Channels] and not [Channel]s so that screen readers read it as "channels" instead of "channel, s"
      - put bullets on their own line so they render correctly as bullets
      
      Change-Id: I7178320f8f70b89edcc811521a5e379c503d2b0e
      a209ce32
  2. Mar 17, 2019
    • Yifei Teng's avatar
      [pm][serve] Disable gzip compression for blobs · b1ab3af3
      Yifei Teng authored
      When blobs are streamed via gzip, their original content length is lost.
      This broke fetching of packages.
      
      TEST: Fetched and ran fortune.
      Change-Id: I85bbaa255f4e0fed28a29d603869f578aba63588
      b1ab3af3
    • Joshua Seaton's avatar
      [host tests] Create 'pseudo_tests.json' · e4f03fe6
      Joshua Seaton authored
      This file is meant to be a supplment to tests.json that provides
      information about the latter's complement, namely tests that don't
      yet contibute test spec metadata.
      copy_host_tests is made to consult this manifest as well as tests.json
      
      Bug: IN-819
      Change-Id: Idc6906365b2dfc9d77d20bcf6598b9901fd712b9
      Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/264247
      
      
      Reviewed-by: default avatarAdam Barth <abarth@google.com>
      Commit-Queue: Joshua Seaton <joshuaseaton@google.com>
      e4f03fe6
    • Rob Krten's avatar
      [docs][fidl] Update wire format for xunions · 3f036ff4
      Rob Krten authored
      Added xunions description and diagram to the wire format doc.
      
      Change-Id: Icd3bec41683ce47133f468b4f88d5527dec8179d
      3f036ff4
    • Adam Barth's avatar
      [build] Use tests.json to copy host tests · d04c3918
      Adam Barth authored
      Rather than generating individual copy rules, we now use tests.json and
      a Python script to copy host tests into the host_tests directory.
      
      After this change, the host tests machinery can be driven entirely off
      GN metadata.
      
      Eventually, we will remove the host_tests directory.
      
      IN-819 #comment
      
      Change-Id: I02e1b7d7e7fd84cf19ce145ae9559d67a4ca721e
      d04c3918
    • Adam Barth's avatar
      [build] Make shell-commands into a meta package · 413171ed
      Adam Barth authored
      Also, make config-data into a meta package.
      
      A meta package is part of the monolith that depends on all the other
      packages in the universe. We need to do some fancy dependency tricks to
      avoid circular dependencies.
      
      Change-Id: I667dca887dc00262717391ddbe2a2f5f9306c3c9
      413171ed
  3. Mar 16, 2019
    • Adam Barth's avatar
      [build] Assert that meta_package_labels are present · 784c3d35
      Adam Barth authored
      People missing meta_package_labels are most likely not using a supported
      product configuration. This assert can detect that condition early and
      loudly.
      
      Change-Id: Ic5e7b3db0ef7cde278cc25e7c4153fc7666f4484
      784c3d35
Loading