Skip to content
Snippets Groups Projects
  1. May 09, 2019
    • Suraj Malhotra's avatar
      [svchost][devmgr][miscsvc] Add miscsvc · 70671add
      Suraj Malhotra authored
      Was originally submitted as Id411227e4c3d2b8add49978cf6ce1a76de509a48.
      
      Startup a miscsvc binary, and provide a channel to it's '/svc/
      directory to svchost, which will then forward it services.
      
      To start miscsvc only implements the paver service.
      
      ZX-3861
      
      Change-Id: I83a630476c08d15e461d74e3321ad55bb21a3c2f
      70671add
    • Josh Gargus's avatar
      [scenic] Opacity support is a HACK. · c3db3180
      Josh Gargus authored
      (this relands I5705b27f46002b904e8d025e360b30f501871de7, modified
      for a soft transition)
      
      For reasons outside the scope of this CL description, Scenic
      wishes to avoid the use of translucent objects within 3D scenes;
      modifying opacity should only be available as a 2D operation.
      However, Scenic does not yet support 2D scenes; "everything" is
      currently part of a 3D scene.  As a short term solution, we
      therefore allow OpacityNode to modify the opacity of shapes in
      the 3D scene, but mark it as a HACK to indicate that this support
      will be removed at some point in the future.
      
      SCN-478 #comment
      
      Testability: no functional change.
      
      Change-Id: Iec09f956655ca1fa49c241066d70b7b5dabd948b
      c3db3180
    • David Worsham's avatar
      [escher] Format code · 00188a92
      David Worsham authored
      Tested: No behavior change
      SCN-1391 #comment
      
      Change-Id: I744362b766037768ed1fe3ffa00b02ed747f4e76
      00188a92
    • Suraj Malhotra's avatar
      [paver] Fix paving for sherlock · 70f44d4c
      Suraj Malhotra authored
      Tested: Paved sherlock, vim2, astro, nuc.
      Tested: runtests -t paver-test.
      
      Change-Id: Ie5b41a5187aacf417a8c1da74316691bf067fe89
      70f44d4c
    • Roland McGrath's avatar
      [prebuilt] Roll Clang · 564ddc5c
      Roland McGrath authored
      Roll Clang to revision 1558731607cb2aef361d02be9973d4e374475254.
      
      Bug: TC-451 #done
      Bug: TC-461 #done
      Bug: ZX-1751 #comment -fno-exceptions hermetic libc++ in toolchain
      Change-Id: Iad6785f5b38535bd38f50432bd3aecfc452137b5
      564ddc5c
    • David Greenaway's avatar
      [guest] Rename internal "fuchsia.guest" FIDL bindings. · a311b577
      David Greenaway authored
      Rename the internal bindings as follows:
      
        fuchsia.guest.device 🠞 fuchsia.virtualization.hardware
        fuchsia.guest.vmm    🠞 fuchsia.virtualization.vmm
      
      This patch doesn't move the public
      "fuchsia.guest.{EnvironmentManager,EnvironmentController,...}" interfaces.
      These will come in following patches.
      
      Bugs: MAC-252 #comment
      Change-Id: I0a137a85cb2b8cc25b163a5dc828c12f98de62b0
      a311b577
    • docs-roller's avatar
      [gndoc] Update GN build arguments documentation · d818aafe
      docs-roller authored
      Test: CQ
      
      Change-Id: I9d0f8c2f409452743e1f3e228f7c8bdb5e0e3c31
      d818aafe
    • Casey Dahlin's avatar
      [debugger] Let symbol server download binaries or symbols · 4e2b795b
      Casey Dahlin authored
      This isn't hooked up to anything yet, but we can now theoretically
      specify whether we want the binary itself or the symbols when
      downloading.
      
      Change-Id: Ic4e162151bf2b7a73e7453a7801a2aef1a022a95
      4e2b795b
    • Roland McGrath's avatar
      [bootloader] Compile with -U_MSC_VER in EFI environment · fb476108
      Roland McGrath authored
      Counteract the compiler's _MSC_VER predefine for the *-windows-msvc
      target used in our EFI build environment.
      
      Bug: TC-461 #comment Gigaboot EFI build disables _MSC_VER predefine
      Change-Id: I39f481acb606262dcb576cbdb080527c6e512280
      fb476108
    • Carlos Pizano's avatar
      [kernel] Add vmar alignment flags · 649d64d8
      Carlos Pizano authored
      This change introduces a set of flags of the form
      
      ZX_VM_ALIGN_<number> that can be combined with other ZX_VM
      flags to control the |address| alignement of
      - zx_vmar_allocate(...., &address);
      - zx_vmar_map(..., &address);
      
      TEST: unit tests added
      
      ZX-1173 #done
      
      Change-Id: I7a6920ec16d1b89a21c36850e99fe336f3c9270d
      649d64d8
    • Julia Hansbrough's avatar
      [scripts] Fix get_ssh_cmd bugs for fuzzer utils · 4911368f
      Julia Hansbrough authored
      TEST= python device_test.py
      
      Change-Id: Ibb769fd2e648a21ad4102b75e54c8544ab891a70
      4911368f
    • Nathan Rogers's avatar
      [sl4f][e2e][benchmarking] Add sl4f Traceutil facade to sl4f · 376d30df
      Nathan Rogers authored
      Add a new |Traceutil| facade to sl4f.  It currently only supports
      copying trace files off of the target device.  It is used in the
      corresponding vendor/google CL.
      
      Also add a Dart side |Traceutil| class, which supports calling methods
      in the |Traceutil| facade, and also driving tracing via ssh and
      /bin/trace.
      
      Test: See the [e2e][benchmarking] vendor/google CL
      
      PT-135 #comment-patch
      
      Change-Id: I1632f463a8b805efc660a22531d835e390ebb47c
      376d30df
    • Ankur Mittal's avatar
      [appmgr-test] Re-enable CreateAndKill test. · f0fa084b
      Ankur Mittal authored
      This flake seem related to FLK-168 and that flake has not happened since
      April 23 so it seems underlying issue was fixed. See FLK-168 for more
      details.
      
      Enabling this and will monitor it to see if issue still persist.
      
      FLK-130 #progress
      
      TEST=CQ
      
      Change-Id: I98e9d94286c957990ce9ea7686aeb5dbdf43c9a4
      f0fa084b
    • Jinwoo Lee's avatar
      [sdk] add licenses for musl and vulkan · 23ac4e4b
      Jinwoo Lee authored
      Bug: DX-1468  #comment
      Change-Id: Ic2f65c135175b97bfd7ceb2cfc688a04d19e54a3
      23ac4e4b
    • Venkatesh Srinivas's avatar
      [kernel][x86] Cpuid: Add HYPERVISOR bit, add minor comments · 0834fee2
      Venkatesh Srinivas authored
      * Add HYPERVISOR feature flag (EAX=1, ECX[31])
      * Comment that CpuId is uncached
      * Comment what ProcessorId in CpuId
      * Comment LEAF1 and LEAF7
      
      Change-Id: I1939422aa7baa6b49eda716e9c43f724c936ce64
      0834fee2
    • Venkatesh Srinivas's avatar
      [kernel][x86] CpuId: Add function to retrieve processor signature · 7b32f982
      Venkatesh Srinivas authored
      x86-64 CPUs return a 'processor signature' when CPUID is invoked with
      EAX=1; allow retrieving that value from ProcessorId in the C++ CPUID
      library.
      
      Loading microcode updates requires comparing the raw processor signature
      with a value in microcode update headers.
      
      ZX-3359
      
      Change-Id: Idd211e37f5d8d7c96ff4c524e844acef240b4750
      7b32f982
  2. May 08, 2019
    • Shac Ron's avatar
      [utest] Disable iosched test due to flakiness. · bec3d66b
      Shac Ron authored
      Temporarily disable iosched test until flakiness resolved.
      
      Bug: FLK-208
      Test: verified test binary no longer builds.
      Change-Id: Ifa124f438da52b219c42fe34e58ad8d997780c01
      bec3d66b
    • David Greenaway's avatar
      [virtualization]: Revert visibility changes in c81aa877 · 68e870a0
      David Greenaway authored
      The gn default visibility is global, while ":*" makes visibility private
      to the local directory. Thus, c81aa877 incorrectly _increases_
      visibility, instead of restricting it as expected.
      
      The author of the original patch clearly needs to read the documentation
      harder :-)
      
      Change-Id: I104696df4d57b08f8bf0435fa5779a169adca641
      68e870a0
    • Sean Klein's avatar
      [fs-management] Minimalize use of ulib/fdio for block device · a667d7c3
      Sean Klein authored
      There is more work to be done to avoid using file descriptors for
      the mount path itself, but this patch avoids referencing block devices
      by fd in favor of referencing them by handle.
      
      Testing: Internal change only; no behavioral change.
      
      Change-Id: I1889da8249ba824aa6afaa1ecfd73deb9ed501c5
      a667d7c3
    • David Stevens's avatar
      [kernel][vm] Add bidirectional COW clones · 50ff5692
      David Stevens authored
      Bidirectional COW clones are implemented by moving the original vmo's
      content into a kernel-private 'hidden' vmo and using that hidden vmo as
      the parent of the original vmo as well as the new bidirectional COW
      clone.
      
      The hidden vmos are an implementation detail of bidirectional clones,
      and are thus not exposed to userspace through any syscalls. However,
      they do show up in 'k' commands, as those commands are not a stable API.
      
      Subsequent changes will improve the memory consumption of bidirectional
      clones.
      
      ZX-1268 #comment [kernel][vm] Add bidirectional COW clones
      
      Change-Id: I4a7f46ff92db2746d1f540c1ca84aae6281edb5b
      50ff5692
    • John Bauman's avatar
      [magma] Test that protected memory uses the right memory type · 432138ed
      John Bauman authored
      The driver should be able to determine the correct memory type from the
      buffer collection.
      
      Change-Id: Id339de7664d06028329a7e598ee09ee021e329cd
      432138ed
    • Gary Bressler's avatar
      [utest] Don't hard-code /boot location for zircon test files · 1651ebe6
      Gary Bressler authored
      This change fixes the zircon tests that were failing in the `bringup`
      build.
      
      The tests were failing because they had hardcoded paths at "/boot/..."
      which failed when the tests were run from "/system". The fix is for
      runtests to pass a TEST_ROOT_DIR environment variable, which is
      "/system" or "/boot" depending on the location of the test. The tests
      use this variable instead of hardcoding the path.
      
      Bug: BLD-463 #comment fix broken tests
      Change-Id: Id6478f68600a55f13dc8c0bde19253c909a03694
      1651ebe6
    • Dylan Swiggett's avatar
      [fidl][docs] Fixes bad link to rust docs · 048bc55e
      Dylan Swiggett authored
      The rust link points to the dart tutorial!
      
      Change-Id: I1e18a7e6b4a80be3d243b72fac0277198dbc671f
      048bc55e
    • Drew Fisher's avatar
      [zxcrypt] statically link most dependencies · 411533bc
      Drew Fisher authored
      This change:
      
      * splits //zircon/system/ulib/zxcrypt into two libraries, so that the
        FDIO dependencies don't leak into the driver, and vice versa
      * reduces the set of dependencies of the driver to those actually
        required
      * cuts out some transitive dependencies on libraries that are not used
        at all by dependencies of zxcrypt
      
      Tests: added some assert_no_deps in the build, and checked the
      dependencies of the new artifact:
      
      (15:24:39) zarvox@zarvox-linux ~/fuchsia/out $ readelf -d ./default.zircon/user-x64-gcc.shlib/obj/system/dev/block/zxcrypt/zxcrypt.so | grep Shared
       0x0000000000000001 (NEEDED)             Shared library: [libzircon.so]
       0x0000000000000001 (NEEDED)             Shared library: [libdriver.so]
       0x0000000000000001 (NEEDED)             Shared library: [libc.so]
      
      DNO-492 #comment zxcrypt.so links most things statically
      
      Change-Id: Ic7d179ae77af6e1efbaa10624ecadcd8b27134f9
      411533bc
    • Bryan Henry's avatar
      [fx] Add get-device and get-device-addr commands · 8bfe040f
      Bryan Henry authored
      Useful both for scripts and for interactive use (like in fx scp or
      sftp).
      
      Change-Id: I8bd3dc398b8fb0547dda44b3e8ca9ee4e3b923ec
      8bfe040f
    • Sean Klein's avatar
      [fs-management] Pass block device by handle, not fd · 824e64c8
      Sean Klein authored
      When launching filesystem binaries, the following handles
      are now passable:
      
      FS_HANDLE_ROOT_ID: The handle representing the root of the filesystem
      server.
      FS_HANDLE_BLOCK_DEVICE_ID: The handle representing the block device
      of the target filesystem.
      
      Moving forward, it is expected that both mounters and mountees (the
      filesystems themselves) will begin using the block device more "by
      handle", rather than "by fd". This avoids interfacing with ulib/fdio,
      simplifies transmission of FIDL requests, and encourages asynchronous
      communication.
      
      Tested by "fs-management" and "fs-tests", which invoke
      the mount, mkfs, and fsck commands, achieving coverage
      of the code paths touched by this patch.
      
      ZX-2718 #done
      
      Change-Id: Ia6ad9d69c8a13e92189125f590d7e25c125ea027
      824e64c8
    • Brett Wilson's avatar
      [debugger] Set registers in StackFrame · 2cd57fe7
      Brett Wilson authored
      Adds all general registers to the topmost StackFrame when sending frame
      information. These are currently unused.
      
      Changes existing register handling code to reduce one query of the register
      state when unwinding with the Android unwinder, and to re-use the register
      saving code in "arch.h" without re-querying the OS.
      
      Adds a unit test for stack unwinding which was previuosly missing. It
      validates that the new registers are set, but not what the specific
      values are (these are hard to predict).
      
      Disables an existing test that we found to be flaky.
      
      Change-Id: I9a873b04dfdf91b0bd4a5f1f96301ee1ef275dcd
      2cd57fe7
    • Olivia Nordquist's avatar
      [modular] api audit · e77326be
      Olivia Nordquist authored
      removing dead code
      
      MF-217 #done
      
      Change-Id: I897f28f55d256fe6679a9294e7c3f96d7eb19a11
      e77326be
    • Vardhan Mudunuru's avatar
      [modular][testing] Teach TestHarness to inject services. · 8ef100b1
      Vardhan Mudunuru authored
      This CL implements features which were needed to enable using Flutter
      Driver under the test harness.
      
      Fixes:
      ==
      * Fix test_session_shell to implement |SessionShell| and hold onto views
      plumbed from AttachView; these keeps views alive and lets test harness
      run flutter driver tests. This is tested by a CL using flutter driver in
       //topaz.
      
      * Give each test harness environment a random name, so one test harness
      doesn't conflict with another if both happen to be running.
      
      New features:
      ==
      a) TestHarness accepts a mapping of Service name -> component URL to
      inject services in the hermetic environment it creates. It works
      similarly to fuchsia.test CMX facet's injected services. This is
      provided using TestHarnessSpec.injected_services
        - This is used to let flutter driver tests specify, and prevent
        modular_test_harness.cmx (and the test component), declaring services
        they want to use from the environment.
      
      b) Introduce TestHarness.ConnectToEnvironmentService, which lets you
      connect to environment services injected using a).
      
      a) and b) are tested together in the TestHarnessImplTest.InjectServices
      test.
      
      Other:
      * Rename TestHarness.GetService -> TestHarness.ConnectToModularService
      * Updating existing tests to use injected services.
      
      Change-Id: If940c8173f04eea36ee71934cf37e6e2a5b67834
      8ef100b1
    • Jeremy Manson's avatar
      [fidlcat] Add zx_channel_read operations. · 3d909bd9
      Jeremy Manson authored
      This allows fidlcat to detect zx_channel_reads and decode/display them.
      
      DX-1483 #comment Add zx_channel_read support
      
      Change-Id: I19756543653e7e6dca0c2be6b6a77b42fe26cd6d
      3d909bd9
    • docs-roller's avatar
      [gndoc] Update GN build arguments documentation · 779accc0
      docs-roller authored
      Test: CQ
      
      Change-Id: I088a995f0cfae82f0211b742c443eca723fcfe58
      779accc0
    • Ankur Mittal's avatar
      [build][package] Add support to compile cml files. · fd2ae4b6
      Ankur Mittal authored
      Relanding this CL after fixing build rules.
      
      TEST=Build and CQ
      
      Change-Id: I69fb22c19df06e9f3fd1d3cfdc51882c91d07b1f
      fd2ae4b6
    • Mukesh Agrawal's avatar
      [bt][l2cap] ERTM TxEngine: honor MaxTransmit for RR-Poll · fe543940
      Mukesh Agrawal authored
      Use the MaxTransmit parameter to limit the number of times we
      will transmit a receiver-ready poll.
      
      * Per Section 5.4, when MaxTransmit=1, only one transmission is
        permitted.
      * Per Section 5.4, when MaxTransmit=0, the poll should be
        retransmitted indefinitely.
      * Per Section 8.6.5.8 (see second to last row in table), when the
        monitor timer expires, and we have _not_ exhausted MaxTransmit, we
        should retransmit the poll frame, and restart the monitor timer.
      * Per Section 5.4, as well as Section 8.6.5.8 (see last row in table),
        when the monitor timer expires, and we have exhausted MaxTransmit,
        the connection should be closed.
      
      (References above are to Core Spec v5.0, Volume 3, Part A.)
      
      Bug: BT-442
      Test: bt-host-unittests
      
      Change-Id: I15e73ab50a8cc8ccaf1f678db5f709350637bf50
      fe543940
    • Erick Tryzelaar's avatar
      [build][gn] Add note that system ota tests uses packages.tar.gz · 36f64af8
      Erick Tryzelaar authored
      This is done because a CQ change won't see that this change
      breaks the system ota tests.
      
      Change-Id: Ifa929d528e42fbdfb5eae17c3e32d22182dff0de
      36f64af8
    • Christopher Tam's avatar
      [fidlc] Fix error reporting on line/file bounds · f825993a
      Christopher Tam authored
      This change brings in fixes for how the fidlc front-end handles
      spans and source context, especially on the boundaries of a line or
      file. This is the underlying cause of FIDL-583.
      
      In more detail, this change:
        * Enables proper pretty printing of start-of-file, start-of-line,
          end-of-line, and end-of-file spans.
        * Fixes a bug in the line-splitting logic of the internal compiler
          SourceFile representation.
        * Adds unit tests to cover empty file and unexpected EOF token cases.
      
      FIDL-583 #done
      
      Test: Add new unit tests to cover the cases being fixed. Run old tests
      to make sure nothing is broken by this.
      
      Change-Id: I4a23916a6264df9b0ebced6764e3f9a573793a19
      f825993a
    • Casey Dahlin's avatar
      [debugger] Don't do device probing when loading a core · a708b147
      Casey Dahlin authored
      Change-Id: Ie5fa9aa3f0af71376449188089faa2a921b55492
      a708b147
    • Jeff Seibert's avatar
      [fshost] Reformat zxcrypt and minfs partitions when missing. · 4dd00289
      Jeff Seibert authored
      If the disk format is unknown but the GPT GUID values dictate that it
      should be a data format, it determines if the volume should be a zxcrypt
      or minfs partition and formats it as such.
      
      Added a unit test that failed without the changes. I added a test that
      would have caught the vim2 breakage, but I also manually tested that it
      boots up properly.
      
      Change-Id: I276d55fc8dbcc8377d6a6b7d5dfe7b0fd9019eb4
      4dd00289
    • Jeff Belgum's avatar
      [rust] Update Time and Duration methods to the into_* form. · a2e23c02
      Jeff Belgum authored
      It is more idiomatic and avoids ambiguity as to whether e.g. `nanos`,
      `micros`, and `millis` refers to the subsecond part of a struct or
      the entire value represented in that unit of measure.
      
      Updates all uses of the methods in fuchsia.git and deprecates the old
      methods.
      
      TEST=CQ
      
      Change-Id: Ibe67ffd028169cffdac0c1ce662bdb78fe7b1cd4
      a2e23c02
    • Fady Samuel's avatar
      Revert "[build][package] Add support to compile cml files." · 11cf4842
      Fady Samuel authored
      This reverts commit d957d81b.
      
      Reason for revert:  Unable to start hello world component
      
      [00055.025] 14138:14201> [component_manager] ERROR: Failed to bind to root component: ResolverError { err: ManifestNotAvailable { uri: "fuchsia-pkg://fuchsia.com/hello_world_hippo#meta/hello_world.cm", err: ClientRead(Status(PEER_CLOSED)) } }
      
      Original change's description:
      > [build][package] Add support to compile cml files.
      > 
      > TEST=Build and CQ
      > 
      > Change-Id: I6548bac320fe18f5d7ca5f795280399c04daee33
      
      TBR=phosek@google.com,anmittal@google.com,jeffbrown@google.com,abarth@google.com,raggi@google.com,shayba@google.com,leolung@google.com
      
      Change-Id: I28fb0847ca14e3c5771935bd06ab463db059293d
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      11cf4842
    • Sean Klein's avatar
      [blobfs] Create BufferedOperation type · 32c67bde
      Sean Klein authored
      This allows clients to easily distinguish between
      an "UnbufferedOperation" (not yet in a buffer registered
      with the block device) and a "BufferedOperation", which
      can directly be transmitted to storage via "FlushWriteRequests".
      
      This change makes each operation self-describing, which makes
      it easier to operate on collections of "BufferedOperation" objects
      that might be acting on distinct objects (e.g., the Journal buffer
      vs the data writeback buffer).
      
      Change-Id: I98811f6e3a256f79fe83bd7e2ec13b717a38c3c5
      32c67bde
Loading