This reverts commit cf254ae8.

Reason for revert: Causes vim2 to fail to pave. See: https://fuchsia.atlassian.net/browse/DNO-519

Original change's description:
> [devhost] Wait for BindDriver in reply to Bind
> 
> Calls to fuchsia.device.Controller/Bind should only return once the
> operation completes, which is when
> fuchsia.device.manager.DeviceController/BindDriver is called.
> 
> ZX-3991 #done
> 
> Change-Id: I10607640072c8f779ac1d5be79d5a2da6de6288b

TBR=kulakowski@google.com,teisenbe@google.com,abdulla@google.com,brettw@google.com

Change-Id: I370d03abd9fa93a70a48f86f4df171f2cf87ee12
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Tracked by: SPN-8

Test: fx shell run fuchsia-pkg://fuchsia.com/hotsort_vk_bench#meta/hotsort_vk_bench.cmx"

- CL following 277184.

This CL replaces shell scripts with GN.

The GN build invokes the 'hotsort_gen' code generator and builds
architecture-specific shader "targets" (bundles of shaders and
algorithm configuration info) using a custom GN template.

The target outputs are placed in their respective $target_gen_dirs for
later inclusion of either a source set or its equivalent binary image.

The hotsort_target.gni template performs the following steps:

  1. Produce list of compute shaders that *will* be generated.
  2. Invoke hotsort_gen to generate compute shaders.
  3. Compile the shaders to SPIR-V modules with glslangValidator
  4. Invoke spirv-opt to optimize and shrink the SPIR-V modules.
  5. Invoke spirv-remap to improve compressibility of modules.
  6. Convert SPIR-V modules to array of C literals.
  7. Dump a binary image of the HotSort target bundle of modules.
  8. The GN template returns a source set of the target.

Steps to verify target outputs are being created:

  1. fx build graphics
  2. ls -R out/default/gen/src/graphics/lib/compute/hotsort/platforms/vk/tests/hotsort_vk_bench/

Change-Id: Ic98c374c70e4fda2c1d8d3284a8cbc46443eaffc

Tested: No behavior changed
SCN-1391 #comment

Change-Id: I98fdc6188963a381141448d36400d4a370ead295

Fixes hermetic dart test that require UI.

Test:
fx run-test slider_mod_tests

Change-Id: I8464abc271378031f2da133290a730c4f2b9d504

This:

MyTable t;
t.set_x(1);
t.set_y(2);
MyFunction(std::move(t));

Can now be reduce to:

MyFunction(MyTable().set_x(1).set_y(2))

Test: Table.ChainSetters; all existing tests using tables also aren't
failing.

FIDL-615

Change-Id: Ieeffa04417e92df7c0bb01d3b461dd968ba33852

This adds the Installer trait, and replaces the InstallPlan trait with
Installer::Plan, an trait to use with the associated InstallPlan type of
the Installer.

A stub implementation is provided for ease of writing tests and for
prototyping work.

Bug: PKG-465
Test: fx run-test omaha_client_lib_tests
Change-Id: Id644c3a41c78a1fce09fa8575027eb7c71c9943d

Tested: No behavior changed
SCN-1018 #comment
SCN-1291 #comment

Change-Id: Ic2dba8b13d6aaea74c19013cdb2561d601114a70

on a QEMU bot, the stub logger took longer than the timeout (100ms) to
send the first message (before it goes to sleep for 200ms) so we
increase the timeout to 500ms (and the sleep to 1s).

FLK-225 #done #comment

TESTED=`fx run-test feedback_agent_tests -t log_listener_unittest -- --gtest_filter=CollectSystemLogTest.Succeed_LogCollectionTimesOut`

Change-Id: Ia8e135e4ac2305076e73658916a5f6c6b0bddda6

Add a simulator configuration to lay the groundwork for driver
unit tests. This first step creates a build target that doesn't
use the zircon driver/device framework. To do so, we create two
sets of sources, one (for the actual driver) that instantiates
a devmgr device and one (for testing) that instantiates a
simulated device.

WLAN-1126

TEST: Built, ran brcmfmac unit tests, ran smoke test with
      fx-linksys. This patch is the first step in a unit test
      framework for the brcmfmac driver.
Change-Id: Icecadcfd75f727084447953c6a521775ca499737

Change-Id: Ia1db1813d4c6f491e0ca02945ca86ffa6f6f28c6

This is first cut to keep review rolling. The patch allows me to
incorporate feedback from review as I keep working on the tool.
There are plenty of TODOs that might serve as a hint to reviewers
what I intend to do in the future, There are codes that look noop
which I have retained because it makes testing easier.
The current version parses only one argument (a file name) and
runs load for few seconds or a minute at max.

When run - output looks like this.
$ odu /tmp/f
===== Aggregate Stats =====
Runtime:50.15060829s IOs:303 write_size(MB):62.40
IOPS:4.79 LAT(us):208579.46 BW(MB/s):0.98

If I print thread specific stats and stage stats the output would look
like

$ odu /tmp/e
===== For generator-0 =====
Generate TimeInStage:344791630 IOPS:292.93 LAT(us):3413.78
BW(MB/s):58.01
Issue TimeInStage:24016252450 IOPS:4.21 LAT(us):237784.68 BW(MB/s):0.83
Verify TimeInStage:6253520 IOPS:16150.90 LAT(us):61.92 BW(MB/s):3198.20
Runtime:49.78938866s IOs:101 write_size(MB):20.80
IOPS:4.21 LAT(us):237784.68 BW(MB/s):0.83
===== For generator-1 =====
Generate TimeInStage:494067320 IOPS:204.43 LAT(us):4891.76
BW(MB/s):40.48
Issue TimeInStage:22197400730 IOPS:4.55 LAT(us):219776.24 BW(MB/s):0.90
Verify TimeInStage:1960320 IOPS:51522.20 LAT(us):19.41 BW(MB/s):10202.42
Runtime:52.46426601s IOs:101 write_size(MB):20.80
IOPS:4.55 LAT(us):219776.24 BW(MB/s):0.90
===== For generator-2 =====
Generate TimeInStage:634360370 IOPS:159.22 LAT(us):6280.80
BW(MB/s):31.53
Issue TimeInStage:24582622520 IOPS:4.11 LAT(us):243392.30 BW(MB/s):0.81
Verify TimeInStage:21145570 IOPS:4776.41 LAT(us):209.36 BW(MB/s):945.82
Runtime:48.96960358s IOs:101 write_size(MB):20.80
IOPS:4.11 LAT(us):243392.30 BW(MB/s):0.81
===== Aggregate Stats =====
Generate TimeInStage:1473219320 IOPS:205.67 LAT(us):4862.11
BW(MB/s):42.08
Issue TimeInStage:70796275700 IOPS:4.28 LAT(us):233651.07 BW(MB/s):0.88
Verify TimeInStage:29359410 IOPS:10320.37 LAT(us):96.90 BW(MB/s):2111.76
Runtime:52.47356284s IOs:303 write_size(MB):62.40
IOPS:4.28 LAT(us):233651.07 BW(MB/s):0.88

Utility saves the arguments to generator in a file called
"./output.confing" whose content may look like
[{"magic_number":5720826294568186926,"process_id":3,"name":"generator-0",
"generator_unique_id":0,"block_size":4096,"max_io_size":1048576,"align":
true,"seed":0,"target_name":"e","target_range":{"start":0,"end":6990506},
"target_type":"target_file","issuer_queue_depth":40,"max_io_count":100,
"sequential":true}...]

Test: fx run-test odu_tests -- --nocapture

Change-Id: I219379093dfef14a0979678ce2e34a76fc5b9bbf

LE-618 #done

Change-Id: Ibdc6d9a9bf187b7127e82c614b5fb7540d0ede09

Test: CQ

Change-Id: I8382094ead019dbfc3a5447ec5a27dccbd1a5f3f

LE-618

Change-Id: Ib68941ffd47954c79dd8784c713c1e1d37607f3c

After moving fbl::RefPtr from std::shared_ptr, removing raw pointers
where appropriate and removing unnecessary uses of .get(), which can be
dangerous.

TEST: no functional change
Change-Id: I143faeb33c98013119fcb3e14d50f3d6648316ee

Moving from std::shared_ptr and std::set, etc. to fbl's intrusive containers
had been planned here for quite awhile as evidenced by johngro@'s TODOs;
this also brings us in line with the style guidelines as fbl::RefPtr is
half the size of std::shared_ptr.

TEST: audio_fidl_tests
Change-Id: Id9734cb8a5099f061a43b017b42a9224bc03fffa

Just like change Ib5d4d93b45152f8117ef2ad3fcdba6c70638bef9 but for the
(Singly|Doubly)LinkedList classes. HashTable is also supported since
it's backed by those.

TEST: new stuff in intrusive_(singly|doubly)_linked_list_tests.cpp
Change-Id: Id00347b4191744b4ebdb2c23f12a2fae65451f2f

Currently if you want to have your class able to live in multiple
WAVLTrees at once, you have to give it multiple WAVLTreeNodeState
members and define the node_state function in multiple NodeTraits
classes.

This change greatly simplifies this use case by allowing a
class to inherit multiple times from fbl::WAVLTreeContainable and pass
it a different tag type as the second template parameter each time. You
then pass the same tag type to the WAVLTree template and you're good to
go.

I also defined a helper template fbl::ContainableBaseClasses which allows
one to inherit from multiple Containable classes (even ones that aren't
necessarily WAVLTreeContainable) without also explicitly inheriting from
the fbl::HasTagTypes class, which is mostly an implementation detail.
This helper template also contains static_asserts to give understandable
error messages for common errors.

TEST: CQ, new stuff in intrusive_wavl_tree_test.cpp

Change-Id: Ib5d4d93b45152f8117ef2ad3fcdba6c70638bef9

Eventually zx_clock_get_new will replace zx_clock_get.

Tests: No behavior change.
Change-Id: I7884752bb866e72c338cf63bf64739894103ff01

appmgr is missing an OWNERS file, which can lead to changes being made
without CF being aware.

Change-Id: Iffa31b40ac2c78d592167c334e9614aa2f90c74f

Prior to this, if you had multiple references to a nullable xunion in
the flat AST, it would include multiple copies of that xunion in the
list of coded types.  Since the list of coded types is directly used to
generate xunion declarations (see TablesGenerator::Produce), it could
emit multiple versions of the same nullable xunion into the C generated
code, leading to compilation failure.

Also applies the same logic to nullable structs and unions, although
they don't have the same failure mode.

Change-Id: I840beaa607f390a9ec7e685d6c0e37477445d657

Calls to fuchsia.device.Controller/Bind should only return once the
operation completes, which is when
fuchsia.device.manager.DeviceController/BindDriver is called.

ZX-3991 #done

Change-Id: I10607640072c8f779ac1d5be79d5a2da6de6288b

When an environment() sets variant_selectors so it doesn't match the
default list used in common environments, things get even hairier for
environment_redirect().  Previously environment() documented that
default_variants must be in the list for environment_redirect() to work
right, but even that was not actually enough.  Instead, remove that
requirement and make environment() always define a dummy environment with
the "default redirect" variant name that environment_redirect() will
choose.  Make that logic choose only from default_variants and line up with
the fallback dummy variant name logic in environment().

Bug: BLD-430
Change-Id: I399a38ba494f4fafc28a3d9e93dece101eab3732

This allows the OTA tests to be used between two local builds.

Change-Id: Ib9e4088fe0d6d17dda57d6b628e5ca636e48b806

- Convenience methods GetProperties,GetConfig no longer that convenient
- move to "internal" namespace
- use weak pointer to access Controller functionality

Tested: fx run-test cpuperf_tests
Change-Id: I36002719309a4798447b6e3c79692298990fb1e2

This reverts commit 1651ebe6.

Reason for revert: The change rolled too much into one commit and did not get anything green.  It needs to be split up and reviewed properly.

Original change's description:
> [utest] Don't hard-code /boot location for zircon test files
> 
> This change fixes the zircon tests that were failing in the `bringup`
> build.
> 
> The tests were failing because they had hardcoded paths at "/boot/..."
> which failed when the tests were run from "/system". The fix is for
> runtests to pass a TEST_ROOT_DIR environment variable, which is
> "/system" or "/boot" depending on the location of the test. The tests
> use this variable instead of hardcoding the path.
> 
> Bug: BLD-463 #comment fix broken tests
> Change-Id: Id6478f68600a55f13dc8c0bde19253c909a03694

TBR=mcgrathr@google.com,geb@google.com,shayba@google.com
Bug: BLD-463

Change-Id: I9d5a296eee311d48ac45a7dd8339d889aca18d4d

Change-Id: Ida400311e4757c34aa23e42fee0c658966ce13a4

Happy to tweak wording as necessary.

Change-Id: I4db141b3ad0436a861d90905b9bf7c9040b649c5

Change-Id: I9378d445e53b88cade30ecdab28021bb4dc4137c

This integrates the component_manager logger, which sends logs to the
kernel debuglog facility, with the log crate instead of defining our own
macros. It also adds a panic hook to ensure that panics are also sent to
the debuglog, rather than relying on component_manager's stderr to be
wired up properly.

Also removes the stderr fallback path, which is unnecessary.

Change-Id: I3510b04239c7f9ab306254663bddaab245f48197

Update #ifdef gates for headers to match their new location in
src/connectivity.

TEST: Compiles
Change-Id: I94f3509a24e91a9e93e4ec6b697fa602fa4bec62

This change implements the minfs inspector backend for different on-disk structures like
superblock, inode table, inode, journal et al and returns each of these as a generic DiskObject.
Please note that alloc block bitmap and inode bitmap are not implemented as part of this
change and will be implemented as a later CL.
This CL also splits the Minfs class and InodeManager class to make them more easy to accomodate
unit testing.

Testing: Added unit tests for root, superblock, inode table, inode and journal.

Change-Id: I3bed793a8c0301bf8ce4367fbca48e31a6f44772

This cl implements Settings Manager based on the recent settings.fidl
submitted for A11y. This cl includes following changes:
  * Implementation of Settings Manager.
  * Unit Tests with Mock for SettingsService and SettingsWathcer.
  * Added a comment in settings.fidl to document expected behavior of
    SettingsWatcher.

Testing:
  * Build: Passed
  * Installed image on device.
  * Unit Test: Passed
    Command Used: fx run-test a11y_tests

MI4-1567 #comment
MI4-1477 #comment

Change-Id: Ib4c36b2e660e39760d34c58cb91864b3d60d7169

Tests: build
Change-Id: If8c72b099513338b5cdbff5fbcdb5c822ec2f9d2

Devs should be able to query for its properties and enumerate children.

CF-768 #done

TEST= added new test.

Change-Id: Ib52c90fef60acc50e9ce0b9c6c85e41983089017

also clean up dependencies and includes in edited integration tests

TESTED=`fx run-test crashpad_agent_tests -t crashpad_agent_integration_test`
TESTED=`fx run-test feedback_agent_tests -t feedback_agent_integration_test`

Change-Id: Ib1a6039aedf7ff49aa8cfd3f8652c587577f15fe

This change adds a new set of tests test that drive amberctl within nested
environments containing isolated instances of Amber to ensure, end to
end, that its interactions with the service produce the expected results

PKG-604 #done

Change-Id: Ib3843f075d51f34e5bc2ddc5bd04cadf6dd6e466

This CL adds an admin-only method to enable or disable the
systemwide creation and update of audio device settings files.

This work is being done in preparation for the creation of long-
running audio tests that (among other things) create and destroy
an endless number of audio input and output devices (in conjunction
with virtualaudio), which otherwise would completely fill all
available storage with audio device settings files.  While we do
also want eventually to test the out-of-storage scenario, we also
want to be able to remove this factor, in order to find the other
factors that may stop us from being able to operate indefinitely.

Test: to be created

Change-Id: I1f0f9fff815b6c6f9d088c50b76d961f852902bb

The write hook to dmctl has been removed.

Tested by causing bootserver to send a reboot command. One way to do
this is to pass bootserver an FVM but not a kernel.

out/default.zircon/tools/bootserver \
  --board_name chromebook-x64 \
  --fvm /out/default/obj/build/images/fvm.sparse.blk \
  -n <node name>

ZX-4038 #comment

Change-Id: Ibb9ea419feb542aa811c60e0d280f68ae2b86144

Add a document describing suggestions for vocabulary usage and avoidance
to aid in clear communication and understandable code.

Change-Id: Iaf7fbdfbb351f0a0e101adbffdaf1d08b9276941