Transitions callers of zx::channel::read and zx::channel::read_etc to a
corrected argument order. The first step happened in a previous commit
which temporarily added method names during the transition,
zx::channel::rea2 and zx::channel::rea2_etc to reflect the new argument
ordering.

This commit renames rea2 callers back to read, and changes the class method
definitions to the corrected order.

Test: CQ.

Bug: ZX-2812
Change-Id: I1ee9067d6a3507c18674d3e60b546882fcbd81f0

"zx::job::default_job()" was the only value used; insert
that directly to avoid using global variables.

If the usage of multiple distinct jobs is required in the future,
we can re-add this feature without using global variables.

Change-Id: I8b678e540d1f8b3840c599fe044f458ba40ff82d

ZX-3948 #done

Change-Id: I54fb5d14feea7e7817cda66fc26ffb7f73b94e9e

Dump-scenes now displays all Resources, even if they aren't reachable
from a Compositor.  This is of great help when debugging issues
where something hasn't been linked into the scene graph and you see a
blank area of the screen.

Test: Ran dump-scenes on sysUI

Change-Id: I2c3c163bad87ec452445960a55930c81010da6c4

This no longer exposes the underlying list outside of the child class

Change-Id: Ib70437cc84a9649f43fa0abc3c93caff73aab08c

WLAN-1087

TEST=Booted on vim2 and associated with GoogleGuest; booted AP mode and
connected from third device.

Change-Id: I1314f0324d188b1c1950bf171bdb78a1d036e877

Test: CQ

Change-Id: I339338d962735c594f24ada99c00b2382ae6fff9

This creates a simple application to test that the low level thread
state API can be used to successfully trigger a HW watchpoint. This
binary is able to trigger a HW exception.

This binary is made for all archs though only the x64 side is implemented.
Ported the HW breakpoint binary to the same layout, having only the
arm64 side implemented.

TEST=Manual on NUC (x64).

Change-Id: Id201e9024626e213da1d4d5f3697d854e4fcd417

Also added a cast so that it builds in c++.

Bug: ZX-3741
Test: qemu time-test

Change-Id: If193d6be048549a425c09e3dc0527cce7415c2cb

Moving router manager fidl to proper location.

Change-Id: Ib4d0f7d9b1e0e0f57b2bcac1ba5655cae85bf7a9

Pipe through color correction matrices provided by a11y by creating a new fidl interface command function that takes in matrix preoffsets, coefficients and postoffsets, as well as a compositor id, and passes the data along through the session manager to the compositor's swapchain, which then passes the information along to the swapchain's display through the display manager

SCN-1126 #done

Tested = New FIDL command for passing color correction data to Scenic,
proper compositor is found based on the provided compositor ID, data
passed to the compositor's display can be retrieved and matches the
original input.

To Be Tested - (SCN_1375) E2E Pixel test to ensure that Zircon display
manager is properly reading and applying the values sent to it by
Scenic.

Change-Id: I330307fee0948ed5c9bdd8bb3bc54aef41cbfa88

After this change, the legacy PaperRenderer "1" is not longer used,
and can be deleted from Escher.

SCN-1370 #done
SCN-670 #comment

Change-Id: Id1f08d089bfbd8585697bfa86cfd477ae5735014

Also log the `disconnect` case, which wasn't done previously.

Test: connect to local network and do a dump manually
Change-Id: I4f0447e58bb4e57333f680f9b3a8a88e19741675

The paver lib was to be closer to the interface it will be once paving
is exposed as a fidl service. The next change will hook it up to the
paver service, and the last will switch the install-disk-image binary to
use the paver service, instead of of directly invoking the library
functionality.

ZX-3861

Tested: Paved NUC, astro, vim2, and pixelbook

Change-Id: Ic705e76af70be1153998888e93250dbf8be21fda

This is in preparation of llcpp integration.

Change-Id: I4b87f1a6c124ac527396b4be81378fd3e1d4af21

This commit adds the thinfs host tests to the build system, allowing
them to be run via `fx run-host-test`.
I had to leave out the `fs/msdosfs` tests because they rely on other
binaries, like `dd` and `mkfs`.

I have tested them on linux and they ran fine.

This is how I ran the tests:

```shell
$ fx run-host-tests thinfs_bitops_test
$ fx run-host-tests thinfs_block_fake_test
$ fx run-host-tests thinfs_block_file_test
$ fx run-host-tests thinfs_cache_test
$ fx run-host-tests thinfs_gpt_test
$ fx run-host-tests thinfs_mbr_test
$ fx run-host-tests thinfs_thinio_test
```

Change-Id: I6fb8ae4bf431e0fbe458c895b1e2f196aa31fbd8

This change adds support for loading and using statically configured URI
rewrite rules in the package resolver. Dynamic rewrite rules are
prioritized over static rewrite rules.

PKG-638 #done

Change-Id: I99d6787a05a9d6696e2df3c278811aab7b813fc8

Change-Id: I2641f35daa8269844c74c777988039dfd9f4e0ec

Use //! instead of /// for crate/module level doc.

Test: fx rustdoc garnet/lib/rust/omaha_client --open
Change-Id: I4b62b841e37d5bb588393e3381419e6a7a99cb59

This integration tests spawns a number of threads and verifies that only
the correct thread hits the breakpoint and all other continue untouched.

The actual logic was implemented in a previous CL.

Added a lot of debug statements in order to track down problems. As
usual, these are deactivated in normal running of the agent.

TEST=Integration :) (fx run-test debug_agent_tests)

Change-Id: If2561a9a7bf2bb60702023b808950e87c92f5894

Since we have anonymous names which do not come from source files, e.g.
the name of the built-in uint32 type, we must handle absence of location
all the way down to how we report errors.

One benefit is the removal of the is_anonymous() method on Name:
callers should always assume that names could be anonymous, and this
should be hidden by the Name object model.

Change-Id: Ib47d23c93d893c3fefc6093d9162264ec492e3ef

Zircon's kernel-linked unit tests have a number of tests of the Priority
Inheritance implementation; the tests have short timeouts. Raise the
timeouts for threads exiting and for rendezvous, to allow the tests to
pass on Grunt Chromebooks (ex: HP Chromebook 14-db00030nr).

Tested:
k ut pi and k ut all on HP Chromebook 14 no long panic:

$ k cpu features
[00297.995] 01189:01210> Vendor: AMD
[00297.995] 01189:01210> Microarch: Bulldozer
[00297.995] 01189:01210> F/M/S: 15/70/0
[00297.995] 01189:01210> patch_level: 6006705
[00297.995] 01189:01210> Brand: AMD A4-9120C RADEON R4, 5 COMPUTE CORES 2C+3G
[00297.995] 01189:01210> Features: fpu sse sse2 sse3 ssse3 sse4.1 sse4.2 mmx avx avx2 fxsr xsave mon aesni clflush
[00297.995] 01189:01210> fsgsbase smep rdrand syscall nx huge rdtscp invar_tsc
[00297.995] 01189:01210> Properties:

$ k ut pi
[00083.559] 00000:00000> pi : Running 6 tests...
[00083.719] 00000:00000>   basic                 : PASSED (159574557 nSec)
[00083.731] 00000:00000>   changing priority     : PASSED (12076525 nSec)
[00085.736] 00000:00000>   long chains           : PASSED (2005062331 nSec)
[00085.947] 00000:00000>   multiple waiters      : PASSED (210688460 nSec)
[00086.093] 00000:00000>   multiple owned queues : PASSED (146293419 nSec)
[00086.106] 00000:00000>   cycles                : PASSED (13520778 nSec)
[00086.106] 00000:00000> pi : All tests passed (6/6) in 2547229379 nSec
[00086.110] 01189:01210>
$

$ k ut all
...
[00107.835] 01189:01210> SUMMARY: Ran 35 test cases: 0 failed
$

ZX-3849

Change-Id: I3a2b50267e9d14ccb1f27e9910184f68a66f3907

Test:
1. Connect to local network and dump inspect state
2. fx run-test wlan-inspect-tests

Change-Id: I761b84969488b966da282d1e5f94c1df7dae0ff6

And mark this device as ZX_PROTOCOL_GPU so that it's exposed through
/dev/class/gpu/.

Change-Id: I8e1d8facbcca4b28db05621e659a847cf4d6eda1

This uses the new configuration port setting to change the default port
to 5356 (from the default of 5353).

DX-1365 #done switch default for system responder

Change-Id: Ic540dda1602aca3ca5539bf7678ab5f17bdb180b

Disable fair scheduler on arm64 and x64 to reduce uncertainty while
other E2E test blockers are addressed.

Bug: ZX-3959
Test: Build arm64 and x64; Observe correct scheduler.
Change-Id: Ic2f15c05d1703c43b98769e473cd4851c9f90db1

(Second attempt, previous try at:
I09e66a7c5bc91fb41b6bfb99510b5be1aa609d57

reverted before due to race condition due to async fidl
call).

the virtcon (virtual-console) binary used to provide new sessions
through a convoluted path through device coordinator. This will make it
expose a fidl service directly for clients to request a new session.

This removes device coordinator from the operational loop and will make
it easy for the virtual-console binary to stand on it's own once we have
something else to start it.

It is a little messy due to the virtcon binary using the "port" library
heavily and fidl being built around the async_loop.

Test:
* Booted the following 3 times and verified that all three virtcons
appear and are interactive:
  * vim2
  * eve
  * qemu
  * qemu w/ KVM
* Tested qemu with virtcon.disable=true
* Tested qemu with zircon-only build (zircon/scripts/run-zircon-x64 -b
-g -k).

ZX-3403 # Get virtcon out of the way.

Change-Id: I708dc16a162e87838498afa5a38c4a5a0d9a3cf2

A commandline tool that talks to omaha client FIDL interface.

Bug: PKG-485
Test: fx shell omaha_client_ctl
Test: fx shell omaha_client_ctl get-channel
Test: fx shell omaha_client_ctl set-channel dev-channel
Test: fx shell omaha_client_ctl get-state
Test: fx shell omaha_client_ctl check-now
Test: fx shell omaha_client_ctl check-now --monitor
Test: fx shell omaha_client_ctl monitor
Change-Id: I7b9a6b4f6cbc91743176022c490376424050ca01

This change addes missing semantic information into the semantic node,
part of the accessibility infrastructure.

Previously, the node missed some important information to represent a
semantic node correctly.

For example: attributes, states and actions that can be performed on a
node were missing.

This change introduces the missing fields into the node data
structure. All the rest is left almost untouched, with some minor
naming improvements and the removal of some redundancies (for example,
removing the extra data field in the node itself).

Another important and noticeable changes is the removal of the label field.

Labels describe the name of a semantic element, but a label of a
semantic node can be defined by another semantic node (please see the
aria spec 1.1 for examples).

With this in mind, the best way of labeling an element is via an
attribute pair <label, actual node label>, when it produces its own,
or by the attribute pair <labeled_by, node_id>, when another node is
responsible for that.

Hit testing logic is also removed, as this is not how we are going to
do this in the future. the field children_hit_test_order was removed,
as we figure out how hit testing will be done for accessibility.

Tested:
* Installed on device.
* fx run-test a11y-tests

MI4-2322 #comment

Change-Id: I2be557e1772257a5e4673e70cc6582dc6af4d84f

The logic for the terminal size was broken and returned a size of 0 in
the success case which disabled scrolling.

Change-Id: I62564ec49eb86091cc0e070ee965c704a426efa0

Now that all other layers have been converted over to use benchmarking
instead, we can remove runbenchmarks.

PT-73 # comment patch

Test: CQ

Change-Id: I6e2672789973dd83ba5295f2178f36f86a4b9830

Run input as a background job and trace record as a foreground job.
This allows us to block on trace record, which ensures that the trace
file is written by the time we start trying to process it.
Unfortunately there's still a race between input and trace record
startup, however I strongly prefer that race over what we had before.

Test: CQ

Change-Id: Id016219e305ae662ec8ed45681ca057131da8187

Test: CQ

Change-Id: Ic91eca3a113e48592f0fa3e0c2d173ea91cabf58

CF-731 #done

Change-Id: I732848a6b4b9015efa008a4a84c5dcf506a81ab1

CF-162 #comment

Change-Id: I3ba3959e5e4877944d89b6f2fdde8b2207bf6882

We were erroneously not running vfs_exit ever due to an incorrect check.
This patch also adds tests to verify vfs_exit runs on shutdown and
reboot.

Bug: ZX-3886
Change-Id: Ic20996992c24e13759e6d2c2c01ccb0e1949357b

Change-Id: I5dc139642fbe341053b92b9b2c9e8b710235ec3b

It's simpler to have it be detached from the details of text_state, and
I think we may want to reuse these functions in other bits of code down
the road?

Change-Id: Iefe1f5d115302f5ba9e2de93a2aeae895a60bc56

When opening an image file, Firefox will set the window title to a
string that inculdes the image dimensions using what appears to be the
unicode multiplicaiton sign (code point 0x00d7). The specific encoding
supplied by Firefox does not appear to be valid UTF8.

Work around this by not panicing and simply truncating strings that are
not valid UTF8. PD-204 tracks finding a more proper solution here that
will allow us to move back to more strict UTF8 parsing.

Test: Opened image file in Firefox and observed no panic in the bridge.
Change-Id: I22f4f81d1865e98a9dfc317536fb3e9ab6199491

The coordinator now handles coordinating suspend on a device-by-device
basis, rather than just handling telling which devhosts to begin
suspending in which order.

Change-Id: I2dbd0370c93158f5a33db5a1f51f64200f13e6f5