Previously GN would implicitly make a group's deps public. I'm making this behave like other target types, so ICU's group's deps need to be public to forward the build information to dependents.

TBR=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1374173003 .

Also add a few comments to the .gn file.

BUG=505316
R=jshin@chromium.org

Review URL: https://codereview.chromium.org/1301493002 .

The Chromium build currently defines both is_component_build (boolean)
and component_mode (a string). We're trying to standardize on the boolean.

TBR=jshin

Review URL: https://codereview.chromium.org/1273843002 .

No intended behavior change (except fewer duplicated compiler flags).

BUG=505319
TBR=mgiuca@chromium.org

Review URL: https://codereview.chromium.org/1220363002.

This warning is currently globally suppressed in Chromium, but this
suppression will be switched off, making a local suppression necessary.

BUG=505319
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/1224463003.

BUG=505304
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/1215103002.

Some Windows-specific ICU code uses this pattern, which triggers a clang warning.

BUG=505302
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/1209413007.

R=brettw@chromium.org, dpranke@chromium.org

Review URL: https://codereview.chromium.org/1183493003.

This allows targets that use GN to correctly note that
they need the .dat file to be included in .isolates.

R=brettw@chromium.org, jshin@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1167613003.

I hang my head in shame.

BUG=498033
TBR=hans@chromium.org

Review URL: https://codereview.chromium.org/1177533002.

This ports https://codereview.chromium.org/515263002/ and
https://codereview.chromium.org/508343002/

I don't see these warnings locally, but they do show up on the bots
for some reason. Probably good to have gyp and gn match anyways.

BUG=498033
R=hans@chromium.org

Review URL: https://codereview.chromium.org/1171153002

1. -Wno-return-type-c-linkage
 - became unnecessary with ICU bug 9504 fixed 3 years ago.
 - remove from both BUILD.gn and icu.gyp

2. -Wnoheader-hygine
 - became unnecessary a long time ago.
 - remove from BUILD.gn (icu.gyp does not have it)

3. -Wstring-conversion and -Wheader-hygine
 - add to BUILD.gn by NOT excluding clang:extra_warnings

BUG=114660
TEST=Build icuuc/icui18n targets (both gyp and GN) after regenerating build files.
R=brettw@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/1158933005

The GYP and GN build's defines have diverged. THis brings GN's defines in line with GYP's current set.

R=jshin@chromium.org

Review URL: https://codereview.chromium.org/1130383003

1. Cherry-pick security patches from the upstream.
  a. BiDi: integer overflow
    http://bugs.icu-project.org/trac/ticket/11451
    http://crbug.com/451799
    bidi.patch was updated to include patches for this issue.
  b. data race in cmemory; remove an unnecessary check with a global variable.
    http://bugs.icu-project.org/trac/ticket/11538
    http://crbug.com/223352
    cmemory.patch was added
  c. Locale::getBaseName() thread-safety
    http://bugs.icu-project.org/trac/ticket/11547
    http://crbug.com/467836
    locid.patch was updated to include patches for this issue.

2. Add UCONFIG_NO_NON_HTML5_CONVERSION=1 to BUILD.gn

3. Clean up
  a. Update README.chromium to flag patches that are already in the upstream.
  b. Split pkg_gen.patch from data.build.patch. pkg_gen.patch was already
     in the upstream while the rest of data.build.patch is Chromium-specific.
  c. Delete an unused converters.patch.

BUG=223352,451799,467836
TEST=See bugs 223352, 467836, 468716, and 466838
R=jyasskin@chromium.org, mark@chromium.org

Review URL: https://codereview.chromium.org/1020303002

I forgot to include this change in
  https://codereview.chromium.org/984233002

TBR=jochen@chromium.org
BUG=NONE

Review URL: https://codereview.chromium.org/1021673003

BUG=none
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1014393002