Skip to content
Snippets Groups Projects
  1. May 09, 2019
    • Christopher Anderson's avatar
      [devmgr] Reduce log spew with isolated devmgrs · 9db287a4
      Christopher Anderson authored
      When devcoordinator comes online it prints an error message
      if the root resource is not available, so it is unnecessary to
      print that the resource is unavailable several tiems later on.
      
      Change-Id: I0785840b53603a4495db286c1bf3495330e4b13f
      9db287a4
    • Josh Gargus's avatar
      [scenic] Cleanup after OpacityNode soft transition. · 37895153
      Josh Gargus authored
      This follows Iec09f956655ca1fa49c241066d70b7b5dabd948b,
      removing OpacityNode and leaving only OpacityNodeHACK;
      it can be landed once nobody references the former name.
      
      Change-Id: I4eed025a37c7d9e9b072ef5f24aad684f207a262
      37895153
    • Kendal Harland's avatar
      [fuchsia] Commit initial starlark and regenerate · 845bd72b
      Kendal Harland authored
      This is the first iteration of starlark code used to
      generate the protobuf APIs for CI/CQ builds. The starlark
      is basically a 1:1 mapping for now. In subsequent changes
      we'll pull common code out into reusable libraries.
      
      infra is still bootstrapping this infrastructure, so there's
      not much documentation yet. Soon to come.
      
      Bug: IN-1198 #comment
      Bug: IN-1102 #comment
      
      Change-Id: Ib994df041388b98ddeb520aada8d3cca89b3ea56
      845bd72b
    • Kevin Wells's avatar
      [fuchsia_component] Build nested environments · 033f1616
      Kevin Wells authored
      This change adds new builder types for creating components
      and extends ServiceFs to allow proxying FIDL services from
      components in nested environments into other components in
      that environment.
      
      Change-Id: I779de6f5d11b11b2ee846ad3fb060ac53949d037
      033f1616
    • Ankur Mittal's avatar
      [log_listener] Support log dump. · 6e03626f
      Ankur Mittal authored
      Supporting log dumps so that dev can get current logs and exit the
      listener if they want to.
      
      TEST=Added new.
      
      CF-767 #done
      
      Change-Id: If2c43ea569bf8982be4b3fc6b5ff4ef6098d86ac
      6e03626f
    • Payton Turnage's avatar
      [mediaplayer] Enable AAC decoding. · 19c3f347
      Payton Turnage authored
      TEST: fx run-test mediaplayer_tests
      Change-Id: Ieb0855c2da5774093ef0d02e5d650197f4135857
      19c3f347
    • Rob Krten's avatar
      [docs][fidl] Adding attributes FragileBase/Selector/Transport · ac5f1dfe
      Rob Krten authored
      Adding attributes to FIDL docs.
      
      Change-Id: Ia6314254d5dc7de5f13cfa8408abf120e0bfea00
      ac5f1dfe
    • docs-roller's avatar
      [gndoc] Update GN build arguments documentation · 38a4bc28
      docs-roller authored
      Test: CQ
      
      Change-Id: Ib19449e6df4df4c744239b2f3f17b54ff4095e8f
      38a4bc28
    • docs-roller's avatar
      [gndoc] Update GN build arguments documentation · 247c545c
      docs-roller authored
      Test: CQ
      
      Change-Id: I3be975b5471c3da31eae772a17b418ecd6e93a20
      247c545c
    • John Sheu's avatar
      [wlan] Remove wlan/drivers/lib · f4fa3484
      John Sheu authored
      Move this header-only library to the common place for WLAN includes:
      wlan/lib/common/
      
      Change-Id: I9e49073f84c724aa8f5035b4efb601bac0dfaf26
      f4fa3484
    • Mukesh Agrawal's avatar
      [bt][l2cap] ERTM TxEngine: add tx window · 217fd927
      Mukesh Agrawal authored
      We need to support having multiple packets in-flight, subject to our
      peer's buffer-size limitations.  As a step towards that goal, add a
      n_frames_in_tx_window argument to the ERTM TxEngine ctor (and
      corresponding field in the object).
      
      Bug: BT-442
      Test: bt-host-unittests
      Change-Id: I21f40c8fa826203166ce68033ad0152f66e0e600
      217fd927
    • Martin Puryear's avatar
      [media][tests] Move AudioLoopbackTests to use virtualaudio · b70d5c18
      Martin Puryear authored
      With this CL, AudioLoopbackTests now instantiates a virtual
      audio output device, so that loopback capture is always
      usable. To wait reliably for the device to be present (and
      to wait reliably for it to be gone before exiting), it must
      use GetNumVirtualDevices in the same way that
      audio_device_tests does.
      
      This test-only CL has no effect on production code
      
      Test: build, CQ
      
      Change-Id: I19bada2c69a0ea4fba7c05317ceaaa7355a9c1b4
      b70d5c18
    • Doug Evans's avatar
      [lib/ui/scenic] Remove unused trace-provider dependency · 84ce1ba7
      Doug Evans authored
      Libraries shouldn't have trace-provider dependencies.
      
      Change-Id: Icbf9a2c3d92e5c67e01d6af7452044387318e88a
      84ce1ba7
    • Yifei Teng's avatar
      [fs] Update io.fidl documentation to reflect hierarchical rights · f9b267f3
      Yifei Teng authored
      progress
      
      This should be merged after
      https://fuchsia-review.googlesource.com/c/topaz/+/277897
      
      ZX-3673 #done
      
      TEST: No behavior change
      Change-Id: I81de657853048a39312426d10ad303d5f294811b
      f9b267f3
    • David Greenaway's avatar
      [sdk][virtualization] Copy //garnet/public/lib/guest to //sdk/lib/virtualization/. · ba866cc9
      David Greenaway authored
      Create a copy of the public library at //garnet/public/lib/guest in
      //sdk/lib/virtualization, but using the new FIDL bindings and names from
      //sdk/fidl/fuschia.virtualization. Uses of
      `fuchsia.guest.{EnvironmentController,EnvironmentManager,InstanceController}`
      become `fuchsia.virtualization.{Realm,Manager,Guest}` respectively.
      
      We need a copy (and not a move) because out of tree code uses the
      existing libraries. //garnet/public/lib/guest will be removed once out
      of tree code can be ported across.
      
      We additionally perform the following file renames:
      
        testing/fake_environment_manager.cc :arrow_right: testing/fake_manager.cc
        testing/fake_environment_manager.h  :arrow_right: testing/fake_manager.h
        meta/guest_lib_unittests.cmx        :arrow_right: meta/virtualization_lib_unittests.cmx
      
      Bugs: MAC-252 #comment
      
      Change-Id: I42a90b4f491f9a60d9948d924ca59175a07fd54b
      ba866cc9
    • Alex Legg's avatar
      [libdriver][integration] Remove OpenAt hook from MockDevice · 5935e298
      Alex Legg authored
      Change-Id: I0527da8585e7a949634cea80ddbc1edbef3c1ae1
      5935e298
    • James Tucker's avatar
      [system_updater] requires the paver service · c031faba
      James Tucker authored
      This fixes a regression introduced in
      ffcb46fb which is covered by e2e tests that
      are not in CQ.
      
      Bug: ZX-3861 #comment regression fixed in system_updater.cmx
      Change-Id: Iecb5516ab2a4b0bfcdc28f030ca879eb456cb284
      c031faba
    • David Greenaway's avatar
      [guest] Copy "fuschia.guest" to "fuschia.virtualization". · caf91a28
      David Greenaway authored
      This is in preparation of a larger rename. To perform a soft transition,
      we need to temporarily have both the old an new FIDL interfaces and
      services provided.
      
      This first step copies the FIDL interfaces from "fuschia.guest" to their
      new locations:
      
        fuchsia.guest.EnvironmentManager    🠞 fuchsia.virtualization.Manager
        fuchsia.guest.EnvironmentController 🠞 fuchsia.virtualization.Realm
        fuchsia.guest.InstanceController    🠞 fuchsia.virtualization.Guest
        fuchsia.guest.BalloonController     🠞 fuchsia.virtualization.BalloonController
      
      Bugs: MAC-252 #comment
      Change-Id: I9cc5c4174aba1da1d516b3382e49fd5b9a0e45d4
      caf91a28
    • Martin Puryear's avatar
      [media][tests] Add GetNumDevices to virtualaudio · ebccadd8
      Martin Puryear authored
      This test-only CL adds a GetNumDevices method to the
      VirtualAudioControl protocol. This will be used by test
      clients (e.g. AudioDeviceTests), to synchronize with the
      Disabling of virtualaudio (which removes all active virtual
      audio input and output devices) or the activation of a
      virtual audio device. Along with this, the virtual_audio
      CL utility is updated to interactively exercise this new
      test function.
      
      VirtualAudio infrastructure is used by AudioDeviceTests (to
      validate the AudioDeviceEnumerator and AudioCore services)
      and by the E2E tests. Unfortunately, AudioDeviceTests is
      currently disabled because of synchronization issues, which
      poses a testability chicken-and-egg for this CL. Once this
      CL lands, the changes to re-enable AudioDeviceTests are
      already prepared and will come immediately after.
      
      Test: virtual_audio driver and virtual_audio utility are test-
      only, as are the fuchsia.virtualaudio FIDL protocols.
      
      MTWN-293 #comment
      
      Change-Id: I0c3f7b0560df7b7e0d103d5b310fc6e86e189551
      ebccadd8
    • Suraj Malhotra's avatar
      [board][arm64] Add a board name for arm64.gni · 2d8a12d1
      Suraj Malhotra authored
      This board file should only be used for qemu testing & inheriting from.
      Boards which inherit from it should override the board_name.
      
      Change-Id: I8696675c0bbd802a0f2f4c99ff8e799fef6edc1a
      2d8a12d1
    • Alex Legg's avatar
      [devfs] Deprecate opening devices as directories · d11bbe5a
      Alex Legg authored
      Devfs should no longer call DirectoryOpen on devices except when opening
      the device itself (i.e. with a path of ".").
      
      This is a small change in behavior in that when the describe flag is set
      devfs will now report ZX_ERR_NOT_FOUND when attempting to open a
      nonexistant file under a device. Previously devmgr would simply close the
      channel in this case.
      
      Also remove the DirectoryOpen handler from devmgr.
      
      Add an additional check to the devfs tests that opening a file under a
      device path (i.e. /dev/<device>/<file>) fails with ZX_ERR_NOT_FOUND
      unless the device has a child device (e.g. /dev/class/block/000).
      
      Change-Id: If7f33ac306940da7e43ae8c5b53a15d907593042
      d11bbe5a
    • Doug Evans's avatar
      [lib/media/camera/simple_camera_lib] Remove unused trace-provider dependency · ae41f2fa
      Doug Evans authored
      Libraries shouldn't have trace-provider dependencies.
      
      Change-Id: I5d2c5dcf42386cb23ddabe4677201f5dd572a1a3
      ae41f2fa
    • Suraj Malhotra's avatar
      [svchost][devmgr][miscsvc] Add miscsvc · 70671add
      Suraj Malhotra authored
      Was originally submitted as Id411227e4c3d2b8add49978cf6ce1a76de509a48.
      
      Startup a miscsvc binary, and provide a channel to it's '/svc/
      directory to svchost, which will then forward it services.
      
      To start miscsvc only implements the paver service.
      
      ZX-3861
      
      Change-Id: I83a630476c08d15e461d74e3321ad55bb21a3c2f
      70671add
    • Josh Gargus's avatar
      [scenic] Opacity support is a HACK. · c3db3180
      Josh Gargus authored
      (this relands I5705b27f46002b904e8d025e360b30f501871de7, modified
      for a soft transition)
      
      For reasons outside the scope of this CL description, Scenic
      wishes to avoid the use of translucent objects within 3D scenes;
      modifying opacity should only be available as a 2D operation.
      However, Scenic does not yet support 2D scenes; "everything" is
      currently part of a 3D scene.  As a short term solution, we
      therefore allow OpacityNode to modify the opacity of shapes in
      the 3D scene, but mark it as a HACK to indicate that this support
      will be removed at some point in the future.
      
      SCN-478 #comment
      
      Testability: no functional change.
      
      Change-Id: Iec09f956655ca1fa49c241066d70b7b5dabd948b
      c3db3180
    • David Worsham's avatar
      [escher] Format code · 00188a92
      David Worsham authored
      Tested: No behavior change
      SCN-1391 #comment
      
      Change-Id: I744362b766037768ed1fe3ffa00b02ed747f4e76
      00188a92
    • Suraj Malhotra's avatar
      [paver] Fix paving for sherlock · 70f44d4c
      Suraj Malhotra authored
      Tested: Paved sherlock, vim2, astro, nuc.
      Tested: runtests -t paver-test.
      
      Change-Id: Ie5b41a5187aacf417a8c1da74316691bf067fe89
      70f44d4c
    • Roland McGrath's avatar
      [prebuilt] Roll Clang · 564ddc5c
      Roland McGrath authored
      Roll Clang to revision 1558731607cb2aef361d02be9973d4e374475254.
      
      Bug: TC-451 #done
      Bug: TC-461 #done
      Bug: ZX-1751 #comment -fno-exceptions hermetic libc++ in toolchain
      Change-Id: Iad6785f5b38535bd38f50432bd3aecfc452137b5
      564ddc5c
    • David Greenaway's avatar
      [guest] Rename internal "fuchsia.guest" FIDL bindings. · a311b577
      David Greenaway authored
      Rename the internal bindings as follows:
      
        fuchsia.guest.device 🠞 fuchsia.virtualization.hardware
        fuchsia.guest.vmm    🠞 fuchsia.virtualization.vmm
      
      This patch doesn't move the public
      "fuchsia.guest.{EnvironmentManager,EnvironmentController,...}" interfaces.
      These will come in following patches.
      
      Bugs: MAC-252 #comment
      Change-Id: I0a137a85cb2b8cc25b163a5dc828c12f98de62b0
      a311b577
    • docs-roller's avatar
      [gndoc] Update GN build arguments documentation · d818aafe
      docs-roller authored
      Test: CQ
      
      Change-Id: I9d0f8c2f409452743e1f3e228f7c8bdb5e0e3c31
      d818aafe
    • Casey Dahlin's avatar
      [debugger] Let symbol server download binaries or symbols · 4e2b795b
      Casey Dahlin authored
      This isn't hooked up to anything yet, but we can now theoretically
      specify whether we want the binary itself or the symbols when
      downloading.
      
      Change-Id: Ic4e162151bf2b7a73e7453a7801a2aef1a022a95
      4e2b795b
    • Roland McGrath's avatar
      [bootloader] Compile with -U_MSC_VER in EFI environment · fb476108
      Roland McGrath authored
      Counteract the compiler's _MSC_VER predefine for the *-windows-msvc
      target used in our EFI build environment.
      
      Bug: TC-461 #comment Gigaboot EFI build disables _MSC_VER predefine
      Change-Id: I39f481acb606262dcb576cbdb080527c6e512280
      fb476108
    • Carlos Pizano's avatar
      [kernel] Add vmar alignment flags · 649d64d8
      Carlos Pizano authored
      This change introduces a set of flags of the form
      
      ZX_VM_ALIGN_<number> that can be combined with other ZX_VM
      flags to control the |address| alignement of
      - zx_vmar_allocate(...., &address);
      - zx_vmar_map(..., &address);
      
      TEST: unit tests added
      
      ZX-1173 #done
      
      Change-Id: I7a6920ec16d1b89a21c36850e99fe336f3c9270d
      649d64d8
    • Julia Hansbrough's avatar
      [scripts] Fix get_ssh_cmd bugs for fuzzer utils · 4911368f
      Julia Hansbrough authored
      TEST= python device_test.py
      
      Change-Id: Ibb769fd2e648a21ad4102b75e54c8544ab891a70
      4911368f
    • Nathan Rogers's avatar
      [sl4f][e2e][benchmarking] Add sl4f Traceutil facade to sl4f · 376d30df
      Nathan Rogers authored
      Add a new |Traceutil| facade to sl4f.  It currently only supports
      copying trace files off of the target device.  It is used in the
      corresponding vendor/google CL.
      
      Also add a Dart side |Traceutil| class, which supports calling methods
      in the |Traceutil| facade, and also driving tracing via ssh and
      /bin/trace.
      
      Test: See the [e2e][benchmarking] vendor/google CL
      
      PT-135 #comment-patch
      
      Change-Id: I1632f463a8b805efc660a22531d835e390ebb47c
      376d30df
    • Ankur Mittal's avatar
      [appmgr-test] Re-enable CreateAndKill test. · f0fa084b
      Ankur Mittal authored
      This flake seem related to FLK-168 and that flake has not happened since
      April 23 so it seems underlying issue was fixed. See FLK-168 for more
      details.
      
      Enabling this and will monitor it to see if issue still persist.
      
      FLK-130 #progress
      
      TEST=CQ
      
      Change-Id: I98e9d94286c957990ce9ea7686aeb5dbdf43c9a4
      f0fa084b
    • Jinwoo Lee's avatar
      [sdk] add licenses for musl and vulkan · 23ac4e4b
      Jinwoo Lee authored
      Bug: DX-1468  #comment
      Change-Id: Ic2f65c135175b97bfd7ceb2cfc688a04d19e54a3
      23ac4e4b
    • Venkatesh Srinivas's avatar
      [kernel][x86] Cpuid: Add HYPERVISOR bit, add minor comments · 0834fee2
      Venkatesh Srinivas authored
      * Add HYPERVISOR feature flag (EAX=1, ECX[31])
      * Comment that CpuId is uncached
      * Comment what ProcessorId in CpuId
      * Comment LEAF1 and LEAF7
      
      Change-Id: I1939422aa7baa6b49eda716e9c43f724c936ce64
      0834fee2
    • Venkatesh Srinivas's avatar
      [kernel][x86] CpuId: Add function to retrieve processor signature · 7b32f982
      Venkatesh Srinivas authored
      x86-64 CPUs return a 'processor signature' when CPUID is invoked with
      EAX=1; allow retrieving that value from ProcessorId in the C++ CPUID
      library.
      
      Loading microcode updates requires comparing the raw processor signature
      with a value in microcode update headers.
      
      ZX-3359
      
      Change-Id: Idd211e37f5d8d7c96ff4c524e844acef240b4750
      7b32f982
  2. May 08, 2019
    • Shac Ron's avatar
      [utest] Disable iosched test due to flakiness. · bec3d66b
      Shac Ron authored
      Temporarily disable iosched test until flakiness resolved.
      
      Bug: FLK-208
      Test: verified test binary no longer builds.
      Change-Id: Ifa124f438da52b219c42fe34e58ad8d997780c01
      bec3d66b
    • David Greenaway's avatar
      [virtualization]: Revert visibility changes in c81aa877 · 68e870a0
      David Greenaway authored
      The gn default visibility is global, while ":*" makes visibility private
      to the local directory. Thus, c81aa877 incorrectly _increases_
      visibility, instead of restricting it as expected.
      
      The author of the original patch clearly needs to read the documentation
      harder :-)
      
      Change-Id: I104696df4d57b08f8bf0435fa5779a169adca641
      68e870a0
Loading