This are the final things in /garnet/bin/auth so we also delete it
(yey!).

AUTH-196 #comment

Change-Id: I0d73f3c20d4195de70799f28ce1183395baac4a6

* apparently RunLoopWithTimeoutUntil() is bad because the default timeout
isn't guaranteed to be enough on some bots so instead we rely on the
infra timeout they give to each test
* we don't check the return value RunLoopUntil() in anticipation of https://fuchsia-review.googlesource.com/c/fuchsia/+/280471

TESTED=`fx run-test feedback_agent_tests`
TESTED=`fx run-test crashpad_agent_tests`

Change-Id: I491252ef6a3e3f51f418ef5e57d3f426411e54f6

This CL extends the host test for host fuzzers to also run the python
unit tests for 'fx fuzz'.

Bugs: SEC-170
Test: fx set core.x64 --with //src/fuzzing:tests
      fx run-host-test fuzzing_host_test
Change-Id: Ic2568e5603b34d35a94ebe85161f476f7854c330

Tracked by SPN-19.

Testability: HotSort library and test compile and run.
Change-Id: I6a80c97057493c3f967cc4eef30691e82d18ad16

Tracked by SPN-22 and SPN-19.

Blocks tests SPN-17, SPN-18.

Change-Id: I4bd95681b26b81e3521c518b4d0894730e5c23ce

Tracked by SPN-19.

Testability: not yet part of build.
Change-Id: I04c73606b03191d2c6e4f2048f329af848c8f5fb

to reflect the absence of timeout:
* update the function comment
* update the return value to void as it will wait an infinite time for the condition to become true

Change-Id: I157d42ecf35b26abcb738690d55439d0271dc32a

Change-Id: Ie192ad3f1e6734a50cc5e125ac42420be9fae39d

We now process both directed and undirected connectable advertisements
when deciding to auto-connect to a bonded peer. This is consistent with
the "Auto Connection Establishment Procedure" behavior described in v5.1
Vol 3, Part C, 9.3.5.1.

Bug: BT-800 #done
Test: 1. bt-host-unittests
      2. Auto-connecting to a Microsoft Designer Mouse should succeed
         all the time.
Change-Id: Ied65930588085ff48eb8b15af7f82decd7954ad8

Forgot to remove the request for /system/data from the CMX
previously.

TEST=none, removing unused request

Change-Id: I7c22dffbd188e8bb94a5dba9914252a2aa5e7760

This makes it easier to fine grain debug messages.

Added timing statements to loading modules, as this is the cause of
a latest timing regression.

Change-Id: I964d1083414d278b12ff2f97aaf609c76f24be39

TEST=unit

Change-Id: I95bc9a9b73387ea4a2b06cce212a1b8b8a8b4ad8

This change adds the ability for the rust cloud provider to simulate
network errors. The next CL will add a mechanism for externally
controlling the network state.

TEST=unit tests in crate::session::tests

Change-Id: Ia329e7cf802054cce73d35bf505677a9577eb8d8

PT-126 # comment CL collecting and logging cpu percentage

Corresponding config CL:
https://cobalt-analytics-review.googlesource.com/c/config/+/4941

Change-Id: I19532cd3ed8460fe70fbedd5ed381c1ef7cbaf77

Change-Id: I4fbecc3940e1b3c179ca95b849b8ac0a16779d95

This is currently only true in tests of component_manager that run as v1
Components, but will not be true of the component_manager started from
bootsvc.

CF-750 #done

Test: No package resolver case is covered by new no_pkg_resolver_test.
Package resolver present case is covered by existing integration tests
like routing_integration_test.

Change-Id: Ide07ab3d87ee5c31ea8f036c7dbb3c3b59c7fc00

by having feedback_agent spawn a new process on every fuchsia.feedback.DataProvider
request it gets, we can better isolate each request handling, in
particular if it has dangling threads due to some attachment collection
hanging and make sure the process exits upon request fulfillment

DX-1497 #comment

TESTED=`fx run-test feedback_agent_tests`

Change-Id: I103b36ef2cfc4df6a7eef5a5783ddc22e93357e8

A future change will move some of the startup code out of main() to
enable testing it in multiple different environments.

Test: Refactor, no change in behavior. Covered by existing tests.

Change-Id: I1fb82522268acdc0265aba6490230fb4404e995f

Remove the ::common:: namespace for sapphire-wide objects.

fx format-code

Test: bt-host-unittests, manual test of supported platforms (no
    behavior change)
BT-870

Change-Id: I810f29852e0da0d3d5bec25d57b2706d39be4e61

Change-Id: Ie2919f76b09db6f7419fc3be598af72f6f10ef24

the default name (from when the lookup fails) changes from "unknown-package" to "", which is fine and package was a bit of a misnomer anyway

TESTED=`fx run-test crashpad_agent_tests`

Change-Id: I51e4b86e2ccc74bc3e2d8751480211139f68aab2

for now, there are no data provider processes, but in the future there
will be one per connection to fuchsia.feedback.DataProvider. This CL is
just to introduce the test utilities.

DX-1497 #comment

TESTED=`fx run-test feedback_agent_tests -t feedback_agent_integration_test`

Change-Id: Ia5cb07334d3d27874318cd6b54fcf4afaa336da0

DeviceId only referred to peers and is renamed to be more consistent
with the idea that it is an identifier for a bluetooth peer.

fx format-code because "Peer" is 2 characters shorter

Test: bt-host-unittests (no behavior change)
BT-870

Change-Id: Ib97223e106bf9a9efb506de343ce218ba0b50c62

Previously the two auth providers were packaged together. There wasn't a
good reason for this and its likely they will eventually be used
separately so we give them their own package.

AUTH-196 #comment

Change-Id: I5dd60fdd18a10261636e46fde90d30587e76f0a9

as part of the effort to use consistent vocabulary, rename RemoteDevice
to Peer, including PeerCache and related variables.

fx format-code for reflows.

Test: bt-host-unittests (no behavior change)
BT-870

Change-Id: Ib96e929f93e2fac23ccf098e6df9921678cd2e11

This makes it easier for other tests to use the infrastructure
created in the system ota tests for other host/target-style testing.

Change-Id: Ib704b713d2889512656ebdbc0a58fd3063649414

This reverts commit f50bcc0c.

Reason for revert: Build is failing

Original change's description:
> [wlan-inspect] Be explicit about logging Option
> 
> Previously, we added a blanket WriteInspect implementation to Option
> types that would log a value only if an Option doesn't exist. When
> looking at an inspect_log call on an optional value, it's non-obvious
> that in some cases, no value would be logged, and this blanket
> implementation was only added because inspect_log didn't have a way to
> specify optional logging.
> 
> With this commit, optional logging can be specified with a question
> mark on the key, so the blanket WriteInspect implementation is also
> removed.
> 
> Test: fx run-test wlan-inspect-tests
> Change-Id: I926c20fe2e64fc2e1221c2b84b61d5d9b062e817

TBR=qsr@google.com,hahnr@google.com,eyw@google.com,kiettran@google.com

Change-Id: Iac6d853aa9561dd04089408b071909da66dcb63e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Previously, we added a blanket WriteInspect implementation to Option
types that would log a value only if an Option doesn't exist. When
looking at an inspect_log call on an optional value, it's non-obvious
that in some cases, no value would be logged, and this blanket
implementation was only added because inspect_log didn't have a way to
specify optional logging.

With this commit, optional logging can be specified with a question
mark on the key, so the blanket WriteInspect implementation is also
removed.

Test: fx run-test wlan-inspect-tests
Change-Id: I926c20fe2e64fc2e1221c2b84b61d5d9b062e817

WLAN-1117 #done

Test: Verify Inspect output. Example:
```
4:
  @time = 80.777
  cipher = 00-0F-AC:4
  derived_key = PTK
5:
  @time = 80.777
  cipher = 00-0F-AC:2
  derived_key = GTK
  key_index = 2
```

Change-Id: Id1046dcfbd65fc800d6b7cfbd04e7dd7ee27052e

This test of code addresses is not flexible enought to account for all
the code our compilers can generate. Testing this in the future will
require something more complicated like assembly code, so this test
removes that part of the checking for now. The rest of the test is still
a good smoke test for the unwinder.

Change-Id: Id2d18eca6ccb8b4d214a3bf627e6da090388542f

And use them in places where we make such syscalls directly with unsafe
Rust today. (Plus add in missing test coverage for logger that covers
the modified code.)

The zx_debuglog_read wrapper currently returns a plain Vec of bytes and
the caller needs to parse it according to the definition of
zx_log_record_t. In the future it ideally would return an already-parsed
Rust struct type, but there is some uncertainty around the existing
debuglog syscalls so this wasn't done yet.

Change-Id: Ibf3ddc6195a751dbacb6e0e9d24250370e8516e9

This CL aligns the Linear and Sample-and-Hold interpolators, in
preparation of introducing additional interpolating resamplers.
No functional change -- just tweaking the linear and point resamplers
to use identical patterns and sequences (as the soon-to-be-added
ones will likely do, as well).

Test: 170 existing automated test cases in audio_mixer_tests
(audio_mixer_tests --full) on all products.boards

MTWN-296 #done

Change-Id: I0753b3fc13d4eb69ffef56a38906043980304df1

Change-Id: I01d51517ff3630a7f1c587e73a3b26d6d36eee84

To prepare for enabling very-long-running tests, as well
as for the introduction of a framework for telemetry
collection, this CL makes consistent the use of logging
by audio_core (and audio_core's tests). Truly blocking
conditions are ERROR; safely-ignored conditions are INFO.
Also, for debug builds audio_core's default log level is
set to INFO, while on release builds it is set to WARNING.

Test: no functional behavior change
Change-Id: I1d8251a6aac79fc0bfb811ca8c398f2ac2004818

Design heavily influenced by AVDTP crate.

Supports:

- Owning a L2CAP socket to a remote peer.
- Responding to unit info and subunit commands.
- Sending AVC passthrough commands to a target.
- Receving target passthrough and vendor dependent packets.
- Sending responses back to controller commands.

BT-657
Test: fx run-test bt-avctp-tests

Change-Id: I861d86a61f17294c430beecf0ca08cea3264e5ea

While adding resampler-related test cases and related refactoring,
in preparation for adding new resamplers, test cases exposed MTWN-296
in the mixer core:

To handle step_size limitations, the mixer uses modulo|numerator|
denominator values for any rate or position fractional components that
cannot be captured with the 13 bits of fixed-point fraction. For a
given mix pass, we calculate end position using these values, doing so
correctly in the usual case of producing every frame, but slightly
incorrectly in the optimization case of MUTED (whether explicitly
muted, or gain is simply too low to ever produce a value). This defect
would primarily be exposed when performing very fine-grained rate
adjustments.

This CL therefore contains the test-code refactoring so far, plus the
test cases that exposed the bug, and the product fix, as well as
additional test cases to verify that no other related bugs lurked.

Test: 15 new test cases, bringing the total to 170
('audio_mixer_tests --full' in basic_envs on all products.boards)

BUG: MTWN-296 #done

Change-Id: If41e20af77bcebbbad7aaf7d5301fded6c027dc3

This CL changes the previous new test cases (which validated the
3:1 resampling ratio) to instead validate the 3.9999:1 resampling
ratio, and to add the 1:3.9999 resampling ratio.  This tests
particularly problematic ratios for both interpolators, and continues
to defend our sample-rate limits (this effectively rate-converts from
191999 Hz to 48000 Hz).

This CL also includes fidelity limit values that we require for these
ratios (both frequency response and signal-to-noise-and-distortion).

Test: test-only CL; adds 8 test cases runnable on any product/board

Change-Id: I4d2ff29a48403eaa98cd13f721b66e38191211bc

The GetNumVirtualDevices API that was recently added to
virtualaudio can be used to eliminate the synchronization
issues that AudioDeviceTests faces, so this set of tests
can now be re-enabled.

Test: re-adds 67 test cases; no production code change

MTWN-293 #done

Change-Id: I6d4618a52835f2ef388bed1dddef9491fc2e2b8d

Previously this was copyable but not copied in practice.

Changes some of the code that took pairs because std::pairs to make the
call-sites better.

This should have no affect on functionality and I measured indexing
performance to be the same within typical measurement error.

Change-Id: I5adebf46f0be89090f8048e7b00db8b3c71c7d42

Performance improves by ~7% by optimizing allocation of vectors and strings
iin module_symbol_index and module_symbol_index_node before doing the indexing.

Performance improves by ~15% by optimizing the allocation of the "seen_attrs"
vector in the DwarfDieDecoder.

This was measured by running the normall-commented-out test
ModuleSymbolIndex.BenchmarkIndexing and giving it an ELF binary of a fully
symbolized release build of Chrome.

There should be no functional change.

Change-Id: I107a3d651ac05e9b2959da88a06e463173eae199