This changelist encapsulates the SetUIService into a struct/impl.
This structure will facilitate future changes where state and logical
units will need to exist across channels.

Test: fx run-test setui_service_tests -- --test
Bug: SU-167
Change-Id: I850d75321a7d9f830bc611ba4ffc3bfcb6680534

Renamed session update function and moved CommandContext creation to
be assigned the trace ID, rather than guess the next ID.

Tested:
- updated unittests
- ran astro

Change-Id: I421ffe839c9add7440361209cc881c66c80e0843

Previously, it was possible for a hot-looping task to be
created as a result of a stale PEER_CLOSED signal arriving
for a new, still-open channel. This change prevents this
by ensuring that the `PEER_CLOSED` signal gets reset and
re-waited in the event that a read or write occurs without
resulting in PEER_CLOSED.

This change fixes the issue for zx::Fifo and zx::Channel,
and a followup change will be opened for zx::Socket.

Change-Id: I0220b084320158d20d624b75c4267b0f87e6687f

Instead of loading bundled defaults from the system_image package
start requesting the config-data feature and also looking for the
settings from the config-data path.

MTWN-262 #done

TEST=none

Change-Id: Ia1cd55f6c8bb1f8ae5546d651b50492642f867c9

Previously this library only supported connecting to Cobalt via the
older, heavier technique of passing a VMO containing the registry bytes.
Now it also supports connecting via the newer, lighter technique of
passing just the project name.

Test:
I added a new test case to cobalt_logger_unittest.cc

Change-Id: Id90ff6fc67faf73d7b19d9dc8a9691adee48de49

Update the ARP table on receiving gratuitous ARP requests and responses,
as specified in RFC 2002.

NET-2102 #done

Change-Id: I8f78200deb2f36f5cfff46bfbd9baec13f2d161f

Cpp Style (anonymous namespace for tests, and CamelCase for function
names).
Use zx type safe classes instead of raw zx_handle_t.
Prevent leak of handles by early release of a[0] on failure.

TEST=core/handle-transfer-test

Change-Id: Ic9ec5346d70afb9846f233c814ad709a3b35addd

BUG: FLK-200 #done

- Test case "TestSucceedsBeforeTimeoutFires" was causing flake due to
low timeout value (5s). Bumped value to 60s to prevent false negatives
in timeout test case.

Change-Id: Id7a999a3025291db12c7c39a3b1c20ced154e89c

Add basic tests that exercise non-blocking and blocking calls from dpc_queue.
Check that a DPC runs on the same CPU that it was queued on in the absence of
hotplug. Also check queueing many DPCs and seeing that they all execute.

Tested:
* k ut dpc_tests on qemu x86, qemu-kvm x86, qemu ARM
Ex (qemu ARM):
$ k ut dpc_tests
[00010.025] 00000:00000> dpc_tests : Running 2 tests...
[00010.030] 00000:00000>   basic test of dpc_queue    : PASSED (3393392 nSec)
[00010.037] 00000:00000>   test queueing lots of DPCs : PASSED (6933168 nSec)
[00010.037] 00000:00000> dpc_tests : All tests passed (2/2) in 11158208 nSec
[00010.041] 01188:01209>
[00010.041] 01188:01209> SUMMARY: Ran 1 test case: 0 failed
$

Change-Id: I405c9eaf99e9f6050378293889d417e97a54ab81

Previously we were removing jobs from the tree then marking them as
dead, but since removing from the tree can trigger the parent to die,
this meant that parent jobs were dying before children.

This CL switches the order so that jobs now correctly die from the
bottom of the tree up. This means that there is a brief window after a
job dies where it still exists and could be retrieved from the job tree,
but it's OK to have a handle or operate on a dead job, most functions
will just return ZX_ERR_BAD_STATE.

The reason this only manifested as test flake is because the job killing
thread would usually be allowed to complete before zx_object_wait_many()
returned in the test thread, but every once in a while
zx_object_wait_many() would fire quickly enough to catch jobs in the bad
state.

FLK-189

Test: new DEBUG_ASSERT() fired in old code but doesn't now
Test: `while runtests -t job-test; do :; done` no longer fails
      after a few minutes (QEMU ARM)
Change-Id: I38119d401c2f6e3310882a58c3d9b52e684d3d34

The original implementation offered only two options for zxcrypt's
key-source policy: always use the TEE, or always use a null key.

For a variety of reasons, including avoiding immediately losing data in
an OTA moving from the null keysource to the TEE keysource, we'd like to
be able to make a smoother transition, where we might try to use the TEE
if possible but be willing to fall back to the null key.  This patchset
expands our options by also allowing a policy for "opportunistically try
the TEE, but fall back to the null key if that fails for any reason" and
"require the TEE for new volumes, but still try the null key to unseal
existing volumes".  The former is safe to deploy even if we're waiting
on bootloader changes to land to enable the keysafe TA, and the latter
helps start the clock on devices which aren't using TEE-backed keys.

After spending sufficiently long with a board configured as
"tee-transitional", we can safely cut the config value over to "tee"
(required) since most devices will have been paved with a new zxcrypt
volume, which will be using a TEE-backed key.

Tests: With a modified bootloader and the keysafe TA included in the
system image, I OTA'd an Astro from "null" to "tee-opportunistic" to
"tee-transitional" without data loss.  I then repaved the Astro under
"tee-opportunistic", then OTA'd to "tee-transitional" and then to "tee",
and observed that each came up and successfully unlocked the /data
volume.  I also added unit test coverage.

SEC-270 #comment

Change-Id: I0fb95e5322468da4e13004e21569f44385d8d8c8

Test=Included unit tests

Change-Id: Ibeb2bec199ff4d43e4de4b8c69e86ac6b7930973

This makes the CobaltEvent interface more uniform with the existing
Log* methods. The only unsupported Log* method is LogCustomEvent.

Test: Add some tests for logging CobaltEvent (including new variant).
Change-Id: I28720826d7a552141d5e0ea64cdfe4e533261262

Test: fx set core.x64 --with bundles:buildbot passes.

Change-Id: I8783140a4380b9777bf41eb284a016c9fdf8a73b

custom .clang-format is removed for drivers so conform to the fuchsia
wide .clang-format

Test: Existing tests provides sufficent coverage. No behavior change.
Change-Id: Ic101de799d831afa545a171fe0ed0a15d7efef21

DPCs are a mechanism to queue work in the zircon kernel to run later from
thread context with interrupts enabled; comment the contract of DPCs more
completely.

* DPCs are run with interrupts enabled
* DPCs are queued to the current CPU and run there except in the presence of
  offlining/hotunplugging a CPU
* DPCs will never move CPUs while executing

Change-Id: Ib8d7d73cf6f8df99f49f632434387a3fd71f7f30

The receive_arp_response test function is not generic enough for the
upcoming gratuitous ARP implementation. This is necessary to send both
request and response ARP packets without reimplementing the same logic
and assertions.

The solution to this was to rename receive_arp_response to
send_arp_packet, which allows for specifying the operation of the ARP
packet (request or response). The function arguments were moved around
to mirror receive_arp_packet.

Change-Id: I815ff437656cdddd0f51f67983df24a95f1e124e

We request that the virtual audio driver notify us every 50ms. If we
don't receive notifications for more than 150ms, it's a sign that the
system is under too much load and tests using audio are likely to have
issues.

Test: Built with threshold set to 40ms to confirm that it fires, then
      swapped it back to 150ms.
Change-Id: I800ae1c3937c2f6ba03e1baea347c32393b11aca

1. Streamlined memory allocations.
2. Fixed ftlmcFlushPage() and ftlmcInCache() to update LRU ordering.

Change-Id: Iedccf0e88fc5abe56db2994a2d46223d010a6b80

Test: time-test

Bug: ZX-3741 #done

Change-Id: I37b0a2e3947ba29b63fa4b1b1f066a9e88231497

The bug in the underlying infrastructure has been fixed.

LE-624 #done

Change-Id: Ib65ef2cc3e98275a3481c93b2a7fed52119b83ee

* //sdk:modular_testing is an SDK that provides testing utilities for
  writing app & integration tests that run under modular. This CL
  bootstraps this SDK with just the runtime necessary to use the
  fuchsia.modular.testing.TestHarness.

* sdk_image.gni now contains the modular_test_harness fuchsia package,
  which is required by //sdk:modular_testing

MF-328

Test: The c++ gtest fixture is tested by test_harness_fixture_test
Change-Id: I3e4944ac25ecf4cf14960d6386ce64e8a2a935d6

Test: No functional changes.
Change-Id: I37e6803d14baa7cd94816bf05686ab5c89cd8be4

This CL contains most of the functionality need to reach feature parity
with the existing implementation of oldhttp. The one notable missing
feature is that this implementation doesn't actually return the body of
the HTTP response.

Change-Id: I94c15a9fac742dde9d058f7c22ab4628ec6d2366

Parts of the build that export data for scenic will start putting
it in the config-data package. In preparation for this, update
scenic to look in both the /system/data path and the config-data
path.

TEST=CQ

SCN-1356 #comment

Change-Id: I01561154ea51fe69e61e55f2b50239cf8e6cd506

* we use a fit::bridge in our LogListener to complete the log collection upon Done(), connection loss or timeout
* the timeout is implemented via a delayed task we post on the async loop that completes the fit::bridge
* we need to share that fit::bridge, otherwise the LogListener could go out of scope (upon Done()) and the async loop is still trying to complete the fit::bridge 10s later

FLX-179 #done #comment

TESTED=`fx run-test feedback_agent_tests -t feedback_agent_integration_test -- --gtest_filter=FeedbackAgentIntegrationTest.GetData_CheckKeys --gtest_repeat=10000` (the issue appears 10s after the first run so usually 1000 times does the trick or manually decrease the 10s timeout)

Change-Id: Idd6bd62938dd9abd3b67a058076a3de6eb1a4f28

Integration tests added in the process.

TEST: Integration test fixture ran in QEMU.

Change-Id: Ifc27cac00a5d9bae9d11da46e9886979b22e5aee

Several shadow techniques previously supported by PaperRenderer "1"
are no longer supported now that PaperRenderer2 is the only option.

TESTABILITY:
The following tests now pass:
( 111 ms )fuchsia.scenic.image_grid_cpp_noclipping_noshadows
( 24 ms )fuchsia.scenic.image_grid_cpp_noclipping_noshadows.catapult_json
( 113 ms )fuchsia.scenic.image_grid_cpp_noshadows
( 24 ms )fuchsia.scenic.image_grid_cpp_noshadows.catapult_json
( 80 ms )fuchsia.scenic.image_grid_cpp_stencil_shadow_volume
( 24 ms )fuchsia.scenic.image_grid_cpp_stencil_shadow_volume.catapult_json
( 50 ms )fuchsia.scenic.image_grid_cpp_x3_noclipping_noshadows
( 29 ms )fuchsia.scenic.image_grid_cpp_x3_noclipping_noshadows.catapult_json
( 39 ms )fuchsia.scenic.image_grid_cpp_x3_noshadows
( 20 ms )fuchsia.scenic.image_grid_cpp_x3_noshadows.catapult_json
( 31 ms )fuchsia.scenic.image_grid_cpp_x3_stencil_shadow_volume
( 18 ms )fuchsia.scenic.image_grid_cpp_x3_stencil_shadow_volume.catapult_json

SCN-1381 #comment

Change-Id: I529bdf69f6fb6870c4ea6e889e7e0630ca9c6d59

Fixes a bug where incremental builds may not publish packages if there are
only contents / timestamp changes to the content files.

Test: build twice, observe null build. touch services.config, observe publish in next build.
Test: manual inspection of depfile to observe correct contents.
Change-Id: I8484e6d9aa36461f2da6aa3248a808e34771c9f3

when one is not supplied in modular config.

- AutoLoginBaseShell will either login as an ephemeral or persistent
"guest" user when launched by basemgr.

- DevBaseShell is explicitly meant to be used in tests, even if the
functionality is similar.

USAGE: specify base_shell=fuchsia-pkg://fuchsia.com/auto_login_base_shell#meta/auto_login_base_shell.cmx and optionally specify base_shell_args=--persist_user

TEST: fx run-test auto_login_base_shell. Test will validate that using auto_login_base_shell
automatically logs in the user to session shell

MF-343 #done

Change-Id: Ice2406ff467cf0ef366236b6c04b831f5fd8a1fb

Clients that need this support should now use device_add() instead of pdev_device_add()
and use composite device support to provide platform device protocol to children of
platform devices.

Now that the platform bus no longer needs to support multiple platform devices
in the same devhost, the proxy side of the driver is now greatly simplified.
The functionality that was provided by DeviceProxy has been folded back into PlatformProxy.
DeviceResources now contains only a single set or resources (rather than a tree)
and the proxy protocol no longer needs a device_id.

Disabled gauss PCIE and hikey960 display drivers, which were the only two remaining
uses of this support, and neither of these drivers are currently in use.

TEST: boot and and run full UI on astro. runtests -t platform-bus-test

Change-Id: Ib248f1ce7be3b08c7ddb4c73ad8bf2766c2613f7

FIDL-606 #done

Improves the ergonomics of fidl::StringView in llcpp.

Also hides the fact that it inherits from fidl_string_t, as casting it
to fidl_string_t would undermine const-safety, due to fidl_string_t
using a non-const data pointer.

Test: No behavior change; compiles.
Change-Id: Id12232962d4090b6b88ae689270e05e9dd926699

- Recent refactor of sandbox_service.cc introduced a flake caused by the
destructor of SandboxBinding being called from another thread, the held
FIDL bindings in SandboxEnv were, consequently, being destroyed in the
wrong dispatcher.

BUG: FLK-195 #done

Offending test was failing once in ~30 runs. Ran test suite > 2000 times
to guarantee fix holds.

Change-Id: Ifa03c66ff8e8cd0991859e4fcd2b6463972d6f59

Use project name instead of project id, preventing the use
of a deprecated API.

TEST=cobalt-client-test

Change-Id: I3bf44d11ae80190882ec71a6a37b0b693411707f

WLAN-1098 #done

Test=hw-sim tests cover this change

Change-Id: If83fdc2de814e52dc36092ddb1fa11f5c4398d9d

Test: existing tests still pass
Change-Id: I680b2c224d18fbcd71e911b33e9a9b91400f97bd

The deleted copies and actions were done so that host tests could be run out of $root_build_dir/host_tests both on the bots and locally with fx run-host-tests. The bots no longer need this and fx now consults tests.json to figure out the location of the tests.

Bug: IN-819 #done.
Change-Id: I6cf1213e68cb5dcbb3e67588978a8b29f90ae167

`fx run-host-tests` relied on all host tests being available in a
single directory. With the consultation of tests.json for host
test locations, this is no longer necessary.

Though it might not be ideal, this preserves CLI of the existing
run-host-tests, with the exception of removing -v for verbosity,
as that may always be passed after `--`.

Test:
fx run-host-tests containers_cpp_unittests cpuperf_raw_printer_test
fx run-host-tests containers_cpp_unittests -- --gtest_filter=VectorBuffer*
fx run-host-tests nonexistent
fx run-host-tests containers_cpp_unittests nonexistent

Bug: IN-849 #done
Bug: DNO-456 #done

Change-Id: Ib3872c86e089f70ae3d11d91cc3d983d17eaac23

Some tests depend on a count of packets sent to client without ACK
accumulating. They send an ACK on startup. In rare cases these ACKS
can arrive late and reset the server's count, resulting in different
behavior than the tests expect and creating a failure.

To fix this, this CL removes the initial ACK so its timing will not
influence the test outcome.

FLK-192 #done

TEST: fx run-test mediasession_tests
Change-Id: I3e8478c08b5843e7645c2876b288252bbf248ba9

LE-618

Change-Id: If657e7b6595554b263233497abdc6485851619d9