Skip to content
Snippets Groups Projects
  1. May 03, 2019
    • Todd Eisenberger's avatar
      [devcoordinator] Make topo paths match devfs paths for composite devices · fef8cdce
      Todd Eisenberger authored
      Without this, the devfs path would include the composite bindpoint and
      the topological path would not.  The topological path has been updated
      to include it.
      
      Change-Id: I8185ae93697bab90361eb6a29ba5c37cea82a1cc
      fef8cdce
    • Aaron Green's avatar
      [build][fuzzing] Re-enable host fuzzers · c21b48dd
      Aaron Green authored
      This CL restores support for host fuzzers by treating them as host
      tools.  When a `fuzz_package` sets `fuzz_host` to true, the package will
      get a dependency on the fuzzers built by the host toolchain.
      
      Bugs: SEC-267
      
      Tests: fx set core.x64 --with //bundles:tests --fuzz-with asan
             fx run-host-test host_fuzzers_test
      
      Change-Id: Ib83b48b7786f1569652aef714d1292bb2bf648c5
      c21b48dd
    • Ankur Mittal's avatar
      [build] Deprecate fuchsia_component · 768abd8b
      Ankur Mittal authored
      Removing its usage from our BUILD files. it would be replaced with a new
      thing in future.
      
      This is part 1
      
      
      CF-749 #progress
      
      TEST=CQ
      
      Change-Id: Ifb2c1abc7a396eebe24fabbef68d0e2fda960634
      768abd8b
    • Derek Gonyeo's avatar
      [docs] add documentation for program.args field in CMX schema · 2555e69d
      Derek Gonyeo authored
      Change-Id: If7cc2f797fc983e1f8f71f9ae4c33c2bd855dbac
      2555e69d
    • Shac Ron's avatar
      [ahci] unsigned portnum and misc fixes. · f483d6d8
      Shac Ron authored
      Convert port numbers to unsigned.
      Time math macroized.
      Replace asserts with ZX_DEBUG_ASSERT.
      Fix an errant free().
      
      Change-Id: I2da53ab90157606aee1ea3d513e6f72120b22dc1
      f483d6d8
    • Gianfranco Valentino's avatar
      [zircon][cobalt-client] Virtualize collector. · cb743785
      Gianfranco Valentino authored
      Make collector a BaseClass with virtual methods, this will allow
      injecting fakes for testing.
      
      TEST=cobalt-client-test
      
      Change-Id: I7ff5c05293eaa71cf30a5b7cfca824f93cb3391f
      cb743785
    • Adam MacBeth's avatar
      [scripts][git] Fix git-file-tidy · a225d5d7
      Adam MacBeth authored
      Make the script define its own paths rather than relying on paths set by external scripts.
      
      Change-Id: Id3d65ce1df6fead9b34d140764ac65de29a0d1c0
      a225d5d7
    • Allan MacKinnon's avatar
      [graphics][compute] Make the 'glslangValidator' GN target compile. · 56d74218
      Allan MacKinnon authored
      The glslangValidator executable target never compiled because if
      ENABLE_OPT is not defined and set to 0, then the expectation is that
      the SPIR-V optimizer is also being linked in... which it isn't.
      
      Change-Id: I2e945801b2227578e103058d0d3cda1c390eb6ce
      56d74218
    • Dan Johnson's avatar
      [amber] Implement fetching packages via OpenRepository · 9f928cd4
      Dan Johnson authored
      Bug: PKG-662
      Change-Id: Iaa064b77cd4a7a65fdfd22c282de7364cfe328a0
      9f928cd4
    • Robert Lord's avatar
      [text][hw-ime] Retry on BadRevision · f88ea038
      Robert Lord authored
      When the default_hw_ime gets a BadRevision response to CommitEdit, it
      will now queue that edit and retry after getting an OnUpdate event.
      
      Change-Id: I232ef43651f8a1ee56006aee0996eba079d01bb6
      f88ea038
    • Tamir Duberstein's avatar
      [netstack] ignore checksum offload capability · db649740
      Tamir Duberstein authored
      This capability was split into TX and RX upstream and renamed, so
      removing it is needed to bump upstream without a breaking change. Since
      we don't expose checksum offload, this is harmless.
      
      Change-Id: I68853e21a4de2f484f950eb62d91f9ce3fff0982
      db649740
    • Marie Janssen's avatar
      [audio] Fix typos, reformat tables · 2c11ea71
      Marie Janssen authored
      Change-Id: Ie8897199db81196da11c32c70e9d742b71875439
      2c11ea71
    • Yifei Teng's avatar
      [build] [llcpp] Allow standalone usage of llcpp without C bindings. · fe0e5b65
      Yifei Teng authored
      Previously, the GN templates for llcpp incorrectly assumed the existence
      of C bindings, causing missing symbols error at link time when the C
      bindings is not present. This change incorporates the necessary
      generated files into the llcpp target.
      
      Test: Add fuchsia-io:llcpp to a target that does not import
      fuchsia-io: c, and builds. E.g. this case
      https: //fuchsia-review.googlesource.com/c/fuchsia/+/273533
      Change-Id: I5469b24698df028701cf69d6e601ebe957c99b70
      fe0e5b65
    • Ruchira Ravoori's avatar
      [cleo]Fix Device enumeration test - PART2 · 3ff5476e
      Ruchira Ravoori authored
      One of my changes needed device enumeration test. The test has gone
      stale since the paths have changed. This change fixes the issues.
      
      Test: runtests -t device-enumeration-test succeeds now.
      
      Change-Id: I3ea8564754378e17e699e1fe83db862a5f7c2db9
      3ff5476e
    • Miguel Flores Ruiz de Eguino's avatar
      [rust][inspect] Add Heap implementation · 16e7fb3b
      Miguel Flores Ruiz de Eguino authored
      TESTED=fx run-test rust-crates-tests -t fuchsia_inspect_lib_test
      
      Change-Id: I082607d91c4a52925d60eeb2368800906c75c35e
      16e7fb3b
    • Erick Tryzelaar's avatar
      [system-ota-tests] Switch to consuming packages.tar.gz · c30d780d
      Erick Tryzelaar authored
      Previously, infra tried to pass in the amber-files produced by
      the build into every test, but this was consuming too much
      space. Instead, this patch switches the system ota tests to
      consume the packages.tar.gz that's produced by the build.
      
      Change-Id: I42e683d4b39f43544d755c8754649309c72de61b
      c30d780d
    • Ankur Mittal's avatar
      [libvfs] Pseudo file's writefn should return a status. · 79293134
      Ankur Mittal authored
      That status is now passed into fuchsia::io::file#Close call if write
      fails, but File is still closed.
      
      TEST=Existing tests
      
      Change-Id: Id7d2e4c21a1fe1cd822939ca2bb7c4b841156b84
      79293134
    • Yifei Teng's avatar
      [fidlc] Deduplicate fidlc arguments by behavior and path · 3a1a5ca3
      Yifei Teng authored
      Previously, a second flag of the same type will silently override the
      first e.g. --table A.cc --table B.cc would result in fidlc emitting
      the coding tables into B.cc, and create an empty file at A.cc.
      
      This patch changes fidlc to support multiple outputs of the same type.
      It is a necessary step for use cases in zircon, where one could have
      one of 1. only C binding, 2. only llcpp, 3. C + llcpp.
      
      TEST: 1. Manually run fidlc to make sure it supports multiple outputs.
      2. Tested with llcpp in the next patch in the stack.
      
      Change-Id: Ia4d18998752c86d28a66c7a514bf43e44bb9da84
      3a1a5ca3
    • John Grossman's avatar
      [futex][trace] Add ktrace events for futex ops. (kernel) · 2d351c53
      John Grossman authored
      Add ktrace events for the 4 main futex operations.  Default them to be
      off at compile time for now.
      
      Note: this CL only adds trace definitions and tracing behavior to the
      kernel.  To make any use of these events, a follow up change which
      implementes the trace importer behavior is needed.
      
      Change-Id: Ia31d42234ac1cda1d66091cf56e7a8447e58facb
      2d351c53
    • Christopher Tam's avatar
      [tee][optee] Bring in ta_storage.h from optee_test · e2e34433
      Christopher Tam authored
      This change adds ta_storage.h from the optee_test suite. This defines
      the values expected by the storage test trusted application, and can be
      used in a client application to test OP-TEE RPC compatibility on
      Fuchsia.
      
      Test: No behavioral change. This is just a third party header from the
      optee_test suite that is needed for client-side code to properly
      interface with a certain application in the trusted world.
      
      OSRB-175 #done
      
      Change-Id: I0439aa8a05d92d0ac40e72b09ce3c07088625885
      e2e34433
    • Justin Mattson's avatar
      [fonts] Remove system_image path · f60693a4
      Justin Mattson authored
      All builds now use the config-data package to provide fonts, stop
      reading the system_image path.
      
      SY-999 #done
      
      TEST=font_provider_test
      
      Change-Id: Ib1eaa1fdd46a3aac2dd8b0a57adec773cef2b0f5
      f60693a4
    • Derek Gonyeo's avatar
      [docs] add note that pkg-config package is needed to rust/third_party · e0f3f2b9
      Derek Gonyeo authored
      The `fx update-rustc-third-party` command will fail to find the local
      openssl libraries needed to update the openssl crate if the `pkg-config`
      package is not installed.
      
      Change-Id: I488539ef8441648b348cd5f80a16581d98c8e30a
      e0f3f2b9
    • Leo Lung's avatar
      [run] Output matched fuchsia-pkg URL · b30d6025
      Leo Lung authored
      Change-Id: I7dcc778dd9f894d002042290fcd5125648bb8896
      b30d6025
    • Dustin Green's avatar
      [amlogic-video] VP9 HW decode works again · 10969966
      Dustin Green authored
      While we're not currently using HW decode for VP9, with local diffs it
      works, or rather, did work, until my recent sysmem plumbing.  With this
      change, only the previous set of local diffs are required for VP9 HW
      decode to work locally.
      
      Re. Testability-Review, currently the changed code is not covered in CQ
      because of the local diffs required for VP9 HW decode (feel free to ping
      me oob re. why), and because no amlogic-based HW target is auto-included
      in CQ.  This situation should improve fairly soon.
      
      This CL also adds use_vp9_decoder_test which is analogous to
      use_h264_decoder_test (and shares much of the code), but currently
      neither is on CQ.
      
      Tested: use_vp9_decoder_test added, use_media_decoder --vp9 (with local changes for HW vp9 decode)
      Change-Id: I43a92fefbd52cd1496c026ac3e0e4144be6fdee6
      10969966
    • Derek Gonyeo's avatar
      [bundles] add //examples to //bundles/buildbot:core · 6c500ed7
      Derek Gonyeo authored
      Change-Id: I2cd2a2f35ea974a0c763b23c04f0c14bd359fcf8
      6c500ed7
    • Robert Hahn's avatar
      [wlanif] Fix buffer overrun · 391ea142
      Robert Hahn authored
      WLAN-1120 #done
      
      Test=Included regression test
      
      Change-Id: Iaefb5f1f311da9ab43fb6b0241554250f9693705
      391ea142
    • Aaron Wood's avatar
      [omaha-client] common::App::new and related cleanups · 47e2042d
      Aaron Wood authored
      Some suggested cleanups in earlier code that was caught in a more recent
      code review.
      
      A) This adds an App::new<I, V>(I, V) -> Self constructor and
      a similar one called ::with_fingerprint().  These use type parameters
      and Into<String> and Into<Version>, and as a result, allow for much
      tidier code when constructing an App.
      
      B) This switches a list traversal to a functional .find() call in the
      RequestBuilder.  Which again, tidies things up.
      
      Bug: PKG-679
      Test: fx run-test omaha_client_lib_tests
      
      Change-Id: If0b595355b2578be43e12722b1b9307496db91fa
      47e2042d
    • Robert Hahn's avatar
      [wlan][driver] Use SME channel in WLAN drivers · 25d6d7c4
      Robert Hahn authored
      None of our vendor drivers supports SME channel yet and thus.
      the introduced code path is not yet exercised.
      
      WLAN-927 #comment
      
      Test=Sanity check broadcom and ath10k
      
      Change-Id: I28236150be548a165c1aec7b5dc341bddf5b007d
      25d6d7c4
    • Christopher R. Johnson's avatar
      [third_party] Itertools 0.7 -> 0.8 · 6869016d
      Christopher R. Johnson authored
      Change-Id: Ic8aff5ffd1e76c26a388a8bdeb80bf3677eb19d4
      6869016d
    • Mukesh Agrawal's avatar
      [bt][l2cap] ERTM TxEngine: add failure callback · d5a6b3b6
      Mukesh Agrawal authored
      After exhausting retries for the receiver-ready poll message, we'll
      need to close the L2CAP channel. As a step towards that goal, add a
      failure callback to the ERTM TxEngine. The creator of the Engine will
      be responsible for closing the channel when this callback is invoked.
      
      Bug: BT-442
      Test: bt-host-unittests
      
      Change-Id: Id462dea7556747c0e46ef20b71f33961b3e82fee
      d5a6b3b6
    • Pascal Perez's avatar
      [fidlc] Include mask in bits declrations · 85e8cba1
      Pascal Perez authored
      FIDL-616 #comment
      
      Change-Id: Ifca16426974b487555e46fd85334bb0515e75c53
      85e8cba1
    • docs-roller's avatar
      [gndoc] Update GN build arguments documentation · 3c06c397
      docs-roller authored
      Test: CQ
      
      Change-Id: I02ae1be7d43a7b57424cf6a44d47229b65d7efb1
      3c06c397
    • Bryan Henry's avatar
      [bootsvc] Split tests into unit and integration tests · 45874bde
      Bryan Henry authored
      Test: fx --dir out/x64 build && ./zircon/scripts/run-zircon-x64 -o
      out/x64.zircon -c
      "bootsvc.next=bin/bootsvc-integration-test,testargument"
      Test: run-zircon and then ran 'boot/test/sys/bootsvc-unit-test'
      
      Change-Id: Ica64d67bbd9bdaa95c6500a9c2dd099e4281b2e7
      45874bde
    • Adrian Danis's avatar
      [x86][hypervisor] Save and restore superset of extended registers · 0f5c7bbd
      Adrian Danis authored
      Changes the existing extneded register save and restore logic to always save and restore
      the full set of potential states and not states that the guest currently has enabled.
      
      Currently the host can be made to panic if the guest enables a state, and then later
      disables it. Sequence of guest operations for the panic is added to the hypervisor
      unit test.
      
      This panic occurs as when xsave occurs any state present in xcr0 is saved. If xcr0 is
      then reduced and xsave runs again this does not remove the previously saved state from
      the xsave region or the XSTATE_BV field in the header. Performing an fxrstor then panics
      as XSTATE_BV has state bits that are not set in xcr0.
      
      Two potential alternate solutions for fixing this are
       1. Manually removing now unused state bits from XSTATE_BV
       2. Make guest xcr0 bits 'sticky' and once enabled keep them enabled
      
      Both of these solutions are more complex and compete with existing hardware optimizations
      of not saving and restoring state that hasn't changed.
      
      Test: hypervisor unit tests + guest integration tests on NUC + qemu
      
      Change-Id: I8c6b3e972800fde48c0aa6283c60d8796bf864aa
      0f5c7bbd
    • Bryan Henry's avatar
      [bootsvc] Support process arguments for bootsvc.next · 77142b7d
      Bryan Henry authored
      Update bootsvc.next to support optionally specifying arguments to the
      process launched by bootsvc, delimited by commas.
      
      Note that the bootsvc tests still only run manually, though we are
      investigating running them automated on CQ similar to the core-tests.
      Tracked in ZX-4000.
      
      ZX-3662 #done
      ZX-4000 #comment
      
      Test: fx --dir out/x64 build && ./zircon/scripts/run-zircon-x64 -o
      out/x64.zircon -c "bootsvc.next=bin/bootsvc-tests,testargument"
      
      Change-Id: Iecfdf22be93c8d0893ffc1b58d541a2b3ad7e97c
      77142b7d
    • Casey Dahlin's avatar
      [debugger] Use BuildID field to get minidump build IDs · 219ebdd3
      Casey Dahlin authored
      This is the end of the truncation madness. We're no longer stuffing GNU
      build IDs into a Microsoft UUID field. We get the whole, correct build
      ID every time. (Unless your crash came from a release before today, in
      which case we're now pretending you don't exist).
      
      Change-Id: I89567f399ff32db933350be8705ec0d79fa71619
      219ebdd3
    • Erick Tryzelaar's avatar
      [gn] go_binary and go_library should support testonly · 8af85d4b
      Erick Tryzelaar authored
      Change-Id: I5d81f8021f51a09f98f1e335280bde0ea1d4f367
      8af85d4b
    • Justin Mattson's avatar
      [fx][netboot] Include SSH keys in ZBI · 3836f7fb
      Justin Mattson authored
      Include the default keys from $FUCHSIA_DIR/.ssh
      
      DX-1308 #comment
      
      TEST=build, 'fx netboot', verify 'fx shell' works
      
      Change-Id: I299c4648302f205a1d5cb2d05468e7f0ac21c531
      3836f7fb
    • Casey Dahlin's avatar
      [debugger] Save and restore auth info · e2b2089d
      Casey Dahlin authored
      Change-Id: I7ee0f6c26007edcd5320c9998f966f2a289b5af1
      e2b2089d
    • Kendal Harland's avatar
      [infra] Add specs for most ci,try builders · ae7b153c
      Kendal Harland authored
      These files were generated using:
      https://fuchsia.googlesource.com/tools/+/refs/heads/sandbox/kjharland/fuchsia-proto-migration/cmd/generate_spec_files/
      
      (some files failed because there's not been a green build or there was some other error.
      I'll need to manually add those).
      
      This change MUST be submitted after http://fxr/277564.
      
      Bug: IN-1102 #comment
      Change-Id: I0a2f6dab69222c81e2b8a9a74b3c08cb28ac175a
      ae7b153c
Loading