Make /dev/misc/dmctl not writeable, remove code handling string parsing.

Test: {Qemu, Frank}: "dm" handles invalid code, writing to dmctl does nothing.
Change-Id: I6d14ce37963dfd87ba6a12d2decb6ef1e0767dd5

Instead of virtualizing the Collector, which only sees a metric as a
flushable and requires less legible ways for verification, provide a
test-only InMemoryLogger class which exposes the necesary internal types
within its class namespace and keeps tracks of the logged data.

TEST=cobalt-client-test, cobalt-client-unit-test

Change-Id: Ib67cb90f3b974a61ebe5fada424dd4b4a27cb1cb

TESTED=updated and ran a test that uses this.

Change-Id: I3aa36bb82c1e9fb8b56ce1ec0a6a58e91c5c5bca

- The test was making it onto release builds which is not what we want.

Change-Id: I1d82cd23906103dd640a24c21311ed6ccb2d4d05

the most recent flake instance revealed that LogMany() was never called
with no messages, but Done() was indeed called when logs_ is still
empty. These new warnings will help us figured out if Done() was called
before any calls to LogMany() or if it might be some race between
LogMany() and Done().

FLK-179 #comment

TESTED=`fx run-test feedback_agent_tests -t log_listener_unittest -- --gtest_filter=CollectSystemLogTest.Fail_LoggerNeverCallsLogManyBeforeDone`

Change-Id: I1954d9e55247cc21b6e07a713ba700cd877f021c

This creates a unit-tested equivalent of WriteTxn::Flush().

Change-Id: I15e407b652282ab2d0360576c3436aa2836fb4cc

Change-Id: I97eb007f63891fb9d45c3b7eac4321cbc6e8918e

this is to make the upcoming test cases easier as we will create multiple requests in one test case

TESTED=`fx run-test feedback_agent_tests -t feedback_agent_integration_test`

Change-Id: Ic05a07a4e3bea1f55b5d9a7ebc698fc78b4c6979

brcmfmac tests should be considered as part of the wlan tests, not
garnet.

TEST: fx run-test brcmfmac_test
Change-Id: I1a9075ffff2b668ab16f9e5eaae29f2ce167603e

Instead of using Arc<Mutex<Realm>> everywhere, move the mutex to the
internals of the Realm struct and only lock it when accessing mutable
data.

Change-Id: I4e8a745104e26c4f0555e1c5577d05a6fa52403e

Tested: No functional change, ldso breakpoints covered by process_unittest.cc.

Change-Id: Ia393279966270b277eefe9a4c4ad020c863a4c01

TESTED=
1. curl -v -X GET 192.168.42.235 -d '{"id": "", "method":
"setui_facade.Mutate", "params": {"account": {"operation":
"set_login_override", "login_override": "auth_provider"}} }'
2. changed an sl4f-based test to use this.

Change-Id: I54b6d7e50af6faa2eaf0397c44926322de814d8e

This avoids issues related to filtering README.* files.

PiperOrigin-RevId: 247100002
Change-Id: I2f06db19b95764aae46975b5dba68a6959cad5e8

this is breaking flutter_screencap_test
TEST=CQ

This reverts commit b209917d.

Change-Id: I561ab911abe7ae54481719cb9a80fd5feb8b051a

This reverts commit 4d833f15.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Revert "[ahci] Port memory configuration math cleanup."
> 
> try revert and check if this is making zircon builders timeout
> 
> This reverts commit 157b4786.
> 
> Reason for revert: <INSERT REASONING HERE>
> 
> Original change's description:
> > [ahci] Port memory configuration math cleanup.
> > 
> > No functionality changes.
> > 
> > Replace pointer math with easier to follow structure describing the
> > port command memory layout.
> > 
> > Test: blktest
> > Change-Id: Ia85bce4224e20497da51e4bee6fb962cfb54a986
> 
> TBR=smklein@google.com,qsr@google.com,sron@google.com,auradkar@google.com
> 
> Change-Id: I555908e7ba0e8ee1b84935ded01284034f4ecea7
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true

TBR=smklein@google.com,anmittal@google.com,qsr@google.com,sron@google.com,auradkar@google.com

Change-Id: I2d43c5f23ff938282ba018a449ad52274f6ef8d8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

try revert and check if this is making zircon builders timeout

This reverts commit 157b4786.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [ahci] Port memory configuration math cleanup.
> 
> No functionality changes.
> 
> Replace pointer math with easier to follow structure describing the
> port command memory layout.
> 
> Test: blktest
> Change-Id: Ia85bce4224e20497da51e4bee6fb962cfb54a986

TBR=smklein@google.com,qsr@google.com,sron@google.com,auradkar@google.com

Change-Id: I555908e7ba0e8ee1b84935ded01284034f4ecea7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

format-code's default mode of `--git` current determines which files
have been modified by using `git diff-index`. `diff-index`, however,
returns not only files that have been modified since the base commit,
but also files that don't have the expected modified time on disk. (For
example, any file that has been touch'ed). This leads to more files
being formatted than expected, such as in workflows such as the
following:

  sed -i -e s/foo/bar/ *.cc
  fx format-code

which will result in all C++ files being formatted, and not just those
modified.

This patch updates format-code to simply use `git diff <BASE_COMMIT>`.
When a base commit is provided, git diff returns (i) committed results;
(ii) staged results; and (iii) files modified in the working directory.
This should match the current behaviour of `fx format-code --git`.

Change-Id: Ie3bcac4322bd2cc4ba64b0f440fae5d76ff94b33

Removing test stubs so they don't appear in test output.

Test: fidl-compiler-test
Change-Id: Ia4223b91704dddb6cb8d3abcdf94107ba7a4ebcf

Tested: CQ; no behavior changed

Change-Id: Ieebd7472f57c4f16a5f4172a0aca940be7e3eeb9

- Deleted garnet/lib/auth entirely since it only contains metadata.
- Updated source paths in README files.
- Replaced redundant BUILD-directives on the form `foo:foo` with `foo`.

AUTH-196 #comment

Tested: Existing coverage
Change-Id: I352650b33e478abf81450fcc2ba878eb8bce2ec3

Bug: PKG-676 #comment Make fuchsia_merkle::hash::Hash public

Change-Id: I600e9a140dcf07d5af72026b1d11d572e56560d4

Tested: modular_tests, started story in sysUI
SCN-1018 #comment
SCN-1291 #comment

Change-Id: I1fe7fbad2de2caf90bb359f1922e0d1978170916

Tested: No behavior changed
SCN-1391 #comment

Change-Id: I6dc0bceca120a8eb093244f6ff56ac5878309f92

Make verbosity configurable by adding the -v flag to increase

TEST=1. fx syslog --tag bt-snoop --verbosity 1
     2. fx shell run fuchsia-pkg://fuchsia.com/bt-snoop#meta/bt-snoop.cmx -v

Change-Id: I3898548f7c6d7ff51792e9db85b198c1d2b72a60

ELAPSED_TIME in cobalt is the appropriate metric for this situation and
has added support for all the features we need to make the switch.

BT-809 #done
TEST=1. fx shell run fuchsia-pkg://fuchsia.com/bt-a2dp-sink#meta/bt-a2dp-sink.cmx
     2. Stream audio from peer.
     3. Metrics are emited and accepted by cobalt logger on test device.

Change-Id: I961b986fced243066727df855c5d6c58bf34246b

SCN-1375 #blocked by (ZX-4025)

Since this test is blocked, it is disabled but can still be merged to
master in its disabled state.

Verified that test is working by visually inspecting the color correction being applied as it ran on hardware.

Change-Id: I7fa58c64eea0689425e859970dffda84ae30db39

This removes the dynamic library dependencies on the C++ standard
library and the fostr library from appmgr to partially resolve
dependency cycles when booting up the system.  With this change, the
only shared library dependency remaining outside of the bootfs is
libfxl_logging.so, which stores a static log level.

By itself this patch has no behavior change in the system.

DNO-492 #comment remove most shared library deps from appmgr

Change-Id: I31394945f62e3ccff4bf61e80daa41b139913e7c

I landed two CLs in parallel without thinking about a dependency between
them. To avoid breaking ToT, I immediately reverted the second one (this
one). This CL relands the change along with two lines that address the
merge conflict.

This CL moves the media source code out of garnet/public/lib/media/audio
and garnet/public/lib/audio_dfx, into sdk/lib/media/audio/cpp and
sdk/lib/media/audio_dfx/cpp. This is in accord with previously-agreed-upon
source layout plan. There should be no behavior change to product or tests.

Test: no behavior change

MTWN-278 #Done

Change-Id: I4fa08b72e267ea9a0697540034cccfb0edf83f7d

Adds a register vector to the stack frame record that is sent from the
debug agent to the client. This will be used in the future to send known
register values for each stack frame along with the backtrace. Currently
the register values are unused.

Add more constructors and comparison functions to StackFrame and
Register to help testing. Update some tests to use these new functions
to improve readability.

Change-Id: I7c25f3fabdd153ff36877d9ddc26a59a2db5ad53

The current build is uploaded to the BUILDBUCKET_ID bucket before
the tests are executed. This patch adds support for downloading
that version to make sure the old build can upgrade to the one
we just built.

Change-Id: Iec1e8edc3388f054deb0b22aa54124f272607327

Extrapolator for unaligned timestamps.

TEST: fx run-test timestamp_extrapolator_tests
Change-Id: Id1e56bb8f9d7ece72f5840e9d1e2c655c6fbeaf7

Devfs will soon start returning not found when trying to open paths that
don't exist. This test previously relied on a quirk where devfs would
close the channel without describing the error.

Change-Id: Icd12ac1f1b743c383617449f0eb62657c1b7c883

Change-Id: I142d4d2fba22860d5fdc3541bdf7007323049958

No functionality changes.

Replace pointer math with easier to follow structure describing the
port command memory layout.

Test: blktest
Change-Id: Ia85bce4224e20497da51e4bee6fb962cfb54a986

This is safe to land now that all of the SDK clients have been prepared.

Tested: No behavior changed; modular_tests, started story in sysUI
SCN-1018 #comment
SCN-1291 #comment

Change-Id: I4fa36b878e2188651b050654af31d0716cbed94a

The sort in ParamsToJSON wasn't needed anymore (it was only needed when
current offset was used).

fx run-test fidlcat_tests
[==========] 50 tests from 2 test suites ran. (81 ms total)
[  PASSED  ] 50 tests.

Change-Id: I3a75a1adda7812ad2a7398a906259b51156f91b4

Addressed Kevin's recommendation in prior CL. Opportunities to refactor
into helper functions was limited, in my opinion.

I focused only on the last two test methods. I factored out a
couple of small code chunks, but more importantly, I reordered the setup
stages in a common order, across both test functions, and added comments
to explain the purpose of each step, highlighting what is unique.

Test: No behavior change

Change-Id: I823d265bd1a75695b324c99a0964ea4205c08d69

Disable test_oldhttp because it frequently times out on CQ.

Bug: FLK-217 #comment disable test
Change-Id: Iaa9629a71490f564116133d28af9f68495abc787

Change-Id: I093ade25c8f0bfc499d2c2eff458008cebca3813

... AddEvent() will already flag the error.

Change-Id: I929f896a24182735c34652ab170b49c66b5c1eee