Skip to content
Snippets Groups Projects
  1. Jul 04, 2012
  2. Jul 03, 2012
    • Shane Tomlinson's avatar
      Merge pull request #1888 from mozilla/frontend_tests_not_finishing · 8d61e325
      Shane Tomlinson authored
      Fix the front end tests not completing.
      8d61e325
    • Shane Tomlinson's avatar
      Removing @benadida's change to make the provisioning mock's setStatus... · fa772f43
      Shane Tomlinson authored
      Removing @benadida's change to make the provisioning mock's setStatus asynchronous.  Instead of generating the key whenever the status is set, generate the key whenever the user is being provisioned.  Since the mock uses jwcrypto which must be seeded, seed jwcrypto with some bits.  This more closely matches what a real RP would do.
      
      In the unit tests, any asynchronous calls to provisioningMock.setStatus have been make synchronous.
      
      In user.js, syncEmailKeypair, since jwcrypto depends on there being a seed to generate a keypair, call network.withContext which ensures there is a seed.
      fa772f43
    • Shane Tomlinson's avatar
      Fix the front end tests not completing. · 02f1a907
      Shane Tomlinson authored
      The changes to wait for entropy from the backend were not expected on the front end tests.  Now before trying to get a certificate for a primary, make sure "session_context" has been called.
      02f1a907
  3. Jul 02, 2012
    • Lloyd Hilaiel's avatar
      Merge pull request #1894 from mozilla/issue_1893_undefined_email · 27b72794
      Lloyd Hilaiel authored
      Send the email address to the "check_registration" controller when starting.
      27b72794
    • Shane Tomlinson's avatar
      Merge pull request #1879 from sawyerh/issue_1093_button_spinners · f841720e
      Shane Tomlinson authored
      Fixes for issue #868 and issue #1517 and styles/assets for issue #1093
      
      @sawyerh - great work on this.  For the future, it is *much* easier to review pull requests that focus on exactly one item.  This would have been easier to review had it been 3 PR's - one for the spinner, one for the iPad update, and one for the button styles - this is something I am working on myself - @lloyd calls me out on it frequently.
      
      Once I updated the frontend unit tests to include the front-end test branch, all ran as expected.  I manually tested the dialog displayed correctly in the iPad sheet program @st3fan produced, Android 2.3.5 native, Fennec Android 2.3.5 mobile phone, Android 4.0 native, Fennec Nightly on Android 4.0, Chrome on Android 4.0, Opera Mobile on Android 4.0, iOS 5 iPod, and iOS5 iPad.
      
      The loader gif still needs hooked up - but it looks great on our buttons.
      
      close #868
      close #1517
      issue #1093
      
      r+
      f841720e
    • Shane Tomlinson's avatar
      Send the email address to the "check_registration" controller when starting. · e5f3d51b
      Shane Tomlinson authored
      * Check for the required fields "email" and "siteName"
      
      issue #1893
      e5f3d51b
  4. Jul 01, 2012
  5. Jun 30, 2012
  6. Jun 29, 2012
Loading