Skip to content
Snippets Groups Projects
  1. May 30, 2012
  2. May 24, 2012
  3. May 23, 2012
  4. May 22, 2012
  5. May 18, 2012
    • Shane Tomlinson's avatar
      Yak shave for interaction_data. Ensure timestamp, lang, etc are always sent in interaction data. · eb545b49
      Shane Tomlinson authored
      * Removed the .interactionData namespace from storage.js, created our first model - shared/models/interaction_data.js
      * Simplified how data is stored into interaction_data, created current and staged sub-namespaces
      * Added stageCurrent and publishStaged functions.
      * in shared/modules/interaction_data.js, simplified calls to model.
      * Tried to make the xhr mock make more sense and provide facilities usable for peeking at last XHR request data.
      
      issue #1597
      eb545b49
  6. May 15, 2012
  7. May 04, 2012
  8. May 02, 2012
  9. Apr 27, 2012
    • Shane Tomlinson's avatar
      Change the order of assertion generation to be after the user is asked "is this your computer?" · be035ba2
      Shane Tomlinson authored
      * This fixes a problem where it is possible that a user takes more than 2 minutes to answer, making the already generated assertion invalid.
      * A lot of general cleanup of the state machine.
      * Push all post email selection flows to a new state, "email_valid_and_ready" which decides whether to ask the user the computer ownership status.
      * Assertions are generated after the "is this your computer" is asked.
      * doEmailChosen is replaced with doGenerateAssertion - there were multiple calls to generate an assertion, not very DRY.
      * Fix a problem in network.js where a user who completes user registration should be marked as authenticated.
      * rename email_chosen.js to generate_assertion.js to clarify its purpose.
      
      issue #1460
      be035ba2
  10. Apr 19, 2012
  11. Apr 12, 2012
    • Shane Tomlinson's avatar
      Visual updates to make secondary action links be more consistent. · 0d3073ce
      Shane Tomlinson authored
      * Secondary links all are some shade of dark grey/black with a dotted underline.
      * Change the font used on the "about" page to be the standard Helvetica Neue except for the header.
      * Change the style of link in the TOS/PP to black text with a dotted underline.
      * Loads more link updates!
      * A lot of cleanup to remove duplicate `color: #549fdc` entries by using the action class.
      * On the main site, put the action links to the far left of the main button.
      * Reduce the amount of "forgot password" CSS by generalizing.
      * Generalize the yellow banner on the main site.
      
      issue #702
      0d3073ce
    • Shane Tomlinson's avatar
      A bunch of changes to make the design more responsive to all screen sizes -... · ea5ce6ca
      Shane Tomlinson authored
      A bunch of changes to make the design more responsive to all screen sizes - mobile, desktop and tablet.
      
      * Start with a slight refactor of the CSS and DOM.
      * Vertical center content when content is smaller than the screen size.
      * Constrain email addresses and show ellipsis if emails overflow box width.  Make sure width is updated when browser window size changes or user changes the screen direction of their device.
      * If form/email address list is taller than available form area, show scroll bar on desktop or expand contents so that entire app must be scrolled on mobile.
      * If dialog opened on a tablet or large desktop window, add a gradient to the left size of the white area that matches the gradient on the arrow.
      * On mobile, footer should always be at the very bottom of the screen unless contents overflow screen height, where it will be pushed off the bottom of the screen.
      
      Things to test and be aware of:
      * Dialog should respond to various screen sizes when resizing browser window on desktop.
      * IE8 does not support media queries so narrowing the browser window will not force the dialog into "mobile" mode.
      * Contents in the "form area", wait, delay, or error screens should always be vertically centered.
      * IE6/IE7 should still see the unsupported dialog with the correct layout (untested on checkin due to #1390)
      * Wide emails should always be constrained to the screen width on mobile or box width on desktop.  The layout should respond to changes in device orientation.
      * The box surrounding the emails should show a scroll bar on desktop/tablet if there are more emails the available screen height.  On mobile, the entire screen height should expand so that the entire app must be scrolled.
      * On mobile, the footer should always be at the very bottom of the screen unless the form area takes up more vertical space than the device height.
      
      issue #1101
      issue #1317
      ea5ce6ca
  12. Apr 11, 2012
  13. Apr 06, 2012
  14. Apr 05, 2012
    • Shane Tomlinson's avatar
      Change Password fixes. · 911ba4b9
      Shane Tomlinson authored
      * Show a tooltip if the passwords are the same.
      * Clear old and new passwords if the password is successfully changed.
      
      issue #1388
      issue #1389
      911ba4b9
  15. Mar 28, 2012
  16. Mar 16, 2012
    • Shane Tomlinson's avatar
      Some light cleanup and refactoring. · c2af660b
      Shane Tomlinson authored
      * Add a unit test harness for is_this_your_computer
      * When the user authenticates, set them as seen.
      * In storage.js, Use an object to store the usersComputer info instead of arrays for developer grok.
      * Add storage.js->clearUsersComputerOwnershipStatus for testing.
      * Clean up user.js->logout a little bit.
      * Completely clear localStorage between every test.
      * Add tests to check for when the user should see the "is this your computer" screen.
      c2af660b
  17. Mar 14, 2012
  18. Mar 13, 2012
    • Shane Tomlinson's avatar
      A whole bunch of changes to get the layout to work on mobile, i18n, etc. · 124b7f17
      Shane Tomlinson authored
      * Change the layout so that the entire form area gets the scroll bar for languages that use a lot of text or if the user has a lot of email addresses.
      * Change the way the privacy policy and buttons are rendered so JS is not needed to set the width of the privacy policy.
      * Put the TOS on its own line.
      * Put "Always sign in using this email" on its own line
      * Change the order of the "Forgot your password?" button and "password" label so that Germanic languages render the entire thing on one line.
      * Remove the "Sign in using" header text.
      
      issue #1300
      issue #1286
      issue #1275
      issue #1274
      issue #1272
      issue #1262
      issue #1261
      124b7f17
  19. Feb 24, 2012
  20. Feb 22, 2012
  21. Feb 21, 2012
  22. Feb 20, 2012
    • Shane Tomlinson's avatar
      Removing the href/target attributes from translated anchor tags. · 9e30274e
      Shane Tomlinson authored
      Instead, translators will see a %s and the href and target attributes will be added dynamically.
      
      issue #1160
      9e30274e
    • Shane Tomlinson's avatar
      Fix the pick_email test failure when all tests are run. · 8d63cf25
      Shane Tomlinson authored
      The problem stemmed from the DOM was not completely reset between every test.  When the manage page inserted email addresses into its portion of the DOM, it added email addresses with elements with the same ID as the pick email controller.  Instead of ensuring we clean wipe these elements between every test, rely on QUnit's ability to reset a portion of the DOM to its initial state.
      
      * Add the `qunit-fixture` class to the bit of DOM that should be reset between every test run.
      * Add the testHelpers.setup/testHelpers.teardown functions to several suites that manually called emtpy() on DOM elements.
      
      issue #1156
      8d63cf25
  23. Feb 17, 2012
  24. Feb 16, 2012
Loading