Skip to content
Snippets Groups Projects
  1. Apr 23, 2016
  2. Apr 22, 2016
    • Wouter van Oortmerssen's avatar
      Merge pull request #3850 from pjulien/3849 · a0d1161f
      Wouter van Oortmerssen authored
      Fix for #3849
      a0d1161f
    • Wouter van Oortmerssen's avatar
    • Wouter van Oortmerssen's avatar
      Fixed a verifier check that didn't return from its parent. · c17cf022
      Wouter van Oortmerssen authored
      Change-Id: I1aef5fdba72de0c3bb8276c9f50fffa494f26e29
      Tested: on Linux.
      c17cf022
    • Wouter van Oortmerssen's avatar
      Fixed SkipByteOrderMark advancing cursor_ too early. · f6330ab8
      Wouter van Oortmerssen authored
      Change-Id: Ie60f01d935ca6b4aa6ce0eab7598602ac0758342
      Tested: on Linux.
      f6330ab8
    • pjulien's avatar
      Fix for #3849 · 6908826f
      pjulien authored
      This avoids the following allocations over repeated use:
      
      - A ``CharsetEncoder``
      - A byte array to contain the contents of the string
      - A wrapper, via ``ByteBuffer#wrap``, for the previously mentioned byte
        array
      
      This also removes a copy of the temporary byte array.  This extra copy
      is needed because ``String#getBytes`` returns a byte array and its
      length must match the exact size of the contents.
      
      This implementation requires that the builder retain a ``ByteBuffer``
      and ``CharEncoder``.  This is considered slower only for users that
      will only allocate a single string in their buffers or none at all.
      
      The improvement is especially potent if the builder is constantly reused
      by its caller.  This also eliminates the penalty for users that do not
      use strings at all since the cost of allocating these fields is
      now amortized.
      
      The only allocation left in this code is a ``CharBuffer`` wrapper.  It's
      possible to eliminate this allocation using an additional copy but need
      further profiling to see which is the bigger problem.
      6908826f
  3. Apr 20, 2016
  4. Apr 18, 2016
  5. Apr 17, 2016
  6. Apr 14, 2016
  7. Apr 13, 2016
  8. Apr 12, 2016
  9. Apr 11, 2016
  10. Apr 08, 2016
  11. Apr 07, 2016
  12. Apr 05, 2016
  13. Apr 04, 2016
  14. Apr 03, 2016
  15. Apr 02, 2016
  16. Mar 30, 2016
  17. Mar 29, 2016
    • Nnamdi's avatar
      Added --gen-name-strings command line option. · 35f6bb50
      Nnamdi authored
      To support the use case described in issue google/flatbuffers#3826, a new command line option --gen-name-strings
      has been added, which will cause a static GetFullyQualifiedName function to be added
      to the C++ output for tables/structs.
      35f6bb50
    • Armen Baghumian's avatar
      Implement __vector_as_bytes and methods to get [ubyte] efficiently · 28a3c939
      Armen Baghumian authored
      Currently in order to get a value type of [ubyte] in PHP, iteration is
      necessary which is not efficient. Helper __vector_as_bytes has been
      implemented in order to return the byte arrays in PHP efficiently.
      
      Appropriate methods also been added to use aforementioned method to return
      the byte array. (e.g. get*Bytes()).
      
      The reason the methods are named get*Bytes() and not for instance
      get*ByteArray() is the fact that PHP doesn't support byte arrays and the
      binary safe string implementation in PHP is used to simulate byte arrays
      and since there is chance for PHP users to confuse this with PHP arrays
      the name get*Bytes() has been chosen.
      
      In the future __vector_as_bytebuffer() method can also be implemented to
      return PHP implementation of ByteBuffer.
      28a3c939
Loading