- Apr 29, 2019
-
-
Todd Eisenberger authored
These are usually the same, but in the case of composite devices there is a difference. Change-Id: I7c6256d5f2a0af8922e85423ccb27330687182e6 Bug: ZX-3971 #done
-
Taylor Cramer authored
Change-Id: I67bc6ff0629782cee3ad3574b4d36e279f634bdb
-
Mukesh Agrawal authored
When we receive a new acknowledgement, we should take the steps required by the Process-ReqSeq action (see Core Spec v5.0, Volume 3, Part A, Sec 8.6.5.6). We can't take all of those steps yet, because we don't have the necessary data structures (in particular, we're missing the retransmission queue). But implement what we can with what we have right now. While there: improve documentation of an existing field. Bug: BT-442 Test: bt-host-unittests Change-Id: I1c966edc163442181785c063a0e361254f91b1da
-
Dale Sather authored
inet::IpAddress was using the posix call getaddrinfo (in local mode) to parse IP addresses. getaddrinfo doesn't work in fuchsia, so this CL replaces the call with a parser. TEST: new inet unit tests Change-Id: I8ef3b3c7ab8d184d14228e206531b2c19274a087
-
Tim Detwiler authored
The linux_runner is never started directly from the command line anymore, so these arguments are unused. Change-Id: I6ca4bea77ff467c2dd66507a47d85ba5a1884aab
-
Tim Detwiler authored
This removes the use of FIDL Sync pointers from the linux_runner, using fit::promises in their place. This removes a large chunk of the blocking logic from the linux_runner, however the gRPC components are still synchronous. Making these async will happen in a subsequent change. This change will make it simpler to add unit tests to this component since we won't have to work around blocking logic. Test: tiles_ctl add linux://chromium Change-Id: Ifbed771d8764153607d4ea483ff2c69a75835d5a
-
Taylor Cramer authored
Change-Id: I090f35372001e1e5fb919152ee5d66fcf7d0b0d3
-
Roland McGrath authored
It was used in only one place and just harmed readability. Test: gn gen && ninja has nothing to do Change-Id: Ifd81fde4bdad3fe7c3386c93cc4f32455071baf1
-
Christopher Anderson authored
- Change GetNextCapability and GetFirstCapability to return a status code to be more testable and consistent with the rest of our API and syscall patterns. - Make GetFirstCapability a protocol method to work with DDKTL better and avoid one-off methods in pci-lib - Update all clients of these apis. ZX-3146 Change-Id: I71fd19fcf22cba784c4ecd755644a3b30c5648e2
-
Pascal Perez authored
- Simpler library names in line with more recent tests; - Clearer names, and no comments (which duplicates what the test name conveys) - No _test suffix Also adding a test for unknown using, which was not covered before. Change-Id: I299acf93596f5b4d4d3907c7c0feac0228248d55
-
Pascal Perez authored
and in one place, an unused header. FIDL-600 #comment Tes: build is greed Change-Id: I60bce1ea490e532bc5ce62104916c61d338ae7bc
-
Ed Coyne authored
We have already switched to using a more direct path to create virtcons, this removes the old path through /dev/misc/dmctl to the devcoordinator. Issue: ZX-3403 Test: Booted frank, virtcon still works, this change is in essence a no-op as nothing is using this code. Change-Id: Icb0b77984a818a56f98d5099d111878e9f88ea57
-
Braden Kell authored
Test: Used hid tool to verify touch screen still worked Test: runtests -t mt8167s_ref-test Change-Id: I07213a60a99c3c8f69bb4c1e4407deb5c1fbe791
-
Tim Detwiler authored
Change-Id: I92d2475bbacd155c32f5ef9c423fadb72d67c9bd
-
Yifei Teng authored
Apparently using data_deps in compiled_action will not trigger a re-execution of the tool when fidlgen_llcpp changes. Out of these following potential locations for the fidlgen dependency I tried: - in data_deps in executable("fidlgen_llcpp_zircon") - in deps in executable("fidlgen_llcpp_zircon") - in data_deps in the compiled_action - in deps in the compiled_action Only the last one will correctly trigger the execution of fidlgen_llcpp_zircon. Also need to put fidlgen_llcpp in the depfile of the update/validate actions, to indicate dependency on incremental builds. TEST: Edit a .go source file in fidlgen_llcpp and observe that fx build -k 0 tools/fidlgen_llcpp_zircon:update is correctly run and modifies the checked in bindings. Change-Id: Ie5779bc67bcc88ac1fea2fa599faea36d3a3ce7b
-
Emircan Uysaler authored
BaseView::PresentScene() expects single call in a vsync, but BaseView::Present() can queue multiple calls, i.e. simplest_app example. For the following calls, it is OK to skip as they will fall into the same vsync interval. This CL removes the checks for that case. However, this check would make sense for InvalidateScene() driven updates, so I noted that we should bring it back when that is the only option. SCN-1379 #done Change-Id: Ie3e662248d82d480fe2f2d04a955f635b3eecf39
-
Adam MacBeth authored
Cleanup while reading the code. TEST: No behavior change. fx run-test audio_mixer_tests Change-Id: I09addb35b886569a830189ffdce91dee2a77bc94
-
Adam MacBeth authored
TEST: No behavior change. Change-Id: Ia0dceedeb3cd5d7d58a3aa3e0d9636e0e59dc600
-
David Reveman authored
This removes read/write FDIO support from goldfish pipe driver. Code that used this has been updated to use the FIDL interface instead. Removes unused code. No change in behavior. Test: /boot/test/sys/goldfish-test Test: goldfish-benchmark Change-Id: Ie20358eb054f9e92bd0d8d05511502a31415e935
-
Przemek Pietrzkiewicz authored
This reverts commit 99311885 "[ledger] Re-enable full range of ledgers for convergence tests." - it seems that the higher number of instances makes the test crash flakily. Reducing the number of instances while we investigate. LE-752 Change-Id: I289a39e4afc9e493624f08302872b3155c27f3ac
-
Ambre Williams authored
Various cosmetic changes: - factor the signalling logic into crate::utils::Signal - FutureOrEmpty takes an Option<&mut F> - use try_next() instead of next() TEST=no functional change, already covered by cloud provider validation tests (fx run-test cloud_provider_memory_diff_tests) Change-Id: I88923829f9611e2a31746a7a1a4ef60663e1b74b
-
David Reveman authored
Goldfish address space is a virtual device that is used by AEMU to provide host visible memory when forwarding Vulkan API from guest to host. Goldfish address space is a PCI device that provides a region of memory that can be used for mapping host side memory into guest. Guest side Vulkan driver can reserve a block of memory and use AEMU specific Vulkan API to map host side memory into the block. DX-939 #comment Test: /boot/test/sys/goldfish-test Change-Id: Ic6906c6f8d618bd8f31d49ad8838eb05a34b1ba9
-
Haowei Wu authored
This change rolls gn prebuilt to latest version to include fixes for gn meta. Bugs: crbug.com/gn/67, crbug.com/gn/68 Tests: CQ and Local Change-Id: I425ce08ffaa0f9b1304d5c0439d7bdcd834a0510
-
Alex Legg authored
BUG=WLAN-895 Change-Id: I921153d15966a00e3523d501937aa1cddc0ad7b6
-
- Apr 28, 2019
-
-
Ben Keller authored
Change-Id: If27ffab06376f5e19e14d83961250c0de8a2a708
-
Roland McGrath authored
The bots now use //bundles/buildbot:PRODUCT instead. Bug: INTK-1015 #done Change-Id: Iee2133cb9270684e7704d9146588a14a03f624e2
-
Aaron Green authored
This CL simply separates the "asan" and "ubsan" variants into their own list so that can be referenced by themselves for things like the fuzzing environments. Bug: BLD-430 Test: ./zircon/scripts/build-zircon -a <arch> -A Change-Id: I5ca5a404d2917947e54ac6d461ac40e957c1aa8e
-
Bert Muthalaly authored
...updating its argument from fuchsia.net.IpAddress to fuchsia.net.stack.InterfaceAddress for symmetry with AddInterfaceAddress. This would be a source-breaking change, but I've searched all downstream consumers that I know of and haven't found any references, so we can atomically update all references in fuchsia.git. NET-1097 #done Change-Id: I6895e9dac471ef3e2eb86a35c6f04421ca82f95f
-
Eric Wang authored
Test: existing tests provide coverage, field is not used. Change-Id: Id1b71691c0c1106c8045cab807c0c5e57d76ddaf
-
- Apr 27, 2019
-
-
Benjamin Lerman authored
LE-618 Change-Id: Ia02ddc19651c043e520d84c731a9cc0247be0353
-
Drew Fisher authored
DNO-492 #comment Tests: paved an Astro, saw this log reasonable content for the empty volumes before formatted, did not log after paved. Change-Id: I07a80dc2a826e80ba5c12ca5901d460a65266153
-
Venkatesh Srinivas authored
write_msr_safe attempts to write a value to an MSR; if it encounters a #GP fault, it returns a status with the value unwritten. Like read_msr_safe, this should be executed with interrupts disabled; I plan to change both of them soon to assert that we are either cpu-pinned or have hard interrupts disabled. Tested: See 4th CL in stack; adds 'k' commands to access read_msr/write_msr. ZX-3359 Change-Id: I6f91818bf1ffc34f54e041ad17aca1317d240321
-
Venkatesh Srinivas authored
read_msr_on_cpu reads an MSR on a single target CPU. The MSR needs to be readable without causing a #GP; the read happens in IPI function handler. ZX-3359 Tested: See 4th patch in patch stack; k cpu rdmsr/wrmsr are added to exercise these. Change-Id: I42e6162ba8c2f19872b4d058532b454367e19879
-
David Reveman authored
This doesn't cause a change in behavior. The code is only used for examples and the change simply increase hw support and allows for optimizations in future drivers. - Determine memory type index instead of assuming 0. - This is a memory allocation dedicated to a single image. Inform the driver of this. Required by goldfish ICD and useful for other drivers. The result of this change is that examples that use this layer can be used when running fuchsia on aemu. DX-939 #comment Test: fx shell present_view fuchsia-pkg://fuchsia.com/vkcube_on_scenic#meta/vkcube_on_scenic.cmx Change-Id: Ib27140ea6c5871e34af01d4ea631e2f4b80fa600
-
Bryce Lee authored
This changelist adds support for retrieving and modifying account settings. It also updates the corresponding fidls by adding a provision login override type and fixing a typo. Bug: SU-167 Test: fx run-test setui_service_tests -- --test Change-Id: I7ddb2ca2f41ebc71fb32feea1094cb3722e86263
-
Bryce Lee authored
This is necessary for the service to be used as an environment service. Bug: SU-167 Test: manual Change-Id: I3bd44796d7b9f7e4e214626d28cac422f4b084be
-
Bryce Lee authored
This changelist introduces persistent storage for retaining settings accessed through the SetUI service. The functionality is exposed through two main traits. The Store trait defines an API for writing and retrieving values, while the SettingCodec trait defines an encoding/decoding protocol. Concrete implementations for both have been provided, using JSON for the latter. Note that the codecs must be updated to support new SettingData types. The JSON codec currently only supports StringValue and AccountSettings. Bug: SU-167 Test: fx run-test setui_service_tests -- --test Change-Id: Iae55c256bdeaeec957a62836abe342793320d2c4
-
Wez . authored
This reverts commit 426805c5. Reason for revert: ViewTokenPair is published in the Fuchsia SDK, so this change was a hard API transition for SDK consumers (e.g. Chromium & ANGLE). Original change's description: > [scenic] Convert ViewTokenPair to object > > This unifies the API for C++, Dart, and Rust better. All 3 language > bindings are pretty idiomatic now. > > Tested: view_token_pair_test > SCN-1214 #comment > > Change-Id: I00bcbde5ff64c747ce427764cdfffdf6530e1295 TBR=abarth@google.com,jjosh@google.com,dworsham@google.com,jsankey@google.com,adamgousetis@google.com Change-Id: Ie9219897b794e5adc38ad5e84a79ee99c1491bca No-Presubmit: true No-Tree-Checks: true No-Try: true
-
Bryce Lee authored
This changelist adds adapters to the SetUI setting service. Adapters allow us to extend the service to handle different types of settings. It also implements the setting listen functionality. A TestAdapter has also been added for the Unknown setting type as an example. Bug: SU-167 Test: fx run-test setui_service_tests -- --test Change-Id: Ia105d77a18ba80d3624bb45d509c6ad6b211a5c3
-
Cristián Donoso authored
This is the stub of the test, that is not joined to the build. This is because a lot of logic for making this test to work is required and the CL is big enough at it is. The following CL will do the actual watchpoint logic and hook up this test to run. TEST=No functional change. Change-Id: Idee83c1e65aa55552242d5679e0ff178b8151fcc
-