Skip to content
Snippets Groups Projects
  1. Apr 29, 2019
    • Todd Eisenberger's avatar
      [devfs] Send watcher events to parent directory, not parent device · 07ac73a0
      Todd Eisenberger authored
      These are usually the same, but in the case of composite devices there
      is a difference.
      
      Change-Id: I7c6256d5f2a0af8922e85423ccb27330687182e6
      Bug: ZX-3971 #done
      07ac73a0
    • Taylor Cramer's avatar
      [rust][async] Move fuchsia_async::Socket to shared functions · 2a8d75ed
      Taylor Cramer authored
      Change-Id: I67bc6ff0629782cee3ad3574b4d36e279f634bdb
      2a8d75ed
    • Mukesh Agrawal's avatar
      [bt][l2cap] ERTM TxEngine: add ability to receive ACKs · 50e19d79
      Mukesh Agrawal authored
      When we receive a new acknowledgement, we should take the steps
      required by the Process-ReqSeq action (see Core Spec v5.0, Volume 3,
      Part A, Sec 8.6.5.6).
      
      We can't take all of those steps yet, because we don't have the
      necessary data structures (in particular, we're missing the
      retransmission queue). But implement what we can with what we have
      right now.
      
      While there: improve documentation of an existing field.
      
      Bug: BT-442
      Test: bt-host-unittests
      
      Change-Id: I1c966edc163442181785c063a0e361254f91b1da
      50e19d79
    • Dale Sather's avatar
      [libinet] fix IpAddress parsing · 53949947
      Dale Sather authored
      inet::IpAddress was using the posix call getaddrinfo (in local mode)
      to parse IP addresses. getaddrinfo doesn't work in fuchsia, so this
      CL replaces the call with a parser.
      
      TEST: new inet unit tests
      Change-Id: I8ef3b3c7ab8d184d14228e206531b2c19274a087
      53949947
    • Tim Detwiler's avatar
      [linux_runner] Remove command line arg parsing. · 6cca03f7
      Tim Detwiler authored
      The linux_runner is never started directly from the command line
      anymore, so these arguments are unused.
      
      Change-Id: I6ca4bea77ff467c2dd66507a47d85ba5a1884aab
      6cca03f7
    • Tim Detwiler's avatar
      [linux_runner] Replace SyncPtrs with fit::promise. · 96eb2398
      Tim Detwiler authored
      This removes the use of FIDL Sync pointers from the linux_runner, using
      fit::promises in their place. This removes a large chunk of the
      blocking logic from the linux_runner, however the gRPC components are
      still synchronous. Making these async will happen in a subsequent
      change.
      
      This change will make it simpler to add unit tests to this component
      since we won't have to work around blocking logic.
      
      Test: tiles_ctl add linux://chromium
      Change-Id: Ifbed771d8764153607d4ea483ff2c69a75835d5a
      96eb2398
    • Taylor Cramer's avatar
      [rust][async] Factor out signal checking into reusable functions · bf77b348
      Taylor Cramer authored
      Change-Id: I090f35372001e1e5fb919152ee5d66fcf7d0b0d3
      bf77b348
    • Roland McGrath's avatar
      [zircon][gn] Remove standard_fuchsia_user_configs variable · 2345e2a1
      Roland McGrath authored
      It was used in only one place and just harmed readability.
      
      Test: gn gen && ninja has nothing to do
      Change-Id: Ifd81fde4bdad3fe7c3386c93cc4f32455071baf1
      2345e2a1
    • Christopher Anderson's avatar
      [pci] Update protocol methods for Capabilities · aa333355
      Christopher Anderson authored
      - Change GetNextCapability and GetFirstCapability to return
        a status code to be more testable and consistent with the
        rest of our API and syscall patterns.
      - Make GetFirstCapability a protocol method to work with DDKTL
        better and avoid one-off methods in pci-lib
      - Update all clients of these apis.
      
      ZX-3146
      
      Change-Id: I71fd19fcf22cba784c4ecd755644a3b30c5648e2
      aa333355
    • Pascal Perez's avatar
      [fidlc] Minor test cleanup · 80c1e6a4
      Pascal Perez authored
      - Simpler library names in line with more recent tests;
      - Clearer names, and no comments (which duplicates what the test name
      conveys)
      - No _test suffix
      
      Also adding a test for unknown using, which was not covered before.
      
      Change-Id: I299acf93596f5b4d4d3907c7c0feac0228248d55
      80c1e6a4
    • Pascal Perez's avatar
      [fidl] Removing unused build dependencies · 72a01e19
      Pascal Perez authored
      and in one place, an unused header.
      
      FIDL-600 #comment
      
      Tes: build is greed
      Change-Id: I60bce1ea490e532bc5ce62104916c61d338ae7bc
      72a01e19
    • Ed Coyne's avatar
      [dmctl] Remove virtcon channel from devcoordinator. · 38a8f8cb
      Ed Coyne authored
      We have already switched to using a more direct path to create virtcons,
      this removes the old path through /dev/misc/dmctl to the devcoordinator.
      
      Issue: ZX-3403
      Test: Booted frank, virtcon still works, this change is in essence a
      no-op as nothing is using this code.
      
      Change-Id: Icb0b77984a818a56f98d5099d111878e9f88ea57
      38a8f8cb
    • Braden Kell's avatar
      [cleo][touch] Use power driver to enable VGP1 regulator · bee42c42
      Braden Kell authored
      Test: Used hid tool to verify touch screen still worked
      Test: runtests -t mt8167s_ref-test
      Change-Id: I07213a60a99c3c8f69bb4c1e4407deb5c1fbe791
      bee42c42
    • Tim Detwiler's avatar
      [vmm][virtio-net] Reduce chattiness of log message. · f73da998
      Tim Detwiler authored
      Change-Id: I92d2475bbacd155c32f5ef9c423fadb72d67c9bd
      f73da998
    • Yifei Teng's avatar
      [llcpp] [build] Change data_deps to deps · d11db8de
      Yifei Teng authored
      Apparently using data_deps in compiled_action will not trigger a
      re-execution of the tool when fidlgen_llcpp changes. Out of these
      following potential locations for the fidlgen dependency I tried:
      
      - in data_deps in executable("fidlgen_llcpp_zircon")
      - in deps in executable("fidlgen_llcpp_zircon")
      - in data_deps in the compiled_action
      - in deps in the compiled_action
      
      Only the last one will correctly trigger the execution of
      fidlgen_llcpp_zircon.
      
      Also need to put fidlgen_llcpp in the depfile of the update/validate
      actions, to indicate dependency on incremental builds.
      
      TEST: Edit a .go source file in fidlgen_llcpp and observe that
      fx build -k 0 tools/fidlgen_llcpp_zircon:update is correctly run and
      modifies the checked in bindings.
      
      Change-Id: Ie5779bc67bcc88ac1fea2fa599faea36d3a3ce7b
      d11db8de
    • Emircan Uysaler's avatar
      [scenic] Fix multiple present checks in BaseView · 26d87582
      Emircan Uysaler authored
      BaseView::PresentScene() expects single call in a vsync, but BaseView::Present()
      can queue multiple calls, i.e. simplest_app example. For the following calls, it
      is OK to skip as they will fall into the same vsync interval. This CL removes
      the checks for that case.
      However, this check would make sense for InvalidateScene() driven updates, so
      I noted that we should bring it back when that is the only option.
      
      SCN-1379 #done
      
      Change-Id: Ie3e662248d82d480fe2f2d04a955f635b3eecf39
      26d87582
    • Adam MacBeth's avatar
      [media][audio] OutputProducerPtr -> std::unique_ptr<OutputProducer> · 94a95815
      Adam MacBeth authored
      Cleanup while reading the code.
      
      TEST: No behavior change. fx run-test audio_mixer_tests
      Change-Id: I09addb35b886569a830189ffdce91dee2a77bc94
      94a95815
    • Adam MacBeth's avatar
      [fxl] Pass string parameters by const reference in DeviceWatcher · d8f56ee8
      Adam MacBeth authored
      TEST: No behavior change.
      Change-Id: Ia0dceedeb3cd5d7d58a3aa3e0d9636e0e59dc600
      d8f56ee8
    • David Reveman's avatar
      [zircon][dev][goldfish] Remove FDIO read/write support · 981d3d17
      David Reveman authored
      This removes read/write FDIO support from goldfish pipe
      driver. Code that used this has been updated to use the FIDL
      interface instead.
      
      Removes unused code. No change in behavior.
      
      Test: /boot/test/sys/goldfish-test
      Test: goldfish-benchmark
      Change-Id: Ie20358eb054f9e92bd0d8d05511502a31415e935
      981d3d17
    • Przemek Pietrzkiewicz's avatar
      [ledger] reduce the number of instances in the convergence test · 7aeab499
      Przemek Pietrzkiewicz authored
      This reverts commit 99311885
      "[ledger] Re-enable full range of ledgers for convergence tests."
      - it seems that the higher number of instances makes the test crash
      flakily.
      
      Reducing the number of instances while we investigate.
      
      LE-752
      
      Change-Id: I289a39e4afc9e493624f08302872b3155c27f3ac
      7aeab499
    • Ambre Williams's avatar
      [ledger] cleanup rust cloud provider · 50b5244e
      Ambre Williams authored
      Various cosmetic changes:
       - factor the signalling logic into crate::utils::Signal
       - FutureOrEmpty takes an Option<&mut F>
       - use try_next() instead of next()
      
      TEST=no functional change, already covered by cloud provider validation
      tests (fx run-test cloud_provider_memory_diff_tests)
      
      Change-Id: I88923829f9611e2a31746a7a1a4ef60663e1b74b
      50b5244e
    • David Reveman's avatar
      [zircon][dev][goldfish] Add goldfish address space driver · 11b276fb
      David Reveman authored
      Goldfish address space is a virtual device that is used
      by AEMU to provide host visible memory when forwarding
      Vulkan API from guest to host.
      
      Goldfish address space is a PCI device that provides
      a region of memory that can be used for mapping host side
      memory into guest. Guest side Vulkan driver can reserve a
      block of memory and use AEMU specific Vulkan API to map
      host side memory into the block.
      
      DX-939 #comment
      
      Test: /boot/test/sys/goldfish-test
      Change-Id: Ic6906c6f8d618bd8f31d49ad8838eb05a34b1ba9
      11b276fb
    • Haowei Wu's avatar
      [zircon] roll gn to latest version. · dcacc2c2
      Haowei Wu authored
      This change rolls gn prebuilt to latest version to include fixes for
      gn meta.
      
      Bugs: crbug.com/gn/67, crbug.com/gn/68
      Tests: CQ and Local
      Change-Id: I425ce08ffaa0f9b1304d5c0439d7bdcd834a0510
      dcacc2c2
    • Alex Legg's avatar
      [wlan][iwlwifi] Prepare to port PCIE transport ops · ee7062e4
      Alex Legg authored
      BUG=WLAN-895
      
      Change-Id: I921153d15966a00e3523d501937aa1cddc0ad7b6
      ee7062e4
  2. Apr 28, 2019
  3. Apr 27, 2019
    • Benjamin Lerman's avatar
      [ledger] Replace PageSnapshot deprecated API with status less API. · 92627f02
      Benjamin Lerman authored
      LE-618
      
      Change-Id: Ia02ddc19651c043e520d84c731a9cc0247be0353
      92627f02
    • Drew Fisher's avatar
      [fshost] log when encountering unknown disk format · 396d2162
      Drew Fisher authored
      DNO-492 #comment
      Tests: paved an Astro, saw this log reasonable content
      for the empty volumes before formatted, did not log after paved.
      
      Change-Id: I07a80dc2a826e80ba5c12ca5901d460a65266153
      396d2162
    • Venkatesh Srinivas's avatar
      [kernel][x86] Add write_msr_safe · eafd9b14
      Venkatesh Srinivas authored
      write_msr_safe attempts to write a value to an MSR; if it encounters a #GP
      fault, it returns a status with the value unwritten.
      
      Like read_msr_safe, this should be executed with interrupts disabled; I
      plan to change both of them soon to assert that we are either cpu-pinned
      or have hard interrupts disabled.
      
      Tested: See 4th CL in stack; adds 'k' commands to access read_msr/write_msr.
      
      ZX-3359
      
      Change-Id: I6f91818bf1ffc34f54e041ad17aca1317d240321
      eafd9b14
    • Venkatesh Srinivas's avatar
      [kernel][x86] Introduce read_msr_on_cpu · bdd2d1c2
      Venkatesh Srinivas authored
      read_msr_on_cpu reads an MSR on a single target CPU. The MSR needs to be
      readable without causing a #GP; the read happens in IPI function handler.
      
      ZX-3359
      
      Tested: See 4th patch in patch stack; k cpu rdmsr/wrmsr are added to
      exercise these.
      
      Change-Id: I42e6162ba8c2f19872b4d058532b454367e19879
      bdd2d1c2
    • David Reveman's avatar
      [vulkan] Improve hw support for VK_LAYER_FUCHSIA_imagepipe_swapchain · 891e5d45
      David Reveman authored
      This doesn't cause a change in behavior. The code is only used for
      examples and the change simply increase hw support and allows for
      optimizations in future drivers.
      
      - Determine memory type index instead of assuming 0.
      - This is a memory allocation dedicated to a single image. Inform
        the driver of this. Required by goldfish ICD and useful for
        other drivers.
      
      The result of this change is that examples that use this layer can
      be used when running fuchsia on aemu.
      
      DX-939 #comment
      
      Test: fx shell present_view fuchsia-pkg://fuchsia.com/vkcube_on_scenic#meta/vkcube_on_scenic.cmx
      Change-Id: Ib27140ea6c5871e34af01d4ea631e2f4b80fa600
      891e5d45
    • Bryce Lee's avatar
      [SetUI] Support account login override mutations. · c0cc79bf
      Bryce Lee authored
      This changelist adds support for retrieving and modifying account
      settings. It also updates the corresponding fidls by adding a
      provision login override type and fixing a typo.
      
      Bug: SU-167
      Test: fx run-test setui_service_tests -- --test
      Change-Id: I7ddb2ca2f41ebc71fb32feea1094cb3722e86263
      c0cc79bf
    • Bryce Lee's avatar
      [SetUI] Add SetUISettingService to base packages. · 8938cc5d
      Bryce Lee authored
      This is necessary for the service to be used as an environment
      service.
      
      Bug: SU-167
      Test: manual
      Change-Id: I3bd44796d7b9f7e4e214626d28cac422f4b084be
      8938cc5d
    • Bryce Lee's avatar
      [SetUI] Add Persistent storage to SetUI service. · b0c7a662
      Bryce Lee authored
      This changelist introduces persistent storage for retaining settings
      accessed through the SetUI service. The functionality is exposed
      through two main traits. The Store trait defines an API for writing
      and retrieving values, while the SettingCodec trait defines an
      encoding/decoding protocol. Concrete implementations for both
      have been provided, using JSON for the latter.
      
      Note that the codecs must be updated to support new SettingData
      types. The JSON codec currently only supports StringValue and
      AccountSettings.
      
      Bug: SU-167
      Test: fx run-test setui_service_tests -- --test
      Change-Id: Iae55c256bdeaeec957a62836abe342793320d2c4
      b0c7a662
    • Wez .'s avatar
      [scenic] Revert "[scenic] Convert ViewTokenPair to object" · 1c2f0e56
      Wez . authored
      This reverts commit 426805c5.
      
      Reason for revert: ViewTokenPair is published in the Fuchsia SDK, so this change was a hard API transition for SDK consumers (e.g. Chromium & ANGLE).
      
      Original change's description:
      > [scenic] Convert ViewTokenPair to object
      >
      > This unifies the API for C++, Dart, and Rust better.  All 3 language
      > bindings are pretty idiomatic now.
      >
      > Tested: view_token_pair_test
      > SCN-1214 #comment
      >
      > Change-Id: I00bcbde5ff64c747ce427764cdfffdf6530e1295
      
      TBR=abarth@google.com,jjosh@google.com,dworsham@google.com,jsankey@google.com,adamgousetis@google.com
      
      Change-Id: Ie9219897b794e5adc38ad5e84a79ee99c1491bca
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      1c2f0e56
    • Bryce Lee's avatar
      [SetUI] Introduce Adapters. · 145eeba7
      Bryce Lee authored
      This changelist adds adapters to the SetUI setting service. Adapters
      allow us to extend the service to handle different types of settings. It
      also implements the setting listen functionality.
      
      A TestAdapter has also been added for the Unknown setting type as
      an example.
      
      Bug: SU-167
      Test: fx run-test setui_service_tests -- --test
      Change-Id: Ia105d77a18ba80d3624bb45d509c6ad6b211a5c3
      145eeba7
    • Cristián Donoso's avatar
      [debugger] Watchpoint integration test. · fc18365e
      Cristián Donoso authored
      This is the stub of the test, that is not joined to the build. This is
      because a lot of logic for making this test to work is required and the
      CL is big enough at it is. The following CL will do the actual
      watchpoint logic and hook up this test to run.
      
      TEST=No functional change.
      
      Change-Id: Idee83c1e65aa55552242d5679e0ff178b8151fcc
      fc18365e
Loading