Skip to content
Snippets Groups Projects
  1. May 04, 2019
    • Suraj Malhotra's avatar
      [svchost][devmgr][miscsvc] Add miscsvc · 1423535d
      Suraj Malhotra authored
      Startup a miscsvc binary, and provide a channel to it's '/svc/
      directory to svchost, which will then forward it services.
      
      To start miscsvc only implements the paver service.
      
      ZX-3861
      
      Change-Id: Id411227e4c3d2b8add49978cf6ce1a76de509a48
      1423535d
    • John Bauman's avatar
      [magma] Fix PlatformBuffer.AddressSpaceSize · e1a788de
      John Bauman authored
      MA-602 #done
      
      Change-Id: Ib77132f8e1d90a45d80eb2fcd34d5b7d19ac9ac8
      e1a788de
    • Suraj Malhotra's avatar
      [paver] Implement paver service · f0829938
      Suraj Malhotra authored
      The paver service implements the fuchsia.paver/Paver FIDL
      service. A new process managed by devcoordinator will need to be
      created to host it until such a time we can launch components in
      the zedboot environment.
      
      ZX-3861
      
      Change-Id: I23e032447e4ebfdf45e63719c02782c0c753d017
      f0829938
    • Dave Schuyler's avatar
      [System Monitor] collect process names · 9f2b185a
      Dave Schuyler authored
      This CL is a step toward gathering more process data. It adds reporting of
      process names.
      
      Change-Id: I88b6dd1810d69e27fd6fa87ab184ed6e08809b9e
      9f2b185a
  2. May 03, 2019
    • Robert Hahn's avatar
      [wlan][sme] Introduce Protection type for client · 3ea580b4
      Robert Hahn authored
      The protection type will soon add WEP support.
      The new enum replaces the previously used Option<Rsna> with
      the following mapping:
      None => Protection::Open
      Some(rsna) => Protection::Rsna(rsna)
      
      Test=Existing tests cover this CL already.
      
      Change-Id: I271013f8df246afc66c56e5baf3471c684a3291d
      3ea580b4
    • Justin Mattson's avatar
      [ota][test] Put SSH keys in ZBI · 95a5e236
      Justin Mattson authored
      This removes the need to add them via the
      --extra_authorized_ssh_keys GN flag.
      
      DX-1308 #comment
      
      Change-Id: Ib9af7b8b2e44a9e4356afbbb45c04dd1d8b7a982
      95a5e236
    • Derek Gonyeo's avatar
      [docs] add documentation on writing and wiring up rust unit tests · 66cf400c
      Derek Gonyeo authored
      Adds documentation under //docs to describe best practices for test
      components and how to write tests for rust.
      
      Adds example hello world components with accompanying test components to
      //examples/hello_world.
      
      Change-Id: I8be0821baf869c9002ccafd7e94e2f7096f68f49
      66cf400c
    • Pascal Perez's avatar
      [fidl][cpp] Bits operators · 864c0abe
      Pascal Perez authored
      Generating various bitwise operators on bits values.
      
      Test: added one which shows how to use operators, and verifies their
      result
      
      Change-Id: I0a80d75af392d9bd30f8fd253c1a60f99f470990
      864c0abe
    • Christopher R. Johnson's avatar
      [libinspect] Sort numeric values numerically. · 42043f23
      Christopher R. Johnson authored
      All metric/property/children keys are strings in inspect, but sometimes
      lexicographic sorting is not desired. For example, values with numeric
      keys make the most sense to sort numerically.
      
      This change changes the logic to the following:
      - If all children of a node have keys consisting of digits, sort
      numerically.
      - Otherwise, sort lexicographically.
      - Perform the above for metrics and properties as well.
      
      This behavior makes a sensible default based on current use cases.
      Future use cases may implement their own sorting if needed.
      
      CF-684: #done
      Change-Id: I378dfa7ce60e51252139e14bb3c9ccc14ef7eb72
      42043f23
    • Jeremy Manson's avatar
      [fidlcat] Add support for tables. · 2419002c
      Jeremy Manson authored
      Also adds Envelope support and a way to stop a value that is being calculated from being
      included in the resulting JSON.
      
      DX-1013 #comment Add support for tables.
      
      Change-Id: I72046cf2c401fdd1c1556a058502048105d96dfe
      2419002c
    • Nathan Rogers's avatar
      [benchmarking] Make catapult converter a host side tool · 967063ec
      Nathan Rogers authored
      As part of the plan outlined in PT-135, catapult converter will run
      after the host side metrics / Fuchsia benchmark results computation.
      Create a catapult converter host side tool in order to allow for this.
      
      Also, because src/lib/uuid has a dependency on Fuchsia, inline the UUID
      creation logic into catapult converter (since it's actually pretty
      simple).
      
      Add additional casts to appease the mac toolchain.
      
      PT-135 #comment-patch
      
      Test:
      $ out/default/host_x64/host_catapult_converter_test
      catapult_converter test passes on CQ
      host_catapult_converter test runs and passes on CQ
      
      Change-Id: I72e2fb62939b99701494f6f1cd7832b2882ec4f2
      967063ec
    • Francois Rousseau's avatar
      [feedback] add warnings to log_listener to help debug flake · e6b2267c
      Francois Rousseau authored
      given that we don't see the warnings regarding the timeout in the flaky runs,
      these new warnings would help us figuring out why the logs are empty: is LogMany()
      called with no messages? is Done() called whith logs_ empty?
      
      FLK-179 #comment
      
      TESTED=`fx run-test feedback_agent_tests -t log_listener_unittest`
      
      Change-Id: I11ffb1d9efad8c12a136140405e3b5aca51c9c54
      e6b2267c
    • Francois Rousseau's avatar
      [crash] connect to fuchsia::feedback::DataProvider asynchronously · 69771074
      Francois Rousseau authored
      this allows crashpad_agent to not block when waiting for feedback data and serve other requests meanwhile
      
      DX-1469 #done #comment
      
      TESTED=`fx run-test crashpad_agent_tests`
      TESTED=`fx shell crasher` (report id ef90b0e8f74f35b9)
      TESTED=`fx k crash` (report id 991c16cca67d56ea)
      
      Change-Id: I59adfb71f63be1cc87f0d4a7646957a55e34f3b7
      69771074
    • David Worsham's avatar
      [scenic] Convert session_shell APIs to ViewToken · 367a9a1c
      David Worsham authored
      We consume some SDK clients as prebuilts, so they must implement the new
      API before we call into it.
      
      Tested: No behavior changed; modular_tests, started story in sysUI
      SCN-1018 #comment
      SCN-1291 #comment
      
      Change-Id: Ifb8797b81c12c7ae293e295c1960e02ee3be1168
      367a9a1c
    • Derek Gonyeo's avatar
      [component_manager] add info on the elf runner to the book · 87fa6227
      Derek Gonyeo authored
      CF-719 #done
      
      Change-Id: I3c747006b48d3fb0d2551b42062dfd440aea4970
      87fa6227
    • Robert Hahn's avatar
      [wlan][sme] Extract handling of MLME-ASSOC.confirm · c674b2de
      Robert Hahn authored
      Key idea is to reduce indentation to make following
      changes more readable.
      
      Test=Existing tests, non functional change, just moving code
      
      Change-Id: If5ac42978fe42b8850396fb6a9840fce3826f8de
      c674b2de
    • David Worsham's avatar
      [scenic] Convert story_shell APIs to ViewToken · 71cf73b1
      David Worsham authored
      We consume some SDK clients as prebuilts, so they must implement the new
      API before we call into it.
      
      Tested: No behavior changed; modular_tests, started story in sysUI
      SCN-1018 #comment
      SCN-1291 #comment
      
      Change-Id: Id6a2354b942e5390fce855f81fd913f770423340
      71cf73b1
    • Dale Sather's avatar
      [media][netconnector] move fidl_publisher.h into netconnector · 55e5c427
      Dale Sather authored
      fidl_publisher.h was in garnet/bin/media/util, but was only used in
      the netconnector implementation. This CL moves it to
      garnet/bin/netconnector, which will be deleted once netconnector
      is no longer used.
      
      TEST: no behavior change
      Change-Id: Iabada3ec6da2084861e7a9c2d41c9ffb7d1309d8
      55e5c427
    • Gianfranco Valentino's avatar
      [zircon][zxtest]: Fix repeat with -1. · 946222f3
      Gianfranco Valentino authored
      Using -i as repeat value will cause to run indefinitely. If combined
      with break on failure, will run until the first fails occures.
      
      Added test.
      
      ZX-4009 #done
      
      TEST=zxtest-test
      
      Change-Id: I10db1f74cd811842e8a82cd5913eb00b8b8dd017
      946222f3
    • docs-roller's avatar
      [gndoc] Update GN build arguments documentation · 2cf203ad
      docs-roller authored
      Test: CQ
      
      Change-Id: I964370ac85b97ea7e9bf21b1ed306c78f39d53bf
      2cf203ad
    • Christopher R. Johnson's avatar
      [inspect_unittests] Move unittests to be part of the inspect library. · f84c0f69
      Christopher R. Johnson authored
      We no longer want a separate bin/ directory for inspect_unittests.
      
      Change-Id: I05de32a36ba7a3718981a14e77882aa94806b956
      f84c0f69
    • Pascal Perez's avatar
      [fidlc] Furthering hack for struct member defaults · 2c6bc920
      Pascal Perez authored
      Because struct member defaults do not get properly resolved (FIDL-486),
      we need to workaround that when generating JSON. Recent change broke
      functionality for string constants.
      
      FIDL-486 #comment
      FIDL-619 #done
      
      Change-Id: If33aa05d5b6267b3e461bb76a9f87755b3388870
      2c6bc920
    • Ruchira Ravoori's avatar
      [mtk-power] Do not fail if the rail is already enabled · 4c4c8b2a
      Ruchira Ravoori authored
      When enabling power domain, if the rail is already enabled, we fail.
      This changeset rectifies this wrong behavior by returning success.
      All this code is changing with https://fuchsia-review.googlesource.com/c/fuchsia/+/273632/
      and that change will not be submitted without the unit tests, that I am
      currently writing. The current change is to unblock folks before the
      other change is reviewed.
      
      ZX-3990 #Done
      
      Test: fx full-build. Without this change, I see the bind failure for
      power driver. With this change, I do not see the error. device-enumeration-test is fixed here
      https://fuchsia-review.googlesource.com/c/fuchsia/+/277336. It fails without this change.
      Succeeds with this change
      
      Change-Id: Iec6fe6d8ec041a301287e4f0b787c3b5519d47d6
      4c4c8b2a
    • David Stevens's avatar
      [zircon][core-tests] Wait for thread termination · 7674ba8d
      David Stevens authored
      In interrupt_suspend_test, wait for the thread under test to terminate
      to reduce interference with subsequent tests.
      
      Change-Id: Icb20edf46bb8b3b645c74bbd298b3dc1c00a9bfd
      7674ba8d
    • Shac Ron's avatar
      [ahci] Convert to class · 3d3aaaef
      Shac Ron authored
      Create class-based AHCI controller.
      Some improvements in error handling in initialization, more to come.
      
      Tests: QEMU boot with disk and blktest
      Change-Id: I102c44abc46e2ae1b57987cf97cada442794a480
      3d3aaaef
    • Ankur Mittal's avatar
      [build] Deprecate fuchsia_component · 0465a996
      Ankur Mittal authored
      Removing its usage from our BUILD files. it would be replaced with a new
      thing in future.
      
      This is part 2
      
      CF-749 #progress
      
      TEST=CQ
      
      Change-Id: I25144d011b42ba1f574e62d17951714c1645df8d
      0465a996
    • Erick Tryzelaar's avatar
      Revert "[system-ota-tests] Switch to consuming packages.tar.gz" · 86638bad
      Erick Tryzelaar authored
      This reverts commit c30d780d.
      
      Reason for revert: <INSERT REASONING HERE>
      
      Original change's description:
      > [system-ota-tests] Switch to consuming packages.tar.gz
      > 
      > Previously, infra tried to pass in the amber-files produced by
      > the build into every test, but this was consuming too much
      > space. Instead, this patch switches the system ota tests to
      > consume the packages.tar.gz that's produced by the build.
      > 
      > Change-Id: I42e683d4b39f43544d755c8754649309c72de61b
      
      TBR=ctiller@google.com,etryzelaar@google.com,computerdruid@google.com
      
      Change-Id: I86e7c4675705fd99c7d1fe4f0936ebe3e81506e7
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      86638bad
    • Gabriel Schine's avatar
      [fx contrib] make-integration-patch: fail on >1 patch in one project. · 29fa849a
      Gabriel Schine authored
      Brings behavior up to parity with the available internal
      documentation on the limitations of the GI infra.
      
      Change-Id: I6abc8b76918ab3ded93c28647d487de3f98e57c8
      29fa849a
    • John Grossman's avatar
      [kernel][mutex][trace] Add ktracing for kernel mutex events. (kernel) · d50dda39
      John Grossman authored
      Add ktracing for kernel mutex events; defaulted to off at compile time.
      
      Note: this CL only adds trace definitions and tracing behavior to the
      kernel.  To make any use of these events, a follow up change which
      implementes the trace importer behavior is needed.
      
      Change-Id: Ia759ff3a62cb0593fa269963a7959b17aabedd24
      d50dda39
    • Aaron Green's avatar
      [scripts][fuzzing] Make SSH options more flexible · c2cab8e7
      Aaron Green authored
      This CL moves the SSH configuration from Host to Device
      and makes it more flexible to handle arbitrary options.  This allows
      other environments like ClusterFuzz to specify the options they need.
      
      Bugs: SEC-107
      Test: for f in scripts/fuzzing/test/*_test.py; do python $f; done
      Change-Id: I5c7c35e5238e390f9cd4eb848a14d995e3271af8
      c2cab8e7
    • Eric Wang's avatar
      [wlantool] fx-format --all · 9d9b5bb8
      Eric Wang authored
      Test: No functional change
      Change-Id: I92591a4d9beabc2e4e25c9e2fd61630664a0327b
      9d9b5bb8
    • Christopher R. Johnson's avatar
      [inspect][rename] Rename inspect::Object to inspect::Node · 99752863
      Christopher R. Johnson authored
      We are renaming Object to Node to avoid confusion with OOP objects. This
      is a large but minor rename.
      
      CF-703: #done
      Change-Id: Ifde94d6aa1b2c86f953b8399b340f5a0a0b50aa9
      99752863
    • Bryan Henry's avatar
      [build] Use destination as test_spec name in package template · 8b5fd42b
      Bryan Henry authored
      We can rely on the destination binary name to be unique, but not
      necessarily the source. This allows two tests in the same package to use
      the same source binary, e.g. with different component manifests.
      
      Change-Id: I842a6eaff1ea87d8231d57e6af7d4ae33220abb1
      8b5fd42b
    • Todd Eisenberger's avatar
      [devcoordinator] Make topo paths match devfs paths for composite devices · fef8cdce
      Todd Eisenberger authored
      Without this, the devfs path would include the composite bindpoint and
      the topological path would not.  The topological path has been updated
      to include it.
      
      Change-Id: I8185ae93697bab90361eb6a29ba5c37cea82a1cc
      fef8cdce
    • Aaron Green's avatar
      [build][fuzzing] Re-enable host fuzzers · c21b48dd
      Aaron Green authored
      This CL restores support for host fuzzers by treating them as host
      tools.  When a `fuzz_package` sets `fuzz_host` to true, the package will
      get a dependency on the fuzzers built by the host toolchain.
      
      Bugs: SEC-267
      
      Tests: fx set core.x64 --with //bundles:tests --fuzz-with asan
             fx run-host-test host_fuzzers_test
      
      Change-Id: Ib83b48b7786f1569652aef714d1292bb2bf648c5
      c21b48dd
    • Ankur Mittal's avatar
      [build] Deprecate fuchsia_component · 768abd8b
      Ankur Mittal authored
      Removing its usage from our BUILD files. it would be replaced with a new
      thing in future.
      
      This is part 1
      
      
      CF-749 #progress
      
      TEST=CQ
      
      Change-Id: Ifb2c1abc7a396eebe24fabbef68d0e2fda960634
      768abd8b
    • Derek Gonyeo's avatar
      [docs] add documentation for program.args field in CMX schema · 2555e69d
      Derek Gonyeo authored
      Change-Id: If7cc2f797fc983e1f8f71f9ae4c33c2bd855dbac
      2555e69d
    • Shac Ron's avatar
      [ahci] unsigned portnum and misc fixes. · f483d6d8
      Shac Ron authored
      Convert port numbers to unsigned.
      Time math macroized.
      Replace asserts with ZX_DEBUG_ASSERT.
      Fix an errant free().
      
      Change-Id: I2da53ab90157606aee1ea3d513e6f72120b22dc1
      f483d6d8
    • Gianfranco Valentino's avatar
      [zircon][cobalt-client] Virtualize collector. · cb743785
      Gianfranco Valentino authored
      Make collector a BaseClass with virtual methods, this will allow
      injecting fakes for testing.
      
      TEST=cobalt-client-test
      
      Change-Id: I7ff5c05293eaa71cf30a5b7cfca824f93cb3391f
      cb743785
    • Adam MacBeth's avatar
      [scripts][git] Fix git-file-tidy · a225d5d7
      Adam MacBeth authored
      Make the script define its own paths rather than relying on paths set by external scripts.
      
      Change-Id: Id3d65ce1df6fead9b34d140764ac65de29a0d1c0
      a225d5d7
Loading