If the disk format is unknown but the GPT GUID values dictate that it
should be a data format, it determines if the volume should be a zxcrypt
or minfs partition and formats it as such.

Added a unit test that failed without the changes. I added a test that
would have caught the vim2 breakage, but I also manually tested that it
boots up properly.

Change-Id: I276d55fc8dbcc8377d6a6b7d5dfe7b0fd9019eb4

It is more idiomatic and avoids ambiguity as to whether e.g. `nanos`,
`micros`, and `millis` refers to the subsecond part of a struct or
the entire value represented in that unit of measure.

Updates all uses of the methods in fuchsia.git and deprecates the old
methods.

TEST=CQ

Change-Id: Ibe67ffd028169cffdac0c1ce662bdb78fe7b1cd4

This reverts commit d957d81b.

Reason for revert:  Unable to start hello world component

[00055.025] 14138:14201> [component_manager] ERROR: Failed to bind to root component: ResolverError { err: ManifestNotAvailable { uri: "fuchsia-pkg://fuchsia.com/hello_world_hippo#meta/hello_world.cm", err: ClientRead(Status(PEER_CLOSED)) } }

Original change's description:
> [build][package] Add support to compile cml files.
> 
> TEST=Build and CQ
> 
> Change-Id: I6548bac320fe18f5d7ca5f795280399c04daee33

TBR=phosek@google.com,anmittal@google.com,jeffbrown@google.com,abarth@google.com,raggi@google.com,shayba@google.com,leolung@google.com

Change-Id: I28fb0847ca14e3c5771935bd06ab463db059293d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

This allows clients to easily distinguish between
an "UnbufferedOperation" (not yet in a buffer registered
with the block device) and a "BufferedOperation", which
can directly be transmitted to storage via "FlushWriteRequests".

This change makes each operation self-describing, which makes
it easier to operate on collections of "BufferedOperation" objects
that might be acting on distinct objects (e.g., the Journal buffer
vs the data writeback buffer).

Change-Id: I98811f6e3a256f79fe83bd7e2ec13b717a38c3c5

After exhausting retries for the receiver-ready poll message, we'll
need to close the L2CAP channel. As a step towards that goal, add a
max transmissions argument to the ERTM TxEngine ctor (and
corresponding field in the object).

Bug: BT-442
Test: bt-host-unittests
Change-Id: Id68f7a0069f63a5827d55dd663ae05420a7ee6c5

FLK-193

Change-Id: I9cd39e28081a4290335a4af2c7fd85fd333e4ba6

Using std::optional for MtkRegulator was not the right choice as I need
to implement pure virtual functions for child classes of MtkRegulator.
Along with that this change also implements GetSupportedVoltageRange.

Test: runtests -t mtk-power-test

Change-Id: Ieec2c7fe08361cf05215e3c2e0cae4182e4ef188

TESTED=fx run-test rust-crates-tests -t fuchsia_inspect_lib_test


CF-607 #comment

Change-Id: Ib8cbc02b931fae5f5c671820e7bf678a1d178770

Bug: PKG-676 #done

Change-Id: I769e27aee69b925736f7d659337ce03a6ac48e76

The APM handles changing power states, and trying to modify them
manually was causing occasional hangs and errors.

Change-Id: Ic65188b4030433ea2f5ddf0708091aa98b5072ba

"Buffer" provides a circular buffer interface.

It is being replaced by both:
- RingBuffer (circular buffer with safer semantics) and
- VmoBuffer (non-circular buffer).

This patch updates a usage in the journal of the info
block, where a Buffer was being used in a non-allocating
manner. This new interface is smaller, and harder
to misuse. This makes the call to "ReserveIndex" extraneous,
since allocation is simply disallowed by the type system.

This patch replaces an untested dependency of the journal
with a tested dependency. It otherwise has no observable
behavior.

Change-Id: Id169c13ba52a2b8d7705316c17d87f57760d6af4

To be customizable on which packages they want to mock through args to
the component. This avoids having to add a list of package names to the
mock.

Change-Id: Ia5adebbca046be949a8202e0ac0cf3a7d9e6138c

Change-Id: Ia365b42f8c57fbc015470d8db1b7aca74079b044

- Minor cleanup in BUILD file.

AUTH-196 #comment

Tested: Existing coverage
Change-Id: I09ffee1ae3fe58267c4c86708218a751cdca0329

Change-Id: Iee23bf313fa11e176d92ee636e741c2ed992621e

RunLoopUntilIdle could hang while we can easily wait (with a timeout)
until the expected result is available

TESTED=`fx run-test feedback_agent_tests -t feedback_agent_unittest`

Change-Id: I4a408138d37b1bca399df3742394a7075b635406

This CL gathers data similar to what the `ps` cli command collects. The data is
not processed/filtered as it is in `ps`, that is left to the Dockyard and UI.

Bug: 20
Change-Id: I46d56732ce742671a8471e1916a9af33fb903bb1

Prior to this fix, if there were multiple blank lines following a
comment, the first one would get deleted because it needed to be
coalesced with the subsequent lines, and the subsequent lines would get
deleted because they were not next to a comment.  This would leave no
blank lines after a comment.

This was not caught by tests because we were only exercising it in the
case of an EOF.  In the EOF case, we don't want trailing newlines, so it
was the correct behavior.  The other cases where we had trailing newlines
after a comment (e.g., before const and enum) were special-cased to do the
right thing.

Change-Id: Ibba0e1ef7834cbe5a6e5af9c4e6faef837e724ea

TEST=Build and CQ

Change-Id: I6548bac320fe18f5d7ca5f795280399c04daee33

Make /dev/misc/dmctl not writeable, remove code handling string parsing.

Test: {Qemu, Frank}: "dm" handles invalid code, writing to dmctl does nothing.
Change-Id: I6d14ce37963dfd87ba6a12d2decb6ef1e0767dd5

Instead of virtualizing the Collector, which only sees a metric as a
flushable and requires less legible ways for verification, provide a
test-only InMemoryLogger class which exposes the necesary internal types
within its class namespace and keeps tracks of the logged data.

TEST=cobalt-client-test, cobalt-client-unit-test

Change-Id: Ib67cb90f3b974a61ebe5fada424dd4b4a27cb1cb

TESTED=updated and ran a test that uses this.

Change-Id: I3aa36bb82c1e9fb8b56ce1ec0a6a58e91c5c5bca

- The test was making it onto release builds which is not what we want.

Change-Id: I1d82cd23906103dd640a24c21311ed6ccb2d4d05

the most recent flake instance revealed that LogMany() was never called
with no messages, but Done() was indeed called when logs_ is still
empty. These new warnings will help us figured out if Done() was called
before any calls to LogMany() or if it might be some race between
LogMany() and Done().

FLK-179 #comment

TESTED=`fx run-test feedback_agent_tests -t log_listener_unittest -- --gtest_filter=CollectSystemLogTest.Fail_LoggerNeverCallsLogManyBeforeDone`

Change-Id: I1954d9e55247cc21b6e07a713ba700cd877f021c

This creates a unit-tested equivalent of WriteTxn::Flush().

Change-Id: I15e407b652282ab2d0360576c3436aa2836fb4cc

Change-Id: I97eb007f63891fb9d45c3b7eac4321cbc6e8918e

this is to make the upcoming test cases easier as we will create multiple requests in one test case

TESTED=`fx run-test feedback_agent_tests -t feedback_agent_integration_test`

Change-Id: Ic05a07a4e3bea1f55b5d9a7ebc698fc78b4c6979

brcmfmac tests should be considered as part of the wlan tests, not
garnet.

TEST: fx run-test brcmfmac_test
Change-Id: I1a9075ffff2b668ab16f9e5eaae29f2ce167603e

Instead of using Arc<Mutex<Realm>> everywhere, move the mutex to the
internals of the Realm struct and only lock it when accessing mutable
data.

Change-Id: I4e8a745104e26c4f0555e1c5577d05a6fa52403e

Tested: No functional change, ldso breakpoints covered by process_unittest.cc.

Change-Id: Ia393279966270b277eefe9a4c4ad020c863a4c01

TESTED=
1. curl -v -X GET 192.168.42.235 -d '{"id": "", "method":
"setui_facade.Mutate", "params": {"account": {"operation":
"set_login_override", "login_override": "auth_provider"}} }'
2. changed an sl4f-based test to use this.

Change-Id: I54b6d7e50af6faa2eaf0397c44926322de814d8e

This avoids issues related to filtering README.* files.

PiperOrigin-RevId: 247100002
Change-Id: I2f06db19b95764aae46975b5dba68a6959cad5e8

this is breaking flutter_screencap_test
TEST=CQ

This reverts commit b209917d.

Change-Id: I561ab911abe7ae54481719cb9a80fd5feb8b051a

This reverts commit 4d833f15.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Revert "[ahci] Port memory configuration math cleanup."
> 
> try revert and check if this is making zircon builders timeout
> 
> This reverts commit 157b4786.
> 
> Reason for revert: <INSERT REASONING HERE>
> 
> Original change's description:
> > [ahci] Port memory configuration math cleanup.
> > 
> > No functionality changes.
> > 
> > Replace pointer math with easier to follow structure describing the
> > port command memory layout.
> > 
> > Test: blktest
> > Change-Id: Ia85bce4224e20497da51e4bee6fb962cfb54a986
> 
> TBR=smklein@google.com,qsr@google.com,sron@google.com,auradkar@google.com
> 
> Change-Id: I555908e7ba0e8ee1b84935ded01284034f4ecea7
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true

TBR=smklein@google.com,anmittal@google.com,qsr@google.com,sron@google.com,auradkar@google.com

Change-Id: I2d43c5f23ff938282ba018a449ad52274f6ef8d8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

try revert and check if this is making zircon builders timeout

This reverts commit 157b4786.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [ahci] Port memory configuration math cleanup.
> 
> No functionality changes.
> 
> Replace pointer math with easier to follow structure describing the
> port command memory layout.
> 
> Test: blktest
> Change-Id: Ia85bce4224e20497da51e4bee6fb962cfb54a986

TBR=smklein@google.com,qsr@google.com,sron@google.com,auradkar@google.com

Change-Id: I555908e7ba0e8ee1b84935ded01284034f4ecea7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

format-code's default mode of `--git` current determines which files
have been modified by using `git diff-index`. `diff-index`, however,
returns not only files that have been modified since the base commit,
but also files that don't have the expected modified time on disk. (For
example, any file that has been touch'ed). This leads to more files
being formatted than expected, such as in workflows such as the
following:

  sed -i -e s/foo/bar/ *.cc
  fx format-code

which will result in all C++ files being formatted, and not just those
modified.

This patch updates format-code to simply use `git diff <BASE_COMMIT>`.
When a base commit is provided, git diff returns (i) committed results;
(ii) staged results; and (iii) files modified in the working directory.
This should match the current behaviour of `fx format-code --git`.

Change-Id: Ie3bcac4322bd2cc4ba64b0f440fae5d76ff94b33

Removing test stubs so they don't appear in test output.

Test: fidl-compiler-test
Change-Id: Ia4223b91704dddb6cb8d3abcdf94107ba7a4ebcf

Tested: CQ; no behavior changed

Change-Id: Ieebd7472f57c4f16a5f4172a0aca940be7e3eeb9

- Deleted garnet/lib/auth entirely since it only contains metadata.
- Updated source paths in README files.
- Replaced redundant BUILD-directives on the form `foo:foo` with `foo`.

AUTH-196 #comment

Tested: Existing coverage
Change-Id: I352650b33e478abf81450fcc2ba878eb8bce2ec3

Bug: PKG-676 #comment Make fuchsia_merkle::hash::Hash public

Change-Id: I600e9a140dcf07d5af72026b1d11d572e56560d4