Change-Id: I9e6b33b75a7e70485a7d125db1251823cc682c3f

Since the introduction of the hierarchical rights, we need
OPEN_FLAG_POSIX to property traverse directires via the POSIX emulation
layer.

Change-Id: Ia33500623998a5919fdf6dd3cd162d6e928b0cc5

Without the request, it's hard to tell exactly what went wrong.

Test: logging change + unable to reproduce locally since adding
Change-Id: I3c91315d14b0f2b47ba02b6af2504c1a55e503c9

Previously, we added a blanket WriteInspect implementation to Option
types that would log a value only if an Option doesn't exist. When
looking at an inspect_log call on an optional value, it's non-obvious
that in some cases, no value would be logged, and this blanket
implementation was only added because inspect_log didn't have a way to
specify optional logging.

With this commit, optional logging can be specified with a question
mark on the key, so the blanket WriteInspect implementation is also
removed.

Test: fx run-test wlan-inspect-tests
Change-Id: I926c20fe2e64fc2e1221c2b84b61d5d9b062e817

WLAN-1117 #done

Test: Verify Inspect output. Example:
```
4:
  @time = 80.777
  cipher = 00-0F-AC:4
  derived_key = PTK
5:
  @time = 80.777
  cipher = 00-0F-AC:2
  derived_key = GTK
  key_index = 2
```

Change-Id: Id1046dcfbd65fc800d6b7cfbd04e7dd7ee27052e

For some reason some of the code was not formatted with rustfmt.  Maybe
rustfmt or it's config has changed, or we forgot to run it.

This change is a noop - just formatting changes.

Change-Id: I86c480b5aa74bbf5c6c33940b9628382f473b20c

Supported operations will be used during argument parsing
to varify that Target supports requested operations. For example
if user wants to stress file creation then to verify we need
Target to support readdir and opendir.

There is no need to have current Option<> in TargetOps structure.

Test: fx run-test odu_tests

Change-Id: Ic5821433f67ca2cdc32d6b7076d4fe278047bfc0

Tested: Just a refactor, no functional changes
fx run-test cpuperf_tests

Change-Id: I18cbef2a3f13072af5a5299839243a9aa0397b0f

- Test icd_load verifies that the loader is loading the IMG VCD.

Change-Id: I9ba6bbaa867df1a73860bae524f20e26d8983ec5

This test of code addresses is not flexible enought to account for all
the code our compilers can generate. Testing this in the future will
require something more complicated like assembly code, so this test
removes that part of the checking for now. The rest of the test is still
a good smoke test for the unwinder.

Change-Id: Id2d18eca6ccb8b4d214a3bf627e6da090388542f

Expose the egalax touchscreen data
so we can use it for unit testing
in garnet.

SCN-1378 #comment

Change-Id: Iaafa0f3b781b95cc6c19c0517c697878e74c44e6

Remove the inverted flag from the Mute button
so the button is 1 when the mic is muted
and 0 when the mic is not muted.

TEST: Manually tested that the mute button
      value corresponded to the mute
      button state.

ZX-3996 #done

Change-Id: Ia312c98987145099d8f26030502476b2cc8b0451

This CL fixes several compiler errors that are specific to the SDK.

This CL also adds a readme that is explicit about the current scope of
this library and which parts are likely to change in the future.

Test: These changes are required to pass the SDK bots.
Change-Id: I3e3a99e2ae8e9d6fadd087959a3c4e9a9d6120d0

Test: no behavior change
Change-Id: I040b167a7def990ec8b44fe864ce7b1ae4a9ba92

To ease the migration from using amber source configs to using
pkg_resolver repository configs, this change modifies the source
management commands in amberctl to perform roughly equivalent operations
on the RepositoryManager and rewrite.Engine.

Test: modified amberctl test to verify pkg_resolver state

PKG-704 #done

Change-Id: I92853a61b59a60693014853862a9494c9d227caa

And use them in places where we make such syscalls directly with unsafe
Rust today. (Plus add in missing test coverage for logger that covers
the modified code.)

The zx_debuglog_read wrapper currently returns a plain Vec of bytes and
the caller needs to parse it according to the definition of
zx_log_record_t. In the future it ideally would return an already-parsed
Rust struct type, but there is some uncertainty around the existing
debuglog syscalls so this wasn't done yet.

Change-Id: Ibf3ddc6195a751dbacb6e0e9d24250370e8516e9

Test: CQ

Change-Id: I7019e0c271e3220291cdf214c1af723ee06e7ed7

It looks like the topological paths for various devices on the vim2
changed for a variety of reasons:

(1) Some devices became componentized, thus their names changed
(2) The vid:pid:did triple changed for other devices.

Change-Id: Id3518c2a0d1c5aebce5f69d96cb8f84e9a09de19

This change adds a json definition for the magma ABI, and a script to
generate magma.h from it. It also updates magma.h to use the generated
output format. Future revisions to the magma ABI should be made in the
json file, and the script used to regenerate the corresponding header.
The script may be run as part of the build, but is currently only done
so by a new codegen test path in the magma test suite.

Test: used pycparser to verify magma.h AST unchanged from current version
      changed magma.json and verified build failure
      changed magma.h and verified build failure
      changed both magma.json and magma.h and verified build success
Change-Id: Id55f0d28ec89adbcaba3b53ed7647852d9a84127

Added a test class to the ISP.  This class is instantiated
by the ArmIspDevice to offer a testing fidl interface when enabled.
Currently this class is always created, a future CL will allow
enabling the test interface with flags.

Also added the fidl interface definition for the test, as well as
a test program.

Test = This is the test.  Running this test!

Change-Id: I87c3568ae82cba4321bb4826ca0dacf016e51f0d

This CL aligns the Linear and Sample-and-Hold interpolators, in
preparation of introducing additional interpolating resamplers.
No functional change -- just tweaking the linear and point resamplers
to use identical patterns and sequences (as the soon-to-be-added
ones will likely do, as well).

Test: 170 existing automated test cases in audio_mixer_tests
(audio_mixer_tests --full) on all products.boards

MTWN-296 #done

Change-Id: I0753b3fc13d4eb69ffef56a38906043980304df1

Change-Id: I01d51517ff3630a7f1c587e73a3b26d6d36eee84

To prepare for enabling very-long-running tests, as well
as for the introduction of a framework for telemetry
collection, this CL makes consistent the use of logging
by audio_core (and audio_core's tests). Truly blocking
conditions are ERROR; safely-ignored conditions are INFO.
Also, for debug builds audio_core's default log level is
set to INFO, while on release builds it is set to WARNING.

Test: no functional behavior change
Change-Id: I1d8251a6aac79fc0bfb811ca8c398f2ac2004818

Design heavily influenced by AVDTP crate.

Supports:

- Owning a L2CAP socket to a remote peer.
- Responding to unit info and subunit commands.
- Sending AVC passthrough commands to a target.
- Receving target passthrough and vendor dependent packets.
- Sending responses back to controller commands.

BT-657
Test: fx run-test bt-avctp-tests

Change-Id: I861d86a61f17294c430beecf0ca08cea3264e5ea

Enabling -fauto-var-init exposed errors due to not initializing locals, ZX-3970.

This fixes the tests, but also initializes all variables here to prevent
future bugs.

It also fixes a possible bug where we try to use a command read from the
channel even if the channel read failed.

Test: runtests -t {job-test, process-test} now pass.
Change-Id: I3fcdb46d0d22400519615de781d57e6c41a460e6

While adding resampler-related test cases and related refactoring,
in preparation for adding new resamplers, test cases exposed MTWN-296
in the mixer core:

To handle step_size limitations, the mixer uses modulo|numerator|
denominator values for any rate or position fractional components that
cannot be captured with the 13 bits of fixed-point fraction. For a
given mix pass, we calculate end position using these values, doing so
correctly in the usual case of producing every frame, but slightly
incorrectly in the optimization case of MUTED (whether explicitly
muted, or gain is simply too low to ever produce a value). This defect
would primarily be exposed when performing very fine-grained rate
adjustments.

This CL therefore contains the test-code refactoring so far, plus the
test cases that exposed the bug, and the product fix, as well as
additional test cases to verify that no other related bugs lurked.

Test: 15 new test cases, bringing the total to 170
('audio_mixer_tests --full' in basic_envs on all products.boards)

BUG: MTWN-296 #done

Change-Id: If41e20af77bcebbbad7aaf7d5301fded6c027dc3

Bug: PKG-706 #comment
Change-Id: I1290a607a908dea20750b7ffb49274b13212b602

These utilities simplify the implementation of gesture interpretation. No
effort is made to provide a complete family of operations; only operations
used in https://fuchsia-review.googlesource.com/278623 are added.

Test: fx run-test math_unittests
Change-Id: I3323dbd9e515edda81f0903ef24e035395fe9e02

Make sure that screenshots take into account higher level rotation
configurations that cause the layout to be oriented differently from
the orientation of the physical hardware that the lower level
display controller expects.

[SCN-1132] #done

Change-Id: I268d2cafc5598469f4e1c9400159959356d1d8b4

DX-939 #comment

Test: scripts/download-prebuilt && prebuilt/downloads/aemu/emulator
Change-Id: I001ddcf3ccc1875520f846d0442aa54a52ba960b

Now that mondrian has been prepared for this, it is safe to re-land.

Tested: modular_tests, flutter_screencap_test, started story in ermine
SCN-1018 #comment
SCN-1291 #comment

Change-Id: I29a300eabff9e9b4ec663a9b50f8fe6fa543ced4

This reverts commit e5444b60.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [drivers] Avoid system/dev/lib/mmio deps in libraries and tests
> 
> Test code needs to use the mock mmio library header while driver
> code needs to use the real mmio library header.  Hence, a library
> like ddktl or hwreg that is used in both contexts cannot rely on
> this header directly.  Instead, make the APIs agnostic to mmio
> implementation by using forward declarations and requiring users of
> the mmio-related APIs to #include what they use.
> 
> The renaming of the mock library to aaa-mock-mmio-reg was a previous
> attempt to work around this issue, which is actually wholly
> inadequate in the current build system.  So the library is renamed
> back to mock-mmio-reg.
> 
> In the hwreg library, this was achieved by using a template common
> to the kernel and non-kernel cases, rather than an explicit forward
> declaration.  To make that work, the argument order for
> RegisterIo::Write was swapped to match MmioBuffer::Write so that
> they are interchangeable in template instantiation.
> 
> Both implementations of the <lib/mmio/mmio.h> were using templates
> where they should have been using simple forward declarations.  Fix
> that so that separate forward declarations become tenable.
> 
> Some cases of non-driver code still using the real mmio library
> remain and need to be untangled.
> 
> Bug: ZX-4062 #comment hwreg, ddktl libraries made mmio-header-agnostic
> Change-Id: I824d395501b35f59ffb23ac37fffb628f163d46e

TBR=teisenbe@google.com,qsr@google.com,mcgrathr@google.com

Change-Id: Ic4a02278d630b16ae349566ca53d781a26863202
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: ZX-4062 #comment hwreg, ddktl libraries made mmio-header-agnostic

Test: no behavior change
Change-Id: Ibbfa84ac7f8c273fc9e8b61d7a4dfc29f84f7ec8

Test: no behavior change
Change-Id: I6af7df3489876a156807a98d6a6fd9f709d92829

This CL changes the previous new test cases (which validated the
3:1 resampling ratio) to instead validate the 3.9999:1 resampling
ratio, and to add the 1:3.9999 resampling ratio.  This tests
particularly problematic ratios for both interpolators, and continues
to defend our sample-rate limits (this effectively rate-converts from
191999 Hz to 48000 Hz).

This CL also includes fidelity limit values that we require for these
ratios (both frequency response and signal-to-noise-and-distortion).

Test: test-only CL; adds 8 test cases runnable on any product/board

Change-Id: I4d2ff29a48403eaa98cd13f721b66e38191211bc

The GetNumVirtualDevices API that was recently added to
virtualaudio can be used to eliminate the synchronization
issues that AudioDeviceTests faces, so this set of tests
can now be re-enabled.

Test: re-adds 67 test cases; no production code change

MTWN-293 #done

Change-Id: I6d4618a52835f2ef388bed1dddef9491fc2e2b8d

Previously this was copyable but not copied in practice.

Changes some of the code that took pairs because std::pairs to make the
call-sites better.

This should have no affect on functionality and I measured indexing
performance to be the same within typical measurement error.

Change-Id: I5adebf46f0be89090f8048e7b00db8b3c71c7d42

Test code needs to use the mock mmio library header while driver
code needs to use the real mmio library header.  Hence, a library
like ddktl or hwreg that is used in both contexts cannot rely on
this header directly.  Instead, make the APIs agnostic to mmio
implementation by using forward declarations and requiring users of
the mmio-related APIs to #include what they use.

The renaming of the mock library to aaa-mock-mmio-reg was a previous
attempt to work around this issue, which is actually wholly
inadequate in the current build system.  So the library is renamed
back to mock-mmio-reg.

In the hwreg library, this was achieved by using a template common
to the kernel and non-kernel cases, rather than an explicit forward
declaration.  To make that work, the argument order for
RegisterIo::Write was swapped to match MmioBuffer::Write so that
they are interchangeable in template instantiation.

Both implementations of the <lib/mmio/mmio.h> were using templates
where they should have been using simple forward declarations.  Fix
that so that separate forward declarations become tenable.

Some cases of non-driver code still using the real mmio library
remain and need to be untangled.

Bug: ZX-4062 #comment hwreg, ddktl libraries made mmio-header-agnostic
Change-Id: I824d395501b35f59ffb23ac37fffb628f163d46e

Tested: No behavior changed; base_view_unittest
SCN-1291 #comment

Change-Id: I1760e5b179b40210c37ba5eae743eff41431733a

Change-Id: I9c946b6fc2d8ded7141b07000f96f764760fa561