- May 10, 2019
-
-
Kevin Wells authored
To ease the migration from using amber source configs to using pkg_resolver repository configs, this change modifies the source management commands in amberctl to perform roughly equivalent operations on the RepositoryManager and rewrite.Engine. Test: modified amberctl test to verify pkg_resolver state PKG-704 #done Change-Id: I92853a61b59a60693014853862a9494c9d227caa
-
Bryan Henry authored
And use them in places where we make such syscalls directly with unsafe Rust today. (Plus add in missing test coverage for logger that covers the modified code.) The zx_debuglog_read wrapper currently returns a plain Vec of bytes and the caller needs to parse it according to the definition of zx_log_record_t. In the future it ideally would return an already-parsed Rust struct type, but there is some uncertainty around the existing debuglog syscalls so this wasn't done yet. Change-Id: Ibf3ddc6195a751dbacb6e0e9d24250370e8516e9
-
docs-roller authored
Test: CQ Change-Id: I7019e0c271e3220291cdf214c1af723ee06e7ed7
-
Gurjant Kalsi authored
It looks like the topological paths for various devices on the vim2 changed for a variety of reasons: (1) Some devices became componentized, thus their names changed (2) The vid:pid:did triple changed for other devices. Change-Id: Id3518c2a0d1c5aebce5f69d96cb8f84e9a09de19
-
Matt Sandy authored
This change adds a json definition for the magma ABI, and a script to generate magma.h from it. It also updates magma.h to use the generated output format. Future revisions to the magma ABI should be made in the json file, and the script used to regenerate the corresponding header. The script may be run as part of the build, but is currently only done so by a new codegen test path in the magma test suite. Test: used pycparser to verify magma.h AST unchanged from current version changed magma.json and verified build failure changed magma.h and verified build failure changed both magma.json and magma.h and verified build success Change-Id: Id55f0d28ec89adbcaba3b53ed7647852d9a84127
-
Garratt Gallagher authored
Added a test class to the ISP. This class is instantiated by the ArmIspDevice to offer a testing fidl interface when enabled. Currently this class is always created, a future CL will allow enabling the test interface with flags. Also added the fidl interface definition for the test, as well as a test program. Test = This is the test. Running this test! Change-Id: I87c3568ae82cba4321bb4826ca0dacf016e51f0d
-
Martin Puryear authored
This CL aligns the Linear and Sample-and-Hold interpolators, in preparation of introducing additional interpolating resamplers. No functional change -- just tweaking the linear and point resamplers to use identical patterns and sequences (as the soon-to-be-added ones will likely do, as well). Test: 170 existing automated test cases in audio_mixer_tests (audio_mixer_tests --full) on all products.boards MTWN-296 #done Change-Id: I0753b3fc13d4eb69ffef56a38906043980304df1
-
Allan MacKinnon authored
Change-Id: I01d51517ff3630a7f1c587e73a3b26d6d36eee84
-
Martin Puryear authored
To prepare for enabling very-long-running tests, as well as for the introduction of a framework for telemetry collection, this CL makes consistent the use of logging by audio_core (and audio_core's tests). Truly blocking conditions are ERROR; safely-ignored conditions are INFO. Also, for debug builds audio_core's default log level is set to INFO, while on release builds it is set to WARNING. Test: no functional behavior change Change-Id: I1d8251a6aac79fc0bfb811ca8c398f2ac2004818
-
Zac Bowling authored
Design heavily influenced by AVDTP crate. Supports: - Owning a L2CAP socket to a remote peer. - Responding to unit info and subunit commands. - Sending AVC passthrough commands to a target. - Receving target passthrough and vendor dependent packets. - Sending responses back to controller commands. BT-657 Test: fx run-test bt-avctp-tests Change-Id: I861d86a61f17294c430beecf0ca08cea3264e5ea
-
Ed Coyne authored
Enabling -fauto-var-init exposed errors due to not initializing locals, ZX-3970. This fixes the tests, but also initializes all variables here to prevent future bugs. It also fixes a possible bug where we try to use a command read from the channel even if the channel read failed. Test: runtests -t {job-test, process-test} now pass. Change-Id: I3fcdb46d0d22400519615de781d57e6c41a460e6
-
Martin Puryear authored
While adding resampler-related test cases and related refactoring, in preparation for adding new resamplers, test cases exposed MTWN-296 in the mixer core: To handle step_size limitations, the mixer uses modulo|numerator| denominator values for any rate or position fractional components that cannot be captured with the 13 bits of fixed-point fraction. For a given mix pass, we calculate end position using these values, doing so correctly in the usual case of producing every frame, but slightly incorrectly in the optimization case of MUTED (whether explicitly muted, or gain is simply too low to ever produce a value). This defect would primarily be exposed when performing very fine-grained rate adjustments. This CL therefore contains the test-code refactoring so far, plus the test cases that exposed the bug, and the product fix, as well as additional test cases to verify that no other related bugs lurked. Test: 15 new test cases, bringing the total to 170 ('audio_mixer_tests --full' in basic_envs on all products.boards) BUG: MTWN-296 #done Change-Id: If41e20af77bcebbbad7aaf7d5301fded6c027dc3
-
Dan Johnson authored
Bug: PKG-706 #comment Change-Id: I1290a607a908dea20750b7ffb49274b13212b602
-
Ross Wang authored
These utilities simplify the implementation of gesture interpretation. No effort is made to provide a complete family of operations; only operations used in https://fuchsia-review.googlesource.com/278623 are added. Test: fx run-test math_unittests Change-Id: I3323dbd9e515edda81f0903ef24e035395fe9e02
-
Chris Fontas authored
Make sure that screenshots take into account higher level rotation configurations that cause the layout to be oriented differently from the orientation of the physical hardware that the lower level display controller expects. [SCN-1132] #done Change-Id: I268d2cafc5598469f4e1c9400159959356d1d8b4
-
David Reveman authored
DX-939 #comment Test: scripts/download-prebuilt && prebuilt/downloads/aemu/emulator Change-Id: I001ddcf3ccc1875520f846d0442aa54a52ba960b
-
David Worsham authored
Now that mondrian has been prepared for this, it is safe to re-land. Tested: modular_tests, flutter_screencap_test, started story in ermine SCN-1018 #comment SCN-1291 #comment Change-Id: I29a300eabff9e9b4ec663a9b50f8fe6fa543ced4
-
Ankur Mittal authored
This reverts commit e5444b60. Reason for revert: <INSERT REASONING HERE> Original change's description: > [drivers] Avoid system/dev/lib/mmio deps in libraries and tests > > Test code needs to use the mock mmio library header while driver > code needs to use the real mmio library header. Hence, a library > like ddktl or hwreg that is used in both contexts cannot rely on > this header directly. Instead, make the APIs agnostic to mmio > implementation by using forward declarations and requiring users of > the mmio-related APIs to #include what they use. > > The renaming of the mock library to aaa-mock-mmio-reg was a previous > attempt to work around this issue, which is actually wholly > inadequate in the current build system. So the library is renamed > back to mock-mmio-reg. > > In the hwreg library, this was achieved by using a template common > to the kernel and non-kernel cases, rather than an explicit forward > declaration. To make that work, the argument order for > RegisterIo::Write was swapped to match MmioBuffer::Write so that > they are interchangeable in template instantiation. > > Both implementations of the <lib/mmio/mmio.h> were using templates > where they should have been using simple forward declarations. Fix > that so that separate forward declarations become tenable. > > Some cases of non-driver code still using the real mmio library > remain and need to be untangled. > > Bug: ZX-4062 #comment hwreg, ddktl libraries made mmio-header-agnostic > Change-Id: I824d395501b35f59ffb23ac37fffb628f163d46e TBR=teisenbe@google.com,qsr@google.com,mcgrathr@google.com Change-Id: Ic4a02278d630b16ae349566ca53d781a26863202 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: ZX-4062 #comment hwreg, ddktl libraries made mmio-header-agnostic
-
Taylor Cramer authored
Test: no behavior change Change-Id: Ibbfa84ac7f8c273fc9e8b61d7a4dfc29f84f7ec8
-
Taylor Cramer authored
Test: no behavior change Change-Id: I6af7df3489876a156807a98d6a6fd9f709d92829
-
Martin Puryear authored
This CL changes the previous new test cases (which validated the 3:1 resampling ratio) to instead validate the 3.9999:1 resampling ratio, and to add the 1:3.9999 resampling ratio. This tests particularly problematic ratios for both interpolators, and continues to defend our sample-rate limits (this effectively rate-converts from 191999 Hz to 48000 Hz). This CL also includes fidelity limit values that we require for these ratios (both frequency response and signal-to-noise-and-distortion). Test: test-only CL; adds 8 test cases runnable on any product/board Change-Id: I4d2ff29a48403eaa98cd13f721b66e38191211bc
-
Martin Puryear authored
The GetNumVirtualDevices API that was recently added to virtualaudio can be used to eliminate the synchronization issues that AudioDeviceTests faces, so this set of tests can now be re-enabled. Test: re-adds 67 test cases; no production code change MTWN-293 #done Change-Id: I6d4618a52835f2ef388bed1dddef9491fc2e2b8d
-
Brett Wilson authored
Previously this was copyable but not copied in practice. Changes some of the code that took pairs because std::pairs to make the call-sites better. This should have no affect on functionality and I measured indexing performance to be the same within typical measurement error. Change-Id: I5adebf46f0be89090f8048e7b00db8b3c71c7d42
-
Roland McGrath authored
Test code needs to use the mock mmio library header while driver code needs to use the real mmio library header. Hence, a library like ddktl or hwreg that is used in both contexts cannot rely on this header directly. Instead, make the APIs agnostic to mmio implementation by using forward declarations and requiring users of the mmio-related APIs to #include what they use. The renaming of the mock library to aaa-mock-mmio-reg was a previous attempt to work around this issue, which is actually wholly inadequate in the current build system. So the library is renamed back to mock-mmio-reg. In the hwreg library, this was achieved by using a template common to the kernel and non-kernel cases, rather than an explicit forward declaration. To make that work, the argument order for RegisterIo::Write was swapped to match MmioBuffer::Write so that they are interchangeable in template instantiation. Both implementations of the <lib/mmio/mmio.h> were using templates where they should have been using simple forward declarations. Fix that so that separate forward declarations become tenable. Some cases of non-driver code still using the real mmio library remain and need to be untangled. Bug: ZX-4062 #comment hwreg, ddktl libraries made mmio-header-agnostic Change-Id: I824d395501b35f59ffb23ac37fffb628f163d46e
-
David Worsham authored
Tested: No behavior changed; base_view_unittest SCN-1291 #comment Change-Id: I1760e5b179b40210c37ba5eae743eff41431733a
-
Dustin Green authored
Change-Id: I9c946b6fc2d8ded7141b07000f96f764760fa561
-
Brett Wilson authored
Performance improves by ~7% by optimizing allocation of vectors and strings iin module_symbol_index and module_symbol_index_node before doing the indexing. Performance improves by ~15% by optimizing the allocation of the "seen_attrs" vector in the DwarfDieDecoder. This was measured by running the normall-commented-out test ModuleSymbolIndex.BenchmarkIndexing and giving it an ELF binary of a fully symbolized release build of Chrome. There should be no functional change. Change-Id: I107a3d651ac05e9b2959da88a06e463173eae199
-
Brian Hamrick authored
Previously, the first event of each window was not being counted, so reported FPS was lower than it should have been. Change-Id: I4c788c8ff2760d18c21e6abe98cfe9eab69ea3c0
-
John Bauman authored
This will allow creating buffer collections of fixed size that don't contain images. This is ignored for now, until the drivers are updated to set the value. Test: in a follow-up patch once this does something. Change-Id: I5e6e5e216e61f006645480f0f89d09fdd28638d8
-
David Worsham authored
Tested: Built and ran Escher on Linux SCN-1391 #comment Change-Id: I35bdcf15aae15b4724f4652c5fa9bb8e790b564b
-
Gurjant Kalsi authored
(1) Refactors the AML Clock Driver for Testing (Inject MMIO regions) (2) Add tests to the AML Clock Driver. (3) Don't needlessly copy gate definitions into the driver. Change-Id: Ib5c685ff0ac6cf23b3df8c4afd90daaffa299472
-
Adam Barth authored
The fidl::EventSender is similar to fidl::Binding except the fidl::EventSender just sends events and does not receive or decode incoming messages. Having a separate class for this functionality is useful because EventSender does not need to couple to an async_dispatcher_t, which means EventSender can be used in scenarios where an async_dispatcher_t is not available or when the client wishes to send events from multiple threads. This CL also uses EventSender in lib/vfs/cpp in a location where an async_dispatcher_t is not available. This change lets us remove a dependency on the C bindings in lib/vfs/cpp, which is the last blocker for adding lib/vfs/cpp to the SDK. The change also lets us remove one more instance of manually constructing FIDL messages. Test: Added event_sender_unittest.cc Change-Id: If9d6c9cca4d16d248d3635be677d35b61d321e28
-
Zach Anderson authored
This reverts commit cf254ae8. Reason for revert: Causes vim2 to fail to pave. See: https://fuchsia.atlassian.net/browse/DNO-519 Original change's description: > [devhost] Wait for BindDriver in reply to Bind > > Calls to fuchsia.device.Controller/Bind should only return once the > operation completes, which is when > fuchsia.device.manager.DeviceController/BindDriver is called. > > ZX-3991 #done > > Change-Id: I10607640072c8f779ac1d5be79d5a2da6de6288b TBR=kulakowski@google.com,teisenbe@google.com,abdulla@google.com,brettw@google.com Change-Id: I370d03abd9fa93a70a48f86f4df171f2cf87ee12 No-Presubmit: true No-Tree-Checks: true No-Try: true
-
Allan MacKinnon authored
Tracked by: SPN-8 Test: fx shell run fuchsia-pkg://fuchsia.com/hotsort_vk_bench#meta/hotsort_vk_bench.cmx" - CL following 277184. This CL replaces shell scripts with GN. The GN build invokes the 'hotsort_gen' code generator and builds architecture-specific shader "targets" (bundles of shaders and algorithm configuration info) using a custom GN template. The target outputs are placed in their respective $target_gen_dirs for later inclusion of either a source set or its equivalent binary image. The hotsort_target.gni template performs the following steps: 1. Produce list of compute shaders that *will* be generated. 2. Invoke hotsort_gen to generate compute shaders. 3. Compile the shaders to SPIR-V modules with glslangValidator 4. Invoke spirv-opt to optimize and shrink the SPIR-V modules. 5. Invoke spirv-remap to improve compressibility of modules. 6. Convert SPIR-V modules to array of C literals. 7. Dump a binary image of the HotSort target bundle of modules. 8. The GN template returns a source set of the target. Steps to verify target outputs are being created: 1. fx build graphics 2. ls -R out/default/gen/src/graphics/lib/compute/hotsort/platforms/vk/tests/hotsort_vk_bench/ Change-Id: Ic98c374c70e4fda2c1d8d3284a8cbc46443eaffc
-
David Worsham authored
Tested: No behavior changed SCN-1391 #comment Change-Id: I98fdc6188963a381141448d36400d4a370ead295
-
Nick Korostelev authored
Fixes hermetic dart test that require UI. Test: fx run-test slider_mod_tests Change-Id: I8464abc271378031f2da133290a730c4f2b9d504
-
Vardhan Mudunuru authored
This: MyTable t; t.set_x(1); t.set_y(2); MyFunction(std::move(t)); Can now be reduce to: MyFunction(MyTable().set_x(1).set_y(2)) Test: Table.ChainSetters; all existing tests using tables also aren't failing. FIDL-615 Change-Id: Ieeffa04417e92df7c0bb01d3b461dd968ba33852
-
Aaron Wood authored
This adds the Installer trait, and replaces the InstallPlan trait with Installer::Plan, an trait to use with the associated InstallPlan type of the Installer. A stub implementation is provided for ease of writing tests and for prototyping work. Bug: PKG-465 Test: fx run-test omaha_client_lib_tests Change-Id: Id644c3a41c78a1fce09fa8575027eb7c71c9943d
-
David Worsham authored
Tested: No behavior changed SCN-1018 #comment SCN-1291 #comment Change-Id: Ic2dba8b13d6aaea74c19013cdb2561d601114a70
-
Francois Rousseau authored
on a QEMU bot, the stub logger took longer than the timeout (100ms) to send the first message (before it goes to sleep for 200ms) so we increase the timeout to 500ms (and the sleep to 1s). FLK-225 #done #comment TESTED=`fx run-test feedback_agent_tests -t log_listener_unittest -- --gtest_filter=CollectSystemLogTest.Succeed_LogCollectionTimesOut` Change-Id: Ia8e135e4ac2305076e73658916a5f6c6b0bddda6
-